Re: [ovs-dev] [PATCH] netdev-linux: favor netlink stats for physical ports

2014-04-29 Thread Andy Zhou
On Tue, Apr 29, 2014 at 8:35 AM, Jarno Rajahalme wrote: > > On Apr 28, 2014, at 3:58 PM, Andy Zhou wrote: > >> Currently physical ports stats are collected from kernel datapath. >> However, those counter do not reflect actual wire packet counters >> when LSO or TSO are enabled by the NIC. In the

Re: [ovs-dev] [PATCH] netdev-linux: favor netlink stats for physical ports

2014-04-29 Thread Andy Zhou
On Tue, Apr 29, 2014 at 7:33 AM, Ben Pfaff wrote: > On Mon, Apr 28, 2014 at 03:58:51PM -0700, Andy Zhou wrote: >> Currently physical ports stats are collected from kernel datapath. >> However, those counter do not reflect actual wire packet counters >> when LSO or TSO are enabled by the NIC. In th

Re: [ovs-dev] [PATCH] netdev-linux: favor netlink stats for physical ports

2014-04-29 Thread Pravin Shelar
On Tue, Apr 29, 2014 at 7:33 AM, Ben Pfaff wrote: > On Mon, Apr 28, 2014 at 03:58:51PM -0700, Andy Zhou wrote: >> Currently physical ports stats are collected from kernel datapath. >> However, those counter do not reflect actual wire packet counters >> when LSO or TSO are enabled by the NIC. In th

Re: [ovs-dev] [PATCH] netdev-linux: favor netlink stats for physical ports

2014-04-29 Thread Jarno Rajahalme
On Apr 28, 2014, at 3:58 PM, Andy Zhou wrote: > Currently physical ports stats are collected from kernel datapath. > However, those counter do not reflect actual wire packet counters > when LSO or TSO are enabled by the NIC. In the meantime, the stats > collected form routing stack does. While b

Re: [ovs-dev] [PATCH] netdev-linux: favor netlink stats for physical ports

2014-04-29 Thread Ben Pfaff
On Mon, Apr 28, 2014 at 03:58:51PM -0700, Andy Zhou wrote: > Currently physical ports stats are collected from kernel datapath. > However, those counter do not reflect actual wire packet counters > when LSO or TSO are enabled by the NIC. In the meantime, the stats > collected form routing stack doe

[ovs-dev] [PATCH] netdev-linux: favor netlink stats for physical ports

2014-04-28 Thread Andy Zhou
Currently physical ports stats are collected from kernel datapath. However, those counter do not reflect actual wire packet counters when LSO or TSO are enabled by the NIC. In the meantime, the stats collected form routing stack does. While both stats are valid, Reporting netlink stats for packet c