On Tue, Apr 29, 2014 at 7:33 AM, Ben Pfaff <b...@nicira.com> wrote:
> On Mon, Apr 28, 2014 at 03:58:51PM -0700, Andy Zhou wrote:
>> Currently physical ports stats are collected from kernel datapath.
>> However, those counter do not reflect actual wire packet counters
>> when LSO or TSO are enabled by the NIC. In the meantime, the stats
>> collected form routing stack does. While both stats are valid, Reporting
>> netlink stats for packet counts and byte counts make it easier
>> to correlate those numbers with external measurements.
>>
>> Signed-off-by: Andy Zhou <az...@nicira.com>
>
> Do you mean GSO instead of LSO here?
>> + /* Use Netlink's packet and byte counts since vport's counters
>> + * do not reflect packet counts on the wire when LSO/TSO are
>> enabled. */
>
> In earlier discussion, we found that Pravin had made the change to the
> current state, but that there wasn't very much rationale in the log.
> Pravin, does this new change make sense?
>
The patch (f613a0d72c5) did not change any functionality. It moved
stats calculation from kernel datapath to netdev layer. Anyways this
change looks good to me.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
