On Tue, Apr 29, 2014 at 8:35 AM, Jarno Rajahalme <jrajaha...@nicira.com> wrote:
>
> On Apr 28, 2014, at 3:58 PM, Andy Zhou <az...@nicira.com> wrote:
>
>> Currently physical ports stats are collected from kernel datapath.
>> However, those counter do not reflect actual wire packet counters
>> when LSO or TSO are enabled by the NIC. In the meantime, the stats
>> collected form routing stack does. While both stats are valid, Reporting
>> netlink stats for packet counts and byte counts make it easier
>> to correlate those numbers with external measurements.
>
> I find the term “netlink stats” confusing, as both port and “netlink” stats 
> are collected via netlink. Also, the stats are not about the netlink itself, 
> so I’d avoid using this term. The comments in code also refer to “ioctl”, 
> which is equally wrong, I think. Would “netdev stats” vs. “vport stats” be a 
> more accurate way of referring to these?

Good point, I agree switching to netdev stats and vport stats are better.

>
>   Jarno
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to