Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-30 Thread Jesse Gross
On Tue, Oct 29, 2013 at 6:16 PM, Alexei Starovoitov wrote: > On Tue, Oct 29, 2013 at 5:56 PM, Jesse Gross wrote: >> On Tue, Oct 29, 2013 at 3:57 PM, Alexei Starovoitov >> wrote: >>> On Tue, Oct 29, 2013 at 3:00 PM, Jesse Gross wrote: On Tue, Oct 29, 2013 at 11:19 AM, Alexei Starovoitov >>>

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-30 Thread Pravin Shelar
On Tue, Oct 29, 2013 at 3:52 PM, Jesse Gross wrote: > On Tue, Oct 29, 2013 at 10:12 AM, Pravin B Shelar wrote: >> diff --git a/datapath/datapath.h b/datapath/datapath.h >> index 879a830..5a89e0e 100644 >> --- a/datapath/datapath.h >> +++ b/datapath/datapath.h >> @@ -53,29 +53,29 @@ >> * up pe

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Alexei Starovoitov
On Tue, Oct 29, 2013 at 5:56 PM, Jesse Gross wrote: > On Tue, Oct 29, 2013 at 3:57 PM, Alexei Starovoitov > wrote: >> On Tue, Oct 29, 2013 at 3:00 PM, Jesse Gross wrote: >>> On Tue, Oct 29, 2013 at 11:19 AM, Alexei Starovoitov >>> wrote: On Tue, Oct 29, 2013 at 11:15 AM, Pravin Shelar wro

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Jesse Gross
On Tue, Oct 29, 2013 at 3:57 PM, Alexei Starovoitov wrote: > On Tue, Oct 29, 2013 at 3:00 PM, Jesse Gross wrote: >> On Tue, Oct 29, 2013 at 11:19 AM, Alexei Starovoitov >> wrote: >>> On Tue, Oct 29, 2013 at 11:15 AM, Pravin Shelar wrote: On Tue, Oct 29, 2013 at 10:24 AM, Andy Zhou wrote:

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Alexei Starovoitov
On Tue, Oct 29, 2013 at 3:00 PM, Jesse Gross wrote: > On Tue, Oct 29, 2013 at 11:19 AM, Alexei Starovoitov > wrote: >> On Tue, Oct 29, 2013 at 11:15 AM, Pravin Shelar wrote: >>> On Tue, Oct 29, 2013 at 10:24 AM, Andy Zhou wrote: This is not a review, but it would be nice to add some code c

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Jesse Gross
On Tue, Oct 29, 2013 at 10:12 AM, Pravin B Shelar wrote: > diff --git a/datapath/datapath.h b/datapath/datapath.h > index 879a830..5a89e0e 100644 > --- a/datapath/datapath.h > +++ b/datapath/datapath.h > @@ -53,29 +53,29 @@ > * up per packet. > */ > struct dp_stats_percpu { > + struct

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Jesse Gross
On Tue, Oct 29, 2013 at 11:19 AM, Alexei Starovoitov wrote: > On Tue, Oct 29, 2013 at 11:15 AM, Pravin Shelar wrote: >> On Tue, Oct 29, 2013 at 10:24 AM, Andy Zhou wrote: >>> This is not a review, but it would be nice to add some code comments in >>> proper data structure layout, so that the sam

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Alexei Starovoitov
On Tue, Oct 29, 2013 at 11:15 AM, Pravin Shelar wrote: > On Tue, Oct 29, 2013 at 10:24 AM, Andy Zhou wrote: >> This is not a review, but it would be nice to add some code comments in >> proper data structure layout, so that the same logic can be followed in the >> future. >> > ok, I will add gene

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Pravin Shelar
On Tue, Oct 29, 2013 at 10:24 AM, Andy Zhou wrote: > This is not a review, but it would be nice to add some code comments in > proper data structure layout, so that the same logic can be followed in the > future. > ok, I will add general guideline in datapath.h as follows: /* * data structure me

Re: [ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Andy Zhou
This is not a review, but it would be nice to add some code comments in proper data structure layout, so that the same logic can be followed in the future. On Tue, Oct 29, 2013 at 10:12 AM, Pravin B Shelar wrote: > Following patch rearranges various ovs structures which > are accessed in datapat

[ovs-dev] [PATCH] datapath: Optimize datapath struct for cacheline access.

2013-10-29 Thread Pravin B Shelar
Following patch rearranges various ovs structures which are accessed in datapath for optimal cacheline access. Signed-off-by: Pravin B Shelar --- datapath/datapath.h | 19 +-- datapath/flow.h | 13 ++--- datapath/flow_table.c |2 +- datapath/vport.h |