On Tue, Oct 29, 2013 at 11:19 AM, Alexei Starovoitov <[email protected]> wrote: > On Tue, Oct 29, 2013 at 11:15 AM, Pravin Shelar <[email protected]> wrote: >> On Tue, Oct 29, 2013 at 10:24 AM, Andy Zhou <[email protected]> wrote: >>> This is not a review, but it would be nice to add some code comments in >>> proper data structure layout, so that the same logic can be followed in the >>> future. >>> >> ok, I will add general guideline in datapath.h as follows: >> >> /* >> * data structure members should be arranged according to frequency of access >> * in ovs fast-path. So that most frequently accessed members are in >> first cache-line >> * for a datapath object. >> */ > > that may be fine as general rule, but I don't see how it helps to > avoid cache misses.
It reduces cache pressure by not polluting cache lines with data that won't be commonly accessed. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
