Re: [ovs-dev] [PATCH] datapath: Fix unused 'done' label build warning in flow.c.

2011-09-22 Thread Justin Pettit
On Sep 22, 2011, at 12:52 PM, Jesse Gross wrote: >> Are you suggesting that we revert the original patch or that we don't use my >> patch? I don't like shipping software with compiler warnings, and since the >> warning was introduced post-1.2.1, I'd like to get rid of the warning. I >> can al

Re: [ovs-dev] [PATCH] datapath: Fix unused 'done' label build warning in flow.c.

2011-09-22 Thread Jesse Gross
On Thu, Sep 22, 2011 at 12:29 PM, Justin Pettit wrote: > On Sep 22, 2011, at 11:17 AM, Jesse Gross wrote: > >> On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit wrote: >>> Commit d6b37e42 (datapath: Allow a packet with no input port to omit >>> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 188

Re: [ovs-dev] [PATCH] datapath: Fix unused 'done' label build warning in flow.c.

2011-09-22 Thread Justin Pettit
On Sep 22, 2011, at 11:17 AM, Jesse Gross wrote: > On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit wrote: >> Commit d6b37e42 (datapath: Allow a packet with no input port to omit >> ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the >> "master" branch, but dropped a few lines. This

Re: [ovs-dev] [PATCH] datapath: Fix unused 'done' label build warning in flow.c.

2011-09-22 Thread Jesse Gross
On Wed, Sep 21, 2011 at 11:51 PM, Justin Pettit wrote: > Commit d6b37e42 (datapath: Allow a packet with no input port to omit > ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the > "master" branch, but dropped a few lines.  This causes a compiler > warning about an unused "done" lab

Re: [ovs-dev] [PATCH] datapath: Fix unused 'done' label build warning in flow.c.

2011-09-22 Thread Justin Pettit
Since it's not clear from the message, this commit is for "branch-1.2". --Justin On Sep 21, 2011, at 11:51 PM, Justin Pettit wrote: > Commit d6b37e42 (datapath: Allow a packet with no input port to omit > ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the > "master" branch, but d

[ovs-dev] [PATCH] datapath: Fix unused 'done' label build warning in flow.c.

2011-09-21 Thread Justin Pettit
Commit d6b37e42 (datapath: Allow a packet with no input port to omit ODP_KEY_ATTR_IN_PORT.) was a crossport from commit 18886b6 in the "master" branch, but dropped a few lines. This causes a compiler warning about an unused "done" label. This commit brings the two patches in line. Signed-off-by: