Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Alin Serdean
Ok will update it to dpif_netlink_vport*. -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Wednesday, September 17, 2014 3:37 PM Către: Alin Serdean Cc: Nithin Raju; Eitan Eliahu; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Ben Pfaff
On Wed, Sep 17, 2014 at 10:33:04PM +, Alin Serdean wrote: > 1. I did not change the dpif_linux_vport* functions because that means > also touching netdev-linux.c. If that is ok with Ben, I can also add > them to a v2 of the patch. I only see one reference to dpif_linux_vport* from netdev-linux

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Alin Serdean
original- De la: Nithin Raju [mailto:nit...@vmware.com] Trimis: Wednesday, September 17, 2014 3:16 PM Către: Alin Serdean Cc: Eitan Eliahu; Ben Pfaff; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC On Sep 17, 2014, at 1:11 PM, Alin

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Nithin Raju
On Sep 17, 2014, at 1:11 PM, Alin Serdean wrote: > The patch contains the necessary modifications to compile and also to run > under MSVC. > > Added the files to the build system and also changed dpif_linux to be under > a more generic name dpif_windows. > > Added a TODO under the windows par

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Alin Serdean
I will rebase and also the filename change in V2. -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Wednesday, September 17, 2014 2:06 PM Către: Alin Serdean Cc: Eitan Eliahu; 'Nithin Raju'; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] Changes needed for

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Nithin Raju
We can do the file re-naming after this checkin. I'm reviewing the change. Let me get back in a few minutes. thanks, Nithin On Sep 17, 2014, at 1:38 PM, Ben Pfaff wrote: > I'm happy to do that. I don't care whether it happens before or after > or simultaneously with the change under conside

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Ben Pfaff
On Wed, Sep 17, 2014 at 08:11:08PM +, Alin Serdean wrote: > The patch contains the necessary modifications to compile and also to run > under MSVC. > > Added the files to the build system and also changed dpif_linux to be under > a more generic name dpif_windows. > > Added a TODO under the wi

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Eitan Eliahu
biect: RE: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC Once Alin confirms we didn't break anything with Linux we are ready to go. Thanks, Eitan -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Wednesday, September 17, 2014 1:38 PM To: E

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Alin Serdean
liahu Cc: Alin Serdean; Nithin Raju; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC I'm happy to do that. I don't care whether it happens before or after or simultaneously with the change under consideration. Did you review the chang

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Eitan Eliahu
s-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC I'm happy to do that. I don't care whether it happens before or after or simultaneously with the change under consideration. Did you review the change? On Wed, Sep 17, 2014 at 08:30:57PM +, Eitan Eliahu wrote: >

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Alin Serdean
] [PATCH] Changes needed for dpif-linux to compile under MSVC I'm happy to do that. I don't care whether it happens before or after or simultaneously with the change under consideration. Did you review the change? On Wed, Sep 17, 2014 at 08:30:57PM +, Eitan Eliahu wrote: > Hi Al

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Ben Pfaff
Thanks, > Eitan > > -Original Message- > From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] > Sent: Wednesday, September 17, 2014 1:11 PM > To: Eitan Eliahu; Nithin Raju; 'Ben Pfaff'; dev@openvswitch.org > Subject: [ovs-dev] [PATCH] Changes needed for

Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Eitan Eliahu
ev] [PATCH] Changes needed for dpif-linux to compile under MSVC The patch contains the necessary modifications to compile and also to run under MSVC. Added the files to the build system and also changed dpif_linux to be under a more generic name dpif_windows. Added a TODO under the windows part in ca

[ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC

2014-09-17 Thread Alin Serdean
The patch contains the necessary modifications to compile and also to run under MSVC. Added the files to the build system and also changed dpif_linux to be under a more generic name dpif_windows. Added a TODO under the windows part in case we want to implement another counterpart for epoll functi