Hi Nithin, Thank you for looking over the patch.
1. I did not change the dpif_linux_vport* functions because that means also touching netdev-linux.c. If that is ok with Ben, I can also add them to a v2 of the patch. 2. I will look over the spacing in v2. Thank you again, Nithin. -----Mesaj original----- De la: Nithin Raju [mailto:nit...@vmware.com] Trimis: Wednesday, September 17, 2014 3:16 PM Către: Alin Serdean Cc: Eitan Eliahu; Ben Pfaff; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] Changes needed for dpif-linux to compile under MSVC On Sep 17, 2014, at 1:11 PM, Alin Serdean <aserd...@cloudbasesolutions.com> wrote: > The patch contains the necessary modifications to compile and also to > run under MSVC. > > Added the files to the build system and also changed dpif_linux to be > under a more generic name dpif_windows. > > Added a TODO under the windows part in case we want to implement > another counterpart for epoll functions. > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> Alin, Thanks for working on this this. I had the following comments: 1. dpif_linux_vport* functions and data types have not been renamed to dpif_netlink_vport. Is there any reason for that? 2. Alignment of the function parameters is a bit off here owning the to the fact that the function names are longer now with s/linux/netlink. Both of these are not major comments and not correctness issues either. I think the patch is good to go. Acked-by: Nithin Raju <nit...@vmware.com> thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
