On Sep 17, 2014, at 1:11 PM, Alin Serdean <aserd...@cloudbasesolutions.com> wrote:
> The patch contains the necessary modifications to compile and also to run > under MSVC. > > Added the files to the build system and also changed dpif_linux to be under > a more generic name dpif_windows. > > Added a TODO under the windows part in case we want to implement another > counterpart for epoll functions. > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> Alin, Thanks for working on this this. I had the following comments: 1. dpif_linux_vport* functions and data types have not been renamed to dpif_netlink_vport. Is there any reason for that? 2. Alignment of the function parameters is a bit off here owning the to the fact that the function names are longer now with s/linux/netlink. Both of these are not major comments and not correctness issues either. I think the patch is good to go. Acked-by: Nithin Raju <nit...@vmware.com> thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
