Re: [ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-05 Thread Eitan Eliahu
Correct, we need to mark is as deleted even if it was not added from user mode (so memory won't be released). If it gets too complex I will just update the port parameters. Thanks, Eitan -Original Message- From: Nithin Raju Sent: Wednesday, November 05, 2014 3:50 PM To: Eitan Eliahu Cc:

Re: [ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-05 Thread Nithin Raju
> The original code should work even when the port is connected. > The port structure is not being reallocated rather just marked as deleted. > The issue is with create port function which insert the port to do the port > list even when it is already created. This is true only if that port has b

Re: [ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-05 Thread Eitan Eliahu
The original code should work even when the port is connected. The port structure is not being reallocated rather just marked as deleted. The issue is with create port function which insert the port to do the port list even when it is already created. This should be handled in a spate change. Th

Re: [ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-05 Thread Eitan Eliahu
This would be the easiest but I have concerns that some other parameters would be updated as well in new versions of NDIS. I am checking into it. Thank you, Eitan -Original Message- From: Nithin Raju Sent: Wednesday, November 05, 2014 2:15 PM To: Eitan Eliahu Cc: dev@openvswitch.org Subj

Re: [ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-05 Thread Nithin Raju
On Nov 5, 2014, at 11:06 PM, Eitan Eliahu wrote: > Hi Nithin, > Actually ovsState will get updated from portParam->PortState in > OvsInitVportWithPortParam() so this should not be an issue. > But, there may be an issue with the nic parameters stored in the voprt. > Even when the documentation r

Re: [ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-05 Thread Eitan Eliahu
Hi Nithin, Actually ovsState will get updated from portParam->PortState in OvsInitVportWithPortParam() so this should not be an issue. But, there may be an issue with the nic parameters stored in the voprt. Even when the documentation reads that only "currently" the port friendly name could get

Re: [ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-05 Thread Nithin Raju
> +case OID_SWITCH_PORT_UPDATED: > +HvDeletePort(switchObject, portParam); > +status = HvCreatePort(switchObject, portParam); > + break; hi Eitan, While this change is ok in general, can you pls. comment on how this code will work if the port is in CONNECTED state, and

[ovs-dev] [PATCH] datapath-windows: Update port property

2014-11-03 Thread Eitan Eliahu
Update Hyper-V port properties on NDIS property port set callback. Driver update the port friendly name in its internal table. Signed-off-by: Eitan Eliahu --- datapath-windows/ovsext/Oid.c | 4 1 file changed, 4 insertions(+) diff --git a/datapath-windows/ovsext/Oid.c b/datapath-windows/ov