On Nov 9, 2011, at 9:17 AM, Jesse Gross wrote:
>> If you have a better suggestion, let me know. I'm hoping that we can get
>> some sanity in 1.2, and then we can just adopt that convention in the
>> userspace.
>
> Yeah, I remember that conversation. What specifically caught my eye
> though wa
On Wed, Nov 9, 2011 at 12:43 AM, Justin Pettit wrote:
> On Nov 8, 2011, at 10:56 PM, Jesse Gross wrote:
>
>> I think after this patch we actually do need to update the comment in
>> datapath/flow.h on tos (it talks about DSCP). Also that block of
>> comments in misaligned.
>
> Okay. Updated.
>
>
On Wed, Nov 9, 2011 at 12:27 AM, Justin Pettit wrote:
> On Nov 8, 2011, at 8:44 PM, Jesse Gross wrote:
>> I also notice that we print both the
>> individual DSCP/ECN components and the combined ToS in decimal in some
>> places as well, which is a little weird.
>
> Yes, this is because OpenFlow's t
On Nov 8, 2011, at 10:56 PM, Jesse Gross wrote:
> I think after this patch we actually do need to update the comment in
> datapath/flow.h on tos (it talks about DSCP). Also that block of
> comments in misaligned.
Okay. Updated.
> I also discovered that there is ipv4_change_dsfield() function t
On Nov 8, 2011, at 8:44 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>>
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> @@ -370,7 +370,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds
>> *ds)
>> ...
>
> I would use # here as well.
Okay. Changed
On Tue, Nov 8, 2011 at 8:44 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>> diff --git a/lib/odp-util.c b/lib/odp-util.c
>> index 2853bf7..29abce4 100644
>> --- a/lib/odp-util.c
>> +++ b/lib/odp-util.c
>> @@ -370,7 +370,7 @@ format_odp_key_attr(const struct nlattr
On Nov 8, 2011, at 4:45 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 03:57:30PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Does this really add the ability to modify ECN in IPv6:
>
>> @@ -2,6 +2,8 @@ post-v1.3.0
>>
>> - OpenFlow:
>>- A
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 2853bf7..29abce4 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -370,7 +370,7 @@ format_odp_key_attr(const struct nlattr *a, struct ds *ds)
> case OVS_KEY_ATTR_IPV4:
>
On Tue, Nov 08, 2011 at 03:57:30PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Does this really add the ability to modify ECN in IPv6:
> @@ -2,6 +2,8 @@ post-v1.3.0
>
> - OpenFlow:
> - Added ability to match on IPv6 flow label through NXM.
>
Signed-off-by: Justin Pettit
---
NEWS |2 +
datapath/actions.c| 10 +--
datapath/datapath.c |4 ---
datapath/flow.c | 13 +++--
include/openflow/nicira-ext.h |9 ++
lib/classifier.c | 15 ++
10 matches
Mail list logo
