On Nov 9, 2011, at 7:29 AM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 11:06:21PM -0800, Justin Pettit wrote:
>> On Nov 8, 2011, at 4:24 PM, Ben Pfaff wrote:
>>
>>> I think that these |=s can become =s:
>>>
- key->ip.tos_frag |= OVS_FRAG_TYPE_LATER;
+
On Tue, Nov 8, 2011 at 11:56 PM, Justin Pettit wrote:
> On Nov 8, 2011, at 8:12 PM, Jesse Gross wrote:
>
>> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>>> diff --git a/datapath/flow.h b/datapath/flow.h
>>> index ba8c66a..f12b11a 100644
>>> --- a/datapath/flow.h
>>> +++ b/datapath/flow.h
On Tue, Nov 8, 2011 at 11:15 PM, Justin Pettit wrote:
> On Nov 8, 2011, at 8:13 PM, Jesse Gross wrote:
>
>> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
>>> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
This will be useful later when we add support for matching the ECN b
On Tue, Nov 08, 2011 at 11:06:21PM -0800, Justin Pettit wrote:
> On Nov 8, 2011, at 4:24 PM, Ben Pfaff wrote:
>
> > I think that these |=s can become =s:
> >
> >> - key->ip.tos_frag |= OVS_FRAG_TYPE_LATER;
> >> + key->ip.frag |= OVS_FRAG_TYPE_LATER;
> >>
> >> -
On Nov 8, 2011, at 8:12 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>> diff --git a/datapath/flow.h b/datapath/flow.h
>> index ba8c66a..f12b11a 100644
>> --- a/datapath/flow.h
>> +++ b/datapath/flow.h
>> @@ -147,7 +143,7 @@ u64 flow_used_time(unsigned long flow_j
On Nov 8, 2011, at 8:13 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
>> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
>>> This will be useful later when we add support for matching the ECN bits
>>> within the TOS field.
>>>
>>> Signed-off-by: Justin
On Nov 8, 2011, at 4:24 PM, Ben Pfaff wrote:
> I think that these |=s can become =s:
>
>> -key->ip.tos_frag |= OVS_FRAG_TYPE_LATER;
>> +key->ip.frag |= OVS_FRAG_TYPE_LATER;
>>
>> -key->ip.tos_frag |= OVS_FRAG_TYPE_FIRST;
>> +
On Tue, Nov 8, 2011 at 8:12 PM, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
>> diff --git a/datapath/flow.h b/datapath/flow.h
>> index ba8c66a..f12b11a 100644
>> --- a/datapath/flow.h
>> +++ b/datapath/flow.h
>> @@ -147,7 +143,7 @@ u64 flow_used_time(unsigned long fl
On Tue, Nov 08, 2011 at 08:13:31PM -0800, Jesse Gross wrote:
> On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
> > On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
> > Did you mean to update the comment on 'frag' below?
> >
> >> ??struct sw_flow_key {
> >> ?? ?? ?? struct {
> >> ??
On Tue, Nov 8, 2011 at 4:24 PM, Ben Pfaff wrote:
> On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
>> This will be useful later when we add support for matching the ECN bits
>> within the TOS field.
>>
>> Signed-off-by: Justin Pettit
>
> I think that these |=s can become =s:
There
On Tue, Nov 8, 2011 at 3:57 PM, Justin Pettit wrote:
> diff --git a/datapath/flow.h b/datapath/flow.h
> index ba8c66a..f12b11a 100644
> --- a/datapath/flow.h
> +++ b/datapath/flow.h
> @@ -147,7 +143,7 @@ u64 flow_used_time(unsigned long flow_jiffies);
> * OVS_KEY_ATTR_ETHERNET 12 -- 4
On Tue, Nov 08, 2011 at 03:57:29PM -0800, Justin Pettit wrote:
> This will be useful later when we add support for matching the ECN bits
> within the TOS field.
>
> Signed-off-by: Justin Pettit
I think that these |=s can become =s:
> if (offset) {
> - key->ip.t
This will be useful later when we add support for matching the ECN bits
within the TOS field.
Signed-off-by: Justin Pettit
---
datapath/datapath.c |6 +--
datapath/flow.c | 73 +-
datapath/flow.h | 10 ++
lib/classifier.
13 matches
Mail list logo
