Re: [ovs-dev] [PATCH 3/3] xlate: Always recirculate after an MPLS POP to a non-MPLS ethertype.

2016-02-26 Thread thomas.morin
2016-02-25, Ben Pfaff: Thomas: can you provide an example of the actions for your use case? mpls,in_port=1,mpls_label=200,mpls_bos=1 actions=pop_mpls:0x0800,mod_dl_src:5a:19:2a:49:c1:ee,mod_dl_dst:fa:16:3e:2f:82:b0,output:220 220 being a patchport, a veth or a tap interface. -Thomas ___

Re: [ovs-dev] [PATCH 3/3] xlate: Always recirculate after an MPLS POP to a non-MPLS ethertype.

2016-02-25 Thread thomas.morin
Hi Jarno, Ben, all, Sorry to chime in a bit late, but this recirculation performance penalty for the basic/key use-case where OVS receives an IP-in-MPLS frame and forwards it to the destination (e.g. a local VM), does not look appealing at all. To allow having the best of both worlds (avoid

Re: [ovs-dev] Problem in datapath flow: eth(bad key length 24, expected 12)

2016-02-03 Thread thomas.morin
Hi Jesse, I'm also running into a similar issue (or the same). This is wtih OVS 2.4.1 running the DKMS kernel datapath on kernel 3.13.0-55-generic (Ubuntu Trusty). # ovs-ofctl --version ovs-ofctl (Open vSwitch) 2.4.1 Compiled Sep 14 2015 15:20:24 OpenFlow versions 0x1:0x4 And, indeed the err

Re: [ovs-dev] [PATCH net-next 00/22 v2] Lightweight & flow based encapsulation

2015-07-22 Thread thomas.morin
Hi Thomas, This looks promising. One question: will this approach allow MPLS-in-GRE and MPLS-in-UDP ? -Thomas 2015-07-21, Thomas Graf: This series combines the work previously posted by Roopa, Robert and myself. It's according to what we discussed at NFWS. The motivation of this series is to:

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-05-26 Thread thomas.morin
Hi Jesse, 2014-05-22, Jesse Gross: >> 2014-05-19, Jesse Gross: >> [...snip...] > I actually have much less of a problem with including an EtherType > from a GRE tunnel. For one thing it actually exists in the packet > rather than being an artificial namespace. Another thing is that it

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-05-21 Thread thomas.morin
Hi Jesse, 2014-05-19, Jesse Gross: [...snip...] >>> I actually have much less of a problem with including an EtherType >>> from a GRE tunnel. For one thing it actually exists in the packet >>> rather than being an artificial namespace. Another thing is that it is >>> metadata akin to the input por

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-05-16 Thread thomas.morin
2014-05-16, Jesse Gross: > On Thu, May 15, 2014 at 1:28 AM, wrote: >> Hi Jesse, >> >> (below) >> >> 2014-05-09, Jesse Gross: >>> On Fri, Apr 25, 2014 at 4:56 AM, wrote: Hi Jesse, (inlined below) Jesse Gross : >> >> In general, I think it would be

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-05-15 Thread thomas.morin
Hi Jesse, (below) 2014-05-09, Jesse Gross: > On Fri, Apr 25, 2014 at 4:56 AM, wrote: >> Hi Jesse, >> >> (inlined below) >> >> Jesse Gross : In general, I think it would be a good idea for the flow key to have a field

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-04-25 Thread thomas.morin
Hi Jesse, 2014-04-25, Jesse Gross: >> Practically speaking, making your layer 3 port code work for >> MPLS-over-GRE is not entirely trivial: >> - on emission, compose_output_action__ pops the Ethernet header before >> push_mpls is called (which is done during commit_odp_actions) ; this >> does not

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-04-25 Thread thomas.morin
Hi Jesse, (inlined below) Jesse Gross : >> >> In general, I think it would be a good idea for the flow key to >> have >> a >> field >> specifying the layer 3 protocol, when an ethernet header is not >> present. > > That makes

Re: [ovs-dev] [PATCH v2 3/3] datapath: add layer 3 flow/port support

2014-04-17 Thread thomas.morin
Hi Lori, all, While I've attempted to adapt the layer 3 port patch to GRE tunneling, and obtained nice results for IP-over-GRE (as I reported last week), I've had a harder time reusing this framework for -over-GRE, in particular for MPLS-over-GRE. Given its name, I maybe shouldn't have expecte

Re: [ovs-dev] adding an option for GRE tunneling without an Ethernet header

2014-04-14 Thread thomas.morin
Hi Lori, 2014-04-14, Lori Jakab: > On 4/14/14, 11:01 AM, thomas.mo...@orange.com wrote: >> 2014-04-11, Lori Jakab: >>> On 4/11/14, 4:24 PM, thomas.mo...@orange.com wrote: The result is the following: - an option is added to GRE tunnel port, to allow making them OVS l3ports >>> My fi

Re: [ovs-dev] adding an option for GRE tunneling without an Ethernet header

2014-04-14 Thread thomas.morin
Hi Lori, 2014-04-11, Lori Jakab: > On 4/11/14, 4:24 PM, thomas.mo...@orange.com wrote: >> >> The result is the following: >> - an option is added to GRE tunnel port, to allow making them OVS l3ports > > My first impression is that starting with my patches and now yours there > are a lot of differe

Re: [ovs-dev] adding an option for GRE tunneling without an Ethernet header

2014-04-11 Thread thomas.morin
Hi Lori, I've ported my GRE patches to your l3port patches. You can find my changes at: https://github.com/tmmorin/openvswitch/tree/l3_v3_gre The result is the following: - an option is added to GRE tunnel port, to allow making them OVS l3ports - the vport-gre.c code is adapted to treat GRE

Re: [ovs-dev] adding an option for GRE tunneling without an Ethernet header

2014-02-28 Thread thomas.morin
Hi Ben, 2014-02-27, Ben Pfaff: > On Thu, Feb 27, 2014 at 05:16:18PM +, thomas.mo...@orange.com wrote: >> Currently, OVS GRE tunnels use Ethertype 6558 and the GRE packets >> produced by OVS hence always are xxx-over-Ethernet-over-GRE. >> Symmetrically OVS expects received GRE packets to be of

Re: [ovs-dev] adding an option for GRE tunneling without an Ethernet header

2014-02-28 Thread thomas.morin
Hi Lori, Praveen, Thank you for the pointer on l3 vports. I'll have a look at this. -Thomas 2014-02-27, Lori Jakab: > Hi Thomas, > > I'm the original contributor of the LISP tunneling code. Since it was > originally accepted, I have been working on a series of patches to > enable more generic

[ovs-dev] adding an option for GRE tunneling without an Ethernet header

2014-02-27 Thread thomas.morin
Hello, Currently, OVS GRE tunnels use Ethertype 6558 and the GRE packets produced by OVS hence always are xxx-over-Ethernet-over-GRE. Symmetrically OVS expects received GRE packets to be of the same ethertype and carry an Ethernet payload. I have written the included patch, which does the foll