Hi Jarno, Ben, all,
Sorry to chime in a bit late, but this recirculation performance penalty
for the basic/key use-case where OVS receives an IP-in-MPLS frame and
forwards it to the destination (e.g. a local VM), does not look
appealing at all.
To allow having the best of both worlds (avoid perf penalty in all
cases, but avoid complex code to automatically determine whether
recirculation is needed or not), would it be possible to specify in a
flow, after an mpls match, whether or not recirculation is wanted ?
Best,
-Thomas
Jarno Rajahalme :
Thanks for the reviews, series pushed to master.
Jarno
On Feb 23, 2016, at 8:21 PM, Ben Pfaff <b...@ovn.org> wrote:
On Wed, Feb 17, 2016 at 11:45:30AM -0800, Jarno Rajahalme wrote:
So far we have tried to optimize MPLS POP action not to recirculate
unless later matching actually needs the inner headers. This made the
code complex and error-prone. Also the cases where this optimization
would have been useful seem rare, as one would typically want to do
something else with the inner packet than blindly send it to some
output port.
With this change multiple consecutive MPLS POPs do not need
recirculation in between, so even if the blind output case is now
little bit less optimal, the multiple POP case is correspondingly
faster with this change.
Suggested-by: Ben Pfaff <b...@ovn.org>
Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
Thank you.
Acked-by: Ben Pfaff <b...@ovn.org>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
_________________________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations
confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce
message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou
falsifie. Merci.
This message and its attachments may contain confidential or privileged
information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete
this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been
modified, changed or falsified.
Thank you.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
