Re: [ovs-dev] ovn: Improving southbound database security

2016-10-13 Thread Numan Siddique
We may have to add one more item in the task breakdown list. Please see below On Wed, Oct 12, 2016 at 11:21 PM, Russell Bryant wrote: > Hello, I'm back to looking at southbound database security concerns in > OVN. A previous thread discussing approaches was here: > > http://openvswitch.org

[ovs-dev] Native DNS support proposal in OVN for internal DNS resolution

2016-10-13 Thread Numan Siddique
Below is the proposal to add native DNS support in OVN for internal DNS resolution. This will be useful If a VM sends a DNS lookup request for another VM belonging to the same virtual network. - hostname of the logical ports will be stored in the north db lsp row - ovn-northd will add the below

[ovs-dev] [PATCH v2] python: Add SSL support to the python ovs client library

2016-10-05 Thread Numan Siddique
SSL support is added to the ovs/stream.py. pyOpenSSL library is used to support SSL. If this library is not present, then the SSL stream is not registered with the Stream class. Signed-off-by: Numan Siddique --- python/ovs/poller.py | 8 + python/ovs/stream.py | 91

Re: [ovs-dev] [PATCH] python: Add SSL support to the python ovs client library

2016-10-05 Thread Numan Siddique
> > > > stderr: > Traceback (most recent call last): > File "../../../../tests/test-ovsdb.py", line 835, in > main(sys.argv) > File "../../../../tests/test-ovsdb.py", line 830, in main > func(*args) > File "../../../../tests/test-ovsdb.py", line 592, in do_idl > while idl.change_

Re: [ovs-dev] [patch v1] ovn: ovn-ctl support to start ovn db servers in backup mode

2016-09-01 Thread Numan Siddique
On Thu, Sep 1, 2016 at 3:29 PM, Numan Siddique wrote: > > > On Thu, Sep 1, 2016 at 10:51 AM, wrote: > >> From: Babu Shanmugam >> >> This patch adds support to start_ovsdb() function in ovn-ctl to start the >> ovn db servers in backup mode. This can be

Re: [ovs-dev] please help review patch "allow DHCPv6 respond multiple IA Address Options"

2016-09-01 Thread Numan Siddique
On Wed, Aug 31, 2016 at 8:44 AM, Zong Kai Li wrote: > On Tue, Aug 30, 2016 at 8:28 PM, Numan Siddique > wrote: > > > > > > On Tue, Aug 30, 2016 at 9:40 AM, Ben Pfaff wrote: > >> > >> The patch will get reviewed, there's no need to ask again. >

Re: [ovs-dev] [patch v1] ovn: ovn-ctl support to start ovn db servers in backup mode

2016-09-01 Thread Numan Siddique
On Thu, Sep 1, 2016 at 10:51 AM, wrote: > From: Babu Shanmugam > > This patch adds support to start_ovsdb() function in ovn-ctl to start the > ovn db servers in backup mode. This can be done in the following ways > 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr to >set

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

2016-08-31 Thread Numan Siddique
On Wed, Aug 31, 2016 at 5:36 PM, Numan Siddique wrote: > > > On Wed, Aug 31, 2016 at 12:03 AM, Andy Zhou wrote: > >> >> >> On Tue, Aug 30, 2016 at 4:17 AM, Numan Siddique >> wrote: >> >>> >>> >>> On Tue, Aug 30, 2016 at 1:11

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

2016-08-31 Thread Numan Siddique
On Wed, Aug 31, 2016 at 12:03 AM, Andy Zhou wrote: > > > On Tue, Aug 30, 2016 at 4:17 AM, Numan Siddique > wrote: > >> >> >> On Tue, Aug 30, 2016 at 1:11 AM, Andy Zhou wrote: >> >>> >>> >>> On Mon, Aug 29, 2016 at 3:14 AM, Numan

Re: [ovs-dev] [PATCH] ovs-monitor-ipsec: Fix flake8-check semicolon error

2016-08-31 Thread Numan Siddique
;proto", "gre", "dir", "out", > "mark", IPSEC_MARK, "mask", IPSEC_MARK, > - "action", "block", "priority", "4294967295"]); > + "action

Re: [ovs-dev] please help review patch "allow DHCPv6 respond multiple IA Address Options"

2016-08-30 Thread Numan Siddique
On Tue, Aug 30, 2016 at 9:40 AM, Ben Pfaff wrote: > The patch will get reviewed, there's no need to ask again. > > On Tue, Aug 30, 2016 at 11:09:23AM +0800, Zong Kai Li wrote: > > Hi, Numan and Justin. > > I wish you can help review patch "allow DHCPv6 respond multiple IA > > Address Options". >

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

2016-08-30 Thread Numan Siddique
On Tue, Aug 30, 2016 at 1:11 AM, Andy Zhou wrote: > > > On Mon, Aug 29, 2016 at 3:14 AM, Numan Siddique > wrote: > >> >> >> On Sat, Aug 27, 2016 at 4:45 AM, Andy Zhou wrote: >> >>> Added the '--no-sync' option base on feedbacks of curre

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

2016-08-29 Thread Numan Siddique
On Sat, Aug 27, 2016 at 4:45 AM, Andy Zhou wrote: > Added the '--no-sync' option base on feedbacks of current > implementation. > > Added appctl command "ovsdb-server/sync-status" based on feedbacks > of current implementation. > > Added a test to simulate the integration of HA manager with OVSDB

Re: [ovs-dev] [Replication SM 0/7] Replication SM

2016-08-25 Thread Numan Siddique
On Thu, Aug 25, 2016 at 5:37 AM, Andy Zhou wrote: > The main purpose of this series patch 6 (OVSDB: Reimplement > replication. Using a state machine). Patch 7 includes > a few replication usability enhancements that has been requested > on the mailing list. > > Andy Zhou (7): > ovsdb: Properly

Re: [ovs-dev] ovsdb active backup deployment

2016-08-21 Thread Numan Siddique
On Sat, Aug 20, 2016 at 2:19 AM, Andy Zhou wrote: > > > On Fri, Aug 19, 2016 at 11:48 AM, Numan Siddique > wrote: > >> >> >> On Wed, Aug 17, 2016 at 11:24 PM, Andy Zhou wrote: >> >>> >>> >>> On Wed, Aug 17, 2016 at 8:30 AM,

Re: [ovs-dev] ovsdb active backup deployment

2016-08-19 Thread Numan Siddique
On Wed, Aug 17, 2016 at 11:24 PM, Andy Zhou wrote: > > > On Wed, Aug 17, 2016 at 8:30 AM, Numan Siddique > wrote: > >> ​Hi Andy, >> I have started working on integrating ovsdb-server HA support with >> pacemaker (via OCF heartbeat, i.e ocf:heartbeat)

[ovs-dev] [PATCH v2] ovsdb-server: Add ovsdb-server/is-backup-server command in unixctl

2016-08-19 Thread Numan Siddique
This command will be useful to query if the ovsdb-server instance is active or backup. Signed-off-by: Numan Siddique --- ovsdb/ovsdb-server.1.in | 4 ovsdb/ovsdb-server.c| 17 + tests/ovsdb-server.at | 19 +++ 3 files changed, 40 insertions(+) v1

[ovs-dev] [PATCH] ovsdb-server: Add ovsdb-server/is-backup-server command in unixctl

2016-08-19 Thread Numan Siddique
This command will be useful to query if the ovsdb-server instance is active or backup. Signed-off-by: Numan Siddique --- ovsdb/ovsdb-server.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index e08c341..283ec1b 100644 --- a

Re: [ovs-dev] [PATCH 2/2] ovn/TODO: Add items proposed for 2.7 in OVN IRC meeting.

2016-08-18 Thread Numan Siddique
On Thu, Aug 18, 2016 at 11:44 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ovn/TODO | 55 +++ > 1 file changed, 55 insertions(+) > > diff --git a/ovn/TODO b/ovn/TODO > index b3c4831..97a5fc9 100644 > --- a/ovn/TODO > +++ b/ovn/TODO

Re: [ovs-dev] [PATCH] ovn-northd: Remove unnecessary 'if' test from build_acls().

2016-08-17 Thread Numan Siddique
nzero > because it doesn't affect the behavior of the code protected by the 'if' > statement. > > This change is best viewed ignoring white space only changes. > > Signed-off-by: Ben Pfaff > --- > ​​ Thanks for correcting it. ​Acked-by: Numan Siddique

Re: [ovs-dev] ovsdb active backup deployment

2016-08-17 Thread Numan Siddique
​Hi Andy, I have started working on integrating ovsdb-server HA support with pacemaker (via OCF heartbeat, i.e ocf:heartbeat). Few comments below. > > >>> Thanks for helping out. > >>> > >>> Given that, I now plan to work from bottom up, initially focusing on > >>> ovsdb server changes. > >>> >

Re: [ovs-dev] [PATCH v2] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-11 Thread Numan Siddique
On Thu, Aug 11, 2016 at 7:45 PM, Ryan Moats wrote: > "dev" wrote on 08/11/2016 07:21:39 AM: > > > > > Signed-off-by: Numan Siddique > > --- > > This all looks does what it promises, so let's get the immediate > out of the way: > > A

[ovs-dev] [PATCH v2] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-11 Thread Numan Siddique
alled after the reconnection - the hmap "installed_flows" is not cleared, because of which ofctrl_put skips adding the flows to the switch. This patch fixes the issue and also adds a test case to test this scenario. Signed-off-by: Numan Siddique --- ovn/controller/ofctrl.c | 7 +++

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-11 Thread Numan Siddique
On Wed, Aug 10, 2016 at 6:07 AM, Numan Siddique wrote: > On Aug 9, 2016 8:28 PM, "Ryan Moats" wrote: > > > > Numan Siddique wrote on 08/09/2016 09:39:21 AM: > > > > > From: Numan Siddique > > > To: Ryan Moats/Omaha/IBM@IBMUS > > > Cc:

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
On Aug 9, 2016 8:28 PM, "Ryan Moats" wrote: > > Numan Siddique wrote on 08/09/2016 09:39:21 AM: > > > From: Numan Siddique > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 08/09/2016 09:39 AM > > Subject: Re: [ovs-dev] [PATCH] ov

Re: [ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
On Tue, Aug 9, 2016 at 7:15 PM, Ryan Moats wrote: > "dev" wrote on 08/09/2016 07:19:27 AM: > > > From: Numan Siddique > > To: ovs dev > > Date: 08/09/2016 07:19 AM > > Subject: [ovs-dev] [PATCH] ovn-controller: Reset flow processing > > af

[ovs-dev] [PATCH] ovn-controller: Reset flow processing after (re)connection to switch

2016-08-09 Thread Numan Siddique
alled after the reconnection - the hmap "installed_flows" is not cleared, because of which ofctrl_put skips adding the flows to the switch. This patch fixes the issue and also adds a test case to test this scenario. Signed-off-by: Numan Siddique --- ovn/controller/ofctrl.c | 7 ++

[ovs-dev] [PATCH v5 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-08-04 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v5 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-08-04 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- include/ovn/actions.h| 11 ++ ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ov

[ovs-dev] [PATCH v5 0/2] ovn: Support native DHCPv6

2016-08-04 Thread Numan Siddique
* Updated documentation patch 2 * Addressed the review comments * Updated documentation -- Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller ovn-northd: Add logical flows to support DHCPv6 include/ovn/actions.h |

[ovs-dev] [PATCH v4 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-08-01 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- include/ovn/actions.h| 11 ++ ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ov

[ovs-dev] [PATCH v4 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-08-01 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v4 0/2] ovn: Support native DHCPv6

2016-08-01 Thread Numan Siddique
Addressed the review comments * Updated documentation -- Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller ovn-northd: Add logical flows to support DHCPv6 include/ovn/actions.h | 11 ++ lib/packets.h | 1 + ovn

[ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-30 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v3 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-30 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- include/ovn/actions.h| 12 ++ ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ov

[ovs-dev] [PATCH v3 0/2] ovn: Support native DHCPv6

2016-07-30 Thread Numan Siddique
v2 -> v3 --- * Rebased the code. * Patch had merge conflict. Resolved it. v1 -> v2 patch 1 * Renamed the DHCPv6 option names from caps to lower cases * Updated documentation patch 2 * Addressed the review comments * Updated documentation -- Numan Si

[ovs-dev] [PATCH v4] ovn-controller: Add datapath-type and iface-types in chassis:external_ids

2016-07-30 Thread Numan Siddique
itoring OVN SB DB to determine the datapath type (DPDK or non-DPDK) configured and take some actions based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chass

[ovs-dev] [PATCH v3] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-29 Thread Numan Siddique
based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chassis.c| 38 ++ ovn/controller/chassis.h| 3 ++- ovn

[ovs-dev] [PATCH v2] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-29 Thread Numan Siddique
based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chassis.c| 38 ++ ovn/controller/chassis.h| 3 ++- ovn

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Numan Siddique
On Thu, Jul 28, 2016 at 10:28 PM, Ben Pfaff wrote: > On Thu, Jul 28, 2016 at 08:05:20PM +0530, Numan Siddique wrote: > > This patch reads the external_ids:datapath-type value from the > > Open_vSwitch table if defined and sets it in the > external_ids:datapath-type > > of

[ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Numan Siddique
some actions based on it. One usecase is, OVN neutron plugin can use this information to set the vif_type (ovs or vhostuser) during the port binding. Signed-off-by: Numan Siddique --- ovn/controller/chassis.c | 36 tests/ovn-controller.at | 48

[ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-27 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v2 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-27 Thread Numan Siddique
Upcoming patch will add logical flows using this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 16 ++- ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 12 ++ ov

[ovs-dev] [PATCH v2 0/2] ovn: Support native DHCPv6

2016-07-27 Thread Numan Siddique
Patch 1 of the version 1 of the series is merged. v1 -> v2 patch 1 * Renamed the DHCPv6 option names from caps to lower cases * Updated documentation patch 2 * Addressed the review comments * Updated documentation -- Numan Siddique (2): ovn-controller:

Re: [ovs-dev] [PATCH] ovn-nbctl: Improve usage message.

2016-07-27 Thread Numan Siddique
n\ > - displays the DHCP options of th > DHCP_OPTIONS_UUID\n\ > + displays the DHCP options for > DHCP_OPTIONS_UUID\n\ > \n\ > %s\ > \n\ > Sorry for the typo and incorrect grammar in the original patch Acked-by: Numan Siddi

Re: [ovs-dev] [PATCH v1 2/3] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 2:07 AM, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 12:55:00AM +0530, Numan Siddique wrote: > > This patch adds a new OVN action 'put_dhcpv6_opts' to support native > > DHCPv6 in OVN. > > > > ovn-controller parses this action and a

Re: [ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Numan Siddique
This patch has "Tested-by: Ramu Ramamurthy " and "Acked-by: Ramu Ramamurthy " and every time I forget to add this when I resubmit the patch. Ramu - My apologies Thanks Numan On Wed, Jul 27, 2016 at 12:54 AM, Numan Siddique wrote: > OVN implements a native DHCPv4 supp

Re: [ovs-dev] [ovs-dev, v2, 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 12:08 AM, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 12:01:06AM +0530, Numan Siddique wrote: > > OVN implements native DHCPv6. DHCPv6 options are stored > > in the 'DHCP_Options' NB table and logical ports refer to this > > table

[ovs-dev] [PATCH v1 3/3] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v1 2/3] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
table. Upcoming patch will add logical flows with this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 7 ++ ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 9 ++

[ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

[ovs-dev] [PATCH v1 0/3] ovn: Support native DHCPv4 and DHCPv6 proposal

2016-07-26 Thread Numan Siddique
This patch series support native DHCPv4 and native DHCPv6 in OVN. Patch 1 adds DHCPv4 logical flows in ovn northd. It uses the OVN action "put_dhcp_opts". Patch 2 and 3 adds native DHCPv6 support. -------- Numan Siddique (3): ovn-northd: Add logical flows to support nat

[ovs-dev] [PATCH v2 0/2] ovn: Native DHCPv6 Support

2016-07-26 Thread Numan Siddique
This patch set implements native DHCPv6 in OVN. Patch 2 depends on the ovn-northd DHCPv4 patch - https://patchwork.ozlabs.org/patch/651958/ v1 -> v2 * Resolved the merge conflicts and rebased. ---- Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts'

Re: [ovs-dev] [PATCH v1 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 12:01 AM, Ben Pfaff wrote: > On Tue, Jul 19, 2016 at 12:36:43AM +0530, Numan Siddique wrote: > > This patch adds a new OVN action 'put_dhcpv6_opts' to support native > > DHCPv6 in OVN. > > > > ovn-controller parses this action and a

[ovs-dev] [PATCH v2 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
table. Upcoming patch will add logical flows with this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 7 ++ ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 9 ++

[ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v2] python: Send old values of the updated cols in notify for update2

2016-07-26 Thread Numan Siddique
r. This patch fixes this issue. It also updates the description of the 'updates' param of the notify function to make it more clear. Fixes: 897c8064 ("python: move Python idl to work with monitor_cond") Signed-off-by: Numan Siddique --- python/ovs/db/

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-26 Thread Numan Siddique
On Tue, Jul 26, 2016 at 6:02 PM, Russell Bryant wrote: > > > On Tue, Jul 5, 2016 at 1:10 AM, Numan Siddique > wrote: > >> > >> > >> > >> > OK. >> > >> > If you have time and the inclination, please feel free to experiment

Re: [ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

2016-07-25 Thread Numan Siddique
On Mon, Jul 25, 2016 at 10:10 PM, Russell Bryant wrote: > > On Thu, Jul 21, 2016 at 6:21 AM, Numan Siddique > wrote: > >> When python IDL calls the "notify" function after processing the "update2" >> message from ovsdb-server, it is suppose to send

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

2016-07-24 Thread Numan Siddique
On Sun, Jul 24, 2016 at 6:26 AM, Ryan Moats wrote: > "dev" wrote on 07/21/2016 05:36:13 AM: > > > From: nickcooper-zhangtonghao > > To: dev@openvswitch.org > > Cc: nickcooper-zhangtonghao > > Date: 07/21/2016 05:36 AM > > Subject: [ovs-dev] [PATCH] ovn: remove the dead code. > > Sent by: "dev"

[ovs-dev] [PATCH v7] ovn-northd: Add logical flows to support native DHCPv4

2016-07-23 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

[ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

2016-07-21 Thread Numan Siddique
r. This patch fixes this issue. It also updates the description of the 'updates' param of the notify function to make it more clear. Fixes: 897c8064 ("python: move Python idl to work with monitor_cond") Signed-off-by: Numan Siddique --- python/ovs/db/idl.py | 19 ++

[ovs-dev] [PATCH v6] ovn-northd: Add logical flows to support native DHCPv4

2016-07-20 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

Re: [ovs-dev] [ovs-dev, v23, 2/2] ovn-controller: Add incremental processing to lflow_run and physical_run

2016-07-19 Thread Numan Siddique
On Tue, Jul 19, 2016 at 5:40 PM, Ryan Moats wrote: > Ben Pfaff wrote on 07/19/2016 12:57:23 AM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 12:57 AM > > Subject: Re: [ovs-dev, v23, 2/2] ovn-controller: Add incremental > > processing

Re: [ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

2016-07-18 Thread Numan Siddique
On Mon, Jul 18, 2016 at 11:40 PM, Ben Pfaff wrote: > On Fri, Jul 15, 2016 at 08:33:59PM +0530, Numan Siddique wrote: > > To support 128-bits in ct_label, the value of the ct_label is expected > > as a hex string in the 'ct_commit' action. > > > > Added a new

[ovs-dev] [PATCH v1 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-18 Thread Numan Siddique
ons to the DHCPv6 request packets using the 'put_dhcpv6_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCPv6 reponder by sending the DHCPv6 reply back to the inport once the 'put_dhcpv6_opts' action is applied. Signed-of

[ovs-dev] [PATCH v1 1/2] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-18 Thread Numan Siddique
table. Upcoming patch will add logical flows with this action. Signed-off-by: Numan Siddique --- ovn/controller/lflow.c | 6 + ovn/controller/pinctrl.c | 295 +++ ovn/lib/actions.c| 114 ++ ovn/lib/actions.h| 9 ++ ov

[ovs-dev] [PATCH v1 0/2] ovn: Support native DHCPv6

2016-07-18 Thread Numan Siddique
This patch set implements native DHCPv6 in OVN. Patch 2 depends on the ovn-northd DHCPv4 patch - https://patchwork.ozlabs.org/patch/648487/ - Numan Siddique (2): ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller ovn-northd: Add logical flows to supp

[ovs-dev] [PATCH v2] ovn: Add 128-bit support for ct_label

2016-07-15 Thread Numan Siddique
To support 128-bits in ct_label, the value of the ct_label is expected as a hex string in the 'ct_commit' action. Added a new accessor in the 'mf_subvalue' struct to access ovs_be128 values. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h

[ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

2016-07-15 Thread Numan Siddique
To support 128-bits in ct_label, the value of the ct_label is expected as a hex string in the 'ct_commit' action. Added a new accessor in the 'mf_subvalue' struct to access ovs_be128 values. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h

[ovs-dev] [PATCH v5] ovn-northd: Add logical flows to support native DHCPv4

2016-07-14 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 256 +- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

Re: [ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

2016-07-08 Thread Numan Siddique
On Jul 8, 2016 8:04 PM, "Russell Bryant" wrote: > > > > On Thu, Jul 7, 2016 at 11:47 PM, Numan Siddique wrote: >> >> Thanks for the review Russel. >> Please see comments inline. >> >> On Fri, Jul 8, 2016 at 1:19 AM, Russell Bryant wrote:

[ovs-dev] [PATCH v2] ovn: Support l2gateway-chassis option in "l2gateway" logical ports

2016-07-08 Thread Numan Siddique
ovn-controller will now bind the l2gateway logical ports. Signed-Off-by: Numan Siddique --- ovn/TODO | 11 --- ovn/controller/binding.c | 34 -- ovn/ovn-nb.xml | 7 +++ ovn/ovn-sb.xml | 8 ++-- tests/ovn.at

Re: [ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

2016-07-07 Thread Numan Siddique
Thanks for the review Russel. Please see comments inline. On Fri, Jul 8, 2016 at 1:19 AM, Russell Bryant wrote: > Thanks for working on this! A few comments ... > > On Mon, Jul 4, 2016 at 7:10 AM, Numan Siddique > wrote: > >> ovn-controller will now bind the l2

Re: [ovs-dev] [PATCH v4] ovn-northd: Add logical flows to support native DHCPv4

2016-07-06 Thread Numan Siddique
On Tue, Jul 5, 2016 at 12:04 PM, Zong Kai LI wrote: > +/* Logical switch ingress table 10 and 11: DHCP options and response >> + * priority 100 flows. */ >> +HMAP_FOR_EACH (op, key_node, ports) { >> +if (!op->nbs) { >> + continue; >> +} >> + >> +i

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-04 Thread Numan Siddique
> > > > OK. > > If you have time and the inclination, please feel free to experiment a > bit with the definition of BUILD_ASSERT_TYPE to see if you can make it > work without warnings. > ​Thanks for the pointers. I will give it a try. Regards Numan ​ __

[ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

2016-07-04 Thread Numan Siddique
ovn-controller will now bind the l2gateway logical ports. Signed-Off-by: Numan Siddique --- ovn/TODO | 9 - ovn/controller/binding.c | 33 +++-- ovn/ovn-nb.xml | 7 +++ ovn/ovn-sb.xml | 6 ++ tests/ovn.at

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-03 Thread Numan Siddique
On Mon, Jul 4, 2016 at 10:47 AM, Ben Pfaff wrote: > On Mon, Jul 04, 2016 at 10:17:24AM +0530, Numan Siddique wrote: > > I am seeing the below compiler warnings with GCC version 6.1 on Fedora > 24. > > > > $gcc --version > > gcc (GCC) 6.1.1 20160621 (Red Hat 6.1

[ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-07-03 Thread Numan Siddique
Hello Everyone, I am seeing the below compiler warnings with GCC version 6.1 on Fedora 24. $gcc --version gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3) libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I ../include -I ./include -I ../lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -

[ovs-dev] [PATCH v4] ovn-northd: Add logical flows to support native DHCPv4

2016-07-03 Thread Numan Siddique
ion is applied. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 91 +- ovn/northd/ovn-northd.c | 267 +-- ovn/ovn-nb.ovsschema | 20 ++- ovn/o

Re: [ovs-dev] [PATCH v3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-03 Thread Numan Siddique
On Mon, Jul 4, 2016 at 4:16 AM, Ben Pfaff wrote: > On Sun, Jul 03, 2016 at 11:57:23AM +0530, Numan Siddique wrote: > > OVN implements a native DHCPv4 support which caters to the common > > use case of providing an IP address to a booting instance by > > providing statel

[ovs-dev] [PATCH v3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-02 Thread Numan Siddique
using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCPv4 reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-off-by: Numan Siddique Co-authored-by:

Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Numan Siddique
On Mon, Jun 27, 2016 at 10:35 PM, Zong Kai LI wrote: > +static void >> +check_and_add_supported_dhcp_opts_to_sb_db(struct northd_context *ctx) >> +{ >> +static bool nothing_to_add = false; >> + >> +if (nothing_to_add) { >> +return; >> +} >> + >> +struct hmap dhcp_opts_to_a

Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Numan Siddique
Hi Zonk Kai Li, Thanks for the review. See inline for the comments. On Mon, Jun 27, 2016 at 9:38 PM, Zong Kai LI wrote: > + >> +eth.dst = eth.src; >> +eth.src = E; >> +ip4.dst = O; >> +ip4.src = S; >> +udp.src = 67; >> +udp.dst = 68; >> +outport = P; >> +inport = ""; /* Allow sending out

[ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Numan Siddique
using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCPv4 reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-off-by: Numan Siddique Co-authored-by:

Re: [ovs-dev] [PATCH v2 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-27 Thread Numan Siddique
On Fri, Jun 24, 2016 at 8:21 AM, Numan Siddique wrote: > > > On Fri, Jun 24, 2016 at 4:13 AM, Ben Pfaff wrote: > >> On Wed, Jun 15, 2016 at 02:48:27PM +0530, Numan Siddique wrote: >> > OVN implements a native DHCP support which caters to the common >> > use

[ovs-dev] [PATCH] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Numan Siddique
using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCPv4 reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-off-by: Numan Siddique Co-authored-by:

Re: [ovs-dev] [PATCH v2 3/4] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-06-23 Thread Numan Siddique
On Fri, Jun 24, 2016 at 3:57 AM, Ben Pfaff wrote: > On Wed, Jun 15, 2016 at 02:47:35PM +0530, Numan Siddique wrote: > > This patch adds a new OVN action 'put_dhcp_opts' to support native > > DHCP in OVN. > > Applied to master, thanks! > ​Thanks Ben for the

Re: [ovs-dev] [PATCH v2 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-23 Thread Numan Siddique
On Fri, Jun 24, 2016 at 4:13 AM, Ben Pfaff wrote: > On Wed, Jun 15, 2016 at 02:48:27PM +0530, Numan Siddique wrote: > > OVN implements a native DHCP support which caters to the common > > use case of providing an IP address to a booting instance by > > providing stat

Re: [ovs-dev] [PATCH v2 0/4] OVN DHCP support proposal

2016-06-15 Thread Numan Siddique
On Wed, Jun 15, 2016 at 8:44 PM, Ryan Moats wrote: > "dev" wrote on 06/15/2016 04:16:44 AM: > > > From: Numan Siddique > > To: ovs dev > > Date: 06/15/2016 04:17 AM > > Subject: [ovs-dev] [PATCH v2 0/4] OVN DHCP support proposal > &

[ovs-dev] [PATCH v2 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-15 Thread Numan Siddique
the DHCP request packets using the 'put_dhcp_opts' action and advances the packet to the next stage. - A logical flow which implements the DHCP reponder by sending the DHCP reply back to the inport once the 'put_dhcp_opts' action is applied. Signed-off-by: Numan Sid

[ovs-dev] [PATCH v2 3/4] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-06-15 Thread Numan Siddique
add logical flows with this action. Signed-off-by: Numan Siddique Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- include/openvswitch/meta-flow.h | 12 +++ lib/dhcp.h | 13 +++ ovn/controller/lflow.c | 11 +++ ovn/controller/pinctrl.c| 188 +

[ovs-dev] [PATCH v2 0/4] OVN DHCP support proposal

2016-06-15 Thread Numan Siddique
ng" and "resuming" the pipeline. The trip to ovn-controller should be transparent to the writer of the OVN logical flows. - Ben Pfaff (2): expr: Shorten declarations of expr_context. expr: Refactor parsing of assignments and exchanges. Numan Siddique (2):

Re: [ovs-dev] [ovs-dev, 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-14 Thread Numan Siddique
> > > This patch set appears to have multiple collisions when I try > to apply it - should it be rebased? > > ​ ​I will fix the conflicts and submit the patch. ​ > Ryan > ___ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/list

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Add logical flows to support native DHCP

2016-06-13 Thread Numan Siddique
On Thu, Jun 9, 2016 at 11:08 AM, Ben Pfaff wrote: > From: Numan Siddique > > OVN implements a native DHCP support which caters to the common > use case of providing an IP address to a booting instance by > providing stateless replies to DHCP requests based on statically >

Re: [ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

2016-06-09 Thread Numan Siddique
On Fri, Jun 10, 2016 at 3:34 AM, FlaviofOvsML wrote: > > > On Tue, Jun 7, 2016 at 1:49 AM, Numan Siddique > wrote: > >> OVN implements a native DHCP support which caters to the common >> use case of providing an IP address to a booting instance by >> providing s

Re: [ovs-dev] [PATCH 0/4] OVN DHCP support proposal

2016-06-09 Thread Numan Siddique
is series. ​ > - Revised ovn-northd and documentation to avoid talking about > "pausing" and "resuming" the pipeline. The trip to ovn-controller > should be transparent to the writer of the OVN logical flows. > > Ben Pfaff (2): > expr: Shorten d

Re: [ovs-dev] [PATCH v10 0/2] ovn: Support native DHCP using 'continuations'

2016-06-08 Thread Numan Siddique
On Thu, Jun 9, 2016 at 11:09 AM, Ben Pfaff wrote: > I liked this series but I wanted to make some changes, so I sent out my > own proposal based on it, with patch 0/4 starting here: > http://openvswitch.org/pipermail/dev/2016-June/072517.html > > Will you look it over and see what you thi

Re: [ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

2016-06-08 Thread Numan Siddique
Sorry for the typo Ramu On Jun 9, 2016 5:40 AM, "Numan Siddique" wrote: > Thanks Dani for testing the patches. > Regards > Numan > On Jun 9, 2016 12:25 AM, "Ramu Ramamurthy" > wrote: > >> I tested and verified this patchset using the corresponding

Re: [ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

2016-06-08 Thread Numan Siddique
ptions > that are used when VMs boot. > > On Mon, Jun 6, 2016 at 10:49 PM, Numan Siddique > wrote: > > OVN implements a native DHCP support which caters to the common > > use case of providing an IP address to a booting instance by > > providing stateless replies to DHCP

  1   2   3   >