v1 -> v2 changes
----------------
* Rebased the patches
* Patches 1 and 2 are from Ben and no changes. So not posting again.
Please see
* https://patchwork.ozlabs.org/patch/632633/
* https://patchwork.ozlabs.org/patch/632634/
* Patch 3 changes
* Deleted the extra test case "put_dhcp_opts" in ovn.at as it is not
required now
* Deleted the tests/test-ovn-dhcp.c
* Patch 4 changes
* Resolved the merge conflicts.
* In the function "build_dhcp_aciton" changed
- ds_put_format(pause_action, "put_dhcp_opts(reg0, offerip =
"IP_FMT", ",
+ ds_put_format(pause_action, "reg0[0] = put_dhcp_opts(offerip =
"IP_FMT", ",
IP_ARGS(offer_ip));
* Fixed the dhcp test case failure
v1
---
Patches 1 and 2 are new.
Patch 3 is based on https://patchwork.ozlabs.org/patch/631320/, with:
- Minor style fixes.
- Change syntax of put_dhcp_opts(), from:
put_dhcp_opts(reg0, offerip=1.2.3.4, ...)
to:
reg0[0] = put_dhcp_opts(offerip=1.2.3.4, ...)
That is, the result is now expressed as a return value, which is
more natural for people coming from C, and the result is now a
single bit instead of an entire register, which makes more sense
for a Boolean anyway and doesn't use up a whole register.
- Arguments to put_dhcp_opts are now architecture independent instead
of host-endian, which makes it possible to test them using the
test-ovn "parse-actions" instead of a separate program.
- Added negative tests for put_dhcp_opts parsing.
- Revised documentation to avoid talking about "pausing" and "resuming"
the pipeline. The trip to ovn-controller should be transparent to
the writer of the OVN logical flows.
Patch 4 is based on https://patchwork.ozlabs.org/patch/631321/, with:
- Minor style fixes.
- Adapt actions to changed put_dhcp_opts() syntax.
- Revised ovn-northd and documentation to avoid talking about
"pausing" and "resuming" the pipeline. The trip to ovn-controller
should be transparent to the writer of the OVN logical flows.
---------------------
Ben Pfaff (2):
expr: Shorten declarations of expr_context.
expr: Refactor parsing of assignments and exchanges.
Numan Siddique (2):
ovn-controller: Add 'put_dhcp_opts' action in ovn-controller
ovn-northd: Add logical flows to support native DHCP
include/openvswitch/meta-flow.h | 12 ++
lib/dhcp.h | 13 ++
ovn/controller/lflow.c | 11 ++
ovn/controller/pinctrl.c | 188 +++++++++++++++++++++++-
ovn/lib/actions.c | 252 +++++++++++++++++++++++++++++---
ovn/lib/actions.h | 13 ++
ovn/lib/automake.mk | 1 +
ovn/lib/expr.c | 246 ++++++++++++++-----------------
ovn/lib/expr.h | 74 +++++++++-
ovn/lib/ovn-dhcp.h | 111 ++++++++++++++
ovn/northd/ovn-northd.8.xml | 91 +++++++++++-
ovn/northd/ovn-northd.c | 267 +++++++++++++++++++++++++++++++++-
ovn/ovn-nb.ovsschema | 19 ++-
ovn/ovn-nb.xml | 314 +++++++++++++++++++++++++++++++++++++++-
ovn/ovn-sb.ovsschema | 16 +-
ovn/ovn-sb.xml | 198 +++++++++++++++++++++++++
ovn/utilities/ovn-nbctl.8.xml | 29 ++++
ovn/utilities/ovn-nbctl.c | 200 ++++++++++++++++++++++++-
tests/automake.mk | 1 +
tests/ovn.at | 276 ++++++++++++++++++++++++++++++++++-
tests/test-ovn-dhcp.c | 156 ++++++++++++++++++++
tests/test-ovn.c | 32 ++++
22 files changed, 2344 insertions(+), 176 deletions(-)
create mode 100644 ovn/lib/ovn-dhcp.h
create mode 100644 tests/test-ovn-dhcp.c
--
2.5.5
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
