Re: [ovs-dev] [PATCH RFC v6 2/2] netdev-dpdk: Add vHost User PMD

2016-10-28 Thread Loftus, Ciara
[snip] > > + > > +static int > > netdev_dpdk_vhost_construct(struct netdev *netdev) > > { > > struct netdev_dpdk *dev = netdev_dpdk_cast(netdev); > > @@ -904,7 +1051,7 @@ netdev_dpdk_vhost_construct(struct netdev > *netdev) > > /* 'name' is appended to 'vhost_sock_dir' and used to crea

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-28 Thread Loftus, Ciara
> > > I'll post few comments to v4 here. > > > > > static int > > > +dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode) > > > +{ > > > +char *devargs; > > > +int err = 0; > > > +uint8_t port_no = 0; > > > +uint32_t driver_id = -1; > > > + > > > +if (id_pool_alloc_id(dpdk

Re: [ovs-dev] [PATCH] netdev-dpdk: Return rx/tx queue sizes only for ETH devices.

2016-10-28 Thread Loftus, Ciara
> > 'dev->requested_{rxq,txq}_size' and 'dev->{rxq,txq}_size' are > relevant only for DPDK_DEV_ETH devices and should be skipped > in 'netdev_dpdk_get_config()' for other ports. > > CC: Ciara Loftus > Fixes: b685696b8c81 ("netdev-dpdk: Allow configurable queue sizes for > 'dpdk' ports") Conside

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Loftus, Ciara
> I'll post few comments to v4 here. > > > static int > > +dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode) > > +{ > > +char *devargs; > > +int err = 0; > > +uint8_t port_no = 0; > > +uint32_t driver_id = -1; > > + > > +if (id_pool_alloc_id(dpdk_get_vhost_id_pool(), &d

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Loftus, Ciara
> > On 20.10.2016 19:33, Loftus, Ciara wrote: > >>>> @@ -894,6 +1006,66 @@ dpdk_dev_parse_name(const char > >> dev_name[], const char prefix[], > >>>> } > >>>> } > >>>> > >>>> +/* When attaching a vhos

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-20 Thread Loftus, Ciara
> > Sorry, CC mail-list > > On 20.10.2016 17:20, Ilya Maximets wrote: > > Not a complete review. > > Few comments inline. Thanks for the review. Comments inline. Thanks, Ciara > > > > Best regards, Ilya Maximets. > > > > On 14.10.2016 17:08, Ciara Loftus wrote: > >> The vHost PMD allows vHost

Re: [ovs-dev] OVS DPDK build errors with commit 01961bb

2016-10-13 Thread Loftus, Ciara
> > Hi > I found that OVS DPDK fails to build with DPDK 16.07 after commit > 01961bb. I am not sure if this is because of some expectations about > DPDK configuration or problems in the code. I could fix this fairly > easily with 4 additions to lib/dpdk.c (patch below), but am unsure > about wheth

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-30 Thread Loftus, Ciara
> > 2016-09-29 3:28 GMT-07:00 Loftus, Ciara : > > > > Hi Ciara, > > thanks for the patch, it looks good to me. > > I only have a minor comment: > > I'd like the requested values to depend only on the current database > > state.  With the current pa

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-29 Thread Loftus, Ciara
> > Hi Ciara, > thanks for the patch, it looks good to me. > I only have a minor comment: > I'd like the requested values to depend only on the current database > state.  With the current patch when a value is invalid (not pow2 or bigger > than 4096) we keep the previous one. > Could you change dp

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-21 Thread Loftus, Ciara
> > Few comments inline. Thanks for the feedback Ilya. > > > The 'options:n_rxq_desc' and 'n_txq_desc' fields allow the number of rx > > and tx descriptors for dpdk ports to be modified. By default the values > > are set to 2048, but can be modified to an integer between 1 and 4096 > > that is

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

2016-09-20 Thread Loftus, Ciara
> > Hi, Ciara. > I also wanted to do something like this. But, IMHO, this configuration > should be per port because different HW behaves differently and has > different capabilities. > > What do you think? > > For the implementation: I think, we should check that value is a power of 2 > because

Re: [ovs-dev] [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD

2016-09-13 Thread Loftus, Ciara
> > > I've added vHost maintainers to CC-list to hear their opinion about > > new API to get number of queues from the vHost PMD. > > Maybe we can expose 'rte_vhost_get_queue_num()' somehow or make > > 'dev_info->nb_rx_queues' usable? > > > I appreciate great investigation. > So far, I am not sure

Re: [ovs-dev] [PATCH] netdev-dpdk: Provide explicit flag to rte_vhost_driver_register

2016-08-19 Thread Loftus, Ciara
you said, this patch isn't needed. Thanks, Ciara > Thanks, > Daniele > > 2016-08-18 5:29 GMT-07:00 Loftus, Ciara : > > > > rte_vhost_driver_register accepts a 'mode' flag which sets server(0) or > > client(1) mode. vHost devices are registered in 'serve

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-18 Thread Loftus, Ciara
> Hi Sean, > > 2016-08-15 9:04 GMT-07:00 Mooney, Sean K : > Hi Daniele > Sorry to top post but I have just read back over the last > couple of revisions of this patch. > > No problem, thanks for stepping in.  As I said many times during the review > of this series I'm not sure what the best inter

Re: [ovs-dev] [PATCH] netdev-dpdk: Provide explicit flag to rte_vhost_driver_register

2016-08-18 Thread Loftus, Ciara
> > rte_vhost_driver_register accepts a 'mode' flag which sets server(0) or > client(1) mode. vHost devices are registered in 'server' mode (0) when > initially created. Before this patch the flags provided to this > function were the device's 'vhost_driver_flags' which hadn't been set > yet when

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-08-16 Thread Loftus, Ciara
> > 2016-07-19 2:53 GMT-07:00 Loftus, Ciara : > > > > > > The idea looks very good to me, thanks for working on it. > > > Very high level comments: > > Hi Daniele thanks for looking at this. > > > > > > > > Do we need to be limited to

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-15 Thread Loftus, Ciara
> > Thanks for the patch, I tried it and it makes possible to restart vswitchd and > qemu. > I believe that now vhost_server_id and vhost_client_id are not constant for > the lifetime of the struct and must be protected with dev->mutex. > The following incremental on top of your patch does that an

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove unnecessary 'if' statement

2016-08-15 Thread Loftus, Ciara
> > Hi Ciara, > Please find my comments below, > > > Regards > _Sugesh > > > > -Original Message- > > From: Loftus, Ciara > > Sent: Monday, August 15, 2016 10:01 AM > > To: Chandran, Sugesh ; > dev@openvswitch.org > > Subjec

Re: [ovs-dev] [PATCH] netdev-dpdk: Remove unnecessary 'if' statement

2016-08-15 Thread Loftus, Ciara
> > Hi Ciara, > Thank you for fixing this. > Changes are looks fine for me. > A minor comment as below. > Acked! > > > Regards > _Sugesh > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ciara > Loftus > > Sent: Friday, August 12, 2016 5:17 PM >

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-11 Thread Loftus, Ciara
> > > 2016-08-08 7:18 GMT-07:00 Loftus, Ciara : > > > > The patch mostly looks good to me, thanks. > > I'm not 100% sure about the interface.  Can we make the flag interface > > specific? > > I'm not 100% sure about making the flag interface

Re: [ovs-dev] [PATCH] netdev-dpdk: add DPDK pdump capability

2016-08-10 Thread Loftus, Ciara
> > This is interesting, thanks for working on this. > The patch looks pretty simple, most of the magic happens in DPDK, so I will > comment only on the OvS side of things. > Why is 'other_config:dpdk-pdump' required?  Can't we always enable the > feature?  I tried running with it and I didn't not

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-08 Thread Loftus, Ciara
> > The patch mostly looks good to me, thanks. > I'm not 100% sure about the interface.  Can we make the flag interface > specific? I'm not 100% sure about making the flag interface specific :) Do you think there's a use case for both client and server mode ports to be used in conjunction with

Re: [ovs-dev] [PATCH] INSTALL.DPDK: Update documentation for DPDK 16.07 support

2016-08-08 Thread Loftus, Ciara
> > Replace 'dpdk_nic_bind.py' references with 'dpdk-devbind.py'. The script > name is changed in DPDK 16.07 as the script can be used also on crypto > devices along with NICs. > > Update the command for setting packet forwarding mode in 'testpmd' app > from 'set fwd mac_retry' to 'set fwd mac re

Re: [ovs-dev] [ovs-dev, 3/3] netdev-dpdk: vHost client mode and reconnect

2016-08-04 Thread Loftus, Ciara
> > Hi, Ciara. > I'm suggesting also following change: > - > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 57dc437..f092fa2 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -959,7 +963,8 @@

Re: [ovs-dev] [PATCH] netdev-dpdk: Avoid reconfiguration on reconnection of same vhost device.

2016-08-04 Thread Loftus, Ciara
> > Binding/unbinding of virtio driver inside VM leads to reconfiguration > of PMD threads. This behaviour may be abused by executing bind/unbind > in an infinite loop to break normal networking on all ports attached > to the same instance of Open vSwitch. > > Fix that by avoiding reconfiguration

Re: [ovs-dev] [PATCH] ovs-rcu: Add new ovsrcu_index type.

2016-08-03 Thread Loftus, Ciara
> > With RCU in Open vSwitch it's very easy to protect objects accessed by > a pointer, but sometimes a pointer is not available. > > One example is the vhost id for DPDK 16.07. Until DPDK 16.04 a pointer > was used to access a vhost device with RCU semantics. From DPDK 16.07 > an integer id (w

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-08-03 Thread Loftus, Ciara
t; Daniele Thanks Daniele, I submitted a new version of this patch that uses the vhost lib & the new RCU index: http://openvswitch.org/pipermail/dev/2016-August/077125.html Thanks, Ciara > > 2016-07-28 6:26 GMT-07:00 Loftus, Ciara : > > > > Thanks for the patch. > > I

Re: [ovs-dev] [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD

2016-08-03 Thread Loftus, Ciara
> > I've applied this patch and performed following test: > > OVS with 2 VMs connected via vhost-user ports. > Each vhost-user port has 4 queues. > > VM1 executes ping on LOCAL port. > In normal situation ping results are following: > > 100 packets transmitted, 100 received, 0% packet los

Re: [ovs-dev] [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD

2016-08-02 Thread Loftus, Ciara
> Subject: Re: [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD > > I've applied this patch and performed following test: > > OVS with 2 VMs connected via vhost-user ports. > Each vhost-user port has 4 queues. > > VM1 executes ping on LOCAL port. > In normal situation ping results are following:

Re: [ovs-dev] [ovs-dev,v3,3/5] netdev-dpdk: Add vHost User PMD

2016-07-29 Thread Loftus, Ciara
> > Not the complete review. Just few comments to design. Hi Ilya, Thanks for the feedback. > > And what about performance? Is there any difference in comparison to > current version of code? I guess, this may be slower than direct > access to vhost library. I had the same concern I've measur

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add DPDK pdump capability

2016-07-29 Thread Loftus, Ciara
> > This looks like a nice useablity feature to add. > Two questions inline > Regards sean. Thanks Sean, replies inline. Ciara > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ciara > Loftus > > Sent: Friday, July 29, 2016 10:58 AM > > To: dev@op

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-28 Thread Loftus, Ciara
> > Thanks for the patch. > I have another concern with this.  If we're still going to rely on RCU to > protect > the vhost device (and as pointed out by Ilya, I think we should) we need to > use RCU-like semantics on the vid array index. I'm not sure a boolean flag is > going to be enough. > CCi

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-26 Thread Loftus, Ciara
> 2016-07-19 2:53 GMT-07:00 Loftus, Ciara : > > > > The idea looks very good to me, thanks for working on it. > > Very high level comments: > Hi Daniele thanks for looking at this. > > > > > Do we need to be limited to pci devices?  Perhaps we can accept th

Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: Add vHost User PMD

2016-07-26 Thread Loftus, Ciara
> Subject: Re: [ovs-dev] [PATCH 3/4] netdev-dpdk: Add vHost User PMD > > Thanks for the patch > This needs a little bit of rebasing, I did it myself to review, but it'd be > nice to > have an updated version. I've submitted a new set here: http://openvswitch.org/pipermail/dev/2016-July/076245.h

Re: [ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-25 Thread Loftus, Ciara
e risk associated with due to the nature of the changes. Thanks, Ciara > > Thanks > Vinod > > > > -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Friday, July 22, 2016 3:49 PM > To: Flavio Leitner ; Vinod, Chegu > >

Re: [ovs-dev] [ovs-dev, RFC, v2, 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Loftus, Ciara
> > On 12.07.2016 12:11, Ciara Loftus wrote: > > This commit introduces support for DPDK 16.07 and consequently breaks > > compatibility with DPDK 16.04. > > > > DPDK 16.07 introduces some changes to various APIs. These have been > > updated in OVS, including: > > * xstats API: changes to structur

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Loftus, Ciara
> > Hi Ciara, > thanks for the patch. > It mostly looks good to me, except a few comments inline > Thanks, > Daniele Thanks for the review Daniele. I've pushed a new version that includes your suggestions. Responses inline. > > 2016-07-12 2:11 GMT-07:00 Ciara Loftus : > This commit introduces

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-19 Thread Loftus, Ciara
> > The idea looks very good to me, thanks for working on it. > Very high level comments: Hi Daniele thanks for looking at this. > > Do we need to be limited to pci devices?  Perhaps we can accept the same > string as rte_eth_dev_attach(). Can you elaborate? For physical devs the string is alway

Re: [ovs-dev] [RFC PATCH v2 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-19 Thread Loftus, Ciara
> > Hi Ciara, > > On 07/12/2016 11:11 AM, Ciara Loftus wrote: > > This RFC patch provides initial support for DPDK 16.07-rc2 (release > > candidate 2) which was tagged July 12th. I plan to submit a full patch > > once the 16.07 release is final, hopefully later this month. This RFC > > patch can

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Loftus, Ciara
> On Fri, Jul 15, 2016 at 11:00 AM, Loftus, Ciara > wrote: > > > > Hello Ciara, > > I like the idea a lot, the restriction on the names has always been a > limitation, > > however, it is more important the port id to physical port relation that is > > co

Re: [ovs-dev] [PATCH] netdev-dpdk : vhost-user port link state fix

2016-07-15 Thread Loftus, Ciara
> > I changed 'netdev' to 'dev' in netdev_dpdk_init(), added Jan to AUTHORS > and > pushed this to master. Another backport request - could this be pushed to 2.5 too? Thanks, Ciara > > Thanks! > > Daniele > > 2016-06-02 5:42 GMT-07:00 Zoltán Balogh : > > > Hi Daniele, > > > > I fixed the pa

Re: [ovs-dev] [PATCH v4] dpif-netdev: Remove PMD latency on seq_mutex

2016-07-15 Thread Loftus, Ciara
> > I applied this to master with the below incremental. > > We _usually_ use positive error numbers in int return value. > > I think there was an extra COVERAGE_INC(seq_change) > > Thanks for the patch! Hi, Could this be backported to the 2.5 branch? Thanks, Ciara > > diff --git a/lib/ovs

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Loftus, Ciara
> > Hello Ciara, > I like the idea a lot, the restriction on the names has always been a > limitation, > however, it is more important the port id to physical port relation that is > confusing. > I was not able to test the patch, it does not apply and I didn't have the time > to apply it manually

Re: [ovs-dev] [RFC PATCH 1/1] netdev-dpdk: vHost client mode and reconnect

2016-07-13 Thread Loftus, Ciara
> Ciara Loftus writes: > > > A new other_config DB option has been added called 'vhost_driver_mode'. > > By default this is set to 'server' which is the mode of operation OVS > > with DPDK has used up until this point - whereby OVS creates and manages > > vHost user sockets. > > > > If set to 'cl

Re: [ovs-dev] [RFC PATCH 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-05 Thread Loftus, Ciara
> > Hi Ciara, > > Ciara Loftus writes: > > > This commit introduces support for DPDK 16.07 and consequently breaks > > compatibility with DPDK 16.04. > > > > DPDK 16.07 introduces some changes to various APIs. These have been > > updated in OVS, including: > > * xstats API: changes to structure

Re: [ovs-dev] [RFC PATCH v2] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-01 Thread Loftus, Ciara
Ignore this - I didn’t number the series correctly. Will send a corrected update in a moment. Ciara > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ciara Loftus > Sent: Friday, July 01, 2016 10:16 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [RFC P

Re: [ovs-dev] [PATCH RFC 0/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-06-20 Thread Loftus, Ciara
> > Hello Ciara, > I like too much the idea of arbitrary names, it has always been a problem > realizing the correct id of a port. > As already mentioned by Jan, what do you think about the possibility of > integrate this with hotplug capabilities? I already sent a patch [1] to > support > hotplu

Re: [ovs-dev] [PATCH] acinclude: check for numa library

2016-06-20 Thread Loftus, Ciara
> > Numa library is needed for NUMA aware vHost User functionality. > Incase of missing numa package, the OVS DPDK configuration fails with > "error: Could not find DPDK libraries in /TARGET/lib" though > the DPDK library is installed. > > This patch fixes this inappropriate error by checking for

Re: [ovs-dev] [PATCH] netdev-dpdk: NUMA Aware vHost User

2016-06-08 Thread Loftus, Ciara
> Thanks for the patch! > I'm not sure how to best handle the libnuma dependency. Question: > Is it still useful to move the device to a PMD thread on the appropriate > numa socket, even if DPDK is compiled without > CONFIG_RTE_LIBRTE_VHOST_NUMA? If it's useful, I'm fine with the > approach followe

Re: [ovs-dev] [PATCH] netdev-dpdk: NUMA Aware vHost User

2016-05-24 Thread Loftus, Ciara
> > > >This commit allows for vHost User memory from QEMU, DPDK and OVS, as > >well as the servicing PMD, to all come from the same socket. > > > >The socket id of a vhost-user port used to be set to that of the master > >lcore. > >Now it is possible to update the socket id if it is detected (duri

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-05-18 Thread Loftus, Ciara
> > > > Implementations for the netdev functions 'get_features' and > > 'get_status' are now available for vhost-user thanks to the addition of > > the vHost PMD. > > > > Signed-off-by: Ciara Loftus > > --- > > lib/netdev-dpdk.c | 23 +-- > > 1 file changed, 13 insertions(+),

Re: [ovs-dev] [PATCH v3 2/3] netdev-dpdk: Add vHost User PMD

2016-05-18 Thread Loftus, Ciara
> > > > DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' > > ports > > to be controlled by the librte_ether API, like physical 'dpdk' ports. > > The commit integrates this functionality into OVS, and refactors some > > of the existing vhost code such that it is vhost-cuse specific.

Re: [ovs-dev] [ovs-dev,v2,2/3] netdev-dpdk: Add vHost User PMD

2016-05-11 Thread Loftus, Ciara
> On 10.05.2016 12:25, Ciara Loftus wrote: > > DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports > > to be controlled by the librte_ether API, like physical 'dpdk' ports. > > The commit integrates this functionality into OVS, and refactors some > > of the existing vhost code su

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Loftus, Ciara
> > On 10.05.2016 11:31, Ilya Maximets wrote: > > On 03.05.2016 14:28, ciara.loftus at intel.com (Loftus, Ciara) wrote: > >>> This patch seem to remove a lot of txq remapping functions (like > >>> netdev_dpdk_remap_txqs).Ã, How does it handle the case of

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Loftus, Ciara
> On 21/04/2016 13:20, Ciara Loftus wrote: > > DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports > > to be controlled by the librte_ether API, like physical 'dpdk' ports. > > The commit integrates this functionality into OVS, and refactors some > > of the existing vhost code su

Re: [ovs-dev] [PATCH] netdev-dpdk: print default vhost-sock-dir if none provided

2016-05-06 Thread Loftus, Ciara
> Hi Ciara, > > Please add a Fixes: tag. > > Ciara Loftus writes: > > > Signed-off-by: Ciara Loftus > > --- > > lib/netdev-dpdk.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > > index b488c60..67b9e0d 100644 > > --- a/li

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-03 Thread Loftus, Ciara
> > Hi Ciara, > thanks for doing this.  I really think this has the potential to clean up the > netdev-dpdk code. Thanks for your feedback Daniele. Comments inline, v2 soon. > The clang thread safety analyzer reports some warnings: > >   CC   lib/netdev-dpdk.lo > ../lib/netdev-dpdk.c:882:1:

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: NUMA Aware vHost

2016-03-19 Thread Loftus, Ciara
> > Thanks for the patch, I'll put this in the use case list for > my series if I need to resend it! > > It would be nice to get the numa socket information without > linking OVS with libnuma, maybe using some DPDK api. From > a quick look I didn't find any way, but maybe you know a > better way.

Re: [ovs-dev] OVS with DPDK Meetup notes

2015-12-01 Thread Loftus, Ciara
> > > > On Thu, Nov 26, 2015 at 05:56:08PM +, Traynor, Kevin wrote: > > > Hi All, > > > > > > Just wanted to post some summary notes on the recent OVS with DPDK > Meetup > > we > > > had after the OVS conference. Thanks to everyone for the often lively > > discussion. > > > I've collated and co

Re: [ovs-dev] [PATCH] INSTALL.DPDK: Mention issue with QEMU v2.4.0 & dpdkvhostuser

2015-10-30 Thread Loftus, Ciara
> > Hi, > > Is this a bug in OVS code? In this case I think we can work on a fix, > rather > than suggesting to downgrade QEMU. > > If this is a bug in DPDK librte_vhost, is there a fix available (on > master, or > on the mailing list)? Hi Daniele, The fix is available in DPDK master: http://d

Re: [ovs-dev] [PATCH] dpif-netdev: move header prefetch earlier into the receive function

2015-09-28 Thread Loftus, Ciara
> > I tested the patch, but I wasn't able to reproduce your measurements. I was able to reproduce a slight performance improvement with this patch for single-flow uni-directional 64B traffic - up about 0.3Mpps for me. Thanks, Ciara > > On my test setup I noticed no difference in throughput fo

Re: [ovs-dev] [PATCH] bugfix: Fix DPDK linking when using a relative path

2015-09-16 Thread Loftus, Ciara
> > When linking with DPDK, if a relative path is used with the > '--with-dpdk' flag, then OVS will always be compiled with vHost Cuse > support, even if it is not enabled in the DPDK build. > This patch fixes this problem, and enables the correct version of > vHost despite whether or not a relati

Re: [ovs-dev] intra VM communication

2015-07-23 Thread Loftus, Ciara
behavior ? If you have the same vHost device (in your case dpdk1) attached to two VMs I expect you will run into issues. I suggest you modify your QEMU command lines to use dpdk0 & dpdk1 for VM1 and dpdk2 and dpdk3 for VM2, rather than using dpdk1 port in both. > /srikanth > > > &

Re: [ovs-dev] intra VM communication

2015-07-23 Thread Loftus, Ciara
dpdk0" >     type: dpdkvhostuser >     Port "dpdk3" >     Interface "dpdk3" >     type: dpdkvhostuser >     ovs_version: "2.4.90" > > My vswitchd options > >  ovs-vswitchd --dpdk -c 0x0FF8 -n 4 --so

Re: [ovs-dev] intra VM communication

2015-07-22 Thread Loftus, Ciara
> > Hello, > > I am trying to use vhost-user for sending traffic between VMs . I have > configured two "dpdkvhostuser" interfaces each VM using one of them each > . > > vswitchd is running with dpdk. > Qemu is running with the vhost interfaces > > Guest OS can see interfaces - Verified with the

Re: [ovs-dev] [PATCH] Fix detection of vhost_cuse in dpdk rte_config.h

2015-07-10 Thread Loftus, Ciara
> > The patch makes sense for branch-2.4 and master. Thanks! > > Acked-by: Daniele Di Proietto +1 from me too - thanks for fixing this! > > On 06/07/2015 22:41, "Mussar, Gary" wrote: > > >Fix detection of vhost_cuse in dpdk rte_config.h > > > >Dpdk allows users to create a config that inclu

Re: [ovs-dev] [PATCH 08/11] metaflow: Extend size of mf_value to 128 bytes.

2015-07-01 Thread Loftus, Ciara
> On Tue, Jun 30, 2015 at 7:56 AM, Loftus, Ciara > wrote: > >> > >> On Wed, Jun 24, 2015 at 1:17 PM, Ben Pfaff wrote: > >> > On Fri, Jun 19, 2015 at 04:13:22PM -0700, Jesse Gross wrote: > >> >> Tunnel metadata can be substantially larger tha

Re: [ovs-dev] [PATCH 08/11] metaflow: Extend size of mf_value to 128 bytes.

2015-06-30 Thread Loftus, Ciara
> > On Wed, Jun 24, 2015 at 1:17 PM, Ben Pfaff wrote: > > On Fri, Jun 19, 2015 at 04:13:22PM -0700, Jesse Gross wrote: > >> Tunnel metadata can be substantially larger than our existing fields > >> (up to 124 bytes in a single Geneve option) so this extends the size > >> of the data that we can h

Re: [ovs-dev] [PATCH v7] netdev-dpdk: add dpdk vhost-user ports

2015-06-08 Thread Loftus, Ciara
> On Thu, Jun 4, 2015 at 6:53 AM, Loftus, Ciara wrote: > > > >> On Fri, May 22, 2015 at 8:40 AM, Ciara Loftus > wrote: > >> > This patch adds support for a new port type to the userspace > >> > datapath called dpdkvhostuser. > ... > ... >

Re: [ovs-dev] [PATCH v7] netdev-dpdk: add dpdk vhost-user ports

2015-06-04 Thread Loftus, Ciara
> On Fri, May 22, 2015 at 8:40 AM, Ciara Loftus wrote: > > This patch adds support for a new port type to the userspace > > datapath called dpdkvhostuser. > > > > A new dpdkvhostuser port will create a unix domain socket which > > when provided to QEMU is used to facilitate communication between

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add dpdk vhost-user ports

2015-05-13 Thread Loftus, Ciara
> On 05/11/2015 01:56 PM, Ciara Loftus wrote: > > This patch adds support for a new port type to the userspace > > datapath called dpdkvhostuser. > > > > A new dpdkvhostuser port will create a unix domain socket which > > when provided to QEMU is used to facilitate communication between > > the vir

Re: [ovs-dev] [PATCH] netdev-dpdk: add dpdk vhost-user ports

2015-05-07 Thread Loftus, Ciara
> On Tue, May 5, 2015 at 8:58 AM, Ciara Loftus wrote: > > This patch adds support for a new port type to the userspace > > datapath called dpdkvhostuser. It adds to the existing > > infrastructure of vhost-cuse, however disables vhost-cuse ports > > as the default port type, in favour of vhost-use

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-05-05 Thread Loftus, Ciara
> On 04/24/2015 04:01 PM, Flavio Leitner wrote: > > On Fri, 24 Apr 2015 14:17:17 +0300 > > Panu Matilainen wrote: > > > >> Hi, > >> > >> A few comments inline... > >> > >> On 04/21/2015 01:10 PM, Ciara Loftus wrote: > >>> This patch adds support for a new port type to the userspace > >>> datapath

Re: [ovs-dev] [PATCH RFC 0/1] dpif-netdev: Make EMC Size Configurable

2015-04-21 Thread Loftus, Ciara
> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Tuesday, April 21, 2015 4:08 PM > To: Loftus, Ciara > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH RFC 0/1] dpif-netdev: Make EMC Size > Configurable > > On Tue, Apr 21, 2015

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-21 Thread Loftus, Ciara
> This patch adds support for a new port type to the userspace datapath > called dpdkvhostuser. It adds to the existing infrastructure of > vhost-cuse, however disables vhost-cuse ports in favour of vhost-user > ports. > > A new dpdkvhostuser port will create a unix do

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-03-24 Thread Loftus, Ciara
> On Thu, Mar 19, 2015 at 11:48 AM, Ciara Loftus > wrote: > > This patch adds support for a new port type to the userspace datapath > > called dpdkvhostuser. It adds to the existing infrastructure of > > vhost-cuse, however disables vhost-cuse ports in favour of vhost-user > > ports. > > > > A new

Re: [ovs-dev] [Qestion] netdev-dpdk: dpdk vhost ports

2015-02-26 Thread Loftus, Ciara
> > > On 02/24/2015 05:13 PM, Loftus, Ciara wrote: > > > Hi Marcel, > > > > > > On 02/23/2015 12:57 PM, Marcel Apfelbaum wrote: > > >> Hi, > > > I CC-ed the developers that submitted the patch. > > > Thanks again, > >

Re: [ovs-dev] [Qestion] netdev-dpdk: dpdk vhost ports

2015-02-25 Thread Loftus, Ciara
> On 02/24/2015 05:13 PM, Loftus, Ciara wrote: > > Hi Marcel, > > > > On 02/23/2015 12:57 PM, Marcel Apfelbaum wrote: > >> Hi, > > I CC-ed the developers that submitted the patch. > > Thanks again, > > Marcel > > >

Re: [ovs-dev] [Qestion] netdev-dpdk: dpdk vhost ports

2015-02-24 Thread Loftus, Ciara
Hi Marcel, On 02/23/2015 12:57 PM, Marcel Apfelbaum wrote: > Hi, I CC-ed the developers that submitted the patch. Thanks again, Marcel > > Regarding patch: [ovs-dev] [PATCH RFC v6 1/1] netdev-dpdk: add dpdk > vhost ports > http://openvswitch.org/pipermail/dev/2015-January/050279.html > > What

Re: [ovs-dev] [PATCH 2/2] miniflow: Use 64-bit data.

2015-01-12 Thread Loftus, Ciara
Hi, After running some performance tests on the latest master, it appears that this commit has caused netdev DPDK performance to drop significantly (by > 50 %). Has anybody else seen this? Regards, Ciara -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jar

Re: [ovs-dev] [PATCH RFC 2/2] openvswitch: Userspace tunneling.

2014-10-14 Thread Loftus, Ciara
Hi, I have been validating the userspace tunneling patches for DPDK and have encountered some problems. My set-up is as follows: 192.168.1.1/24 192.168.1.2/24 ++++ | br1