> On Thu, Jun 4, 2015 at 6:53 AM, Loftus, Ciara <ciara.lof...@intel.com> wrote: > > > >> On Fri, May 22, 2015 at 8:40 AM, Ciara Loftus <ciara.lof...@intel.com> > wrote: > >> > This patch adds support for a new port type to the userspace > >> > datapath called dpdkvhostuser. > ... > ... > >> > + " --vhost_sock_dir DIR override default directory > >> > where\n" > >> > + " vhost-user sockets are > >> > created.\n"); > >> > >> since --cuse_dev_name and --vhost_sock_dir is sub-argument under > >> --dpdk, it should have single hyphen prefix. > > > > Thanks for the review, please see suggested changes implemented in the > v8 patch. > Thanks for the updated patch. > > > I've chosen to keep the 'dpdkvhostuser' port name and instead change the > 'dpdkvhost' port to 'dpdkvhostcuse'. There tends to be confusion sometimes > around which port is in use, but with these names it will be clearer to the > user exactly which vhost they are using. > > > In future release we will deprecate vhost-cuse and there will be only > one option to setup dpdk-vhost. Therefore there is no need to > explicitly name it this way.
Hi Pravin, I checked with the OpenStack team to see if there would be any impact of this name change and unfortunately there is. The OpenStack project has a hard dependency on the "dpdkvhostuser" port name. Please see: https://github.com/openstack/nova/blob/stable/kilo/nova/network/linux_net.py#L1384-1385 This code was part of the recent "Kilo" release and from what I know, it would be very unlikely to be able to change this on their stable branch. Even if this was possible, it appears it would cause some difficulty as distros would be required to package the changed code. Considering that changing the port name would effectively remove vhost-user support from OpenStack, would you be willing to keep this name at least until such a time as the OpenStack project can change the name in their codebase? Thanks, Ciara _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
