Re: [ovs-dev] [PATCH 2/2] ovn-southbound: implement read-only connection support

2016-10-25 Thread Lance Richardson
> From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Tuesday, October 25, 2016 12:38:49 PM > Subject: [ovs-dev] [PATCH 2/2] ovn-southbound: implement read-only > connection support > > Add a connection table to the southbound db schema, similar > t

[ovs-dev] [PATCH 1/2] ovsdb: implement read-only remote connection type

2016-10-25 Thread Lance Richardson
Adds a new "read_only" column for remote connections. Operations that would alter the state of the database are not permitted on connections for which the "read_only" column is set to "true". Signed-off-by: Lance Richardson --- ovsdb/jsonrpc-server.c | 7 --

[ovs-dev] [PATCH 2/2] ovn-southbound: implement read-only connection support

2016-10-25 Thread Lance Richardson
punix, ssl, tcp, unix). - SSL configuration table for southbound db. - Connection table for NB schema. Signed-off-by: Lance Richardson --- ovn/ovn-sb.ovsschema | 37 ++- ovn/ovn-sb.xml| 245 ++ ovn/utilities/ovn-sbctl.c |

[ovs-dev] [PATCH 0/2] ovn: Implement read-only connection support for sb db

2016-10-25 Thread Lance Richardson
Add read-only connection support for "remote=db:" connection type to ovsdb-server. Implement connection table with read-only attribute in southbound db. Lance Richardson (2): ovsdb: implement read-only remote connection type ovn-southbound: implement read-only connection support

Re: [ovs-dev] [PATCH] ovn/TODO: Remove completed IPAM item.

2016-10-25 Thread Lance Richardson
deal." > > -* IPAM enhancements. > - > -Russell Bryant: "Be able to specify a MAC and only have the IP be > -dynamic. Right now both are dynamic." > - > * Native DNS support > > Russell Bryant: "This is

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-21 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Russell Bryant" > Cc: "ovs dev" > Sent: Friday, October 21, 2016 4:33:33 PM > Subject: Re: [ovs-dev] ovn: Improving southbound database security > > On Fri, Oct 21, 2016 at 04:10:58PM -0400, Russell Bryant wrote: > > On Thu, Oct 20, 2016 at 5:52 PM, Han Zhou wrote: >

Re: [ovs-dev] [PATCH v2] ovsdb: implement read-only remote connection type

2016-10-18 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org, az...@ovn.org, nusid...@redhat.com, > bscha...@redhat.com, jpet...@ovn.org, russ...@ovn.org > Sent: Monday, October 17, 2016 2:35:22 PM > Subject: Re: [PATCH v2] ovsdb: implement read-o

[ovs-dev] [PATCH v2] ovsdb: implement read-only remote connection type

2016-10-14 Thread Lance Richardson
--remote=ssl:ro:192.168.0.10: Operations that would alter the state of the database are not permitted on connections for which the "ro" access-type is specified. Signed-off-by: Lance Richardson --- RFC->v1: - Added autotest keywords for ssl tests. - Changed active tcp

[ovs-dev] [PATCH] ovsdb: implement read-only remote connection type

2016-10-14 Thread Lance Richardson
--remote=ssl:ro:192.168.0.10: Operations that would alter the state of the database are not permitted on connections for which the "ro" access-type is specified. Signed-off-by: Lance Richardson --- RFC->v1: - Added autotest keywords for ssl tests. - Changed active tcp

Re: [ovs-dev] [RFC] ovsdb: implement read-only remote connection type

2016-10-13 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org, jpe...@ovn.org > Sent: Thursday, October 13, 2016 5:08:42 PM > Subject: Re: [ovs-dev] [RFC] ovsdb: implement read-only remote connection type > > On Thu, Oct 13, 2016 at 03:08:46PM

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-13 Thread Lance Richardson
> From: "Andy Zhou" > To: "Ben Pfaff" > Cc: "ovs dev" , "Numan Siddique" , > "Babu Shanmugam" , > "Lance Richardson" , "Justin Pettit" , > "Russell Bryant" > Sent: Thursday, October 13, 2016

[ovs-dev] [RFC v2] ovsdb: implement read-only remote connection type

2016-10-13 Thread Lance Richardson
n ok 1880: ovsdb-server/read-only unix connection ok Shouldn't they all match the "read-only" keyword?? Signed-off-by: Lance Richardson --- v2: resending with corrected cc: list lib/stream-ssl.c | 11 +- lib/stream

[ovs-dev] [RFC] ovsdb: implement read-only remote connection type

2016-10-13 Thread Lance Richardson
n ok 1880: ovsdb-server/read-only unix connection ok Shouldn't they all match the "read-only" keyword?? Signed-off-by: Lance Richardson --- lib/stream-ssl.c | 11 +- lib/stream-tcp.c

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-13 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Andy Zhou" > Cc: "ovs dev" , "Numan Siddique" , > "Babu Shanmugam" , > "Lance Richardson" , "Justin Pettit" , > "Russell Bryant" > Sent: Thursday, October 13, 2016

Re: [ovs-dev] [PATCH v2] ovn-northd: support IPAM with externally specified MAC

2016-10-06 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org, russ...@ovn.org > Sent: Thursday, October 6, 2016 4:48:45 PM > Subject: Re: [PATCH v2] ovn-northd: support IPAM with externally specified MAC > > On Thu, Oct 06, 2016 at 03:58:51

[ovs-dev] [PATCH v2] ovn-northd: support IPAM with externally specified MAC

2016-10-06 Thread Lance Richardson
04:05 dynamic" Acked-by: Ben Pfaff Acked-by: Russell Bryant Signed-off-by: Lance Richardson --- v2: - Simplified is_dynamic_lsp_address() using implementation by Ben Pfaff (with minor adjustment, removed a space from scan string). - Use ovs_scan() to extract sta

Re: [ovs-dev] [PATCH] ovn-northd: support IPAM with externally specified MAC

2016-10-03 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Russell Bryant" > Cc: "Lance Richardson" , "ovs dev" > Sent: Monday, October 3, 2016 4:24:22 PM > Subject: Re: [ovs-dev] [PATCH] ovn-northd: support IPAM with externally > specified MAC > > On Mon, Oc

[ovs-dev] [PATCH] ovn-northd: support IPAM with externally specified MAC

2016-09-22 Thread Lance Richardson
04:05 dynamic" Signed-off-by: Lance Richardson --- ovn/lib/ovn-util.c | 38 ++ ovn/lib/ovn-util.h | 2 +- ovn/northd/ovn-northd.c | 30 +++--- ovn/ovn-nb.xml | 35 --- te

Re: [ovs-dev] [PATCH] travis: Work around glibtoolize error.

2016-09-21 Thread Lance Richardson
ninstall libtool && brew install libtool || true > -- > 2.9.3 > LGTM, although I wonder what changed in the base image and hope we don't see similar drift in the future... Acked-by: Lance Richardson ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] datapath: avoid deferred execution of recirc actions

2016-09-20 Thread Lance Richardson
f43e6dfb056b58628e43179d8f6b59eae417754d Author: Lance Richardson Date: Mon Sep 12 17:07:23 2016 -0400 openvswitch: avoid deferred execution of recirc actions The ovs kernel data path currently defers the execution of all recirc actions until stack utilization is at a minimum. This is too limiting for some

[ovs-dev] [RFC v2] ovn-northd: support IPAM with externally specified MAC

2016-09-19 Thread Lance Richardson
04:05 dynamic" Signed-off-by: Lance Richardson --- v2: Eliminated compilation warning, dropped usage of isspace(). ovn/lib/ovn-util.c | 38 ++ ovn/lib/ovn-util.h | 2 +- ovn/northd/ovn-northd.c | 30 +++--- ovn/

[ovs-dev] [RFC] ovn-northd: support IPAM with externally specified MAC

2016-09-15 Thread Lance Richardson
04:05 dynamic" Signed-off-by: Lance Richardson --- ovn/lib/ovn-util.c | 38 ++ ovn/lib/ovn-util.h | 2 +- ovn/northd/ovn-northd.c | 30 +++--- ovn/ovn-nb.xml | 35 --- te

Re: [ovs-dev] [PATCH] ovn: make ipam tests more reliable

2016-09-14 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Wednesday, September 14, 2016 8:03:16 PM > Subject: Re: [ovs-dev] [PATCH] ovn: make ipam tests more reliable > > On Wed, Sep 14, 2016 at 07:30:50PM -0400, Lance Richardso

[ovs-dev] [PATCH] ovn: make ipam tests more reliable

2016-09-14 Thread Lance Richardson
-by: Lance Richardson --- tests/ovn.at | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 5707f47..1fcd666 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -4436,7 +4436,7 @@ AT_CHECK([ovn-nbctl get Logical-Switch-Port p0

Re: [ovs-dev] backport request for 2.6: enable kernel datapath check in rpms

2016-09-14 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Russell Bryant" > Cc: "ovs dev" , "Flavio Leitner" , > "Lance Richardson" > Sent: Wednesday, September 14, 2016 1:50:33 PM > Subject: Re: [ovs-dev] backport request for 2.6: enable kernel datapath c

[ovs-dev] backport request for 2.6: enable kernel datapath check in rpms

2016-09-13 Thread Lance Richardson
Requesting backports of these commits to the 2.6 branch:     commit 8ef22bb1ceb7b2841d2e29eb283387f0a3a67ff9         rhel: add option to run kernel datapath test when building rpms     commit ed71ac3e23e472378b1d292fcd8d3c43e46fe153         check-kernel: add recheck support These appear safe, an

[ovs-dev] [PATCH net-next] openvswitch: avoid deferred execution of recirc actions

2016-09-13 Thread Lance Richardson
are three or fewer recursions through ovs_execute_actions(). Suggested-by: Pravin Shelar Signed-off-by: Lance Richardson --- net/openvswitch/actions.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch

Re: [ovs-dev] [PATCH 0/2] support kernel datapath check when building rpms

2016-09-08 Thread Lance Richardson
Hi Flavio, Could you review this series? Thanks! Lance - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Cc: f...@sysclose.org > Sent: Friday, September 2, 2016 9:55:25 AM > Subject: [ovs-dev] [PATCH 0/2] support kernel dat

Re: [ovs-dev] [PATCH 0/2] support kernel datapath check when building rpms

2016-09-02 Thread Lance Richardson
Apologies, this series should have been marked "PATCH v2". - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Cc: f...@sysclose.org > Sent: Friday, September 2, 2016 9:55:25 AM > Subject: [ovs-dev] [PATCH 0/2] support

[ovs-dev] [PATCH 1/2] rhel: build source rpm packages

2016-09-02 Thread Lance Richardson
Build source RPM packages for rpm-fedora and rpm-fedora-kmod targets. Signed-off-by: Lance Richardson --- v1->v2: No changes. rhel/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rhel/automake.mk b/rhel/automake.mk index a3c180c..541f3fc 100644 --- a/r

[ovs-dev] [PATCH 0/2] support kernel datapath check when building rpms

2016-09-02 Thread Lance Richardson
mmand line. One use case is to be able to download the source RPM to a test system and easily execute kernel datapath tests in addition to the normal test suite as a side-effect of building the binary RPMs. Lance Richardson (2): rhel: build source rpm packages rhel: add option to run kerne

[ovs-dev] [PATCH 2/2] rhel: add option to run kernel datapath test when building rpms

2016-09-02 Thread Lance Richardson
production environments (it is generally not recommended to run rpmbuild as root). Suggested-by: Flavio Leitner Signed-off-by: Lance Richardson --- v1->v2: Added comments about testing with out-of-tree modules. rhel/openvswitch-fedora.spec.in | 20 +++- rhel/openvswitch.spec.i

[ovs-dev] [PATCH] check-system-userspace: add recheck support

2016-09-02 Thread Lance Richardson
Add support for "make check-system-userspace RECHECK=yes", similar to existing support for "make check RECHECK=yes". Signed-off-by: Lance Richardson --- tests/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/automake.mk b/tests/autom

Re: [ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms

2016-09-01 Thread Lance Richardson
> From: "Joe Stringer" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Thursday, September 1, 2016 4:51:19 PM > Subject: Re: [ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath > test when building rpms > > On 1 September 2016

[ovs-dev] [PATCH 2/3] rhel: build source rpm packages

2016-09-01 Thread Lance Richardson
Build source RPM packages for rpm-fedora and rpm-fedora-kmod targets. Signed-off-by: Lance Richardson --- rhel/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rhel/automake.mk b/rhel/automake.mk index a3c180c..541f3fc 100644 --- a/rhel/automake.mk +++ b/rhel

[ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms

2016-09-01 Thread Lance Richardson
production environments (it is generally not recommended to run rpmbuild as root). Suggested-by: Flavio Leitner Signed-off-by: Lance Richardson --- rhel/openvswitch-fedora.spec.in | 16 +++- rhel/openvswitch.spec.in| 17 - 2 files changed, 31 insertions(+), 2 deletion

[ovs-dev] [PATCH 0/3] support kernel datapath check when building rpms

2016-09-01 Thread Lance Richardson
atapath_kernel" option is provided on rpmbuild command line. One use case is to be able to download the source RPM to a test system and easily execute kernel datapath tests in addition to the normal test suite as a side-effect of building the binary RPMs. Lance Richardson (3): che

[ovs-dev] [PATCH 1/3] check-kernel: add recheck support

2016-09-01 Thread Lance Richardson
Support "make check-kernel RECHECK=yes", similar to existing support for "make check RECHECK=yes". Signed-off-by: Lance Richardson --- tests/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/automake.mk b/tests/automake.mk index 5d1

[ovs-dev] [PATCH] system-traffic: add a bonding test case

2016-08-30 Thread Lance Richardson
Add a test case to check connectivity over an OVS bond, using a Linux bond over veth interfaces. Also added a new macro "ADD_VETH_BOND", modeled after "ADD_VETH", in anticipation of future additional bonding test cases. Signed-off-by: Lance Richardson --- tests/system-c

[ovs-dev] [PATCH v2] upcall: reduce log level for "no reference to recirc flow" message

2016-08-29 Thread Lance Richardson
Reduce log level from "warn" to "debug" for "upcall: no reference to recirc flow" log message. Suggested-by: Jarno Rajahalme Signed-off-by: Lance Richardson --- v2: Instead of ignoring log message in system-traffic.at, reduce level so it no longer appears in th

Re: [ovs-dev] [PATCH] system-traffic: Ignore "no reference for recirc flow" in ct controller test

2016-08-29 Thread Lance Richardson
> From: "Jarno Rajahalme" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Monday, August 29, 2016 4:41:28 PM > Subject: Re: [ovs-dev] [PATCH] system-traffic: Ignore "no reference for > recirc flow" in ct controller test > > La

[ovs-dev] [PATCH] system-traffic: Ignore "no reference for recirc flow" in ct controller test

2016-08-29 Thread Lance Richardson
for the kernel data path. This log message means that an upcall with a recirc reference was received when the associated recirc id was expired/expiring. Eliminate the failure cause by ignoring the "no reference for recirc flow" message when checking vswitchd log. Signed-off-by: Lance

Re: [ovs-dev] [net] openvswitch: Allow deferred action fifo to expand during run time

2016-08-24 Thread Lance Richardson
> From: "David Miller" > To: az...@ovn.org > Cc: d...@openvswitch.com, net...@vger.kernel.org > Sent: Friday, March 18, 2016 5:19:09 PM > Subject: Re: [net] openvswitch: Allow deferred action fifo to expand during > run time > > From: Andy Zhou > Date: Thu, 17 Mar 2016 21:32:13 -0700 > > > Cur

Re: [ovs-dev] [PATCH] fedora.spec: include ovn-trace

2016-08-24 Thread Lance Richardson
> Thanks for the fix! Babu submitted the same patch a little while before > you did, so I'm going to apply that one. > > https://patchwork.ozlabs.org/patch/661860/ > > -- > Russell Bryant > Sorry for the noise, didn't think to check the queue. I'm glad to see it fixed! Lance __

[ovs-dev] [PATCH] fedora.spec: include ovn-trace

2016-08-23 Thread Lance Richardson
Include ovn-trace and accompanying man page in fedora/rhel rpm. Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") Signed-off-by: Lance Richardson --- rhel/openvswitch-fedora.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/o

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

2016-08-22 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Russell Bryant" > Cc: "Lance Richardson" , "ovs dev" > , "Russell Bryant" > Sent: Monday, August 22, 2016 1:22:43 PM > Subject: Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

Re: [ovs-dev] [PATCH 1/3] OVN-Tutorial: Replace example with ASCII quotes.

2016-08-22 Thread Lance Richardson
t; +$ make sandbox SANDBOXFLAGS="--ovn" > > Running the sandbox with OVN enabled does the following additional steps to > the > environment: Nice, I fell into this trap the first time I tried to run the ovn tutorials. Acked-by: Lance Richardson ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Mac OS X?

2016-08-19 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Martin Segeth" > Cc: dev@openvswitch.org > Sent: Friday, August 19, 2016 3:52:05 PM > Subject: Re: [ovs-dev] Mac OS X? > > On Fri, Aug 19, 2016 at 09:44:50PM +0200, Martin Segeth wrote: > > I was trying to build OVS 2.5.0 on a Mac but get a few a errors. While > > rese

Re: [ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES

2016-08-16 Thread Lance Richardson
> From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Tuesday, August 16, 2016 3:11:28 PM > Subject: [ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES > > Found by 'make distcheck'. > > Fixes: 4acd1e87a8bf ("ovn-trace: New utili

[ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES

2016-08-16 Thread Lance Richardson
Found by 'make distcheck'. Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") Signed-off-by: Lance Richardson --- ovn/utilities/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/automake.mk b/ovn/utilities/automake.mk index aae

[ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

2016-08-16 Thread Lance Richardson
Soliciting feedback/discussion to sanity-check proposed solution (described below) before implementation. Thanks,    Lance --- Limiting the impact of a compromised chassis. Problem Description: --- Each ovn-controller instance currently has full write access to the OVN southbou

Re: [ovs-dev] [openvswitch 2.5.90] testsuite: 2224 failed

2016-08-05 Thread Lance Richardson
Wow, that is a very strange finding. I also see it on Fedora 23 with gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6), 2/100 failures with default configuration, 100% failure rate with -march=native. Lance - Original Message - > From: "Ilya Maximets" > To: "Numan Siddique" , "Ben Pfaff" ,

Re: [ovs-dev] [PATCH] ovn-controller: Handle physical changes correctly

2016-07-23 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: dev@openvswitch.org > Sent: Friday, July 22, 2016 5:54:26 PM > Subject: [ovs-dev] [PATCH] ovn-controller: Handle physical changes correctly > > [1] reported increased failure rates in certain tests > with incremental processing (the numbers

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-23 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Saturday, July 23, 2016 1:49:36 AM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl > state machine > > On Fri, Jul 22, 2016

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-23 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Friday, July 22, 2016 6:16:59 PM > Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one > passive connection > > On

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-22 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Friday, July 22, 2016 6:47:14 PM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl > state machine > > On

Re: [ovs-dev] ovn test failures

2016-07-21 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Thursday, July 21, 2016 9:05:53 AM > Subject: Re: [ovs-dev] ovn test failures > > "dev" wrote on 07/21/2016 06:32:02 AM: > >

[ovs-dev] ovn test failures

2016-07-21 Thread Lance Richardson
It seems the failure rate for OVN end-to-end tests went up significantly when commit 70c7cfef188b5ae9940abd5b7d9fe46b1fa88c8e was merged earlier this week. After this commit, 100 iterations of "make check TESTSUITEFLAGs='-j8 -k ovn'" gave (number of failures in left-most column): 2 2179: ovn

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-19 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Tuesday, July 19, 2016 10:20:37 AM > Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one > passive connection > >

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-19 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Monday, July 18, 2016 11:36:27 PM > Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one > passive connection >

Re: [ovs-dev] Question about ovs-vtep implementation

2016-07-19 Thread Lance Richardson
- Original Message - > From: "Darrell Ball" > To: "Lance Richardson" > Cc: "ovs dev" , "Daniele Di Proietto" > > Sent: Friday, July 15, 2016 2:06:36 PM > Subject: Re: [ovs-dev] Question about ovs-vtep implementation >

Re: [ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests

2016-07-18 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: "Amitabha Biswas" , dev@openvswitch.org > Sent: Monday, July 18, 2016 2:34:02 PM > Subject: Re: [ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests > > On

Re: [ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests

2016-07-18 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Amitabha Biswas" > Cc: dev@openvswitch.org > Sent: Monday, July 18, 2016 1:33:56 PM > Subject: Re: [ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests > > On Fri, May 20, 2016 at 11:17:57AM -0700, Amitabha Biswas wrote: > > This patch fixes the

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-18 Thread Lance Richardson
> From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Wednesday, July 6, 2016 7:39:52 PM > Subject: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive > connection > > Investigation found that Some of the occasional failures in the > &q

Re: [ovs-dev] Question about ovs-vtep implementation

2016-07-15 Thread Lance Richardson
> From: "Darrell Ball" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Tuesday, July 12, 2016 5:34:04 PM > Subject: Re: [ovs-dev] Question about ovs-vtep implementation > > On Fri, Jul 8, 2016 at 12:20 PM, Lance Richardson > wrote: &g

[ovs-dev] OVN: Limiting the impact of a compromised chassis

2016-07-15 Thread Lance Richardson
I've been doing some investigation into the "Limiting the impact of a compromised chassis" issue described in ovn/TODO. These are some initial thoughts, posting here for feedback and any other ideas folks might have about how we should go about solving this part of the issue. The fact that we're h

[ovs-dev] [PATCH v2] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-15 Thread Lance Richardson
command will fail because ovs-vtep will have already deleted p0 from the vtep db. Eliminate this race while adding an additional check to verify that ovs-vtep is working as expected by waiting for ovs-vtep to remove entries for the deleted physical ports from the vtep db. Signed-off-by: Lance Ric

Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-13 Thread Lance Richardson
> > diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at > > index c296f0e..c978137 100644 > > --- a/tests/ovn-controller-vtep.at > > +++ b/tests/ovn-controller-vtep.at > > @@ -225,8 +225,9 @@ AT_CHECK([sed -n 's/^.*\(|WARN|.*\)$/\1/p' > > ovn-controller-vtep.log | sed 's/([[- >

Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-13 Thread Lance Richardson
- Original Message - > From: "Darrell Ball" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Tuesday, July 12, 2016 7:05:18 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in > "binding 1" test

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-11 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: "Lance Richardson" > Cc: dev@openvswitch.org, "Justin Pettit" > Sent: Monday, July 11, 2016 1:44:18 PM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl > sta

Re: [ovs-dev] [patch_v8] ovn: Add local router support (RFC).

2016-07-11 Thread Lance Richardson
- Original Message - > From: "Darrell Ball" > To: dlu...@gmail.com, d...@openvswitch.com > Sent: Monday, July 11, 2016 11:07:03 AM > Subject: [ovs-dev] [patch_v8] ovn: Add local router support (RFC). > > This patch adds local router support. The idea is to do openflow rule > calculatio

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-09 Thread Lance Richardson
+ Ryan Moats - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Cc: "Justin Pettit" > Sent: Thursday, July 7, 2016 8:33:57 PM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl > state machine

[ovs-dev] Question about ovs-vtep implementation

2016-07-08 Thread Lance Richardson
The "ovn-controller-vtep - vtep-macs 1" test case fails occasionally, with ovs-vswitchd logs similar to these:     bridge|INFO|bridge br-vtep_vtep_ls1: added interface vx1 on port 2     tunnel|WARN|bfd1.2.3.5: attempting to add tunnel port with same config as port 'vx1' (::->1.2.3.5, key=0, dp po

[ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-08 Thread Lance Richardson
command will fail because ovs-vtep will have already deleted p0 from the vtep db. Accomodate this race while ensuring that p0 and p1 have been removed from both dbs by using the "--if-exists" option on the second delete. Signed-off-by: Lance Richardson --- tests/ovn-controller-vte

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-07 Thread Lance Richardson
Oops, had intended to cc: Justin. - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Thursday, July 7, 2016 8:31:08 PM > Subject: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl > state machine > > The

[ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-07 Thread Lance Richardson
served in several hundred attempts. Signed-off-by: Lance Richardson --- v2: Added maximum iteration limit to state machine loop. ovn/controller/ofctrl.c | 50 ++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/ovn/controller/ofctrl.c

Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state machine

2016-07-07 Thread Lance Richardson
- Original Message - > From: "Justin Pettit" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Thursday, July 7, 2016 5:25:52 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl > state machine > > >

[ovs-dev] [PATCH v2] ovn-sbctl: eliminate a spurious test case error cause

2016-07-07 Thread Lance Richardson
l and ovn-vtep-controller tests, so fix it there as well. Signed-off-by: Lance Richardson --- Changes in v2: - Duplicated fix in ovn-nbctl.at and ovn-controller-vtep.at - Changed sed match string from 'connection reset' to 'reset by peer'. tests/ovn-controll

Re: [ovs-dev] [PATCH] ovn-sbctl: eliminate a spurious test case error cause

2016-07-07 Thread Lance Richardson
Self-NAK, this is needed in two other locations and a typo needs to be fixed. V2 is in progress. - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Thursday, July 7, 2016 2:49:14 PM > Subject: [ovs-dev] [PATCH] ovn-sbctl: eliminat

[ovs-dev] [PATCH] ovn-sbctl: eliminate a spurious test case error cause

2016-07-07 Thread Lance Richardson
n this test case, and the difference between EPIPE and ECONNRESET on send is simply a matter of whether the peer had unconsumed data in its receive buffer when the peer socket was closed, it should be OK to ignore "reset by peer" logs as well. Signed-off-by: Lance Richardson --- tests/ovn-sbc

[ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-06 Thread Lance Richardson
to a crash when the bogus packet buffer on the list is dereferenced). Fix by taking a hint from David Wheeler and adding a level of indirection. Signed-off-by: Lance Richardson --- lib/netdev-dummy.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/netd

Re: [ovs-dev] [PATCH v4] Makefile.am: Add clang static analysis support

2016-07-05 Thread Lance Richardson
++ b/Makefile.am > @@ -401,6 +401,13 @@ ovsext_clean: datapath-windows/ovsext.sln > endif > .PHONY: ovsext > > +clang-analyze: clean > + @which clang scan-build >/dev/null 2>&1 || \ > + (echo "Unable to find clang/scan

Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state machine

2016-07-05 Thread Lance Richardson
- Original Message - > From: "Ryan Moats" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Tuesday, July 5, 2016 12:17:17 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl > statemachine >

Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state machine

2016-07-05 Thread Lance Richardson
- Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Tuesday, July 5, 2016 8:58:24 AM > Subject: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state > machine > > The "ovn -- 2 HVs, 3 LRs connecte

[ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state machine

2016-07-05 Thread Lance Richardson
the state machine's "while state != old_state" loop to include processing of receive events. Without this fix, around 40 failures are seen out of 100 attempts, with this fix no failures have been observed in several hundred attempts. Signed-off-by: Lance Richardson --- ovn

[ovs-dev] [PATCH] ovn: reduce duplicated process termination code in test scripts

2016-07-03 Thread Lance Richardson
This change set introduces new macros to simplify and consolidate process termination handling for OVN test cases. Signed-off-by: Lance Richardson --- tests/ofproto-macros.at | 47 tests/ovn-controller.at | 11 +- tests/ovn.at| 277

Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-03 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Sunday, July 3, 2016 3:18:51 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only > when transaction is possible > &

Re: [ovs-dev] [PATCH v8 2/2] INSTALL.DPDK: Refactor DPDK install guide, add ADVANCED doc

2016-07-03 Thread Lance Richardson
- Original Message - > From: "Bhanuprakash Bodireddy" > To: dev@openvswitch.org > Cc: "daniele di proietto" > Sent: Sunday, July 3, 2016 10:48:25 AM > Subject: [ovs-dev] [PATCH v8 2/2] INSTALL.DPDK: Refactor DPDK install guide,   >   add ADVANCED doc > > Add INSTALL.DPDK-ADVANCED doc

Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-02 Thread Lance Richardson
- Original Message - > From: "Lance Richardson" > To: "Ben Pfaff" > Cc: dev@openvswitch.org > Sent: Saturday, July 2, 2016 4:11:14 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only > when transaction is poss

Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-02 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Saturday, July 2, 2016 3:23:35 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only > when transaction is possible &

Re: [ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, 3 lports/LS, 1 LR" test

2016-07-02 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Saturday, July 2, 2016 2:45:23 PM > Subject: Re: [ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, > 3 lports/LS, 1 LR" te

[ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, 3 lports/LS, 1 LR" test

2016-07-02 Thread Lance Richardson
Gracefully exit all daemons in this test case. Signed-off-by: Lance Richardson --- tests/ovn.at | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 37888bf..b8a9bf5 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -1866,9

[ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-02 Thread Lance Richardson
ion is possible. This addresses a cause of occasional failures in the "3 HVs, 3 LS, 3 lports/LS, 1 LR" test case. Signed-off-by: Lance Richardson --- ovn/controller/binding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/binding.c b/ovn/controller/binding

Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis support

2016-06-28 Thread Lance Richardson
> + scan-build -o $(srcdir)/tests/clang-analyzer-results > --use-analyzer=/usr/bin/clang \ > + make || exit 1; \ > + else \ > + echo -e "Unable to find clang/scan-build, Install clang,clang-analyzer >

Re: [ovs-dev] [PATCH] Makefile.am: Add clang static analysis support

2016-06-27 Thread Lance Richardson
- Original Message - > From: "Bhanuprakash Bodireddy" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Monday, June 27, 2016 3:23:26 PM > Subject: RE: [ovs-dev] [PATCH] Makefile.am: Add clang static analysis support > > >-Ori

Re: [ovs-dev] [PATCH] Makefile.am: Add clang static analysis support

2016-06-27 Thread Lance Richardson
- Original Message - > From: "Bhanuprakash Bodireddy" > To: dev@openvswitch.org > Sent: Monday, June 27, 2016 12:11:40 PM > Subject: [ovs-dev] [PATCH] Makefile.am: Add clang static analysis support > > Clang Static Analyzer is a source code analysis tool to find bugs. This > patch adds

Re: [ovs-dev] [PATCH] tests: Fixed ovsdb-monitor tests

2016-06-24 Thread Lance Richardson
- Original Message - > From: "Guru Shetty" > To: "Paul Boca" > Cc: dev@openvswitch.org > Sent: Friday, June 24, 2016 2:50:35 PM > Subject: Re: [ovs-dev] [PATCH] tests: Fixed ovsdb-monitor tests > > On 24 June 2016 at 09:51, Paul Boca wrote: > > > Redirect ovsdb-client stderr to /dev/nu

Re: [ovs-dev] [PATCH] tests: Fixed ovsdb-monitor tests

2016-06-24 Thread Lance Richardson
> $8 > output], > + AT_CHECK([ovsdb-client -vjsonrpc --detach --no-chdir > --pidfile="`pwd`"/client-pid --log-file="`pwd`"/ovsdb-client-log -d json > monitor --format=csv unix:socket $4 $5 $8 > output], > [0], [ignore], [ignore], [kil

Re: [ovs-dev] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-21 Thread Lance Richardson
- Original Message - > From: "Paul Boca" > To: "Lance Richardson" > Cc: "Alin Serdean" , dev@openvswitch.org, > "Ben Pfaff" > Sent: Tuesday, June 21, 2016 3:43:44 PM > Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND

Re: [ovs-dev] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT

2016-06-21 Thread Lance Richardson
- Original Message - > From: "Alin Serdean" > To: "Lance Richardson" , dev@openvswitch.org > Sent: Tuesday, June 14, 2016 1:22:36 PM > Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > > I'll take a look over it tomorrow :).

  1   2   >