On 2014/1/18 6:56, Ben Pfaff wrote:
I'm still not really happy with the degree of abstraction here. I'm
going to try some experiments of my own to see whether what I want is
practical.
Thanks, I don't have a good idea for abstraction properties before,
I'll try to find a good one and you can
Hi Ben,
Is this patch in the right format?
Should I send all patches again?
Thanks!
Alexander Wu
On 2014/1/10 15:04, Alexander Wu wrote:
v5.2:
Merge and solve conflicts while free table_features in
oftable_destroy().
v5.1:
Update mutex for get message, add some comments for get/set
features(use ofp13_* struct
currently, change it to ofputil later).
Use the encode/decode functions to handle table features request.
Currently we just implement GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
---
ofproto/ofpro
v5.1
Splited from ofctl-patch.
Fix spelling.
Signed-off-by: Alexander Wu
---
utilities/ovs-ofctl.8.in |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 9a8fd33..352d3c7 100644
--- a/utilities/ovs-ofctl.8.in
the ofpbuf_pull?
2. Add function to print OFPMP_TABLE_FEATURES.
But now the print is crude and dirty.
Fix it to bitmap or more desc later.
3. Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-off-by: Alexander Wu
---
ofp13_action_type and make them work.
v3:
Add func to get instruction/action name by OpenFlow instruction type directly.
Signed-off-by: Alexander Wu
Signed-off-by: Ben Pfaff
---
include/openflow/openflow-1.3.h | 20 ++--
lib/ofp-actions.c | 21
request doesn't contain a body, then it's a GET request.
It means OFPMP_TABLE_FEATURES consists of 2 parts: GET and SET.
We implement the GET message now, and part of SET.
But the entire SET message seems difficult, because it configures the
whole pipeline.
Hope your suggestions.
Al
v5.1
Split this patch to two because this one has been
reviewed yet.
v5:
Add dump-table-features to ovs-ofctl.8.in
v4:
No change.
v3:
No change.
v2:
No change
v1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by
e/decode functions to handle table features request.
Currently we just implement GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
---
ofproto/ofproto-provider.h |8 ++
ofproto/ofproto.c
On 2013/12/30 1:43, Ben Pfaff wrote:
On Wed, Dec 18, 2013 at 05:48:39PM +0800, Alexander Wu wrote:
v5:
Merge ofp-util.def to this patch to make it work independent.
Fix different return type in func ovs_instruction_type_from_inst_type
Use OVS_NOT_REACHED now.
v4:
Add enums of
On 24/12/2013 04:58, Ben Pfaff wrote:
On Wed, Dec 18, 2013 at 05:48:40PM +0800, Alexander Wu wrote:
v5:
No change.
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
Signed-off-by: Alexander Wu
Acked
entire SET message seems difficult, because it configures the
whole pipeline.
Hope your suggestions.
Alexander Wu (5):
ofp-actions: Complete ofp13_action_type and add function to use
instructions.
bitmap: add bitmap_count1 function
ofp-util: Implement OFPMP_TABLE_FEATURES en/decode
v5:
No change.
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
Signed-off-by: Alexander Wu
Acked-by: Ben Pfaff
Signed-off-by: Ben Pfaff
---
lib/bitmap.c | 15 +++
lib/bitmap.h |1 +
2
v5:
Add dump-table-features to ovs-ofctl.8.in
v4:
No change.
v3:
No change.
v2:
No change
v1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
utilities/ovs-ofctl.8.in |4
utilities/ovs
ow the print is crude and dirty.
Fix it to bitmap or more desc later.
3. Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-off-by: Alexander Wu
---
lib/ofp-print.c| 168 ++-
lib/o
ment GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
---
ofproto/ofproto-provider.h |8 ++
ofproto/ofproto.c | 232 +++-
2 files changed, 239 insertions(+), 1 deletions(-)
diff --
type directly.
Signed-off-by: Alexander Wu
Signed-off-by: Ben Pfaff
---
include/openflow/openflow-1.3.h | 20 ++--
lib/ofp-actions.c | 21 +
lib/ofp-actions.h |3 +++
lib/ofp-parse.c | 19
On 18/12/2013 08:48, Ben Pfaff wrote:
On Mon, Dec 09, 2013 at 06:41:10PM +0800, Alexander Wu wrote:
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
Acked-by: Ben Pfaff
Can I have a Signed-off-by
On 18/12/2013 08:54, Ben Pfaff wrote:
On Mon, Dec 09, 2013 at 06:41:13PM +0800, Alexander Wu wrote:
v4:
No change.
v3:
No change.
v2:
No change
v1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
On 18/12/2013 08:51, Ben Pfaff wrote:
On Mon, Dec 09, 2013 at 06:41:11PM +0800, Alexander Wu wrote:
v4.3:
Rollback table id 255 to 253 according to OpenFlow spec and current implement
Update AT.
v4.2:
Fix last table features id to 255.
Add more comments.
Fix wrong print of last
On 18/12/2013 08:53, Ben Pfaff wrote:
On Mon, Dec 09, 2013 at 06:41:12PM +0800, Alexander Wu wrote:
v4.3:
Fix last table features id to 253 according to current
imlement and OpenFlow spec.
v4.2:
Fix last table features id to 255.
v4:
1. update abstract table-features to bitmap
On 18/12/2013 08:50, Ben Pfaff wrote:
On Mon, Dec 09, 2013 at 06:41:09PM +0800, Alexander Wu wrote:
v4:
Add enums of ofp13_action_type and make them work.
v3:
Add func to get instruction/action name by OpenFlow instruction type
directly.
Can I have a Signed-off-by?
Sure!
GCC
On 10/12/2013 04:50, Jarno Rajahalme wrote:
On Dec 8, 2013, at 7:34 PM, Alexander Wu wrote:
Hi Jarno,
I get my gcc predefined __core2. But its performance seems to be worse when
I add '-O2'. Not sure if it's the reality.
From the numbers below it seems that performance
nction to print OFPMP_TABLE_FEATURES.
But now the print is crude and dirty.
Fix it to bitmap or more desc later.
3. Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-off-by: Alexander Wu
---
lib/ofp-print.c| 155 +-
lib/o
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
---
lib/bitmap.c | 15 +++
lib/bitmap.h |1 +
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index
v4:
Add enums of ofp13_action_type and make them work.
v3:
Add func to get instruction/action name by OpenFlow instruction type directly.
---
include/openflow/openflow-1.3.h | 20 ++--
lib/ofp-actions.c | 19 +++
lib/ofp-actions.h
we'll do it later.
Signed-off-by: Alexander Wu
ofproto
---
ofproto/ofproto-provider.h |8 ++
ofproto/ofproto.c | 230 +++-
2 files changed, 237 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofproto-provider.h b/ofproto/ofproto-pro
v4:
No change.
v3:
No change.
v2:
No change
v1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
utilities/ovs-ofctl.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff
the entire SET message seems difficult, because it configures the
whole pipeline.
Hope your suggestions.
Alexander Wu (5):
ofp-actions: Complete ofp13_action_type and add function to use
instructions.
bitmap: add bitmap_count1 function
ofp-util: Implement OFPMP_TABLE_FEATURES en/decode
x27;t contain a body, then it's a GET request.
It means OFPMP_TABLE_FEATURES consists of 2 parts: GET and SET.
We implement the GET message now, and part of SET.
But the entire SET message seems difficult, because it configures the
whole pipeline.
Hope your suggestions.
Alexander Wu
v4:
Add enums of ofp13_action_type and make them work.
v3:
Add func to get instruction/action name by OpenFlow instruction type directly.
---
include/openflow/openflow-1.3.h | 20 ++--
lib/ofp-actions.c | 19 +++
lib/ofp-actions.h
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
---
lib/bitmap.c | 15 +++
lib/bitmap.h |1 +
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index
v4:
No change.
v3:
No change.
v2:
No change
v1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
utilities/ovs-ofctl.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff
desc later.
3. Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-off-by: Alexander Wu
---
lib/ofp-print.c| 157 +-
lib/ofp-util.c | 624
lib/ofp-util.def | 21 ++
lib/o
* struct
currently, change it to ofputil later).
Use the encode/decode functions to handle table features request.
Currently we just implement GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
---
ofproto/ofproto-provider.h |
On 07/12/2013 00:13, Jarno Rajahalme wrote:
On Dec 6, 2013, at 1:18 AM, Alexander Wu wrote:
Hi Jarno,
I've read your patch "better count1_bits", and I test the gcc
builtins separately.
Call __builtin_popcount|__builtin_popcountl|__builtin_popcountll 10
v4:
No change.
v3:
No change.
v2:
No change
v1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
utilities/ovs-ofctl.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff
il later).
Use the encode/decode functions to handle table features request.
Currently we just implement GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
---
ofproto/ofproto-provider.h |8 ++
ofproto/ofproto.c
v4.1:
Update bitmap_count1 function: call count_1bits to improve
performance.
v4:
Add bitmap_count1 function to count all 1 bits.
---
lib/bitmap.c | 15 +++
lib/bitmap.h |1 +
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index
functions *_raw, maybe we
should change it the ofpbuf_pull?
2. Add function to print OFPMP_TABLE_FEATURES.
But now the print is crude and dirty.
Fix it to bitmap or more desc later.
3. Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-
SET.
We implement the GET message now, and part of SET.
But the entire SET message seems difficult, because it configures the
whole pipeline.
Hope your suggestions.
Alexander Wu (5):
ofp-actions: Complete ofp13_action_type and add function to use
instructions.
bitmap: add bitmap_count
v4:
Add enums of ofp13_action_type and make them work.
v3:
Add func to get instruction/action name by OpenFlow instruction type directly.
---
include/openflow/openflow-1.3.h | 20 ++--
lib/ofp-actions.c | 19 +++
lib/ofp-actions.h
eve there're some particuler cpus which the buildin_popcount
is suitable for, any way to represent them?
On 06/12/2013 12:26, Ben Pfaff wrote:
On Fri, Dec 06, 2013 at 12:02:59PM +0800, Alexander Wu wrote:
Some additional test for bitmap performance (10 million loops):
suse-kvm-of13:/tes
On 06/12/2013 10:39, Alexander Wu wrote:
On 06/12/2013 01:47, Ben Pfaff wrote:
On Wed, Dec 04, 2013 at 05:38:29PM +0800, Alexander Wu wrote:
V4:
Add bitmap_count1 function to count all 1 bits.
I suggest using the count_1bits() function to speed this up.
Thanks,
Ben.
Hi Ben,
Thanks
On 06/12/2013 01:47, Ben Pfaff wrote:
On Wed, Dec 04, 2013 at 05:38:29PM +0800, Alexander Wu wrote:
V4:
Add bitmap_count1 function to count all 1 bits.
I suggest using the count_1bits() function to speed this up.
Thanks,
Ben.
Hi Ben,
Thanks for your suggestion! I'll updat
il later).
Use the encode/decode functions to handle table features request.
Currently we just implement GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
---
ofproto/ofproto-provider.h |8 ++
ofproto/ofproto.c
V4:
Add bitmap_count1 function to count all 1 bits.
---
lib/bitmap.c | 15 +++
lib/bitmap.h |1 +
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index ac568e9..7dd5a0f 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -92,3 +92,18 @@ b
v4:
Add enums of ofp13_action_type and make them work.
V3:
Add func to get instruction/action name by OpenFlow instruction type directly.
---
include/openflow/openflow-1.3.h | 20 ++--
lib/ofp-actions.c | 19 +++
lib/ofp-actions.h
functions *_raw, maybe we
should change it the ofpbuf_pull?
2. Add function to print OFPMP_TABLE_FEATURES.
But now the print is crude and dirty.
Fix it to bitmap or more desc later.
3. Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-
e pipeline.
Hope your suggestions.
Alexander Wu (5):
ofp-actions: Complete ofp13_action_type and add function to use
instructions.
bitmap: add bitmap_count1 function
ofp-util: Implement OFPMP_TABLE_FEATURES en/decode
ofproto: handle OFPMP_TABLE_FEATURES msgs and its lifecycle.
ofct
V4:
No change.
V3:
No change.
V2:
No change
V1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
utilities/ovs-ofctl.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff
On 26/11/2013 05:27, Ben Pfaff wrote:
1.3 Actions:
Actions use separate struct, the reason as below:
OFPAT11_ACTION(in ofp-util.def) has 24 actions, but OpenFlow 1.3.2
[p58] has 17 actions, most of OFPAT11_SET_*, OFPAT11_COPY_TTL_* and
*_PBB(not implement) are different her
On 22/11/2013 06:21, Ben Pfaff wrote:
On Thu, Nov 21, 2013 at 05:04:30PM +0800, Alexander Wu wrote:
V3:
Add description for table-features get/set struct.
V2:
No change.
V1:
Add table_feature structs in ofproto && oftable to initialize.
The struct in ofproto is used to ge
On 22/11/2013 06:37, Ben Pfaff wrote:
On Thu, Nov 21, 2013 at 05:04:36PM +0800, Alexander Wu wrote:
V3:
First commit. Add translate function from OpenFlow enum to OVS-internal enum.
Signed-off-by: Alexander Wu
I don't understand why the last patch in the series would add a
function
On 22/11/2013 06:35, Ben Pfaff wrote:
On Thu, Nov 21, 2013 at 05:04:34PM +0800, Alexander Wu wrote:
V3:
No change.
V2:
No change.
V1:
Make the enums allowed
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
This misjudges the purpose of this function. It does not deliver an
On 22/11/2013 06:36, Ben Pfaff wrote:
On Thu, Nov 21, 2013 at 05:04:35PM +0800, Alexander Wu wrote:
V3:
Update printable messages: instruction/action/oxm/next_table.
Update action features, now the actions are correct.
V2:
Fix type of NEXT_TABLE_MISS
V1:
Implement the at for
On 22/11/2013 06:36, Ben Pfaff wrote:
On Thu, Nov 21, 2013 at 05:04:32PM +0800, Alexander Wu wrote:
V3:
Modify type of element_size and print error if 0.
Fix CodingStyle.
Change print of next_tables msg, change enums to OFPUTIL_*.
Make all print human-readable.
V2:
Change calls
On 22/11/2013 06:19, Ben Pfaff wrote:
On Thu, Nov 21, 2013 at 05:04:29PM +0800, Alexander Wu wrote:
V3:
1. Update names of functions/macros to make them meaningful.
2. Fix codingstyle.
3. Remove useless logic/struct/function.
4. Make printable messages more friendly.
5. Add
On 22/11/2013 06:02, Ben Pfaff wrote:
On Thu, Nov 21, 2013 at 05:04:28PM +0800, Alexander Wu wrote:
V3:
No change.
V2:
No change.
V1:
Fix the limits to right ones.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
Applied to master, thanks!
Thanks
Many thanks for review!
On 13/11/2013 16:08, Simon Horman wrote:
I think it would be quite helpful if you added some text describing
the relationship between tf and otf:
a) in the changelog
b) above otf
c) above tf
On Wed, Nov 06, 2013 at 10:45:52PM +0800, Alexander Wu wrote:
V2:
No
Many thanks for review!
On 13/11/2013 16:24, Simon Horman wrote:
On Wed, Nov 06, 2013 at 10:46:10PM +0800, Alexander Wu wrote:
V2:
No change
V1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
Many thanks for review!
On 13/11/2013 15:12, Simon Horman wrote:
On Wed, Nov 06, 2013 at 10:45:26PM +0800, Alexander Wu wrote:
V2:
No change.
V1:
Fix the limits to right ones.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
lib/ofp-msgs.h |4 ++--
1 files
Many thanks for review!
On 13/11/2013 16:25, Simon Horman wrote:
On Wed, Nov 06, 2013 at 10:46:12PM +0800, Alexander Wu wrote:
V2:
No change.
V1:
Make the enums allowed
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
lib/rconn.c |4 ++--
1 files changed, 2
On 13/11/2013 16:24, Simon Horman wrote:
On Wed, Nov 06, 2013 at 10:46:07PM +0800, Alexander Wu wrote:
V2:
Change calls of ofputil.
Fix CodingStyle accoring to Simon Horman's suggestions.
V1:
Add function to print OFPMP_TABLE_FEATURES.
But now the print is crude and dirty.
On 13/11/2013 16:21, Simon Horman wrote:
On Wed, Nov 06, 2013 at 10:46:04PM +0800, Alexander Wu wrote:
V2:
1. fix function align, align to 79 bytes, fix BE64 to UINT64, etc.
2. fix n_tables_miss init type.
3. Change calls from ofputil.
Simon Horman suggestions:
1. Fix CodingStyle
On 13/11/2013 16:21, Simon Horman wrote:
On Wed, Nov 06, 2013 at 10:45:31PM +0800, Alexander Wu wrote:
V2:
Restructure implement of OFPMP_TABLE_FEATURES
Change decode_*_raw to normalized pull functions
1. add macros and funcs to en/decode table features
2. restructure
V3:
Update printable messages: instruction/action/oxm/next_table.
Update action features, now the actions are correct.
V2:
Fix type of NEXT_TABLE_MISS
V1:
Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-off-by: Alexander Wu
---
test
V3:
Add description for table-features get/set struct.
V2:
No change.
V1:
Add table_feature structs in ofproto && oftable to initialize.
The struct in ofproto is used to get
The struct in oftable is used to set (set is not implement yet)
Signed-off-by: Alexander Wu
---
V3:
First commit. Add translate function from OpenFlow enum to OVS-internal enum.
Signed-off-by: Alexander Wu
---
lib/ofp-actions.c | 16
lib/ofp-actions.h |3 +++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
print OFPMP_TABLE_FEATURES.
But now the print is crude and dirty.
Fix it to bitmap or more desc later.
Signed-off-by: Alexander Wu
---
lib/ofp-print.c | 140 ++-
1 files changed, 139 insertions(+), 1 deletions(-)
diff --git a/lib/ofp-print.c b/li
V3:
No change.
V2:
No change
V1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
utilities/ovs-ofctl.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/utilities
V3:
No change.
V2:
No change.
V1:
Make the enums allowed
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
lib/rconn.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/rconn.c b/lib/rconn.c
index f7f90f7..0f72a99 100644
--- a/lib/rconn.c
+++ b/lib
we just implement GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
---
ofproto/ofproto.c | 275 -
1 files changed, 274 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofprot
*_raw, maybe we
should change it the ofpbuf_pull?
Signed-off-by: Alexander Wu
---
lib/ofp-util.c | 699
lib/ofp-util.h | 211 +
2 files changed, 910 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-u
Alexander Wu (9):
ofp-msgs: Fix limits of OFPMP_TABLE_FEATURES.
ofp-util: Implement OFPMP_TABLE_FEATURES en/decode
ofproto-provider: Add/Modify headers for OFPMP_TABLE_FEATURES in
ofproto
ofproto: handle OFPMP_TABLE_FEATURES msgs and its lifecycle.
ofp-print: Implement the function
V3:
No change.
V2:
No change.
V1:
Fix the limits to right ones.
Signed-off-by: Alexander Wu
Reviewed-by: Simon Horman
---
lib/ofp-msgs.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-msgs.h b/lib/ofp-msgs.h
index c526a15..26fd6a3 100644
--- a/lib
On 12/11/2013 11:58, YAMAMOTO Takashi wrote:
+ OFPTFPT13_MATCH:
IN_PORT,IN_PHY_PORT,METADATA,ETH_DST,ETH_SRC,ETH_TYPE,VLAN_VID,VLAN_PCP,IP_DSCP,IP_ECN,IP_PROTO,IPV4_SRC,IPV4_DST,TCP_SRC,TCP_DST,UDP_SRC,UDP_DST,SCTP_SRC,SCTP_DST,ICMPV4_TYPE,ICMPV4_CODE,ARP_OP,ARP_SPA,ARP_TPA,ARP_SHA,ARP_THA,
On 12/11/2013 15:10, Ben Pfaff wrote:
On Tue, Nov 12, 2013 at 03:03:37PM +0800, Alexander Wu wrote:
On 12/11/2013 12:32, Ben Pfaff wrote:
I've add a PATCH[0/N] by hand, and the patches after are not in a
single thread. All the patches are sent by hand.
Maybe you couldn't
On 12/11/2013 12:34, Ben Pfaff wrote:
On Tue, Nov 12, 2013 at 11:03:45AM +0800, Alexander Wu wrote:
On 12/11/2013 07:55, Ben Pfaff wrote:
These patches seem to be whitespace damaged. Perhaps you could make
them available through a branch somewhere?
Sorry for the whitespace. It's caus
the usage of tools. So I can't use "git send-email".
The only way to contact you all is using email now, and I could
only send patches via email, I'm very sorry for perplexing the
patches.
I'll try to gain privilege to send-email by git, thanks!
Best regards,
Alexander Wu
are implemented: */
case OFPTYPE_QUEUE_GET_CONFIG_REQUEST:
return handle_queue_get_config_request(ofconn, oh);
+/* fallthrough */
this looks like a broken rebase.
YAMAMOTO Takashi
--
Best Regards,
Alexander Wu
___
dev m
On 12/11/2013 07:55, Ben Pfaff wrote:
On Wed, Nov 06, 2013 at 10:45:22PM +0800, Alexander Wu wrote:
Thanks.
These patches seem to be whitespace damaged. Perhaps you could make
them available through a branch somewhere?
Another thing to say:
I've add a PATCH[0/N] by hand, and the pa
MOTO Takashi
Good question.
Not only oxm, action and instruction in table-features has this matter.
The length may be useless now, but I'm not sure if it makes sense.
--
Best Regards,
Alexander Wu
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
s. You can find this one
in emails:
[PATCH v2 0/8] Implement OFPMP_TABLE_FEATURES GET - Fix fi error
And you'll see the content below:
Alexander Wu:
This patch is to implement table features GET msg in openflow 1.3.
The spec says:
If the request body contains an array
lookup flow-entries ——> table-miss process
| not found
OF1.3 | lookup flow-entries include table-miss entry ——>
| drop (absent_table_miss)
So in OF1.3, a FLOW_MOD msg is ok to replace a TABLE_MOD msg, I think.
--
Best Regards,
Alexander
Alexander Wu:
This patch is to implement table features GET msg in openflow 1.3.
The spec says:
If the request body contains an array of one or more ofp_table_features
structs, the switch will attempt to change its flow tables to match the
requested flow table configuration. This
V2:
Fix type of NEXT_TABLE_MISS
V1:
Implement the at for OFPMP_TABLE_FEATURES.
(I've tested it via NOX-OF1.3 too.)
Signed-off-by: Alexander Wu
---
tests/ofp-print.at | 187
tests/ofproto.at | 25 +++
2 files changed
V2:
No change
V1:
Now the cli we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
---
utilities/ovs-ofctl.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index
V2:
Change calls of ofputil.
Fix CodingStyle accoring to Simon Horman's suggestions.
V1:
Add function to print OFPMP_TABLE_FEATURES.
But now the print is crude and dirty.
Fix it to bitmap or more desc later.
Signed-off-by: Alexander Wu
---
lib/ofp-print.c |
V2:
No change.
V1:
Make the enums allowed
Signed-off-by: Alexander Wu
---
lib/rconn.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/rconn.c b/lib/rconn.c
index f7f90f7..0f72a99 100644
--- a/lib/rconn.c
+++ b/lib/rconn.c
@@ -1381,8 +1381,6
ns to init table features(use ofp13_* struct
currently, change it to ofputil later).
Use the encode/decode functions to handle table features request.
Currently we just implement GET table feature.
SET table feature may be a hard job, we'll do it later.
Signed-off-by: Alexander Wu
--
V2:
No change.
V1:
Add table_feature structs in ofproto && oftable to initialize.
The struct in ofproto is used to get
The struct in oftable is used to set (set is not implement yet)
Signed-off-by: Alexander Wu
---
ofproto/ofproto-provider.h |3 +++
1 files changed, 3 in
Alexander Wu:
This patch is to implement table features GET msg in openflow 1.3.
The spec says:
If the request body contains an array of one or more ofp_table_features
structs, the switch will attempt to change its flow tables to match the
requested flow table con guration. This
V2:
No change.
V1:
Fix the limits to right ones.
Signed-off-by: Alexander Wu
---
lib/ofp-msgs.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-msgs.h b/lib/ofp-msgs.h
index c526a15..26fd6a3 100644
--- a/lib/ofp-msgs.h
+++ b/lib/ofp-msgs.h
@@ -343,10
code table features msgs function, and
NOTE that we implement the decode functions *_raw, maybe we
should change it the ofpbuf_pull?
Signed-off-by: Alexander Wu
---
lib/ofp-util.c | 723
lib/ofp-util.h | 153
2 files ch
On 01/11/2013 12:32, Simon Horman wrote:
On Sat, Oct 26, 2013 at 06:15:30PM +0800, Alexander Wu wrote:
Add some functions to init table features(use ofp13_* struct
currently, change it to ofputil later).
Use the encode/decode functions to handle table features request.
Currently we just
On 01/11/2013 12:32, Simon Horman wrote:
On Sat, Oct 26, 2013 at 06:12:27PM +0800, Alexander Wu wrote:
Add headers and function prototype for table features.
And modify the limits of mp-table-features msg
Signed-off-by: Alexander Wu
---
lib/ofp-msgs.h |4 +-
lib/ofp-util.h
Thanks for your reply!
On 01/11/2013 12:29, Simon Horman wrote:
On Sat, Oct 26, 2013 at 06:14:28PM +0800, Alexander Wu wrote:
Implement the encode/decode table features msgs function, and
NOTE that we implement the decode functions *_raw, maybe we
should change it the ofpbuf_pull?
Signed-off
Signed-off-by: Alexander Wu
---
tests/ofp-print.at | 187
tests/ofproto.at | 25 +++
2 files changed, 212 insertions(+), 0 deletions(-)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index 87d5da8..a8ca0a3 100644
--- a/tests
li we implement is very crude. Maybe it could
display better.
Signed-off-by: Alexander Wu
---
lib/rconn.c |4 +-
ofproto/ofproto.c | 384 -
utilities/ovs-ofctl.c | 17 +++
3 files changed, 402 insertions(+), 3 deletions(-)
diff --
1 - 100 of 103 matches
Mail list logo
