Many thanks for review!

On 13/11/2013 16:08, Simon Horman wrote:
I think it would be quite helpful if you added some text describing
the relationship between tf and otf:

a) in the changelog
b) above otf
c) above tf

On Wed, Nov 06, 2013 at 10:45:52PM +0800, Alexander Wu wrote:

V2:
   No change.

V1:
   Add table_feature structs in ofproto && oftable to initialize.
   The struct in ofproto is used to get
   The struct in oftable is used to set (set is not implement yet)

Signed-off-by: Alexander Wu <alexander...@huawei.com>
---
  ofproto/ofproto-provider.h |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/ofproto/ofproto-provider.h b/ofproto/ofproto-provider.h
index 2844e4c..5782da7 100644
--- a/ofproto/ofproto-provider.h
+++ b/ofproto/ofproto-provider.h
@@ -152,6 +152,8 @@ struct ofproto {
      struct hmap groups OVS_GUARDED;   /* Contains "struct ofgroup"s. */
      uint32_t n_groups[4] OVS_GUARDED; /* # of existing groups of each type. */
      struct ofputil_group_features ogf;
+    /* ANOTHER solution. it doesn't need to copy */
+    struct ofputil_table_features otf[OFTABLE_NUM]; /* seems like to be "tf", not 
"otf" */
  };

  void ofproto_init_tables(struct ofproto *, int n_tables);
@@ -258,6 +260,7 @@ struct oftable {
      uint32_t eviction_group_id_basis;
      struct hmap eviction_groups_by_id;
      struct heap eviction_groups_by_size;
+    struct ofputil_table_features tf;
  };

  /* Assigns TABLE to each oftable, in turn, in OFPROTO.
--
1.7.3.1.msysgit.0






_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to