Re: [ovs-dev] [ovs dpdk] why all the ovs threads pinned to master lcore?

2016-10-25 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: >> >>++ pidof ovs-vswitchd >>+ ps -To tid,pid,psr,comm -p 25932 >> TID PID PSR COMMAND >>25932 25932 1 ovs-vswitchd >>25934 25932 0 eal-intr-thread >>25935 25932 1 dpdk_watchdog1 >>25936 25932 2 vhost_thread2 >>25937 25932 1 pdump-thread >>25938 2593

[ovs-dev] [PATCH v2 6/7] checkpatch: fix the if and whitespace checks

2016-10-21 Thread Aaron Conole
ional. */ } So fix that as well. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index d21574c..ab389ba 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpat

[ovs-dev] [PATCH v2 0/7] checkpatch: Misc. cleanups, and a new feature

2016-10-21 Thread Aaron Conole
line number where a change occurs in the file, instead of in the patchfile. With these two features, a simple script for check_file in lib/*.c; do ./utilities/checkpatch.py -f $check_file; done will print a number of violations (hopefully, correctly!). Aaron Conole (7): checkpatch

[ovs-dev] [PATCH v2 2/7] checkpatch: Print the line in question distinctly

2016-10-21 Thread Aaron Conole
This makes it easier to distinguish between the line, and the warning/error message. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 15b59a3..5fbac9a 100755

[ovs-dev] [PATCH v2 4/7] checkpatch: Print file line numbers

2016-10-21 Thread Aaron Conole
plied file line number. This can be useful with future work to 'mock' apply and build a real contextual scanner for checking multi-line changes. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/utilities/checkpatch

[ovs-dev] [PATCH v2 7/7] checkpatch: Add file-parsing mode

2016-10-21 Thread Aaron Conole
This adds a new argument and feature, 'check-file', which will allow checkpatch to run against files instead of only against patches. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 39 ++- 1 file changed, 30 insertions(+), 9 deletion

[ovs-dev] [PATCH v2 1/7] checkpatch: Announce the file where errors occur

2016-10-21 Thread Aaron Conole
This makes finding the warning and error marks much easier. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 13 + 1 file changed, 13 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 754059a..15b59a3 100755 --- a/utilities/checkpatch.py

[ovs-dev] [PATCH v2 5/7] checkpatch: Fix signoff error

2016-10-21 Thread Aaron Conole
When no 'Signed-off-by' tags are found, the output will look like: E: No signatures found. E: Too many signoffs; are you missing Co-authored-by lines? Warnings: 0, Errors: 2 However, there should really only be one error reported in this case. Signed-off-by: Aa

[ovs-dev] [PATCH v2 3/7] checkpatch: convert some of the warnings

2016-10-21 Thread Aaron Conole
These coding issues are not just things that shouldn't be done. They are styles which should never be submitted. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/utilities/checkpatch.py b/util

Re: [ovs-dev] [PATCH] dpdk: Fix DPDK pdump compilation

2016-10-13 Thread Aaron Conole
Ciara Loftus writes: > The rte_pdump header file was not included in the file that requires it. > Fix this. > > Fixes: 01961bbdd34a ("dpdk: New module with some code from netdev-dpdk.") > Signed-off-by: Ciara Loftus > --- I'm not sure why I didn't see this compilation error when I built; I'm o

Re: [ovs-dev] 答复: Re: [PATCH] netdev: Initialize netdev's features before getting them

2016-10-13 Thread Aaron Conole
xu.binb...@zte.com.cn writes: > Hi Aaron, > > Thanks for your suggestion, I'll resubmit a patch for DPDK, and take a look > at > lib/netdev-bsd.c to confirm that the additional patch is needed or not. > > Thanks, > > Aaron Conole 写于 2016/10/12 21:26:14:

Re: [ovs-dev] [PATCH 12/13] dpdk: New module with some code from netdev-dpdk.

2016-10-12 Thread Aaron Conole
o a new module 'dpdk-stub' is introduced to implement some functions > when DPDK is not available. This replaces the old 'netdev-nodpdk' > module. > > Some redundant includes are removed or reorganized as a consequence. > > No functional change. > > CC: Aaro

Re: [ovs-dev] [PATCH 1/6] checkpatch: Fix up the co-authors check

2016-10-12 Thread Aaron Conole
Aaron Conole writes: > The signed-off and co-authors check that was committed is just plain > wrong. The test should be more than 1 'Signed-off-by'. > > Signed-off-by: Aaron Conole > --- > utilities/checkpatch.py | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [ovs-dev] Why not implement netdev datapath in a separated process

2016-10-12 Thread Aaron Conole
Huanle Han writes: > Hi, Hi Huanle, > I'm thinking about this quesion, after experience the dpdk feature in ovs. > Could you give me some answer? I'll take a stab at it. > Currently, netdev datapath(or called dpdk) is implemented inside daemon > process "ovs-vswitchd". > It makes ovs-vswitchd

Re: [ovs-dev] [PATCH] netdev: Initialize netdev's features before getting them

2016-10-12 Thread Aaron Conole
Hi Binbin, Binbin Xu writes: > When OVS&DPDK is used, DPDK doesn't support features 'advertised', > 'supported' and 'peer'. If a physical port added to bridge, features > descirbed above can't be assigned, and the values are random. > > Signed-off-by: Binbin Xu > --- Thanks for reporting this.

[ovs-dev] [PATCH 3/6] checkpatch: print the final warning / error count

2016-10-07 Thread Aaron Conole
Because we track it, might as well report it. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index ed53f32..61678a9 100755 --- a/utilities/checkpatch.py +++ b

[ovs-dev] [PATCH 6/6] checkpatch: Print file line numbers

2016-10-07 Thread Aaron Conole
plied file line number. This can be useful with future work to 'mock' apply and build a real contextual scanner for checking multi-line changes. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/utilities/checkpatch

[ovs-dev] [PATCH 5/6] checkpatch: convert some of the warnings

2016-10-07 Thread Aaron Conole
These coding issues are not just things that shouldn't be done. They are styles which should never be submitted. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpat

[ovs-dev] [PATCH 4/6] checkpatch: Print the line in question distinctly

2016-10-07 Thread Aaron Conole
This makes it easier to pick out of the warnings/errors. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 61678a9..c8f21b0 100755 --- a/utilities/checkpatch.py

[ovs-dev] [PATCH 2/6] checkpatch: Announce the file where errors occur.

2016-10-07 Thread Aaron Conole
This makes finding the warning and error marks much easier. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 17e5be4..ed53f32 100755 --- a/utilities/checkpatch.py +++ b

[ovs-dev] [PATCH 1/6] checkpatch: Fix up the co-authors check

2016-10-07 Thread Aaron Conole
The signed-off and co-authors check that was committed is just plain wrong. The test should be more than 1 'Signed-off-by'. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utilities/checkpatch.py b

[ovs-dev] [PATCH 0/6] Misc. Checkpatch cleanups

2016-10-07 Thread Aaron Conole
Two of these are 'bug fixes' to the checkpatch infrastructure (1/6, and 5/6), while the rest are enhancements. In particular, 6/6 hasn't been aggressively tested. These were developed while working on other patches, but are being submitted here as an independent series.

[ovs-dev] [PATCH] rhel-systemd: Delay shutting down the services

2016-10-07 Thread Aaron Conole
down systems. Fixes: 84ad12083491 ("rhel: Improved Systemd Integration") Co-authored-by: Flavio Leitner Signed-off-by: Aaron Conole --- rhel/usr_lib_systemd_system_openvswitch.service | 2 ++ rhel/usr_lib_systemd_system_ovs-vswitchd.service | 3 ++- rhel/usr_lib_systemd_sy

Re: [ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

2016-10-06 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Oct 05, 2016 at 11:09:39AM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote: >> >> On 09/08/2016 05:50 PM, Aaron Conole wrote: >> >> > >&g

Re: [ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

2016-10-05 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote: >> On 09/08/2016 05:50 PM, Aaron Conole wrote: >> > >> >> It sounds like new feature territory, but you do make a case for >> > it being considered a set of fixes ... &

Re: [ovs-dev] [PATCH 02/13] netdev-nodpdk.c: Add missing copyright.

2016-10-05 Thread Aaron Conole
Daniele Di Proietto writes: > Looks like we forgot to add the copyright headers to netdev-dpdk.h. > Looking at the contribution history of the file, this commit adds the > header with Red Hat copyright. > > CC: Aaron Conole > Signed-off-by: Daniele

[ovs-dev] [PATCH] ovstest: Initialize command mode to RO

2016-10-04 Thread Aaron Conole
When the read-only infrastucture support was added, the test-suite registration was missed. This causes tools like valgrind to complain about uninitialized variable usage. Fixes: 1f4a7252d9e7 ("Add read-only option to ovs-dpctl and...") Cc: Ryan Moats Signed-off-by: Aaron Conole ---

Re: [ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

2016-10-04 Thread Aaron Conole
g daemons, or the vhost-sock-dir. As mentioned before, a manual > intervention will > not survive an ovs-vswitchd restart, but an ovs restart will also break the > connection to the > existing VM (that's why I think client mode is a much better approach). Agreed. Let's drop

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Fix issues introduced by recent style fix.

2016-09-30 Thread Aaron Conole
Ilya Maximets writes: > Double word removed. Error message rewritten to avoid breaking of the > user-visible string. > > CC: Mark Kavanagh > Fixes: 58be5c0eecf3 ("netdev-dpdk: Fix coding style") > Signed-off-by: Ilya Maximets > --- > lib/netdev-dpdk.c | 7 --- > 1 file changed, 4 insertion

Re: [ovs-dev] OVS+DPDK: Requested device 0000:01:00.0 cannot be used

2016-09-27 Thread Aaron Conole
ychen writes: > hi, > I follow the doc "INSTALLDPDK.md" to build ovs dpdk envrioment, but failed to > start ovs-vswitchd > here is my configurations: > 1. kernel: 3.10.45-openstack-amd64 #1 SMP Tue Jul 1 01:52:20 UTC 2014 x86_64 > GNU/Linux > 2. NIC: > 01:00.0 Ethernet controller [0200]: Inte

Re: [ovs-dev] [PATCH] CONTRIBUTING.md: Improve recommended command for Fixes: header.

2016-09-23 Thread Aaron Conole
Ben Pfaff writes: > It usually makes sense to CC the author of the commit being fixed. > > The CC tag wasn't mentioned before, so describe it too. > > Signed-off-by: Ben Pfaff > --- ACK. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/

Re: [ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

2016-09-20 Thread Aaron Conole
Christian Ehrhardt writes: ... > But now even worse than having to have a delta for such a long time it seems > we have to add > openvswitch delta as well. > This is due to the EAL commandline no more being "reachable" via > "ovs-vswitchd [...] --dpdk > [DPDK-EAL-OPTIONS]" by the (otherwise grea

Re: [ovs-dev] Regarding OVS GTP implementation

2016-09-15 Thread Aaron Conole
Ashish Kurian writes: > Dear Developers, > > As Niti instructed me, I tried to locate the openvswitch.ko file in my OVS > directory and could not find it. Can you please help me in identifying why > I cannot locate that file on my OVS directory? You need to configure '--with-linux', and then you

Re: [ovs-dev] [PATCH v2 2/2] utilities: ovs-ctl: Handle start up errors

2016-09-12 Thread Aaron Conole
Markos Chandras writes: > Make sure we take the return values into consideration so we can > break early in case of failures. This makes the ovs-ctl helper more > accurate in reporting the real status of its managing processes. > > Cc: Aaron Conole > Signed-off-by: Markos Chan

Re: [ovs-dev] [PATCH v2 1/2] utilities: ovs-lib: Signal start_daemon failures

2016-09-12 Thread Aaron Conole
Markos Chandras writes: > Make sure we communicate failures to the caller when start_daemon fails > to start a process as the caller may not be able to proceed after this. > > Cc: Aaron Conole > Signed-off-by: Markos Chandras Acked-b

Re: [ovs-dev] [PATCH] utilities: ovs-lib: Signal start_daemon failures

2016-09-09 Thread Aaron Conole
Markos Chandras writes: > Make sure we communicate failures to the caller when start_daemon fails > to start a process as the caller may not be able to proceed after this. > > Signed-off-by: Markos Chandras > --- > utilities/ovs-lib.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

2016-09-08 Thread Aaron Conole
Russell Bryant writes: >> On Wed, Sep 7, 2016 at 11:53 AM, Aaron Conole wrote: >> >> Greetings all, >> >> I'd like to request a backport to branch 2.5 of the following commits: >> >>c416eaf8c247225f0ebeb22b6ca5c473e9

[ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

2016-09-07 Thread Aaron Conole
Greetings all, I'd like to request a backport to branch 2.5 of the following commits: c416eaf8c247225f0ebeb22b6ca5c473e96a53d2 ("ovs-ctl: Remove code for upgrading...") 7fc28c50c0128a0c72853f8f243fd5045bcb9917 ("ovs-ctl: Allow selective start for...") 0cfd47f9dcc3914db8d266ed834d6e2c8fc1a

Re: [ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

2016-09-04 Thread Aaron Conole
Sorry for the top-post and don't want to be a pest - ping? Aaron Conole writes: > Currently, when using Open vSwitch with DPDK and qemu guests, the recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to com

Re: [ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-21 Thread Aaron Conole
"Mooney, Sean K" writes: >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron Conole >> Sent: Saturday, August 20, 2016 12:48 AM >> To: dev@openvswitch.org; Ben Pfaff ; Daniele Di Proietto >> >> Subject

Re: [ovs-dev] [PATCH v4 3/3] netdev-dpdk: Support user-defined socket attribs

2016-08-21 Thread Aaron Conole
"Mooney, Sean K" writes: >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Aaron Conole >> Sent: Saturday, August 20, 2016 12:48 AM >> To: dev@openvswitch.org; Ben Pfaff ; Daniele Di Proietto >> >> Subject:

[ovs-dev] [PATCH v4 3/3] netdev-dpdk: Support user-defined socket attribs

2016-08-19 Thread Aaron Conole
rship, and 'vhost-sock-perms' to set the permissions bits for all vhost_user server sockets. Signed-off-by: Aaron Conole --- v3->v4: * Rebased on upstream, the dev->vhost_id had to move to dev->vhost_server_id INSTALL.DPDK.md | 8 ++

[ovs-dev] [PATCH v4 2/3] chutil: Add hardness amplification versions of chmod/chown

2016-08-19 Thread Aaron Conole
/tsafrir_html/index.html Fallbacks are provided which return ENOTSUP on systems where the POSIX1.2008 function calls for {fchmod,fchown,fstat,readlink,open}at are not available. Signed-off-by: Aaron Conole --- v3->v4: * Complete rewrite using both directory traversal and hardness amplificat

[ovs-dev] [PATCH v4 1/3] chutil: introduce a new change-utils lib

2016-08-19 Thread Aaron Conole
and fchown calls are implemented. Signed-off-by: Aaron Conole Acked-by: Ben Pfaff --- lib/automake.mk | 2 + lib/chutil-unix.c | 348 lib/chutil.h| 32 + lib/daemon-unix.c | 149 +- tests/automake.mk

[ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-19 Thread Aaron Conole
systems. Aaron Conole (3): chutil: introduce a new change-utils lib chutil: Add hardness amplification versions of chmod/chown netdev-dpdk: Support user-defined socket attribs INSTALL.DPDK.md | 8 + configure.ac | 2 +- lib/automake.mk | 2 + lib/chutil-unix.

Re: [ovs-dev] Remote OVS feature discovery

2016-08-15 Thread Aaron Conole
Daniele Di Proietto writes: > 2016-08-15 11:39 GMT-07:00 Mooney, Sean K : > >> >> >> >> >> *From:* Daniele Di Proietto [mailto:diproiet...@ovn.org] >> *Sent:* Monday, August 15, 2016 6:29 PM >> *To:* Mooney, Sean K >> *Cc:* dev@openvswitch.org; Loftus, Ciara >> *Subject:* Re: [ovs-dev] Remote O

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-12 Thread Aaron Conole
Hi Terry, Terry Wilson writes: > On Thu, Aug 11, 2016 at 8:53 PM, Aaron Conole wrote: >> I've been working on a better solution - it occurred to me that since >> this is being done for linux-only anyway, I might as well do this with >> systemd. I can get almost ever

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-11 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Aug 11, 2016 at 01:00:21PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> > Neither of those is a simple "return server->listen_fd;" function. Any >> > chance that would be accepted? It would solve the problem just fine.

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-11 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Aug 11, 2016 at 11:33:59AM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Mon, Aug 01, 2016 at 08:24:40AM -0400, Aaron Conole wrote: >> >> Aaron Conole writes: >> >> >> >> > Cu

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-11 Thread Aaron Conole
Thanks so much for the review, Ben! Wall of text follows (apologies), so I suggest having your breakfast first :) Ben Pfaff writes: > On Mon, Aug 01, 2016 at 08:24:40AM -0400, Aaron Conole wrote: >> Aaron Conole writes: >> >> > Currently, when using Open vSwitch w

Re: [ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

2016-08-10 Thread Aaron Conole
Russell Bryant writes: > On Fri, Jul 22, 2016 at 10:40 AM, Flavio Leitner wrote: > > On Thu, Jul 21, 2016 at 10:18:51AM -0400, Aaron Conole wrote: > > Markos Chandras writes: > > > > > Hi Aaron, > > > > > > On 07/20/2016 10:21 PM, Aaron Co

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add DPDK pdump capability

2016-08-10 Thread Aaron Conole
Ciara Loftus writes: > This commit provides the ability to 'listen' on DPDK ports and save > packets to a pcap file with a DPDK app that uses the librte_pdump > library. One such app is the 'pdump' app that can be found in the DPDK > 'app' directory. Instructions on how to use this can be found i

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

2016-08-10 Thread Aaron Conole
y, >> Sean K >> Sent: Wednesday, July 20, 2016 2:37 PM >> To: Aaron Conole >> Cc: dev@openvswitch.org; Flavio Leitner >> Subject: Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory >> in ovsdb >> >> Hi sorry for the delay >> Replie

Re: [ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-08-01 Thread Aaron Conole
Aaron Conole writes: > Currently, when using Open vSwitch with DPDK and qemu guests, the recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to communicate. When these sockets are > created, they inherit the per

Re: [ovs-dev] [PATCH v2 0/3] redhat: Improve the systemd integration

2016-08-01 Thread Aaron Conole
Aaron Conole writes: > These patches make adjustments to the way systemd is done so that we have: > > * one daemon started per service > * services which correspond to actual daemon names > * a single 'dummy' service to start all at once > * some convenient info

Re: [ovs-dev] [PATCH] rhel: Add support for DPDK Bond

2016-07-26 Thread Aaron Conole
ort", if is a DPDK ring port (name must >start with dpdkr and end with portid, eg "dpdkr0") > > * "OVSDPDKVhostPort" if is a DPDK vhost-cuse port > > * "OVSDPDKVhostUserPort" if is a DPDK vhost-user port > > +* "OVSDP

[ovs-dev] [PATCH v2 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

2016-07-25 Thread Aaron Conole
will start the ovs-vswitchd service as well. A future commit will clean this up, and change the ifup configuration in the process. Signed-off-by: Aaron Conole Reviewed-by: Markos Chandras Acked-by: Flavio Leitner --- v2: * No change (added tags, only) rhel/automake.mk

[ovs-dev] [PATCH v2 0/3] redhat: Improve the systemd integration

2016-07-25 Thread Aaron Conole
Fedora 23 and RHEL-7. v2: * Cleanup ovs-lib.in to be consistent with other tests for Xno * Cleanup cleanup the rhel ovsdb-server service to not reference the vswitchd Aaron Conole (3): utilities/ovs-ctl.in: Allow non-monitoring daemons rhel/ovsdb-server.service: Rename the nonetwork ser

[ovs-dev] [PATCH v2 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-25 Thread Aaron Conole
This commit allows the ovs-ctl command to spawn daemons without the internal process monitor. This is useful when integrating with, ex. systemd, which provides its own monitoring facilities. Signed-off-by: Aaron Conole Reviewed-by: Markos Chandras Acked-by: Ben Pfaff Acked-by: Flavio

[ovs-dev] [PATCH v2 3/3] rhel: Improved Systemd Integration

2016-07-25 Thread Aaron Conole
daemons. Signed-off-by: Aaron Conole Reviewed-by: Markos Chandras --- v2: * Removed reference to ovs-vswitchd service from ovsdb-server service rhel/automake.mk | 1 + rhel/etc_sysconfig_network-scripts_ifup-ovs | 6 +++--- rhel/openvswitch

Re: [ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-25 Thread Aaron Conole
Flaviof writes: > On Wed, Jul 20, 2016 at 4:21 PM, Aaron Conole wrote: > > This commit allows the ovs-ctl command to spawn daemons without the > internal process monitor. This is useful when integrating with, > ex. systemd, which provides its own monitoring facilities. >

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-24 Thread Aaron Conole
Hi Daniele, Daniele Di Proietto writes: > Thanks for the patch. > > I have another concern with this. If we're still going to rely on RCU to > protect the vhost device (and as pointed out by Ilya, I think we should) we > need to use RCU-like semantics on the vid array index. I'm not sure a > bo

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-21 Thread Aaron Conole
Hi Ben, Ben Pfaff writes: > This document has two different kinds of text: > >- The first sections of the document, "Release Strategy" and "Release > Numbering", describe what we've already been doing for most of the > history of Open vSwitch. If there is anything surprising in th

Re: [ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

2016-07-21 Thread Aaron Conole
Markos Chandras writes: > Hi Aaron, > > On 07/20/2016 10:21 PM, Aaron Conole wrote: >> This commit builds upon some of the recent ovs-ctl changes to build a >> more integrated systemd setup. A new service (ovs-vswitchd) is >> added to track the ovs-vswitchd, and ovsdb

[ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

2016-07-20 Thread Aaron Conole
daemons. Signed-off-by: Aaron Conole --- rhel/automake.mk | 1 + rhel/etc_sysconfig_network-scripts_ifup-ovs | 6 +++--- rhel/openvswitch-fedora.spec.in | 3 ++- rhel/usr_lib_systemd_system_openvswitch.service | 6 -- rhel

[ovs-dev] [PATCH 0/3] redhat: Improve the systemd integration

2016-07-20 Thread Aaron Conole
Fedora 23 and RHEL-7. Aaron Conole (3): utilities/ovs-ctl.in: Allow non-monitoring daemons rhel/ovsdb-server.service: Rename the nonetwork service Red Hat Systemd Integration rhel/automake.mk | 3 ++- rhel/etc_sysconfig_network-scripts_ifdown-ovs

[ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-20 Thread Aaron Conole
This commit allows the ovs-ctl command to spawn daemons without the internal process monitor. This is useful when integrating with, ex. systemd, which provides its own monitoring facilities. Signed-off-by: Aaron Conole Acked-by: Ben Pfaff Acked-by: Flavio Leitner --- utilities/ovs-ctl.8 | 5

[ovs-dev] [PATCH 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

2016-07-20 Thread Aaron Conole
will start the ovs-vswitchd service as well. A future commit will clean this up, and change the ifup configuration in the process. Signed-off-by: Aaron Conole Acked-by: Flavio Leitner --- rhel/automake.mk | 2 +- rhel/etc_sysconfig_network-scripts_ifdown

[ovs-dev] [PATCH v3 2/3] lib/chutil: Add chmod and chown for opened files

2016-07-20 Thread Aaron Conole
implementation also resolves some unix domain sockets to their filenames. Signed-off-by: Aaron Conole --- lib/chutil-unix.c | 108 lib/chutil.h| 4 ++ tests/test-chutil.c | 6 +++ 3 files changed, 118 insertions(+) diff --git a/lib

[ovs-dev] [PATCH v3 1/3] chutil: introduce a new change-utils lib

2016-07-20 Thread Aaron Conole
and fchown calls are implemented. Signed-off-by: Aaron Conole Acked-by: Ben Pfaff --- lib/automake.mk | 2 + lib/chutil-unix.c | 347 lib/chutil.h| 32 + lib/daemon-unix.c | 149 +- tests/automake.mk

[ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

2016-07-20 Thread Aaron Conole
for chmod/chown on already opened files. There exist known implementations for other systems, including FreeBSD, but only linux is implemented. ENOTSUP is set when these calls fail on non-linux systems. Aaron Conole (3): chutil: introduce a new change-utils lib lib/chutil: Add chmod and

Re: [ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

2016-07-20 Thread Aaron Conole
Aaron Conole writes: > Currently, when using Open vSwitch with DPDK and qemu guests, the recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to communicate. When these sockets are > created, they inherit the per

[ovs-dev] [PATCH v3 3/3] netdev-dpdk: Support user-defined socket attribs

2016-07-20 Thread Aaron Conole
rship, and 'vhost-sock-perms' to set the permissions bits for the vhost_user sockets. These settings apply to all vhost-user sockets. Signed-off-by: Aaron Conole --- INSTALL.DPDK.md | 7 +++ lib/netdev-dpdk.c| 37 ++--- vswit

Re: [ovs-dev] [ovs-discuss] ovs+dpdk hang?

2016-07-19 Thread Aaron Conole
Apologies for the top post, I believe I might be reproducing this or a similar failure, intermittently. See http://openvswitch.org/pipermail/dev/2016-July/075673.html Thanks, Aaron "Kavanagh, Mark B" writes: >> >>>Hi Mark, >>> >>>I observed the same issue using Ubuntu 16.04 server > with 4.4.0

[ovs-dev] [BUG] netdev-dpdk deadlock in dpdk_watchdog

2016-07-19 Thread Aaron Conole
I haven't fully had a chance to investigate this, but it seems there's a possible deadlock with the dpdk netdev - specifically vhostuser class. I've seen it intermittently with 2.4, 2.5, and now master. It's quite rare to reproduce. Below is a sample stack trace. In it, notice that thread 12 (dp

Re: [ovs-dev] Backport Request for 2.5.0

2016-07-14 Thread Aaron Conole
Ben Pfaff writes: > On Tue, Jul 05, 2016 at 11:39:06AM -0400, Aaron Conole wrote: >> Hello, >> >> I'd like to request for the following 5 commits to be backported to >> 2.5.0, if it's appropriate: >> >> 314ce6479a8380e2aeaa

Re: [ovs-dev] [RFC PATCH 1/1] netdev-dpdk: vHost client mode and reconnect

2016-07-12 Thread Aaron Conole
Ciara Loftus writes: > A new other_config DB option has been added called 'vhost_driver_mode'. > By default this is set to 'server' which is the mode of operation OVS > with DPDK has used up until this point - whereby OVS creates and manages > vHost user sockets. > > If set to 'client', OVS will

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

2016-07-11 Thread Aaron Conole
"Mooney, Sean K" writes: > "Wojciechowicz, RobertX" writes: > >> Hi Ben, >> >> >>> -Original Message- >>> From: Ben Pfaff [mailto:blp at ovn.org] >>> Sent: Tuesday, July 5, 2016 5:07 PM >>> To: Wojciechowicz, RobertX >>> Cc: dev at openvswitch.org >>> Subject: Re: [ovs-dev] [PATCH v2] o

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-07-06 Thread Aaron Conole
Daniele Di Proietto writes: > On 06/07/2016 11:26, "Aaron Conole" wrote: > >>Ansis Atteka writes: >> >>> On Wed, Jul 6, 2016 at 7:24 AM, Aaron Conole wrote: >>>> Aaron Conole writes: >>>> >>>>> Daniele

Re: [ovs-dev] [RFC 3/3] Red Hat Systemd Integration

2016-07-06 Thread Aaron Conole
Flavio Leitner writes: > On Wed, Jul 06, 2016 at 04:28:26PM -0400, Aaron Conole wrote: >> Flavio Leitner writes: >> >> > On Fri, Jul 01, 2016 at 05:26:23PM -0400, Aaron Conole wrote: >> >> +ConditionPathIsReadWrite=/var/run/openvswitch/db.sock >> &g

Re: [ovs-dev] [PATCH] Makefile.am: Add INSTALL.DPDK-ADVANCED.md to EXTRA_DIST.

2016-07-06 Thread Aaron Conole
Daniele Di Proietto writes: > Fixes: c9b9d6dfc06c("INSTALL.DPDK: Refactor DPDK install guide, add > ADVANCED doc") > > Signed-off-by: Daniele Di Proietto > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.am b/Makefile.am > index b2c1126..be42921 100644 > ---

Re: [ovs-dev] [RFC 3/3] Red Hat Systemd Integration

2016-07-06 Thread Aaron Conole
Flavio Leitner writes: > On Fri, Jul 01, 2016 at 05:26:23PM -0400, Aaron Conole wrote: >> This commit builds upon some of the recent ovs-ctl changes to build a >> more integrated systemd setup. A new service (openvswitch-network) is > > I think you renamed to 'ovs

Re: [ovs-dev] [RFC 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-06 Thread Aaron Conole
Ben Pfaff writes: > On Fri, Jul 01, 2016 at 05:26:21PM -0400, Aaron Conole wrote: >> This commit allows the ovs-ctl command to spawn daemons without the >> internal process monitor. This is useful when integrating with, >> ex. systemd, which provides its own monitoring faci

Re: [ovs-dev] [RFC 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-06 Thread Aaron Conole
Flavio Leitner writes: > On Fri, Jul 01, 2016 at 09:32:24PM -0700, Ben Pfaff wrote: >> On Fri, Jul 01, 2016 at 05:26:21PM -0400, Aaron Conole wrote: >> > This commit allows the ovs-ctl command to spawn daemons without the >> > internal process monitor. This is u

Re: [ovs-dev] [RFC 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

2016-07-06 Thread Aaron Conole
Flavio Leitner writes: > On Fri, Jul 01, 2016 at 05:26:22PM -0400, Aaron Conole wrote: >> Currently, openvswitch.service calls out to start >> openvswitch-nonetwork.service. However, openvswitch-nonetwork.service >> is better called ovsdb-server, since that is truly nonet

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-07-06 Thread Aaron Conole
Ansis Atteka writes: > On Wed, Jul 6, 2016 at 7:24 AM, Aaron Conole wrote: >> Aaron Conole writes: >> >>> Daniele Di Proietto writes: >>> >>>> On 10/06/2016 10:51, "Aaron Conole" wrote: >>>> >>>>>Aaron Cono

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Support user-defined socket attribs

2016-07-06 Thread Aaron Conole
Aaron Conole writes: > Daniele Di Proietto writes: > >> On 10/06/2016 10:51, "Aaron Conole" wrote: >> >>>Aaron Conole writes: >>> >>>> Christian Ehrhardt writes: >>>> >>>>> On Tue, May 24, 2016 at 4:10

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

2016-07-06 Thread Aaron Conole
"Wojciechowicz, RobertX" writes: > Hi Ben, > > >> -Original Message- >> From: Ben Pfaff [mailto:b...@ovn.org] >> Sent: Tuesday, July 5, 2016 5:07 PM >> To: Wojciechowicz, RobertX >> Cc: dev@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory >>

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

2016-07-06 Thread Aaron Conole
"Wojciechowicz, RobertX" writes: > Hi Aaron, > >> -Original Message- >> From: Aaron Conole [mailto:acon...@redhat.com] >> Sent: Tuesday, July 5, 2016 4:47 PM >> To: Wojciechowicz, RobertX >> Cc: Ben Pfaff ; dev@openvswitch.org >> S

Re: [ovs-dev] [PATCH 2/2] utilities: ovs-ctl.in: Allow passing DPDK options to ovs-vswitchd

2016-07-05 Thread Aaron Conole
Markos Chandras writes: > On 07/05/2016 03:08 PM, Aaron Conole wrote: >> Markos Chandras writes: >> >>> On 07/02/2016 03:22 AM, Aaron Conole wrote: >>>> Markos Chandras writes: >>>> >>>>> The ovs-ctl script is used to launch ovs

[ovs-dev] Backport Request for 2.5.0

2016-07-05 Thread Aaron Conole
Hello, I'd like to request for the following 5 commits to be backported to 2.5.0, if it's appropriate: 314ce6479a8380e2aeaa53eb5bab96a23c06d62d - ovs-tcpdump: Add a tcpdump wrapper utility 8647686ee8ac496b54499d14f3c37de84fdd47df - fedora: Add pcap, tcpd

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

2016-07-05 Thread Aaron Conole
Hi Robert, "Wojciechowicz, RobertX" writes: > Hi, > >> -Original Message- >> From: Ben Pfaff [mailto:b...@ovn.org] >> Sent: Saturday, July 2, 2016 2:49 AM >> To: Wojciechowicz, RobertX >> Cc: dev@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket direct

Re: [ovs-dev] [PATCH 2/2] utilities: ovs-ctl.in: Allow passing DPDK options to ovs-vswitchd

2016-07-05 Thread Aaron Conole
Markos Chandras writes: > On 07/02/2016 03:22 AM, Aaron Conole wrote: >> Markos Chandras writes: >> >>> The ovs-ctl script is used to launch ovs-vswitchd among other things. >>> However it does not make it possible to pass DPDK options to the >>> dae

Re: [ovs-dev] [RFC PATCH 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-05 Thread Aaron Conole
use the stats id to do the actual stats processing? If thing it's worthwhile, I would gladly donate some code to the cause :-) Otherwise it looks good. Thanks for posting it ahead of the DPDK release, so we can evaluate it! Reviewed-by: Aaron Conole -Aaron ___

Re: [ovs-dev] [PATCH 1/2] utilities: ovs-ctl: Drop duplicate line

2016-07-01 Thread Aaron Conole
Markos Chandras writes: > The --ovs-vswitchd-wrapper=WRAPPER line is referenced twice so drop it. > > Signed-off-by: Markos Chandras > --- > utilities/ovs-ctl.in | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in > index b2a97fc..8ec825b 100755 >

Re: [ovs-dev] [PATCH 2/2] utilities: ovs-ctl.in: Allow passing DPDK options to ovs-vswitchd

2016-07-01 Thread Aaron Conole
Markos Chandras writes: > The ovs-ctl script is used to launch ovs-vswitchd among other things. > However it does not make it possible to pass DPDK options to the > daemon. We fix this by explicitly looking and extracting the DPDK > options from the command line which is then reconstructed so it

[ovs-dev] [RFC 3/3] Red Hat Systemd Integration

2016-07-01 Thread Aaron Conole
initialize the daemons. Signed-off-by: Aaron Conole --- rhel/automake.mk | 1 + rhel/openvswitch-fedora.spec.in | 3 ++- rhel/usr_lib_systemd_system_openvswitch.service | 5 +++-- rhel/usr_lib_systemd_system_ovs-vswitchd.service | 21

[ovs-dev] [RFC 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

2016-07-01 Thread Aaron Conole
-vswitchd service as well. A future commit will clean this up. Signed-off-by: Aaron Conole --- rhel/automake.mk | 2 +- rhel/etc_sysconfig_network-scripts_ifdown-ovs | 14 +++--- rhel/etc_sysconfig_network-scripts_ifup-ovs | 14

[ovs-dev] [RFC 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-01 Thread Aaron Conole
This commit allows the ovs-ctl command to spawn daemons without the internal process monitor. This is useful when integrating with, ex. systemd, which provides its own monitoring facilities. Signed-off-by: Aaron Conole --- utilities/ovs-ctl.8 | 5 + utilities/ovs-ctl.in | 1 + utilities

[ovs-dev] [RFC 0/3] redhat: Improve the systemd integration

2016-07-01 Thread Aaron Conole
a bit, but I'm not submitting them as PATCH until I've had wider feedback. Aaron Conole (3): utilities/ovs-ctl.in: Allow non-monitoring daemons rhel/ovsdb-server.service: Rename the nonetwork service Red Hat Systemd Integration rhel/automake.mk

  1   2   3   4   >