On Fri, Aug 12, 2016 at 1:06 PM, Ben Pfaff wrote:
> On Thu, Aug 11, 2016 at 05:20:34PM -0700, Jesse Gross wrote:
>> Currently metadata transmitted by OVN over Geneve tunnels is
>> unprotected by any checksum other than the one provided by the link
>> layer - this includes both the VNI and data sto
On Thu, Aug 11, 2016 at 7:10 PM, Ryan Moats wrote:
> "dev" wrote on 08/11/2016 07:20:34 PM:
>
>> From: Jesse Gross
>> To: dev@openvswitch.org
>> Date: 08/11/2016 07:22 PM
>> Subject: [ovs-dev] [PATCH rebase 3/3] ovn-controller: Use UDP
>> checksums when creating Geneve tunnels.
>> Sent by: "dev"
On Fri, Aug 12, 2016 at 12:57 PM, Ben Pfaff wrote:
> On Thu, Aug 11, 2016 at 05:20:33PM -0700, Jesse Gross wrote:
>> Originally, processing of encapsulations simply iterated over all tables on
>> every wakeup and would replace anything that changed. This is somewhat
>> inefficient but it captured
On Thu, Aug 04, 2016 at 05:55:34PM +, Ryan Moats wrote:
> ovs-dpctl and ovs-ofctl lack a dry-run option. Add it
> and the necessary scaffolding to each.
>
> Signed-off-by: Ryan Moats
The point behind a --dry-run option is supposed to be that it does
everything up to but not actually includi
On Sat, Aug 06, 2016 at 04:44:13PM -0500, Ryan Moats wrote:
> "dev" wrote on 08/04/2016 06:50:03 AM:
>
> > From: nickcooper-zhangtonghao
> > To: dev@openvswitch.org
> > Cc: nickcooper-zhangtonghao
> > Date: 08/04/2016 06:50 AM
> > Subject: [ovs-dev] [PATCH] ovn-controller:improve the ofctrl_run
On Thu, Aug 04, 2016 at 04:50:03AM -0700, nickcooper-zhangtonghao wrote:
> Before calling the function "ofctrl_run" and "pinctrl_run",
> the "br-int"" has been checked. Remove the conditional statements in
> the function may make the code clearer.
>
> Signed-off-by: nickcooper-zhangtonghao
>
Ap
On Wed, Aug 03, 2016 at 04:57:05PM -0700, Andy Zhou wrote:
> When ovsdb-sever is running in the backup state, it would be nice to
> make sure there is no un-intended changes to the backup database.
>
> This patch makes the ovsdb server only accepts 'read' transactions as
> a backup server. When th
On Wed, Aug 03, 2016 at 04:57:04PM -0700, Andy Zhou wrote:
> Found by inspection
>
> Signed-off-by: Andy Zhou
It's not obvious from the context that this can cause a problem, but I
think it's safe in any case.
Acked-by: Ben Pfaff
___
dev mailing list
On Wed, Aug 03, 2016 at 04:57:03PM -0700, Andy Zhou wrote:
> Pollblock requires the run() function to be paired with a wait()
poll_block(), I guess.
> function. Add one for replication.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailin
On Wed, Aug 03, 2016 at 04:57:02PM -0700, Andy Zhou wrote:
> Current replication code refers the other ovsdb-sever instance as
> a 'remote'. which is overloaded in ovsdb.
>
> Switching to use active/backup instead to make it less confusing.
> Active is the server that should be servicing the clien
On Wed, Aug 03, 2016 at 07:07:38PM +, Ryan Moats wrote:
> When setting a where clause, if the timeout is set to a value of 0,
> the clause is tested once and if it fails, a message of '"wait" timed
> out' is returned. This can be misleading because there wasn't any
> real time, so change the m
On Fri, Jul 29, 2016 at 05:28:26PM +, Mickey Spiegel wrote:
> Could you expand on why priorities in a single stage aren't enough to
> satisfy the use case?
>
>
> If two features are configured independently with a mix of
> prioritized allow and drop rules, then with a single stage, a
> new se
On Tue, Aug 09, 2016 at 09:14:15AM +0300, Liran Schour wrote:
> Do we plan to include the ovn conditional monitoring usage in 2.6.0?
> Performance evaluation shows up to 75% reduction of computation at the
> ovn-controller and also a reduction of computation at the server side,
> depending at the
The conditional replication code had hardly any comments. This adds some.
This commit also fixes a number of style problems, factors out some code
into a helper function, and moves some struct declarations from a public
header, that were not used by client code, into more private locations.
Sign
On Tue, Aug 02, 2016 at 04:38:00PM +0300, Liran Schour wrote:
> Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group
> MAC_Binding tables. As a result ovn-controller will be notified only about
> records belongs to a datapath that is being served by this hypervisor.
>
> Performance
On Sun, Aug 14, 2016 at 08:58:31AM +0900, Nam Bong Ha wrote:
> Has the tuple space search been used from the early version?
Yes.
> In several thesis I read, it says they do linear search.
>
> Isn't there any openswitch version that uses linear search?
No.
What theses are you reading?
_
On 12 August 2016 at 12:28, Chandra S Vejendla wrote:
> In cases where a DNAT IP is moved to a new router or the SNAT IP is reused
> with a new mac address, the NAT IPs become unreachable because the external
> switches/routers have stale ARP entries. This commit
> aims to fix the problem by send
Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call
ovs_list_remove() on the clause's 'node' member, but it should only be
called once.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 7d3d328..7
The function always allocated a clause but didn't use it if it was
going to be a duplicate.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index ad0d1e1..7d3d328 100644
--- a/lib/ovsdb-idl.c
+++ b
Has the tuple space search been used from the early version?
In several thesis I read, it says they do linear search.
Isn't there any openswitch version that uses linear search?
Thank you
2016. 8. 13. 오전 1:49에 "Ben Pfaff" 님이 작성:
> On Fri, Aug 12, 2016 at 08:40:12PM +0900, Nam Bong Ha wrote:
>
On 12 August 2016 at 15:48, Joe Stringer wrote:
> On 11 August 2016 at 23:34, Gurucharan Shetty wrote:
> > The schema prevented one from setting more than one load balancer
> > to a switch. This removes that anamoly.
> >
> > Signed-off-by: Gurucharan Shetty
>
> The system tests part looks good
On 12 August 2016 at 15:46, Joe Stringer wrote:
> On 12 August 2016 at 02:48, Gurucharan Shetty wrote:
> > The client and servers are in the same subnet.
> >
> > (This would not have worked without the recent
> > IPv6 patches that let packets to loop back)
> >
> > Signed-off-by: Gurucharan Shett
Message could not be delivered
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 02, 2016 at 04:37:59PM +0300, Liran Schour wrote:
> Call for poll_immediate_wake() when condition is changed.
>
> Signed-off-by: Liran Schour
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/
Hmm. I'm truly puzzled. I run the tests on i686 all the time and don't
get any consistent failures. Is there anything unusual about your
setup, or anything that might assist me in reproducing it?
We have checked in a few other commits more recently than the commit
0a0f39d that you tested that s
On Fri, Aug 12, 2016 at 12:21:28PM +0530, bscha...@redhat.com wrote:
> From: Babu Shanmugam
>
> ovn-northd sets 'ip.dscp' to the DSCP value
>
> Signed-off-by: Babu Shanmugam
Thanks for the revision (and for adding a test)!
This comment in ovn-northd seems like an incomplete thought (and what'
On Fri, Aug 12, 2016 at 12:21:27PM +0530, bscha...@redhat.com wrote:
> From: Babu Shanmugam
>
> ovn-northd processes the list of Port_Bindings and hashes the list of
> queues per chassis. When it finds a port with qos_parameters and without
> a queue_id, it allocates a free queue for the chassis
> On Aug 13, 2016, at 9:29 AM, Ben Pfaff wrote:
>
>> On Fri, Aug 12, 2016 at 04:30:01PM -0700, Justin Pettit wrote:
>>
>>> On Aug 8, 2016, at 11:21 AM, Ben Pfaff wrote:
>>>
>>> This makes it more convenient to access a 128-bit value stored in an
>>> mf_subvalue.
>>>
>>> Signed-off-by: Ben Pf
On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote:
> Upstream commit:
> commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca
> Author: Martynas Pumputis
> Date: Tue Aug 9 16:24:50 2016 +0100
>
> openvswitch: do not ignore netdev errors when creating tunnel vports
>
> The cr
On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote:
> Upstream commit:
> commit 5ef9f289c4e698054e5687edb54f0da3cdc9173a
> Author: Ian Wienand
> Date: Wed Aug 3 15:44:57 2016 +1000
>
> OVS: Ignore negative headroom value
>
> net_device->ndo_set_rx_headroom (introduced i
The actions and expr modules had each developed their own error handling
code that were very similar. Upcoming code needs similar error handling,
so rather than duplicating it again, integrate it into the lexer itself.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
include/ovn/actions.h |
This new utility is intended to fulfill for OVN the purpose that
"ofproto/trace" has for Open vSwitch. First, it's meant to be a useful
tool for troubleshooting and diagnosis and in general for improving one's
understanding of the emergent properties of a flow table. Second, it
simplifies and inc
This allows "ovstest test-ovn evaluate-expr" work with arbitrary
microflows rather than just a few restricted variables, but the main point
is to enable the upcoming "ovn-trace" utility to accept arbitrary
microflows in a format that seems reasonable for OVN.
Signed-off-by: Ben Pfaff
Acked-by: Ry
An upcoming commit will need to evaluate individual expressions outside the
context of a classifier. test-ovn already had a function to do this but it
wasn't general-purpose, so this commit makes a general-purpose version and
adopts it for use in test-ovn as well.
Signed-off-by: Ben Pfaff
Acked-
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
ovn/controller-vtep/ovn-controller-vtep.c | 5 +++--
ovn/lib/ovn-util.c| 27 +
ovn/lib/ovn-util.h| 4
ovn/northd/ovn-northd.c | 27 --
This makes it easier to debug based on the southbound database without
looking at the northbound representation. This commit adds the name
to "ovn-sbctl dump-flows" output and it will be even more useful in
an upcoming commit.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
ovn/northd/ovn-no
The exciting part is the final commit. I recommend reading the
documentation for the new program.
Also available at https://github.com/blp/ovs-reviews/tree/ovnacts
v1->v2: First 9 commits applied. Rebased.
v2->v3: First 12 commits applied. Fixed bad %-specifier in patch 2.
v3->v4: First commit
The function nxm_execute_reg_move() was almost a general-purpose function
for manipulating subfields, except for its awkward interface that took a
struct ofpact_reg_move instead of a plain source and destination. This
commit introduces a general-purpose function in meta-flow that corrects
this fla
On Fri, Aug 12, 2016 at 04:30:01PM -0700, Justin Pettit wrote:
>
> > On Aug 8, 2016, at 11:21 AM, Ben Pfaff wrote:
> >
> > This makes it more convenient to access a 128-bit value stored in an
> > mf_subvalue.
> >
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin Pettit
Thanks, I applied thi
No problem, stuff happens.
On Fri, Aug 12, 2016 at 05:58:51PM -0700, Daniele Di Proietto wrote:
> I just applied the same fix, sorry for breaking it
>
> Daniele
>
> 2016-08-12 17:52 GMT-07:00 Ben Pfaff :
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/dpif-netdev.c | 2 +-
> > 1 file changed,
On Sat, Jul 30, 2016 at 03:32:01PM +0530, Numan Siddique wrote:
> This patch reads the 'Bridge.datapath_type' column value of the integration
> bridge and 'Open_vSwitch.iface_types' column value and sets these in the
> external_ids:datapath-type and external_ids:iface-types of Chassis table.
>
> T
On Fri, Aug 12, 2016 at 1:33 AM, Russell Bryant wrote:
>
> On Tue, Aug 9, 2016 at 11:55 PM, Zong Kai LI wrote:
>>
>> This patch renames table Address_Set to Set, Address_Set.addresses to
>> Set.members to reflect a more broad purpose, that we can define other
>> types
>> of sets than address set.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The original message was included as attachment
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
44 matches
Mail list logo
