On Wed, Aug 03, 2016 at 04:57:05PM -0700, Andy Zhou wrote:
> When ovsdb-sever is running in the backup state, it would be nice to
> make sure there is no un-intended changes to the backup database.
> 
> This patch makes the ovsdb server only accepts 'read' transactions as
> a backup server. When the server role is changed into an active server,
> all existing client connections will be reset. After reconnect, all
> clinet transactions will then be accepted.
> 
> Signed-off-by: Andy Zhou <az...@ovn.org>

It's a little odd to add a manpage .so-include if only one manpage
.so-includes it.  Is it likely that other manpages will include it
later?

s/execept/except/ in the manpage.

In jsonrpc_create_readonly_lock_error(), the error string is a little
garbled, s/methodsno/methods not/.

GCC 4.9.1 complains:

../ovsdb/execution.c: In function 'ovsdb_execute':
../ovsdb/execution.c:172:33: error: 'ro' may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
         if (!error && read_only && !ro) {
                                 ^
../ovsdb/execution.c:173:19: error: 'op_name' may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
             error = ovsdb_error("not allowed",
                   ^
cc1: all warnings being treated as errors

If you fix those things then:
Acked-by: Ben Pfaff <b...@ovn.org>

Thanks!

Ben
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to