On Fri, Aug 12, 2016 at 1:33 AM, Russell Bryant <russ...@ovn.org> wrote: > > On Tue, Aug 9, 2016 at 11:55 PM, Zong Kai LI <zealo...@gmail.com> wrote: >> >> This patch renames table Address_Set to Set, Address_Set.addresses to >> Set.members to reflect a more broad purpose, that we can define other >> types >> of sets than address set. >> >> Per discussion around [1] and [2], this patch only does rename work on >> table >> Address_Set, and consider put future purpose on using table Set, to create >> port set which will be used to improve and skinny ACLs, in following >> pacthes. >> >> Since it only renames table Address_Set, and up to now, only address set >> get >> supported, so this patch doesn't rename variables and methods which used >> for >> address set, such as [3]. >> >> [1] http://openvswitch.org/pipermail/dev/2016-August/077121.html >> [2] http://openvswitch.org/pipermail/dev/2016-August/077224.html >> [3] >> >> https://github.com/openvswitch/ovs/blob/master/ovn/controller/lflow.c#L41-L42 >> >> https://github.com/openvswitch/ovs/blob/master/ovn/controller/lflow.c#L62-L205 >> >> Signed-off-by: Zong Kai LI <zealo...@gmail.com> >> --- > > > I brought this patch up for discussion in today's OVN IRC meeting. Ben > raised a good point: > > <blp> russellb: I have questions whether port sets and address sets are > really the same kind of beast though. For port sets, possibly we want to > manage them via references to rows as opposed to sets of strings. > > I think that's a great point, so let's just defer the rename and we'll go > through deciding on a final approach for this after 2.6. > > -- > Russell Bryant
Hi, Russell, thanks for your help on this patch. But I think it gets a little strange that we try to manage ports set via references to rows, don't we have Logical_Switch.ports to do that? And that idea seems will not directly work with ACL, for ACL is using port name, not port refer, and ACL with port refer in match seems not so friendly to user to insert. I think we can try to support multiple variable types in Set, port names set or port refers set can be both supported. And to a port set has port reference in it, I'm not sure whether it's really useful, since a port is usually belongs to a switch or a router. I don't see a scenario that uses port refer set yet. And sure, it's acceptable for me to defer it. Thanks. Zongkai, LI _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
