On 03.02.2016 03:32, Joe Stringer wrote:
> On 29 January 2016 at 04:03, Ilya Maximets wrote:
>> Hi.
>>
>> On 29.01.2016 04:02, Daniele Di Proietto wrote:
>>> Hi guys,
>>>
>>> Sorry for resurrecting this thread, but I think we should reconsider
>>> this patch at this point.
>>>
>>> Let me explain:
On Tue, Feb 2, 2016 at 9:14 PM, Daniele Di Proietto
wrote:
> The 'key' pointer must point at the first unused element in the key
> array.
>
> Fixes: b89c678b7a26 ("dpif-netdev: optmizing emc_processing()")
> CC: Andy Zhou
> Signed-off-by: Daniele Di Proietto
>
Sorry about this. Acked-by: Andy
The 'key' pointer must point at the first unused element in the key
array.
Fixes: b89c678b7a26 ("dpif-netdev: optmizing emc_processing()")
CC: Andy Zhou
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netd
On 02/02/2016 10:39, "Jarno Rajahalme" wrote:
>With the small nits below:
>
>Acked-by: Jarno Rajahalme
Thanks Jarno and Ilya for the reviews!
I applied this on master and branch-2.5
>
>> On Jan 26, 2016, at 9:13 PM, Daniele Di Proietto
>> wrote:
>>
>> It is ok to iterate a cmap with CMAP_F
Commit d916785ce98c("dpif-netdev: Fix improper use of CMAP_FOR_EACH.")
fixes a problem that's worth documenting.
Requested-by: Jarno Rajahalme
Signed-off-by: Daniele Di Proietto
---
lib/cmap.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/cmap.h b/lib/cmap.h
index c653424..c7c65a
> On Feb 2, 2016, at 6:13 PM, Ben Pfaff wrote:
>
> The update_port() function called in ofproto_port_add() can encounter
> errors that prevent a port from being added, but nothing was checking for
> the error and in fact update_port() didn't even pass the error along to
> its caller. This commi
Thanks!
I added your ack and pushed this to master and branch-2.5
On 02/02/2016 04:52, "Chandran, Sugesh" wrote:
>Hi Daniele,
>I feel this approach is fine to go ahead. At least it looks to me more
>readable than the earlier one.
>Once again thank you for sending out the patch.
>
>Acked!
>
>Reg
The update_port() function called in ofproto_port_add() can encounter
errors that prevent a port from being added, but nothing was checking for
the error and in fact update_port() didn't even pass the error along to
its caller. This commit fixes the problem.
The scenario that led me to examine th
This check prevents an obvious way for a vhost-user socket to escape the
intended directory.
There might be other ways to escape the directory (none comes to mind at
the moment), but this is a problem that should be properly solved by
mandatory access control.
A similar check is done for a bridge
If ovs-vswitchd crashes, it will not be able to recreate the same
vhost user ports, since the socket will still be in the file system.
This commit introduces an unlink() before creation to remove an eventual
preexisting vhost user socket.
This mimics the behavior of the OpenFlow management socket
This effectively stops vswitchd from creating bridges with '/' in the
name. OVS used to print a warning but the bridge was created anyway.
This restriction is implemented because the bridge name is part of a
filesystem path.
This check is no substitute for Mandatory Access Control, but it
certain
On Tue, Feb 2, 2016 at 4:41 PM, Han Zhou wrote:
>
>
> On Tue, Feb 2, 2016 at 2:01 PM, Russell Bryant wrote:
> >
> > On 02/02/2016 04:49 PM, Ben Pfaff wrote:
> > > On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
> > >> Previously, ovn-controller translated logical flows into OpenF
Hi Jesse,
Exactly as you said, the newest version works well, and the mpls label could be
push and pop. Thanks for your answer.
Best,
Yali
-邮件原件-
发件人: Jesse Gross [mailto:je...@kernel.org]
发送时间: 2016年2月3日 7:24
收件人: zhangyali (D)
抄送: dev@openvswitch.org
主题: Re: [ovs-dev] [ovs discussion
On Mon, Feb 1, 2016 at 8:05 AM, Simon Horman wrote:
> On Tue, Jan 26, 2016 at 10:09:28PM -0800, Jesse Gross wrote:
>> On Tue, Jan 19, 2016 at 10:15 PM, Simon Horman
>> wrote:
>> > Add support for layer 3 GRE vports (non-tap aka non-VTEP).
>> >
>> > This makes use of a separate vport type for GRE,
On Tue, Feb 2, 2016 at 2:01 PM, Russell Bryant wrote:
>
> On 02/02/2016 04:49 PM, Ben Pfaff wrote:
> > On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
> >> Previously, ovn-controller translated logical flows into OpenFlow flows
> >> for *every* logical datapath. This patch makes i
On 29 January 2016 at 04:03, Ilya Maximets wrote:
> Hi.
>
> On 29.01.2016 04:02, Daniele Di Proietto wrote:
>> Hi guys,
>>
>> Sorry for resurrecting this thread, but I think we should reconsider
>> this patch at this point.
>>
>> Let me explain: I'm still perfectly happy with the fix we applied,
>
Is there any reason the ovsdb-client tool modification is dropped from v2
to v3? I find it difficult to properly
review and test the changes without it. Do you mind repost this series that
includes the modification?
Thanks for includes IDL tests in series. It would be also nice to have more
tests
Nithin do we still need this patch?
I am happy to drop it otherwise.
Alin.
> -Mesaj original-
> De la: Ben Pfaff [mailto:b...@ovn.org]
> Trimis: Wednesday, February 3, 2016 12:25 AM
> Către: Alin Serdean
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] Update windows datapath
On Mon, Feb 1, 2016 at 8:02 PM, zhangyali (D) wrote:
> Hi all,
>
> I have noticed that OVS support multiple tunneling protocols, such as, GRE,
> VXLAN, etc. I am not sure if the MPLS has been also supported now (could not
> find it ...). Since the openflow protocol has support the corresponding
Commit 792e5ed750ce ("datapath: inet: frag: Always orphan skbs inside
ip_defrag().") broke the build for OVS backport against kernel-4.3. Fix
the build.
Signed-off-by: Joe Stringer
---
v2: First post.
---
datapath/linux/compat/include/net/ip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
Typically the way that we include backported code is by testing for
existence of the feature in the upstream codebase via header checks,
then attempt to use the upstream code as much as possible. However, for
the IP fragmentation handling backport we have an additional constraint
which is that we c
This series makes the IP fragmentation backport detection more robust in the
face of different linux distributions backporting various patches to older
kernels.
Most of the patches from v1 of this series were applied. However, there were a
few additional issues also discovered during v1, so this v
Remove v4.2 as it is EOL; Add v4.3 as we support this version in
OVS-2.5. Update other versions to the latest listed on kernel.org.
Signed-off-by: Joe Stringer
---
v2: Updated to the latest versions.
---
.travis.yml | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --g
Previously a version check was used to determine whether the upstream
ip_fragment() should be used or the backported version. The actual test
is for whether upstream commit d6b915e29f4a ("ip_fragment: don't forward
defragmented DF packet") is present, so test for that instead.
Signed-off-by: Joe S
These should not have the same name as the upstream ones, to reduce
confusion when they are created. Rename them.
Suggested-by: Pravin B Shelar
Signed-off-by: Joe Stringer
---
v2: First post.
---
datapath/linux/compat/ip_fragment.c| 2 +-
datapath/linux/compat/nf_conntrack_reasm.c | 2 +
Kernels 3.17 to 4.2 have a work queue to evict old fragments, but do not
track these fragments in an eviction list. On these kernels, we detect
the absence of the list_evictor and provide one. This commit fixes the
reliance on kernel versions in the case that this functionality is
backported.
Sign
On Tue, Feb 2, 2016 at 4:31 PM, Russell Bryant wrote:
> On 02/02/2016 05:21 PM, Ben Pfaff wrote:
>> On Tue, Feb 02, 2016 at 05:01:35PM -0500, Russell Bryant wrote:
>>> On 02/02/2016 04:49 PM, Ben Pfaff wrote:
On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
> Previously, ov
On 29 January 2016 at 15:54, pravin shelar wrote:
> On Mon, Jan 11, 2016 at 5:53 PM, Joe Stringer wrote:
>> Broadly, for the conntrack and ip_fragment backport in the OVS tree, we have
>> until now depended on a macro to include the entire backport based on kernel
>> version. Any kernel that the
Update these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/vlog.at | 174 +-
1 file changed, 99 insertions(+), 75 deletions(-)
diff --git a/tests/vlog.at b/tests/vlog.at
index 7c1b445..c2e2caa 100644
Also update the Python ovs package info to note that both Python 2 and 3
are supported.
Signed-off-by: Russell Bryant
---
NEWS| 3 +++
python/setup.py | 6 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index e683dae..46600c8 100644
--- a/NEWS
+++ b/
Update these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/unixctl-py.at | 198 +---
1 file changed, 111 insertions(+), 87 deletions(-)
diff --git a/tests/unixctl-py.at b/tests/unixctl-py.at
index 9ba7023..0
Update these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/daemon-py.at | 483 -
1 file changed, 260 insertions(+), 223 deletions(-)
diff --git a/tests/daemon-py.at b/tests/daemon-py.at
index cafa8df..e5
Convert these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/jsonrpc-py.at | 79 +++--
1 file changed, 47 insertions(+), 32 deletions(-)
diff --git a/tests/jsonrpc-py.at b/tests/jsonrpc-py.at
index 3d3bd3b..9
Update Python tests to run for both Python 2 and Python 3.
Signed-off-by: Russell Bryant
---
tests/ovsdb-idl.at | 56 ++
1 file changed, 40 insertions(+), 16 deletions(-)
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at
index ebf82a5..33d5
Update Python tests to run for both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/library.at | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/tests/library.at b/tests/library.at
index d5dcb12..11a405b 100644
--- a/tests/library.at
Run json.at tests for both Python 2 and 3 if available.
Signed-off-by: Russell Bryant
---
tests/json.at | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/tests/json.at b/tests/json.at
index 8846ac9..a4c40c8 100644
--- a/tests/json.at
+++ b/tests/json.at
@
Update the reconnect tests to use both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/reconnect.at | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/reconnect.at b/tests/reconnect.at
index 9ebe183..c88ca78 100644
--- a/tests/reconnect.at
+++ b/tests/reconn
ovsdb.at includes some macros for running some identical test cases for
both C and Python. Update these macros to run the test case for both
Python 2 and 3. Retain the existing behavior for the direct use of the
_PY versions of these macros to only run against Python 2 without any
changes needed.
The only Python 3 errors here were the use of print. The rest of the
changes make it so we can check this file with flake8.
Signed-off-by: Russell Bryant
---
Makefile.am | 2 +-
build-aux/check-structs | 30 --
2 files changed, 25 insertions(+), 7 deleti
This test checks the output based on Python's string representation of
an array of two unicode strings. These strings have a "u" prefix in
Python 2, but not Python 3. In Python 3, all strings are unicode.
Use sed on the output to strip the "u" from Python 2 output when
checking for the expected
Update the tests in check-structs.at to run with both Python 2 and 3 if
available. The check-structs script is written in Python, though does
not use the ovs Python library. The script did require fixes in a
previous commit to make it Python 3 compatible, so this ensures that
compatibility remain
The configure script already checked for Python 2 (>=2.7). Add another
check for Python 3 (>=3.4). This will be used later for automatically
running tests with Python 3 as well if available.
Signed-off-by: Russell Bryant
---
configure.ac | 1 +
m4/openvswitch.m4 | 42
This is this final series for Python 3 support. It refactors the test suite to
run Python tests against both Python 2 and 3.
Russell Bryant (14):
tests: Deal with Python output differences.
configure: Check for presence of Python 3.
check-structs: Make Python 3 compatible.
check-structs.a
On Tue, Feb 02, 2016 at 05:31:42PM -0500, Russell Bryant wrote:
> On 02/02/2016 05:21 PM, Ben Pfaff wrote:
> > On Tue, Feb 02, 2016 at 05:01:35PM -0500, Russell Bryant wrote:
> >> On 02/02/2016 04:49 PM, Ben Pfaff wrote:
> >>> On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
> P
On 02/02/2016 05:21 PM, Ben Pfaff wrote:
> On Tue, Feb 02, 2016 at 05:01:35PM -0500, Russell Bryant wrote:
>> On 02/02/2016 04:49 PM, Ben Pfaff wrote:
>>> On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
Previously, ovn-controller translated logical flows into OpenFlow flows
>>>
On 02/02/2016 05:23 PM, Ben Pfaff wrote:
> On Tue, Feb 02, 2016 at 04:03:41PM -0600, Ryan Moats wrote:
>> I'm trying to wrap my head around how the flood fill would improve things
>> when I have lots of instances attached to a single network...
>
> If all your hypervisors really use all your logic
On 29 January 2016 at 15:44, pravin shelar wrote:
> On Mon, Jan 11, 2016 at 5:53 PM, Joe Stringer wrote:
>> This function is a likely candidate for backporting, and currently
>> relies on version checks to include the source or not. Grep for the
>> appropriate functions instead, and include the b
On 29 January 2016 at 15:09, pravin shelar wrote:
> On Mon, Jan 11, 2016 at 5:53 PM, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>> ---
>> acinclude.m4 | 2 ++
>> datapath/compat.h| 5 +
>> datapath/linux/c
On Wed, Dec 02, 2015 at 08:54:21PM +, Alin Serdean wrote:
> Currently when building the windows datapath from the command line we specify
> the type (Release or Debug), which will build both versions (Win 8 and Win
> 8.1)
> of that type. This made a strict requirement of WDK 8.1.
>
> This pat
On Tue, Feb 02, 2016 at 04:03:41PM -0600, Ryan Moats wrote:
> I'm trying to wrap my head around how the flood fill would improve things
> when I have lots of instances attached to a single network...
If all your hypervisors really use all your logical switches and logical
routers, it won't help.
_
On Tue, Feb 02, 2016 at 05:01:35PM -0500, Russell Bryant wrote:
> On 02/02/2016 04:49 PM, Ben Pfaff wrote:
> > On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
> >> Previously, ovn-controller translated logical flows into OpenFlow flows
> >> for *every* logical datapath. This patch
On Mon, Jan 25, 2016 at 05:02:03PM -0500, Russell Bryant wrote:
> Previously, all ct() actions applied to localnet ports used the default
> conntrack zone. We should allocate a ct zone ID for all localnet ports
> just like we do for all local VIFs so that none of our connection
> tracking interfer
On Mon, Jan 25, 2016 at 05:02:01PM -0500, Russell Bryant wrote:
> Before this patch, physical.c build up the set of local datapaths for
> its own use. I'd like to use it in another module in a later patch, so
> pull it out of physical. It's now populated by the bindings module,
> since that seems
On Mon, Jan 25, 2016 at 05:02:02PM -0500, Russell Bryant wrote:
> Multiple logical ports on the same chassis that were connected to the
> same physical network via localnet ports were not able to send packets
> to each other. This was because ovn-controller created a single patch
> port between br
On Tue, Feb 02, 2016 at 02:15:29PM -0800, Ben Pfaff wrote:
> On Thu, Jan 21, 2016 at 04:11:50PM -0500, Russell Bryant wrote:
> > Multiple logical ports on the same chassis that were connected to the
> > same physical network via localnet ports were not able to send packets
> > to each other. This
On Thu, Jan 21, 2016 at 04:11:50PM -0500, Russell Bryant wrote:
> Multiple logical ports on the same chassis that were connected to the
> same physical network via localnet ports were not able to send packets
> to each other. This was because ovn-controller created a single patch
> port between br
On Thu, Jan 21, 2016 at 04:11:49PM -0500, Russell Bryant wrote:
> Before this patch, physical.c build up the set of local datapaths for
> its own use. I'd like to use it in another module in a later patch, so
> pull it out of physical. It's now populated by the bindings module,
> since that seems
Sorry for the partial repeat, but my previous reply bounced off of dev and
then I realized that I hit send too soon...
That's why I said a patch set series - this patch was based on top of
another patch. Applying this patch by itself results in the compile error
you are seeing...
I'm trying to w
On 02/02/2016 04:34 PM, Russell Bryant wrote:
> On 02/02/2016 04:24 PM, Ben Pfaff wrote:
>> On Fri, Jan 22, 2016 at 09:32:33PM -0500, Russell Bryant wrote:
>>> Python 3 has separate types for strings and bytes. Python 2 used the
>>> same type for both. We need to convert strings to bytes before w
On 02/02/2016 04:49 PM, Ben Pfaff wrote:
> On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
>> Previously, ovn-controller translated logical flows into OpenFlow flows
>> for *every* logical datapath. This patch makes it so we skip doing so
>> for the egress pipeline if the datapath
I see that now that I'm reviewing the prerequisite patch.
On Tue, Feb 02, 2016 at 09:55:15PM +, Ryan Moats wrote:
> That's why I said a patch set series - this patch was based on top of another
> patch. Applying this patch by itself results in the compile error you are
> seeing...
>
> Ryan
On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote:
> Previously, ovn-controller translated logical flows into OpenFlow flows
> for *every* logical datapath. This patch makes it so we skip doing so
> for the egress pipeline if the datapath is a logical switch with no
> logical ports bo
On 02/02/2016 04:30 PM, Ben Pfaff wrote:
> On Fri, Jan 22, 2016 at 02:53:13PM -0500, Russell Bryant wrote:
>> The flake8 command evolved over a series of patches and now includes the
>> use of both --select and --ignore. Unfortunately, this wasn't doing
>> what I thought. The use of --select comp
On Tue, Feb 02, 2016 at 02:02:15PM +0300, Ilya Maximets wrote:
> While killing OVS may not call rte_vhost_driver_unregister()
> for vhost-user ports. As a result corresponding socket will
> remain in a system and opening of that port after restart
> will fail.
>
> Signed-off-by: Ilya Maximets
Th
On 02/02/2016 04:24 PM, Ben Pfaff wrote:
> On Fri, Jan 22, 2016 at 09:32:33PM -0500, Russell Bryant wrote:
>> Python 3 has separate types for strings and bytes. Python 2 used the
>> same type for both. We need to convert strings to bytes before writing
>> them out to a socket. We also need to co
On 02/02/2016 04:22 PM, Ben Pfaff wrote:
> On Fri, Jan 22, 2016 at 09:32:32PM -0500, Russell Bryant wrote:
>> Python 3 no longer supports __cmp__. Instead, we have to implement the
>> "rich comparison" operators. We implement __eq__ and __lt__ and use
>> functools.total_ordering to implement the
On Fri, Jan 22, 2016 at 02:53:13PM -0500, Russell Bryant wrote:
> The flake8 command evolved over a series of patches and now includes the
> use of both --select and --ignore. Unfortunately, this wasn't doing
> what I thought. The use of --select completely overrides what --ignore
> does, meaning
On Fri, Jan 22, 2016 at 09:32:33PM -0500, Russell Bryant wrote:
> Python 3 has separate types for strings and bytes. Python 2 used the
> same type for both. We need to convert strings to bytes before writing
> them out to a socket. We also need to convert data read from the socket
> to a string.
On Fri, Jan 22, 2016 at 09:32:32PM -0500, Russell Bryant wrote:
> Python 3 no longer supports __cmp__. Instead, we have to implement the
> "rich comparison" operators. We implement __eq__ and __lt__ and use
> functools.total_ordering to implement the rest.
>
> In one case, no __cmp__ method was
On Fri, Jan 22, 2016 at 09:32:31PM -0500, Russell Bryant wrote:
> Comparing None to an integer worked in Python 2, but fails in Python 3.
>
> Signed-off-by: Russell Bryant
> ---
> python/ovs/reconnect.py | 2 +-
> tests/test-reconnect.py | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
On Fri, Jan 22, 2016 at 09:32:30PM -0500, Russell Bryant wrote:
> I've hit several bugs in this Python 3 work where the fix was some code
> needed to be converted to use isinstance(). This has been primarily
> around deadling with the changes to unicode handling. Go ahead and
> convert the rest o
On Fri, Jan 22, 2016 at 09:32:29PM -0500, Russell Bryant wrote:
> six.unichr() is equivalent to unichr() in Python 2
> and chr() in Python 3.
>
> Signed-off-by: Russell Bryant
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvsw
On Fri, Jan 22, 2016 at 09:32:28PM -0500, Russell Bryant wrote:
> sys.maxint does not exist in Python 3, as an int does not have a max
> value anymore (except as limited by implementation details and system
> resources).
>
> sys.maxsize works as a reasonable substitute as it's the same as
> sys.ma
On Fri, Jan 22, 2016 at 09:32:27PM -0500, Russell Bryant wrote:
> StringIO.StringIO in Python 2 became io.StringIO in Python 3. Use
> six.StringIO which is an alias for the two cases.
>
> Signed-off-by: Russell Bryant
Acked-by: Ben Pfaff
___
dev mail
On Fri, Jan 22, 2016 at 09:32:26PM -0500, Russell Bryant wrote:
> This code asserted that the callback argument was of type
> types.FunctionType. It's more pythonic to just check that the argument
> is callable, and not specifically that it's a function. There are other
> ways to implement a call
On Fri, Jan 22, 2016 at 09:32:25PM -0500, Russell Bryant wrote:
> types.StringTypes does not exist in Python 3. We can use
> six.string_types, instead.
>
> Signed-off-by: Russell Bryant
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
htt
On Fri, Jan 22, 2016 at 09:32:24PM -0500, Russell Bryant wrote:
> Python 2 had str and unicode. Python 3 only has str, which is always a
> unicode string. Drop use of unicode with the help of six.text_type
> (unicode in py2 and str in py3) and six.string_types ([str, unicode] in
> py2 and [str] i
On Fri, Jan 22, 2016 at 09:32:23PM -0500, Russell Bryant wrote:
> Python 2 has both long and int types. Python 3 only has int, which
> behaves like long.
>
> In the case of needing a set of integer types, we can use
> six.integer_types which includes int and long for Python 2 and just int
> for P
On Tue, Feb 02, 2016 at 03:15:12PM -0500, Russell Bryant wrote:
> On 02/01/2016 02:12 PM, Ben Pfaff wrote:
> > On Mon, Feb 01, 2016 at 10:12:49AM -0500, Russell Bryant wrote:
> >> In general, I definitely agree that this problem is something we need to
> >> work on. I've been wanting to look into
I sat down with this patch series and ran a case of stamping out 800
of the following patterns (each in its own openstack project) to see how
this patch set improves things within lflow_run:
n1 -- r1 -- x1
n1 is an openstack network with a dhcp subnet
r1 is an openstack router
x1 is an openstac
On 02/01/2016 02:12 PM, Ben Pfaff wrote:
> On Mon, Feb 01, 2016 at 10:12:49AM -0500, Russell Bryant wrote:
Thanks a lot for the background and references.
>> In general, I definitely agree that this problem is something we need to
>> work on. I've been wanting to look into adding a way for use
On Mon, Feb 1, 2016 at 7:00 PM, Daniele Di Proietto
wrote:
>
>
> On 01/02/2016 12:46, "Andy Zhou" wrote:
>
> >For the machines I have access to, Reloading the same pointer from
> >memory seems to inhibit complier optimization somewhat.
> >
> >In emc_processing(), using a single packet pointer, i
On Mon, Feb 1, 2016 at 7:02 PM, Daniele Di Proietto
wrote:
> Thanks for the patch!
>
> Acked-by: Daniele Di Proietto
>
> On 01/02/2016 12:46, "Andy Zhou" wrote:
>
> >Commit d262ac2c60ce1da7b477737f70e8efd38b32502d introduced a slight
> >performance drop for the fast path, where every packets hi
On Wed, Jan 20, 2016 at 03:15:00PM +0900, Simon Horman wrote:
> The motivation is to allow pushing single bytes in
> a manner to that already used for 16, 32 and 64 bit integers.
>
> This will be used by a follow-up patch to allow layer 3 packet -
> that is packets without an ethernet header - to
On Tue, Feb 02, 2016 at 02:02:16PM +0300, Ilya Maximets wrote:
> Memory pool for vhost-user ports always created even if construction
> fails. And message about successfull socket creation also printed.
>
> Signed-off-by: Ilya Maximets
Thanks, applied to master and branch-2.5.
__
With the small nits below:
Acked-by: Jarno Rajahalme
> On Jan 26, 2016, at 9:13 PM, Daniele Di Proietto
> wrote:
>
> It is ok to iterate a cmap with CMAP_FOR_EACH and remove elements with
> cmap_remove(), but having quiescent states inside the loop might create
> problems, since some of the p
On Tue, Feb 02, 2016 at 01:13:16PM +0200, Alexandru Ardelean wrote:
> Would it be an idea to add a ?
> #ifndef OVS_DEFAULT_THREAD_STACK_SIZE
> #define OVS_DEFAULT_THREAD_STACK_SIZE (2 * 1024 * 1024)
> #endif
>
> That way for our embedded musl libc case, we could add it to our CFLAGS.
What if we
On Tue, Feb 02, 2016 at 09:31:22AM +0100, Quentin Monnet wrote:
> 2016-02-01 18:14 GMT+01:00 Ben Pfaff :
>
> > On Mon, Feb 01, 2016 at 04:40:44PM -0800, Quentin Monnet wrote:
> > > Proposal: add an option to ovs-ofctl utility so as to obtain colorized
> > output
> > > in tty, for easier reading. C
On Tue, Feb 02, 2016 at 05:10:44PM +0530, Ajmer Singh wrote:
> I have added vendor extension in ONOS and now next target is to add the
> same vendor extension for OVS (OpenVswitch-2.4). I have not much idea about
> OVS and the code is very big ;) that's why difficult to understand or
> figure out h
On Tue, Feb 02, 2016 at 02:06:22PM +0300, Ilya Maximets wrote:
> > Then you need to validate that the socket is in a directory reserved for
> > sockets, like other parts of OVS do.
> >
> > Seriously it's not acceptable to have OVS break if you kill it and
> > restart it. That's just crappy, lazy
On Tue, Feb 02, 2016 at 08:55:37AM -0500, Aaron Conole wrote:
> Hi Ilya,
>
> Ilya Maximets writes:
> > Ilya Maximets (2):
> > netdev-dpdk: Unlink vhost-user sockets on fatal signals.
> > netdev-dpdk: Fix leak on netdev_dpdk_vhost_user_construct failure.
> >
> > lib/netdev-dpdk.c | 11 +++
On 29 January 2016 at 02:22, Wenyu Zhang wrote:
> Add logical router related vtep-ctl commands:
> vtep-ctl add-lr LR
> vtep-ctl del-lr LR
> vtep-ctl list-lr
> vtep-ctl lr-exists LR
>
> Signed-off-by: Wenyu Zhang
>
You will need the following incremental
diff --git a/vtep/vtep-ctl.c b/vtep/vtep
On 2 February 2016 at 02:41, Sorin Vinturis <
svintu...@cloudbasesolutions.com> wrote:
> This patch series adds support for MPLS to the OVS extension.
>
> Sorin Vinturis (2):
> [PATCH v3 1/2] datapath-windows: Support for OVS_KEY_ATTR_MPLS attribute
> [PATCH v3 2/2] datapath-windows: Accept MP
On 2 February 2016 at 02:43, Sorin Vinturis <
svintu...@cloudbasesolutions.com> wrote:
> Updated FAQ document to reflect MPLS support for Hyper-V.
>
> Signed-off-by: Sorin Vinturis
>
Applied, thanks!
> ---
> FAQ.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/FAQ.md
While killing OVS may not call rte_vhost_driver_unregister()
for vhost-user ports. As a result corresponding socket will
remain in a system and opening of that port after restart
will fail.
Signed-off-by: Ilya Maximets
---
lib/netdev-dpdk.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
Acked-by: Nithin Raju
-Original Message-
From: dev on behalf of Sorin Vinturis
Date: Tuesday, February 2, 2016 at 2:43 AM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH] datapath-windows: Updated FAQ regarding
Hyper-V MPLS.
>Updated FAQ document to reflect MPLS support for Hyper-
Hi, Aaron.
Thank you for response.
1/2 blocked by mail-list filter right now and waits for
approval from moderator. Your '@redhat.com' address was
in CC list.
Best regards, Ilya Maximets.
On 02.02.2016 16:55, Aaron Conole wrote:
> Hi Ilya,
>
> Ilya Maximets writes:
>> Ilya Maximets (2):
>> ne
Hi Ilya,
Ilya Maximets writes:
> Ilya Maximets (2):
> netdev-dpdk: Unlink vhost-user sockets on fatal signals.
> netdev-dpdk: Fix leak on netdev_dpdk_vhost_user_construct failure.
>
> lib/netdev-dpdk.c | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
1/2 doesn't seem to h
Hi Daniele,
I feel this approach is fine to go ahead. At least it looks to me more readable
than the earlier one.
Once again thank you for sending out the patch.
Acked!
Regards
_Sugesh
> -Original Message-
> From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
> Sent: Tuesday, Feb
Hi,
I have added vendor extension in ONOS and now next target is to add the
same vendor extension for OVS (OpenVswitch-2.4). I have not much idea about
OVS and the code is very big ;) that's why difficult to understand or
figure out how we can add vendor extension in OVS. Can you please guide me
h
1 - 100 of 118 matches
Mail list logo
