Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

2015-07-15 Thread Saloni Jain
Hi Ben, According Open vSwitch Manual: "ovs-vswitchd can perform all configured bridging and switching locally, or  it can be configured to communicate with one or more external Open‐Flow controllers.  The switch is typically configured to connect  to  a "primary   controller"  that  takes  char

Re: [ovs-dev] [ovn-controller-vtep V3 3/7] ovn-sbctl: Add ovn-sbctl.

2015-07-15 Thread Alex Wang
On Wed, Jul 15, 2015 at 3:48 PM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 08:22:39PM -0700, Alex Wang wrote: > > This commit adds ovn-sbctl to ovn family by using the db-ctl-base > > library. > > > > As a side effect, we move the ovn-nbctl/ovn-sbctl related files > > into ovn/utilities. > > > >

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Joe Stringer
On 15 July 2015 at 17:41, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote: >> On 15 July 2015 at 15:53, Jesse Gross wrote: >>> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: > There are several im

[ovs-dev] [PATCH 3/4] ovs-vsctl: Remove redundant checks.

2015-07-15 Thread Joe Stringer
In several places, "br" is dereferenced just before a check such as "if (br ...)". These checks may be optimised out, and they provide no additional safety, so this patch removes them. Found by MIT STACK analyzer. Signed-off-by: Joe Stringer --- utilities/ovs-vsctl.c | 9 +++-- 1 file chang

[ovs-dev] [PATCH 0/4] Fixes to undefined behaviour.

2015-07-15 Thread Joe Stringer
I was recently introduced to the MIT "STACK" code analyzer[1]. STACK analyses the intermediate representation of LLVM-compiled code, and attempts to detect cases where the compiler may optimise some code unexpectedly, usually due to undefined behaviour. This series addresses the issues found by thi

[ovs-dev] [PATCH 1/4] ofp-parse: Fix typo in consistency check.

2015-07-15 Thread Joe Stringer
This check in parse_ofp_str__() attempted to detect inconsistencies between matches and actions, or inconsistencies within the actions. In this case, ofpacts_check() would effectively zero the "usable_protocols" and return 0 (ie, OK). However, when checking the return parameter, it checks the point

[ovs-dev] [PATCH 2/4] vtep-ctl: Remove extraneous NULL pointer check.

2015-07-15 Thread Joe Stringer
OVS will exit if the allocations in this function fail, so this check is pointless. Found by MIT STACK analyzer. Signed-off-by: Joe Stringer --- vtep/vtep-ctl.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c index f065fc9..8dfd3ad

[ovs-dev] [PATCH 4/4] ovn: Fix extra token detection.

2015-07-15 Thread Joe Stringer
This code attempts to first check whether another error was detected for the string it is parsing, then if it's not at the end of the tokens, report an error. However, 'errorp' is always a valid pointer to a 'char *', so the first check in this statement always evaluates false. Furthermore, this b

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Alex Wang
On Wed, Jul 15, 2015 at 1:33 PM, Russell Bryant wrote: > On 07/15/2015 03:15 PM, Russell Bryant wrote: > > On 07/15/2015 03:09 PM, Alex Wang wrote: > >> Also, what do you think about my proposal for using "type" and > "options" > >> fields on logical ports in OVN_Northbound instead of a s

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Alex Wang
On Wed, Jul 15, 2015 at 1:10 PM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 08:22:38PM -0700, Alex Wang wrote: > > In a gateway like the VTEP L2 gateway, physical vlans belonging to > > the same logical network form a "logical switch". Each logical switch > > has a dedicated tunnel key and will

Re: [ovs-dev] IS MSTP enabled on OVS 2.3.9

2015-07-15 Thread ravali.burra
Hi Justin Thanks for reply. Yes I want to implement the code of MSTP in OVS. Could you please help me in how to proceed further with the design and implementation of MSTP in OVS. Thanks & Regards, Ravali -Original Message- From: Justin Pettit [mailto:jpet...@nicira.com] Sent: 16 July 2

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 5:41 PM, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote: >> On 15 July 2015 at 15:53, Jesse Gross wrote: >>> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: > There are sev

[ovs-dev] [PATCH v4] datapath-windows: Output a packet to two or more VXLAN ports

2015-07-15 Thread Alin Serdean
If we have a flow rule in the following form: actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are VXLAN tunnels with different tunnelling information) A packet which will hit that specific flow will only be sent out encapsulated with the first tunnelling information. This

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-15 Thread Alin Serdean
Hi Jarno, This is breaking the windows build (https://ci.appveyor.com/project/blp/ovs/build/1.0.459): lib/classifier.c(1355) : error C2229: struct '' has an illegal zero-sized array. The problem is the following (https://msdn.microsoft.com/en-us/library/0scy7z2d.aspx ): https://github.com/open

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 5:31 PM, Joe Stringer wrote: > On 15 July 2015 at 15:53, Jesse Gross wrote: >> On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: >>> On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: There are several implementations of functions that parse/format fl

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Joe Stringer
On 15 July 2015 at 15:53, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: >> On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: >>> There are several implementations of functions that parse/format >>> flags and their binary representation. This factors them out i

Re: [ovs-dev] [ovn-controller-vtep V3 1/7] ofproto-macros.at: Make check_logs() check all daemons' log files.

2015-07-15 Thread Alex Wang
Thx for the review, applied to master~ On Wed, Jul 15, 2015 at 12:42 PM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 08:22:37PM -0700, Alex Wang wrote: > > As we have more daemons with OVN that can be tested using ovs autotest > > framework, it is convenient to extend check_logs() to check the lo

Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

2015-07-15 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 05:51:50PM +0530, Saloni Jain wrote: > In addition to my previous response, please suggest if "vswitchd" > should query and get the current stored table-configurartion > using query_tables_desc() and then modify table-config properties > according to user's request. I don't

Re: [ovs-dev] ovs-ofctl mod-table commands supporting OF1.4 Eviction and Vacancy-Events

2015-07-15 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 11:39:17AM +0530, Saloni Jain wrote: > Thanks for the reply. > Please help me understand below points: > As per openflow specification 1.4, Page 72 "The flag OFPTC_VACANCY_EVENTS > control vacancy events in that table (see 7.4.5). If this flag is set, the > switch must gen

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Gurucharan Shetty
tomorrow is fine, thank Jarno! On Wed, Jul 15, 2015 at 5:11 PM, Jarno Rajahalme wrote: > I can get on this tomorrow, if a more urgent fix is needed, then the three > patches on the series I pushed should be reverted. > > Jarno > > >> On Jul 15, 2015, at 16:35, Gurucharan Shetty wrote: >> >> O

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Jarno Rajahalme
I can get on this tomorrow, if a more urgent fix is needed, then the three patches on the series I pushed should be reverted. Jarno > On Jul 15, 2015, at 16:35, Gurucharan Shetty wrote: > > One of the patches in this series breaks windows build because of zero > sized array. > https://ci.ap

Re: [ovs-dev] [RFC PATCH v2 6/7] flow: Split miniflow's map.

2015-07-15 Thread Jarno Rajahalme
> On Jul 14, 2015, at 10:37 PM, Ben Pfaff wrote: > > On Fri, Jul 10, 2015 at 10:35:24AM -0700, Jarno Rajahalme wrote: >> Use two maps in miniflow to allow for expansion of struct flow past >> 512 bytes. We now have one map for tunnel related fields, and another >> for the rest of the packet met

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Gurucharan Shetty
One of the patches in this series breaks windows build because of zero sized array. https://ci.appveyor.com/project/blp/ovs/build/1.0.458 On Wed, Jul 15, 2015 at 4:01 PM, Jarno Rajahalme wrote: > >> On Jul 14, 2015, at 10:31 PM, Ben Pfaff wrote: >> >> On Fri, Jul 10, 2015 at 10:35:23AM -0700, Ja

Re: [ovs-dev] [PATCH] [OVN] Add QoS to NB schema

2015-07-15 Thread Gal Sagie
Yes, there are currently plans for marking (DSCP) and flow classification profiles. And other ideas like connections limiting. On Wed, Jul 15, 2015 at 8:38 PM, Ben Pfaff wrote: > On Sun, Jul 12, 2015 at 09:21:41AM +0300, Gal Sagie wrote: > > Add QoS profile and QoS rule tables and explanations >

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Alex Wang
On Wed, Jul 15, 2015 at 3:14 PM, Ben Pfaff wrote: > On Wed, Jul 15, 2015 at 04:23:14PM -0400, Russell Bryant wrote: > > On 07/15/2015 04:03 PM, Ben Pfaff wrote: > > > On Wed, Jul 15, 2015 at 12:09:21PM -0700, Alex Wang wrote: > > >> With you suggestion, first, the logical port name in ovn-nb can

Re: [ovs-dev] [RFC PATCH v2 5/7] flow: Eliminate miniflow_clone() and minimask_clone().

2015-07-15 Thread Jarno Rajahalme
> On Jul 14, 2015, at 10:31 PM, Ben Pfaff wrote: > > On Fri, Jul 10, 2015 at 10:35:23AM -0700, Jarno Rajahalme wrote: >> miniflow_clone() and minimask_clone() are no longer used, remove them >> from the API. >> >> Now that miniflow data is always inlined, it makes sense to rename >> miniflow_cl

Re: [ovs-dev] [RFC PATCH v2 4/7] match: Single malloc minimatch.

2015-07-15 Thread Jarno Rajahalme
Pushed to master, Jarno > On Jul 14, 2015, at 10:16 PM, Ben Pfaff wrote: > > On Fri, Jul 10, 2015 at 10:35:22AM -0700, Jarno Rajahalme wrote: >> Allocate the miniflow and minimask in struct minimatch at once, so >> that they are consecutive in memory. This halves the number of >> allocations

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-15 Thread Jarno Rajahalme
Thanks for the review, pushed to master. Jarno > On Jul 15, 2015, at 3:05 PM, Ben Pfaff wrote: > > On Wed, Jul 15, 2015 at 01:11:54PM -0700, Jarno Rajahalme wrote: >> >>> On Jul 14, 2015, at 4:50 PM, Ben Pfaff wrote: >>> >>> On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote:

Re: [ovs-dev] [RFC PATCH v2 2/7] meta-flow: Add a missing break statement.

2015-07-15 Thread Jarno Rajahalme
> On Jul 10, 2015, at 11:19 AM, Jesse Gross wrote: > > On Fri, Jul 10, 2015 at 10:35 AM, Jarno Rajahalme > wrote: >> Signed-off-by: Jarno Rajahalme >> --- >> lib/meta-flow.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This one seems like an obvious bugfix that can go in in

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 11:35 AM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: >> There are several implementations of functions that parse/format >> flags and their binary representation. This factors them out into >> common routines. In addition to reducing cod

Re: [ovs-dev] [ovn-controller-vtep V3 3/7] ovn-sbctl: Add ovn-sbctl.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 08:22:39PM -0700, Alex Wang wrote: > This commit adds ovn-sbctl to ovn family by using the db-ctl-base > library. > > As a side effect, we move the ovn-nbctl/ovn-sbctl related files > into ovn/utilities. > > Signed-off-by: Alex Wang > Acked-by: Ben Pfaff > > --- > V2->V

Re: [ovs-dev] [v2 2/2] ovsdb: Add per transaction commit instruction counter

2015-07-15 Thread Andy Zhou
When dropping perf-counter.c, I missed that It also contained a fix that is necessary for the remaining patches for pass unit tests. I will add it back to the patch set and post v3. Sorry about this. On Tue, Jul 14, 2015 at 5:06 PM, Ben Pfaff wrote: > On Tue, Jul 14, 2015 at 03:57:15PM -0700, B

[ovs-dev] [v3 1/3] perf-counter: initialize perf counter shash before use

2015-07-15 Thread Andy Zhou
Private variable perf_counters needs to be initialized before use. Otherwise, perf_counter_init() call will cause crashes. Signed-off-by: Andy Zhou --- lib/perf-counter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/perf-counter.c b/lib/perf-counter.c index 8c859cc..6

[ovs-dev] [v3 3/3] ovsdb: Add per transaction commit instruction counter

2015-07-15 Thread Andy Zhou
Measure user space only instruction counters for commit each transaction. This measurement is mainly useful for tuning OVSDB internal implementation, such as how OVSDB scales over number of client connections. A simple usage example: ovs-appctl -t ovsdb-server ovsdb-server/perf-counters-clear ovs

[ovs-dev] [v3 2/3] perf-counter: simplify the performance macro

2015-07-15 Thread Andy Zhou
Replace the original PERF_FUNCTION_BEGIN and PERF_FUNCTION_END pair with a single PERF macro. This design is also more flexible, removing the restriction of have only one measurement per function. The next patch will make use of this macro. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff --- v1 -

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 04:23:14PM -0400, Russell Bryant wrote: > On 07/15/2015 04:03 PM, Ben Pfaff wrote: > > On Wed, Jul 15, 2015 at 12:09:21PM -0700, Alex Wang wrote: > >> With you suggestion, first, the logical port name in ovn-nb can be > >> duplicated. > >> And if that is allowed, we need to

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 01:11:54PM -0700, Jarno Rajahalme wrote: > > > On Jul 14, 2015, at 4:50 PM, Ben Pfaff wrote: > > > > On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote: > >> Now that performance critical code already inlines miniflows and > >> minimasks, we can simplify stru

Re: [ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 01:18:26PM -0700, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 12:37 PM, Ben Pfaff wrote: > > On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote: > >> Several encapsulation formats have the concept of an 'OAM' bit > >> which typically is used with networking tracin

Re: [ovs-dev] IS MSTP enabled on OVS 2.3.9

2015-07-15 Thread Justin Pettit
> On Jul 14, 2015, at 5:13 AM, ravali.bu...@wipro.com wrote: > > Hi Team, > > I am using ovs-master code Version 2.3.9 for my experiments. > > Currently what I understood from ovs-vsctl man page we are having commands > for the configuring RSTP. > > Similar way I want to configure MSTP in

Re: [ovs-dev] [RFC PATCH 0/6] Increase miniflow's capacity.

2015-07-15 Thread Jarno Rajahalme
On Jul 15, 2015, at 08:53, Traynor, Kevin wrote: >> From: Jarno Rajahalme [mailto:jrajaha...@nicira.com] >> Sent: Friday, July 10, 2015 6:38 PM >> To: Traynor, Kevin >> Cc: dev@openvswitch.org >> Subject: Re: [ovs-dev] [RFC PATCH 0/6] Increase miniflow's capacity. >> >> >> On Jul 10, 2015, at

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Russell Bryant
On 07/15/2015 03:15 PM, Russell Bryant wrote: > On 07/15/2015 03:09 PM, Alex Wang wrote: >> Also, what do you think about my proposal for using "type" and "options" >> fields on logical ports in OVN_Northbound instead of a special port >> name? If we went this route, you don't need "lo

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Russell Bryant
On 07/15/2015 04:03 PM, Ben Pfaff wrote: > On Wed, Jul 15, 2015 at 12:09:21PM -0700, Alex Wang wrote: >> With you suggestion, first, the logical port name in ovn-nb can be >> duplicated. >> And if that is allowed, we need to pass the "options" down to ovn-sb >> Binding table to uniquely binding the

Re: [ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 12:37 PM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote: >> Several encapsulation formats have the concept of an 'OAM' bit >> which typically is used with networking tracing tools to >> distinguish test packets from real traffic. OVS already

Re: [ovs-dev] [RFC PATCH v2 3/7] flow: Always inline miniflows.

2015-07-15 Thread Jarno Rajahalme
> On Jul 14, 2015, at 4:50 PM, Ben Pfaff wrote: > > On Fri, Jul 10, 2015 at 10:35:21AM -0700, Jarno Rajahalme wrote: >> Now that performance critical code already inlines miniflows and >> minimasks, we can simplify struct miniflow by always dynamically >> allocating miniflows and minimasks to th

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 08:22:38PM -0700, Alex Wang wrote: > In a gateway like the VTEP L2 gateway, physical vlans belonging to > the same logical network form a "logical switch". Each logical switch > has a dedicated tunnel key and will keep records of all MACs learned > from the owned vlans. So

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 02:22:58PM -0400, Russell Bryant wrote: > On 07/13/2015 11:22 PM, Alex Wang wrote: > > In a gateway like the VTEP L2 gateway, physical vlans belonging to > > the same logical network form a "logical switch". Each logical switch > > has a dedicated tunnel key and will keep r

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 12:09:21PM -0700, Alex Wang wrote: > With you suggestion, first, the logical port name in ovn-nb can be > duplicated. > And if that is allowed, we need to pass the "options" down to ovn-sb > Binding table to uniquely binding the vtep lport to vtep chassis. I'm starting to w

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Alex Wang
On Wed, Jul 15, 2015 at 12:15 PM, Russell Bryant wrote: > On 07/15/2015 03:09 PM, Alex Wang wrote: > > Also, what do you think about my proposal for using "type" and > "options" > > fields on logical ports in OVN_Northbound instead of a special port > > name? If we went this route, y

Re: [ovs-dev] [ovn-controller-vtep V3 1/7] ofproto-macros.at: Make check_logs() check all daemons' log files.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 08:22:37PM -0700, Alex Wang wrote: > As we have more daemons with OVN that can be tested using ovs autotest > framework, it is convenient to extend check_logs() to check the log files > of all daemons. > > Signed-off-by: Alex Wang > > --- > V2->V3: > - adopt Ben's suggest

Re: [ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 12:37:08PM -0700, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote: > > Several encapsulation formats have the concept of an 'OAM' bit > > which typically is used with networking tracing tools to > > distinguish test packets from real traffic. O

Re: [ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote: > Several encapsulation formats have the concept of an 'OAM' bit > which typically is used with networking tracing tools to > distinguish test packets from real traffic. OVS already internally > has support for this, however, it doesn't d

Re: [ovs-dev] [PATCH] datapath-windows: update extension information

2015-07-15 Thread Ben Pfaff
Done, thanks! On Wed, Jul 15, 2015 at 06:17:35PM +, Alin Serdean wrote: > Sorry forgot to mention in the commit notes, yes please apply it on 2.4 as > well. > > Alin. > > -Mesaj original- > De la: Ben Pfaff [mailto:b...@nicira.com] > Trimis: Wednesday, July 15, 2015 8:46 PM > Către

Re: [ovs-dev] [PATCH v2] datapath-windows: Update VXLAN header information

2015-07-15 Thread Ben Pfaff
Thanks, done. On Wed, Jul 15, 2015 at 06:17:14PM +, Alin Serdean wrote: > Sorry forgot to mention in the commit notes, yes please apply it on 2.4 as > well. > > Alin > > -Mesaj original- > De la: Ben Pfaff [mailto:b...@nicira.com] > Trimis: Wednesday, July 15, 2015 8:42 PM > Către:

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Russell Bryant
On 07/15/2015 03:09 PM, Alex Wang wrote: > Also, what do you think about my proposal for using "type" and "options" > fields on logical ports in OVN_Northbound instead of a special port > name? If we went this route, you don't need "logical_switches" to be a > smap, it can just be

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Alex Wang
On Wed, Jul 15, 2015 at 11:22 AM, Russell Bryant wrote: > On 07/13/2015 11:22 PM, Alex Wang wrote: > > In a gateway like the VTEP L2 gateway, physical vlans belonging to > > the same logical network form a "logical switch". Each logical switch > > has a dedicated tunnel key and will keep records

Re: [ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 12:04:54PM -0700, Jesse Gross wrote: > On Wed, Jul 15, 2015 at 11:38 AM, Ben Pfaff wrote: > > On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote: > >> Several encapsulation formats have the concept of an 'OAM' bit > >> which typically is used with networking tracin

Re: [ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

2015-07-15 Thread Jesse Gross
On Wed, Jul 15, 2015 at 11:38 AM, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote: >> Several encapsulation formats have the concept of an 'OAM' bit >> which typically is used with networking tracing tools to >> distinguish test packets from real traffic. OVS already

Re: [ovs-dev] [PATCH] Fix build on linux.

2015-07-15 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 02:30:57PM -0400, Russell Bryant wrote: > A recent commit added a new file but didn't add it to EXTRA_DIST. > > Signed-off-by: Russell Bryant > CC: Ben Pfaff > CC: Alin Gabriel Serdean Already fixed, sorry about that. ___ dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix broken break by distributing resource.h.

2015-07-15 Thread Jarno Rajahalme
Me too :-) Acked-by: Jarno Rajahalme > On Jul 15, 2015, at 11:32 AM, Russell Bryant wrote: > > On 07/15/2015 02:28 PM, Ben Pfaff wrote: >> Commit e19a0c6 (datapath-windows: update extension information) added >> resource.h but did not distribute it. >> >> Signed-off-by: Ben Pfaff >> --- >> I

Re: [ovs-dev] [PATCH 2/2] tunneling: Allow matching and setting tunnel 'OAM' flag.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 02:53:57PM -0700, Jesse Gross wrote: > Several encapsulation formats have the concept of an 'OAM' bit > which typically is used with networking tracing tools to > distinguish test packets from real traffic. OVS already internally > has support for this, however, it doesn't d

Re: [ovs-dev] [PATCH 1/2] flow: Factor out flag parsing and formatting routines.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote: > There are several implementations of functions that parse/format > flags and their binary representation. This factors them out into > common routines. In addition to reducing code, it also makes things > more consistent across differen

Re: [ovs-dev] [PATCH] datapath-windows: Fix broken break by distributing resource.h.

2015-07-15 Thread Russell Bryant
On 07/15/2015 02:28 PM, Ben Pfaff wrote: > Commit e19a0c6 (datapath-windows: update extension information) added > resource.h but did not distribute it. > > Signed-off-by: Ben Pfaff > --- > I already applied this to master to fix the broken build. > > datapath-windows/automake.mk | 3 ++- > 1 f

[ovs-dev] [PATCH] Fix build on linux.

2015-07-15 Thread Russell Bryant
A recent commit added a new file but didn't add it to EXTRA_DIST. Signed-off-by: Russell Bryant CC: Ben Pfaff CC: Alin Gabriel Serdean --- datapath-windows/automake.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk index a4f5a57.

[ovs-dev] [PATCH] datapath-windows: Fix broken break by distributing resource.h.

2015-07-15 Thread Ben Pfaff
Commit e19a0c6 (datapath-windows: update extension information) added resource.h but did not distribute it. Signed-off-by: Ben Pfaff --- I already applied this to master to fix the broken build. datapath-windows/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

Re: [ovs-dev] [ovn-controller-vtep V3 2/7] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-07-15 Thread Russell Bryant
On 07/13/2015 11:22 PM, Alex Wang wrote: > In a gateway like the VTEP L2 gateway, physical vlans belonging to > the same logical network form a "logical switch". Each logical switch > has a dedicated tunnel key and will keep records of all MACs learned > from the owned vlans. So user can just sen

Re: [ovs-dev] [PATCH v2] datapath-windows: Update VXLAN header information

2015-07-15 Thread Alin Serdean
Sorry forgot to mention in the commit notes, yes please apply it on 2.4 as well. Alin -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Wednesday, July 15, 2015 8:42 PM Către: Alin Serdean Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Update

Re: [ovs-dev] [PATCH] datapath-windows: update extension information

2015-07-15 Thread Alin Serdean
Sorry forgot to mention in the commit notes, yes please apply it on 2.4 as well. Alin. -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Wednesday, July 15, 2015 8:46 PM Către: Alin Serdean Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: update e

Re: [ovs-dev] [ovn-controller-vtep V3 1/6] ofproto-macros.at: Make check_logs() check all log files.

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 12:04:11PM -0700, Alex Wang wrote: > As we have more daemons with OVN that can be tested using ovs autotest > framework, it is convenient to extend check_logs() to check all log files > (except the testsuite.log). > > Signed-off-by: Alex Wang > > --- > V2->V3: > - adopt B

Re: [ovs-dev] [PATCH] datapath-windows: update extension information

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 05:18:20PM +, Alin Serdean wrote: > This patch sets additional information about the driver used by various > applications. > > Signed-off-by: Alin Gabriel Serdean Thanks! I applied this to master. Should I also apply it to branch-2.4? Thanks, Ben. ___

Re: [ovs-dev] [PATCH v2] datapath-windows: Update VXLAN header information

2015-07-15 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 04:59:26PM +, Alin Serdean wrote: > Use tunnel key information on the IP header preceding the VXLAN header. > > Signed-off-by: Alin Gabriel Serdean > --- > v2: use separate variable to store the number of transmitted bytes Thanks, I applied this to master. Should I a

Re: [ovs-dev] [PATCH] [OVN] Add QoS to NB schema

2015-07-15 Thread Ben Pfaff
On Sun, Jul 12, 2015 at 09:21:41AM +0300, Gal Sagie wrote: > Add QoS profile and QoS rule tables and explanations > to the NB schema. > Add specific bandwidth limit rule configurations > in the document > > Signed-off-by: Gal Sagie This is a lot of schema to support just a little bit of function

Re: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS

2015-07-15 Thread Sorin Vinturis
Rebased v2 patch: http://openvswitch.org/pipermail/dev/2015-July/057480.html -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Wednesday, 15 July, 2015 19:06 To: Ben Pfaff; Alin Serdean Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH v2] ofproto: Implement OF1.4 Set/Get asynchronous configuration messages.

2015-07-15 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 05:42:50PM +0530, niti1...@gmail.com wrote: > From: Niti > > This patch adds support for Openflow1.4 set/get asynchronous configuration > messages. OpenVSwitch already supports set/get asynchronous configuration > messages for Openflow1.3. In this patch OFPT_SET_ASYNC_CONF

Re: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS

2015-07-15 Thread Sorin Vinturis
Hi Ben, I sent a rebased v2 patch. Thanks, Sorin -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Wednesday, 15 July, 2015 18:55 To: Alin Serdean Cc: Sorin Vinturis; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS Same

Re: [ovs-dev] [PATCH] datapath-windows: Fixed spelling errors in OVS

2015-07-15 Thread Ben Pfaff
Same here. On Mon, Jul 13, 2015 at 11:44:28AM +, Alin Serdean wrote: > Just one small nit think you need to rebase. Could not apply the patch on > master. > > Alin. > > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Alin Serdean > Trimis: Monday, July 1

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when cleaning up the VXLAN tunnel

2015-07-15 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 08:26:51AM +, Sorin Vinturis wrote: > When removing vport also remove the vxlan tunnel port. > > Signed-off-by: Sorin Vinturis > Reported-by: Sorin Vinturis > Reported-at: https://github.com/openvswitch/ovs-issues/issues/94 Thanks, applied to master and branch-2.4. _

Re: [ovs-dev] [RFC PATCH 0/6] Increase miniflow's capacity.

2015-07-15 Thread Traynor, Kevin
> From: Jarno Rajahalme [mailto:jrajaha...@nicira.com] > Sent: Friday, July 10, 2015 6:38 PM > To: Traynor, Kevin > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [RFC PATCH 0/6] Increase miniflow's capacity. > > > On Jul 10, 2015, at 9:38 AM, Traynor, Kevin wrote: > > > -Original Messag

Re: [ovs-dev] [PATCH] doc: Document proposed OVN Gateway HA design.

2015-07-15 Thread Ben Pfaff
On Thu, Jul 09, 2015 at 06:12:53PM -0700, Ethan Jackson wrote: > High availability for gateways in network virtualization deployments > is fairly difficult to get right. There are a ton of options, most of > which are too complicated or perform badly. To help solve this > problem, this patch prop

Re: [ovs-dev] [RFC PATCH v2 7/7] dpif-netdev: Bug fix and performance improvement.

2015-07-15 Thread Jarno Rajahalme
> On Jul 14, 2015, at 22:38, Ben Pfaff wrote: > >> On Fri, Jul 10, 2015 at 10:35:25AM -0700, Jarno Rajahalme wrote: >> MINIFLOW_FOR_EACH_IN_MAPS and NETDEV_FLOW_KEY_FOR_EACH_IN_MAPqS had a >> bug where tunnel metadata values remaining after the processing of the >> tnl_map was not advanced corre

[ovs-dev] [PATCH] datapath-windows: Enable failure after restarting extension

2015-07-15 Thread Sorin Vinturis
If the extension was previously enabled and running, after issuing a restart, stop+start, the extension fails to be enabled. This happens because the extension's DeviceObject is not yet initialized before the FilterAttach routine is called. This patch addresses this issue. Signed-off-by: Sorin Vi

Re: [ovs-dev] [PATCH] ovn-nb: Add per-port IP addresses to routers.

2015-07-15 Thread Gal Sagie
On Wed, Jul 15, 2015 at 1:08 AM, Ben Pfaff wrote: > A router needs one IP address per port, not just one for the whole router. > > Reported-by: Gal Sagie > Reported-at: http://openvswitch.org/pipermail/dev/2015-July/057242.html > Signed-off-by: Ben Pfaff > --- > ovn/ovn-nb.ovsschema | 1 - >

Re: [ovs-dev] [PATCH] ovn-nb: Add per-port IP addresses to routers.

2015-07-15 Thread Gal Sagie
The change looks good to me. The question i have is how will public network be configured/connected to the logical router in OVN? (In neutron router can only be connected to one public network) This layer also need to support SNAT/DNAT functionality between the public network and the virtual netwo

[ovs-dev] [PATCH 2/2] datapath-windows: Support for IRP cancelling mechanism

2015-07-15 Thread Sorin Vinturis
Under certain circumstances, we might need to cancel a pending IRP that has been submitted and not yet responded. This might occur when the request takes too long to complete or when the process which initiated the request terminated, leaving the request outstanding. This patch adds this missing p

[ovs-dev] [PATCH 0/2] datapath-windows: IRP cancelling mechanism

2015-07-15 Thread Sorin Vinturis
This patch series adds support for IRP cancelling mechanism to the OVS extension. Sorin Vinturis (2): [PATCH 1/2] datapath-windows: Process tunnel filter requests iteratively [PATCH 2/2] datapath-windows: Support for IRP cancelling mechanism ___ dev

[ovs-dev] [PATCH 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-07-15 Thread Sorin Vinturis
In order to support IRP cancelling mechanism for pending IRPs, all tunnel filter requests, VXLAN tunnel create/delete, need to be processed iteratively. Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/TunnelFilter.c | 89 +++--- 1 file changed, 27 insertions

[ovs-dev] [PATCH v2] datapath-windows: Solved BSOD when cleaning up the VXLAN tunnel

2015-07-15 Thread Sorin Vinturis
When removing vport also remove the vxlan tunnel port. Signed-off-by: Sorin Vinturis Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/94 Acked-by: Alin Gabriel Serdean --- v2: Added ack and rebased. --- datapath-windows/ovsext/Vport.c | 6 ++ datapa

[ovs-dev] [PATCH v2] datapath-windows: Fixed spelling errors in OVS

2015-07-15 Thread Sorin Vinturis
Solved some spelling errors observed in the datapath code. Signed-off-by: Sorin Vinturis --- v2: rebased the patch. --- datapath-windows/ovsext/TunnelFilter.c | 22 +++--- datapath-windows/ovsext/TunnelIntf.h | 20 ++-- datapath-windows/ovsext/Vport.c|

Re: [ovs-dev] [PATCH 1/2] ovn: Minor cleanups in "physical" component comments.

2015-07-15 Thread Justin Pettit
> On Jul 15, 2015, at 12:38 AM, Gal Sagie wrote: > > > Acked-by: Gal Sagie Thanks! I pushed it to master. --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] ovn: Minor cleanups in "physical" component comments.

2015-07-15 Thread Gal Sagie
On Wed, Jul 15, 2015 at 3:33 AM, Justin Pettit wrote: > There's only this one patch in this "series". I forgot to clean that up > before I sent it. > > --Justin > > > > On Jul 14, 2015, at 5:31 PM, Justin Pettit wrote: > > > > Signed-off-by: Justin Pettit > > --- > > ovn/controller/physical.c

Re: [ovs-dev] [PATCH] ovs-ofctl.8: Specify correct variable in "snoop" description.

2015-07-15 Thread Justin Pettit
> On Jul 14, 2015, at 8:00 PM, Ben Pfaff wrote: > > On Tue, Jul 14, 2015 at 05:26:12PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed it to master. --Justin ___ dev mailing list dev@openvswi