On Mon, Jul 13, 2015 at 02:53:56PM -0700, Jesse Gross wrote:
> There are several implementations of functions that parse/format
> flags and their binary representation. This factors them out into
> common routines. In addition to reducing code, it also makes things
> more consistent across different parts of OVS.
>
> Signed-off-by: Jesse Gross <[email protected]>
Thanks, I like reducing code size!
This patch deletes a test and part of a test in ovs-ofctl.at. Why?
In parse_flags(), s/preceed/preceded/:
*res_string = xasprintf("%s: %s must be preceed by '+' "
parse_flags() could use a function-level comment.
format_flags_masked() will output the empty string if flags == 0 && mask
== 0, and I think that parse_flags() will accept that too, but I don't
know if it's the most user-friendly form. Don't know if that matters.
format_flags_masked() will output "0" if flags == 0 && mask == max_mask,
but parse_flags() won't accept "0". It would be nice to resolve that.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
