On Mon, Jul 13, 2015 at 08:22:39PM -0700, Alex Wang wrote:
> This commit adds ovn-sbctl to ovn family by using the db-ctl-base
> library.
> 
> As a side effect, we move the ovn-nbctl/ovn-sbctl related files
> into ovn/utilities.
> 
> Signed-off-by: Alex Wang <al...@nicira.com>
> Acked-by: Ben Pfaff <b...@nicira.com>
> 
> ---
> V2->V3:
> - rebase to base.
> - adopt Russell's review comments.
> - move ovn-nbctl/sbctl related files into ovn/utilities.
> 
> PATCH->V2:
> - change command add/del-ch to add/del-chassis.
> - refine the manual based on comments from Ben.

I get a test failure in a new test due to:
    ovn-sbctl: unknown command 'add-chassis'; use --help for help

I think that the manual should say that it is really for advanced
debugging and troubleshooting and that it should not be used in normal
operation (I guess ovn-nbctl should say the same thing; I thought it did
before but I don't see it now).

If you fix those then:
Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to