Would be nice to have an option for Release or debug build. User mode code too.
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Thursday, February 05, 2015 10:39 PM
To: Gurucharan Shetty
Cc: dev@openvswitch.org; Gurucharan Shetty
Subject: Re
> +- C:\MinGW\msys\1.0\bin\bash -lc "cd /c/openvswitch && ./configure
> CC=build-aux/cccl LD=\"`which link`\" LIBS=-lws2_32
> --with-pthread=C:/pthreads-win32/Pre-built.2 --with-openssl=C:/OpenSSL-Win32
> --with-vstudioddk=\"Win8.1 Release\”"
Thanks for the patch.
Only comment I had was to was
> On Feb 5, 2015, at 6:36 PM, Gurucharan Shetty wrote:
>
>> Guru,
>> I have a minor question. Does the yml file you added do testing as well? I
>> see there’s a command to run configure and ‘make’ but, does it run tests
>> also? You mentioned “build test”. Hence I asked.
>
> I used the term "b
In a previous commit, support had been added to support building
the kernel datapath from command line. In this patch, we document
it.
Signed-off-by: Nithin Raju
---
INSTALL.Windows.md | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/INSTALL.Wi
On Thu, Feb 5, 2015 at 6:11 PM, Jesse Gross wrote:
> On Thu, Feb 5, 2015 at 6:02 PM, Pravin Shelar wrote:
>> On Thu, Feb 5, 2015 at 1:47 PM, Thomas Graf wrote:
>>> On 02/05/15 at 11:58am, Pravin Shelar wrote:
On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf
wrote:
> I kept it because
On Thu, Feb 5, 2015 at 1:40 PM, Jarno Rajahalme wrote:
> OVS userspace already probes the openvswitch kernel module for
> OVS_ACTION_ATTR_SET_MASKED support. This patch adds the kernel module
> implementation of masked set actions.
>
> The existing set action sets many fields at once. When only
Signed-off-by: Gurucharan Shetty
---
appveyor.yml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/appveyor.yml b/appveyor.yml
index 32a0524..8d0c0d7 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -39,5 +39,5 @@ build_script:
- C:\MinGW\msys\1.0\bin\bash -lc "cp
/c/pthrea
> Guru,
> I have a minor question. Does the yml file you added do testing as well? I
> see there’s a command to run configure and ‘make’ but, does it run tests
> also? You mentioned “build test”. Hence I asked.
I used the term "build test" meaning to say, testing whether the build
works! 'make c
On Thu, Feb 5, 2015 at 3:37 PM, Nithin Raju wrote:
> In a previous commit, support had been added to support building
> the kernel datapath from command line. In this patch, we document
> it.
> ---
> INSTALL.Windows.md | 28 +++-
> 1 files changed, 23 insertions(+), 5 de
On Thu, Feb 5, 2015 at 6:02 PM, Pravin Shelar wrote:
> On Thu, Feb 5, 2015 at 1:47 PM, Thomas Graf wrote:
>> On 02/05/15 at 11:58am, Pravin Shelar wrote:
>>> On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote:
>>> > I kept it because vxlan_sock only holds the receive side flags only
>>> > as mask
On Thu, Feb 5, 2015 at 1:47 PM, Thomas Graf wrote:
> On 02/05/15 at 11:58am, Pravin Shelar wrote:
>> On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote:
>> > I kept it because vxlan_sock only holds the receive side flags only
>> > as masked with VXLAN_F_RCV_FLAGS. GBP is not split into a receive a
On Thu, Feb 05, 2015 at 03:37:09PM -0800, Nithin Raju wrote:
> In a previous commit, support had been added to support building
> the kernel datapath from command line. In this patch, we document
> it.
Guru, will you review this?
___
dev mailing list
dev
> On Feb 5, 2015, at 2:29 PM, Alin Serdean
> wrote:
>
> Ok will update it first things tomorrow.
>
> Thanks,
> Alin.
Alin,
I had been working on this patch when I was trying to respond to:
http://openvswitch.org/pipermail/dev/2015-February/051073.html
Looks like both of us intended to work on
Those are not necessary and makes the test output file harder to read.
Signed-off-by: Andy Zhou
---
tests/kmod-macros.at | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/kmod-macros.at b/tests/kmod-macros.at
index 86f1cef..ee9ba8a 100644
--- a/tests/kmod-macros.at
+++
Improve test failure handling.
Signed-off-by: Andy Zhou
---
tests/kmod-macros.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/kmod-macros.at b/tests/kmod-macros.at
index f3494fc..9ba2aa5 100644
--- a/tests/kmod-macros.at
+++ b/tests/kmod-macros.at
@@ -9,6 +9,7 @@
#
m4_define([OVS_
The ping output can be useful. There is no down side in saving it.
Signed-off-by: Andy Zhou
---
tests/kmod-traffic.at | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kmod-traffic.at b/tests/kmod-traffic.at
index ddb2cb2..bcc4c17 100644
--- a/tests/kmod-traffic.at
+++
Improves test failure handling. Remove name spaces that are no longer
needed so they to linger around before the next test starts.
Signed-off-by: Andy Zhou
---
tests/kmod-traffic.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/kmod-traffic.at b/tests/kmod-traffic.at
index 34e5062..d
Remove namespaces also removes the ports in them, thus may
causing vswitch to generate warning log messages about not being
able find the port before it exits.
Remove namespaces after ovs-vswitchd exits improves test reliability.
Signed-off-by: Andy Zhou
---
tests/kmod-macros.at | 7 ++-
t
This is mostly a style fix. The macro is used in the next patch to
add commands to the 'cleanup" file. This fix makes the 'cleanup' file
easier to read.
Signed-off-by: Andy Zhou
---
tests/kmod-macros.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kmod-macros.at b/te
Those are some small incremental improvements to kernel module autotests, based
on
early user feedbacks.
Andy Zhou (6):
test: remove namespace after ovs-vswitchd is stopped
test: remove unnecessary command lines
test: remove unnecessary leading blanks
test: add name space removal on test
In a previous commit, support had been added to support building
the kernel datapath from command line. In this patch, we document
it.
---
INSTALL.Windows.md | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md
> +AppVeyor (appveyor.com) provides a free Windows autobuild service for
> +opensource projects. Open vSwitch has integration with AppVeyor for
> +continuous build. A developer can build test his changes for Windows by
Guru,
I have a minor question. Does the yml file you added do testing as wel
> On Feb 5, 2015, at 9:56 AM, Gurucharan Shetty wrote:
>
> Windows openssl libraries are distributed through slproweb.
> The maintainer there is very strict about retiring unsafe
> versions of openssl and only lets the latest versions of
> openssl to be downloaded. Instead of updating INSTALL.Win
Ok will update it first things tomorrow.
Thanks,
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet...@nicira.com]
Trimis: Thursday, February 5, 2015 11:38 PM
Către: Alin Serdean
Cc: Ben Pfaff; dev; Gurucharan Shetty
Subiect: Re: [ovs-dev] [PATCH 2/2] appveyor: Provide a autobu
On 02/05/15 at 11:58am, Pravin Shelar wrote:
> On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote:
> > I kept it because vxlan_sock only holds the receive side flags only
> > as masked with VXLAN_F_RCV_FLAGS. GBP is not split into a receive and
> > transmit flag so your suggestion would work for GB
> On Feb 5, 2015, at 11:02 AM, Nithin Raju wrote:
>
>> On Feb 5, 2015, at 11:00 AM, Gurucharan Shetty wrote:
>>
>>> From other discussions, it looks like they are quite prompt in
>>> installing new software.
>> They added WDK 8.1 support today. I will send in the patch for
>> userspace integrat
Looks like user mode does not use pre-compiled headers, but the driver does.
-Original Message-
From: Eitan Eliahu
Sent: Thursday, February 05, 2015 1:39 PM
To: 'Gurucharan Shetty'; Ben Pfaff
Cc: dev; Gurucharan Shetty
Subject: RE: [ovs-dev] [PATCH 2/2] appveyor: Provide a autobuild serv
> * autoconf tests on mingw does not have the infrastructure to be
> executed in parallel. (I think it is because of no mknod. Probably it
> can be worked around, but the fix will likely be needed upstream in
> the code that generates testsuite)
Sorry, I was meaning to say mkfifo instead of mknod
_
Testing on a single CPU machine is problematic (even if it would have run
fast), but the build itself has its own advantage. The driver build should be
much quicker.
Do we use precompiled header option?
https://msdn.microsoft.com/en-us/library/2yzw0wyd.aspx
Thanks,
Eitan
-Original Message-
On 02/05/15 at 10:29am, Pravin Shelar wrote:
> I pushed this patch to master to fix build failure on few kernels.
Thanks
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Feb 5, 2015 at 1:13 PM, Alin Serdean
wrote:
> Nice one Guru.
Thanks!
>
> If you want I can look up to also build for the extension.
>
> I also need to update the documentation for it :).
If you update the documentation for command line build of kernel in
INSTALL.Windows.md, I can look at a
On 02/05/15 at 07:40pm, Bruce Hartpence wrote:
> Good afternoon,
>
> We have a small IEEE project here that runs a competitor to RSTP. We would
> like to try building a module for OVS but are not sure where to start or the
> best way to get involved. Any pointers would be appreciated.
Resources
OVS userspace already probes the openvswitch kernel module for
OVS_ACTION_ATTR_SET_MASKED support. This patch adds the kernel module
implementation of masked set actions.
The existing set action sets many fields at once. When only a subset
of the IP header fields, for example, should be modified
>
> Oh!
>
> Do you have an idea of what takes up the bulk of the time for the OVS
> unit tests in Windows?
I think the main reasons are:
* Creation of new processes is slow on Windows. So some unit tests
that run hundreds of processes causes the unit tests to go very slow
(for e.g., bfd and cfm).
*
Nice one Guru.
If you want I can look up to also build for the extension.
I also need to update the documentation for it :).
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty
Trimis: Thursday, February 5, 2015 10:31 PM
Către: Ben Pfaff
Cc
Thank you all for the feedback.
I will take into account in my next patch series :).
Alin.
-Mesaj original-
De la: Joe Stringer [mailto:joestrin...@nicira.com]
Trimis: Thursday, February 5, 2015 6:33 AM
Către: Ankur Sharma
Cc: Alin Serdean; dev@openvswitch.org
Subiect: Re: [ovs-dev] [PA
Certainly multicore would help, since the build and the tests
parallelize very well; the 1620 tests run in about 41 seconds with -j10
on my laptop, or 344 seconds sequentially, an 8.4x speedup on an
8-thread machine.
On Thu, Feb 05, 2015 at 12:56:12PM -0800, Steven Noble wrote:
> From reading thei
From reading their FAQ it’s 40 minutes for all plans :( They do offer a 50%
discount on plans for non-profits/opensource projects, and the paid plans run
on faster hardware, so there may be value to trying.
> On Feb 5, 2015, at 12:42 PM, Gurucharan Shetty wrote:
>
>>
>> Nice.
>>
>> It doesn
On Thu, Feb 5, 2015 at 11:34 AM, Andy Zhou wrote:
>>
>> I think it should be doable with BPF to have the verifier accept if
>> a helper is called with less args than expected, to initialize those
>> to 0. This would allow for helpers to support additional arguments.
> I am not sure it is fundament
On Thu, Feb 05, 2015 at 12:42:06PM -0800, Gurucharan Shetty wrote:
> >
> > Nice.
> >
> > It doesn't look like it runs the unit tests, is that possible?
> It is possible. Unfortunately the free version times out after 40
> minutes. OVS unit tests in Windows are slow (taking a total of ~35
> min, lea
>
> Nice.
>
> It doesn't look like it runs the unit tests, is that possible?
It is possible. Unfortunately the free version times out after 40
minutes. OVS unit tests in Windows are slow (taking a total of ~35
min, leaving only 5 min for the build.)
___
d
On Thu, Feb 05, 2015 at 12:31:22PM -0800, Gurucharan Shetty wrote:
> >> +AppVeyor (appveyor.com) provides a free Windows autobuild service for
> >> +opensource projects. Open vSwitch has integration with AppVeyor for
> >> +continuous build. A developer can build test his changes for Windows by
>
On Thu, Feb 5, 2015 at 11:16 AM, Andy Zhou wrote:
>>> +bpf/ovs-actions.bpf: $(srcdir)/bpf/ovs-actions.c $(DEP_FILES)
>>> + $(AM_V_GEN)clang -DHAVE_CONFIG_H $(BPF_INCLUDES) $(NOSTDINC_FLAGS) \
>>> + $(AM_CFLAGS) $(EXTRA_CFLAGS) -Wno-unused-value
>>> -Wno-pointer-sign \
>>> +
>> +AppVeyor (appveyor.com) provides a free Windows autobuild service for
>> +opensource projects. Open vSwitch has integration with AppVeyor for
>> +continuous build. A developer can build test his changes for Windows by
>> +logging into appveyor.com using a github account, creating a new projec
On Thu, Feb 5, 2015 at 11:47 AM, Andy Zhou wrote:
> On Thu, Feb 5, 2015 at 6:48 AM, Thomas Graf wrote:
>> On 02/04/15 at 02:48pm, Andy Zhou wrote:
>>> struct bpf_verifier_ops {
>>> /* return eBPF function prototype for verification */
>>> - const struct bpf_func_proto *(*get_func_proto
On Thu, Feb 5, 2015 at 2:37 AM, Thomas Graf wrote:
> On 02/04/15 at 03:17pm, Pravin Shelar wrote:
>> On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote:
>> > +
>> > + flags = TUNNEL_KEY;
>> > + vxlan_port = vxlan_vport(vport);
>> > + if (vxlan_port->exts & VXLAN_F_GBP && md->gbp)
On Thu, Feb 5, 2015 at 6:48 AM, Thomas Graf wrote:
> On 02/04/15 at 02:48pm, Andy Zhou wrote:
>> struct bpf_verifier_ops {
>> /* return eBPF function prototype for verification */
>> - const struct bpf_func_proto *(*get_func_proto)(enum bpf_func_id
>> func_id);
>> + const struct bp
Good afternoon,
We have a small IEEE project here that runs a competitor to RSTP. We would like
to try building a module for OVS but are not sure where to start or the best
way to get involved. Any pointers would be appreciated.
Thanks,
Bruce Hartpence
Associate Professor
Rochester Institute o
On Thu, Feb 5, 2015 at 7:07 AM, Thomas Graf wrote:
> On 02/04/15 at 02:48pm, Andy Zhou wrote:
>> BPF_PROG action allows an action to be implemented in eBPF language and
>> downloaded by the userspace at runtime.
>>
>> Signed-off-by: Andy Zhou
>
> Thanks a lot for putting this together Andy and Jo
On Thu, Feb 5, 2015 at 6:18 AM, Thomas Graf wrote:
> First of all, I *love* this. I have some questions on versioning of
> helpers in the kernel. I will put comments in the respective kernel
> patches directly.
>
Thanks for the feedbacks.
> On 02/04/15 at 02:49pm, Andy Zhou wrote:
>> +EXTRA_DIST +
On Thu, Feb 05, 2015 at 09:56:03AM -0800, Gurucharan Shetty wrote:
> The appveyor.yml file added through this commit lets
> AppVeyor auto build service to run a build of OVS on
> Windows platform.
>
> Signed-off-by: Gurucharan Shetty
This is nice!
> +AppVeyor (appveyor.com) provides a free Wind
Yes. That's the plan.
On Thu, Feb 5, 2015 at 5:44 AM, Thomas Graf wrote:
> On 02/04/15 at 02:49pm, Andy Zhou wrote:
>> The OVS eBPF patch sets are developed against master 'net-next' tree,
>> which is currently targeting for kernel version 3.19.
>>
>> The datapath in OVS mater does not currently
On Thu, Feb 05, 2015 at 09:56:02AM -0800, Gurucharan Shetty wrote:
> Windows openssl libraries are distributed through slproweb.
> The maintainer there is very strict about retiring unsafe
> versions of openssl and only lets the latest versions of
> openssl to be downloaded. Instead of updating INS
> On Feb 5, 2015, at 11:00 AM, Gurucharan Shetty wrote:
>
>> From other discussions, it looks like they are quite prompt in
>> installing new software.
> They added WDK 8.1 support today. I will send in the patch for
> userspace integration. If you help me a bit, I will follow it up with
> a Wind
Windows openssl libraries are distributed through slproweb.
The maintainer there is very strict about retiring unsafe
versions of openssl and only lets the latest versions of
openssl to be downloaded. Instead of updating INSTALL.Windows
everytime there is a change in latest version, leave it to
use
The appveyor.yml file added through this commit lets
AppVeyor auto build service to run a build of OVS on
Windows platform.
Signed-off-by: Gurucharan Shetty
---
INSTALL.Windows.md |9 +
Makefile.am|1 +
appveyor.yml | 43 +++
> From other discussions, it looks like they are quite prompt in
> installing new software.
They added WDK 8.1 support today. I will send in the patch for
userspace integration. If you help me a bit, I will follow it up with
a Windows kernel autobuild too.
__
On Wed, Feb 4, 2015 at 4:58 PM, Daniele Di Proietto <
daniele.di.proie...@gmail.com> wrote:
> Hey Alex,
>
> I remember that calling certain DPDK functions (that we use to
> initialize devices) with '_lcore_id !=0' resulted in an error. If this
> is not the case anymore with DPDK 1.7.1 (i.e. if you
Hey Kevin,
Thanks for the testing,~!
On Thu, Feb 5, 2015 at 10:29 AM, Traynor, Kevin
wrote:
> Hi,
>
> I've done some quick testing on this patch for different values of
> NON_PMD_CORE_ID and it looks to be working fine.
>
> The only issue I've seen is that I'm isolcpus for all cores except core
Hi,
I've done some quick testing on this patch for different values of
NON_PMD_CORE_ID and it looks to be working fine.
The only issue I've seen is that I'm isolcpus for all cores except core 0, so
when I change the NON_PMD_CORE_ID to non-zero, the pmd is being scheduled on
core 0 also and th
On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote:
> Fixes an insufficient ifdef in compat/vxlan.c which caused required
> symbols not to be included in the build. The declarations were properly
> enabled so the build would succeed but the module would spit missing
> symbols when being inserted.
>
Sorry for not remembering about these…
On Dec 10, 2014, at 6:03 PM, Jesse Gross wrote:
> On Tue, Dec 9, 2014 at 4:10 PM, Jarno Rajahalme wrote:
>> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
>> index df3c7f2..276bb60 100644
>> --- a/net/openvswitch/flow_netlink.
On 02/04/15 at 02:48pm, Andy Zhou wrote:
> BPF_PROG action allows an action to be implemented in eBPF language and
> downloaded by the userspace at runtime.
>
> Signed-off-by: Andy Zhou
Thanks a lot for putting this together Andy and Joe and everybody else
who was involved. This is much further
On 02/04/15 at 02:48pm, Andy Zhou wrote:
> struct bpf_verifier_ops {
> /* return eBPF function prototype for verification */
> - const struct bpf_func_proto *(*get_func_proto)(enum bpf_func_id
> func_id);
> + const struct bpf_func_proto *(*get_func_proto)(int func_id);
This change
On 02/04/15 at 02:49pm, Andy Zhou wrote:
> This is a hack in xlate code to always generate both BPF output
> and the original output action. Since the currnet BPF output 'action'
> simply generate a kenrel log message about the output port number.
>
> With this patch, Every time datapath output a
First of all, I *love* this. I have some questions on versioning of
helpers in the kernel. I will put comments in the respective kernel
patches directly.
On 02/04/15 at 02:49pm, Andy Zhou wrote:
> +EXTRA_DIST += $(srcdir)/bpf/ovs-bpf-helpers.h \
> + $(srcdir)/bpf/bpf-shared.h \
> +
On 02/04/15 at 02:49pm, Andy Zhou wrote:
> +struct ovs_action_bpf_prog {
> + __be32 prog_fd;
> + __be32 arg0;
> + __be32 arg1;
> +};
Given the 64 bit registers of BPF. Should we have all args in the
Netlink message be 64 bit as well?
___
dev
2015-02-05 14:16 GMT+03:00 Thomas Graf :
> STT obviously does some abuse but so do other encaps like VXLAN which
> abuse the outer UDP sport to benefit from RSS. It is however very hard
> to argue with the feedback given.
>
As STT have performance benefits to me (i'm use tunnels to transfer traff
On 02/04/15 at 02:49pm, Andy Zhou wrote:
> /**
> + * struct ovs_action_bpf_prog - %OVS_ACTION_ATTR_BPF_PROG action argument.
> + *
> + * XXX provides bpf program id and execution context.
> + *
> + */
> +struct ovs_action_bpf_prog {
> + __be32 prog_fd;
> + __be32 arg0;
> + __be32 arg1
On 02/04/15 at 02:49pm, Andy Zhou wrote:
> The OVS eBPF patch sets are developed against master 'net-next' tree,
> which is currently targeting for kernel version 3.19.
>
> The datapath in OVS mater does not currently support 3.19 kernel.
> But we should not really using OVS datapath, The changes
On 02/03/15 at 11:27am, Pravin Shelar wrote:
> On Tue, Feb 3, 2015 at 10:19 AM, John W. Linville
> wrote:
> > Thanks for doing that research for me! :-) You don't see any way to
> > work with Dave M. around his objections?
> >
> > Violating an "upstream first" policy seems like you are making an "
On 02/04/15 at 03:17pm, Pravin Shelar wrote:
> On Wed, Feb 4, 2015 at 7:45 AM, Thomas Graf wrote:
> > +
> > + flags = TUNNEL_KEY;
> > + vxlan_port = vxlan_vport(vport);
> > + if (vxlan_port->exts & VXLAN_F_GBP && md->gbp)
> > + flags |= TUNNEL_VXLAN_OPT;
> >
> why n
Hi man!
http://rentkievapartment.com/Reese.php?arivumani_gmail_com
...
> 1/2/2015 9:30:00 AM, arivum...@gmail.com wrote:
Worry never robs tomorrow of its sorrow, it only saps today of its joy. -
Leo Buscaglia
___
dev mailing list
dev@openvsw
73 matches
Mail list logo
