First of all, I *love* this. I have some questions on versioning of helpers in the kernel. I will put comments in the respective kernel patches directly.
On 02/04/15 at 02:49pm, Andy Zhou wrote: > +EXTRA_DIST += $(srcdir)/bpf/ovs-bpf-helpers.h \ > + $(srcdir)/bpf/bpf-shared.h \ > + $(srcdir)/bpf/ovs-actions.c > + > +DEP_FILES = $(srcdir)/bpf/ovs-bpf-helpers.h \ > + $(srcdir)/bpf/bpf-shared.h \ > + $(srcdir)/datapath/linux/compat/include/linux/openvswitch.h Some tab / space mixing here. > +bpf/ovs-actions.bpf: $(srcdir)/bpf/ovs-actions.c $(DEP_FILES) > + $(AM_V_GEN)clang -DHAVE_CONFIG_H $(BPF_INCLUDES) $(NOSTDINC_FLAGS) \ > + $(AM_CFLAGS) $(EXTRA_CFLAGS) -Wno-unused-value > -Wno-pointer-sign \ > + -O2 -emit-llvm -c $< -o -| $(LLC) -filetype=obj -o $@ I assume you will convert this to a Makefile template _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
