On Thu, Feb 5, 2015 at 6:18 AM, Thomas Graf <tg...@noironetworks.com> wrote:
> First of all, I *love* this. I have some questions on versioning of
> helpers in the kernel. I will put comments in the respective kernel
> patches directly.
>
Thanks for the feedbacks.
> On 02/04/15 at 02:49pm, Andy Zhou wrote:
>> +EXTRA_DIST += $(srcdir)/bpf/ovs-bpf-helpers.h \
>> + $(srcdir)/bpf/bpf-shared.h \
>> + $(srcdir)/bpf/ovs-actions.c
>> +
>> +DEP_FILES = $(srcdir)/bpf/ovs-bpf-helpers.h \
>> + $(srcdir)/bpf/bpf-shared.h \
>> + $(srcdir)/datapath/linux/compat/include/linux/openvswitch.h
>
> Some tab / space mixing here.
Will fix.
>
>> +bpf/ovs-actions.bpf: $(srcdir)/bpf/ovs-actions.c $(DEP_FILES)
>> + $(AM_V_GEN)clang -DHAVE_CONFIG_H $(BPF_INCLUDES) $(NOSTDINC_FLAGS) \
>> + $(AM_CFLAGS) $(EXTRA_CFLAGS) -Wno-unused-value
>> -Wno-pointer-sign \
>> + -O2 -emit-llvm -c $< -o -| $(LLC) -filetype=obj -o $@
>
> I assume you will convert this to a Makefile template
Yes. It needs to be addressed. Not sure if additional changes are
required now that
BPF backend is merged into LLVM upstream,
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
