[ovs-dev] [PATCH V2] ovs-command-completion: Autotest integration.

2014-12-31 Thread Alex Wang
This commit integrates the unit tests defined in utilities/ovs-command-compgen-test.bash into 'make check'. The tests will be skipped if the current shell is not bash. Signed-off-by: Alex Wang --- PATCH->V2 - use $BASH_VERSION to check if currently running under bash. - convert m4 macros to bash

Re: [ovs-dev] [PATCH 2/2] ovs-command-completion: Autotest integration.

2014-12-31 Thread Alex Wang
Hey Ben, Thx for the review, On Thu, Dec 11, 2014 at 12:07 PM, Ben Pfaff wrote: > > On Tue, Nov 25, 2014 at 06:17:46PM -0800, Alex Wang wrote: > > This commit integrates the unit tests defined in > > utilities/ovs-command-compgen-test.bash into 'make check'. > > The tests will be skipped if the

Re: [ovs-dev] [PATCH 1/2 V5] Linux datapath changes to support 802.1AD

2014-12-31 Thread Pravin Shelar
On Tue, Dec 30, 2014 at 7:12 AM, Thomas F Herbert wrote: > This is the linux kernel datapath portion of the 802.1AD patch. > > > Signed-off-by: Thomas F Herbert > > --- > datapath/actions.c| 32 ++--- > datapath/flow.c | 80 >

Re: [ovs-dev] [PATCH 0/7] Datapath backports to support 3.18.x, net, net-next

2014-12-31 Thread Pravin Shelar
On Tue, Dec 30, 2014 at 1:33 AM, Thomas Graf wrote: > On 12/29/14 at 07:15pm, Pravin Shelar wrote: >> On Mon, Dec 29, 2014 at 4:19 PM, Thomas Graf wrote: >> > This series includes several backports which affect the datapath >> > and brings it closer to upstream. It also allows to build the >> > d

Re: [ovs-dev] [PATCH net] openvswitch: Consistently include VLAN header in flow and port stats.

2014-12-31 Thread Pravin Shelar
On Wed, Dec 31, 2014 at 8:45 AM, Ben Pfaff wrote: > Until now, when VLAN acceleration was in use, the bytes of the VLAN header > were not included in port or flow byte counters. They were however > included when VLAN acceleration was not used. This commit corrects the > inconsistency, by always

Re: [ovs-dev] [PATCH trivial 1/3] odp-util: Reuse standard delimiters.

2014-12-31 Thread Ben Pfaff
On Mon, Dec 15, 2014 at 03:30:03PM -0800, Joe Stringer wrote: > Signed-off-by: Joe Stringer Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2 V5] Linux datapath changes to support 802.1AD

2014-12-31 Thread Flavio Leitner
On Wednesday, December 31, 2014 02:53:27 PM Thomas F Herbert wrote: > Flavio, > > Thanks for your review. I am preparing a version 6 of the patch in which > I will be fixing the issues you pointed out but I am interested in > further guidance in your responses below. > > Thanks, Tom > > > On

Re: [ovs-dev] [PATCH 1/2 V5] Linux datapath changes to support 802.1AD

2014-12-31 Thread Thomas F Herbert
Flavio, Thanks for your review. I am preparing a version 6 of the patch in which I will be fixing the issues you pointed out but I am interested in further guidance in your responses below. Thanks, Tom On 12/30/14, 3:30 PM, Flavio Leitner wrote: On Tuesday, December 30, 2014 10:12:59 AM yo

Re: [ovs-dev] [PATCH v2 3/3] datapath-windows: Add a WFP system provider

2014-12-31 Thread Nithin Raju
On Dec 22, 2014, at 7:06 AM, Sorin Vinturis wrote: > This patch was enforced by the WHCK logo testing. In order to pass the > Windows Filtering Platform tests we need to add a persistent system > provider. > > Signed-off-by: Sorin Vinturis hi Sorin, Sorry the delay in the review. The code m

Re: [ovs-dev] [RFC 0/2] Add support to control Reports forwarding

2014-12-31 Thread Flavio Leitner
On Wednesday, December 31, 2014 08:52:56 AM Ben Pfaff wrote: > On Thu, Dec 11, 2014 at 09:38:17AM -0200, Flavio Leitner wrote: > > The RFC4541 section 2.1.1 item 1 allows the snooping switch > > to provide an administrative control to allow Report messages > > to be flooded to ports not connected t

Re: [ovs-dev] [PATCH net] openvswitch: Consistently include VLAN header in flow and port stats.

2014-12-31 Thread Flavio Leitner
On Wednesday, December 31, 2014 08:45:46 AM Ben Pfaff wrote: > Until now, when VLAN acceleration was in use, the bytes of the VLAN header > were not included in port or flow byte counters. They were however > included when VLAN acceleration was not used. This commit corrects the > inconsistency,

Re: [ovs-dev] [PATCH] vtep: Document rationale for the 'switches' column in the Global table.

2014-12-31 Thread Gurucharan Shetty
On Mon, Dec 1, 2014 at 10:28 AM, Ben Pfaff wrote: > At first glance it wasn't obvious why there was the possibility for more > than one switch. > > Signed-off-by: Ben Pfaff I always imagined in my imagination the possibility of having multiple Physical_Switches records to be do something with a s

Re: [ovs-dev] [PATCH 1/3] datapath-windows: Cleanup OVS

2014-12-31 Thread Ben Pfaff
Thanks for the review, I applied this change. I don't see reviews for patches 2 or 3 yet so I didn't apply them. On Sat, Dec 20, 2014 at 12:07:26AM +, Nithin Raju wrote: > Sorry for the delay. Thanks for making this change. > > Acked-by: Nithin Raju > > On Dec 11, 2014, at 4:51 AM, Sorin V

Re: [ovs-dev] Query while writing test case for Vacancy Events

2014-12-31 Thread Ben Pfaff
I suggest submitting the entire patch when it's ready. I don't feel like reviewing a test case in isolation. On Fri, Dec 12, 2014 at 02:31:29PM +0530, Shashwat Srivastava wrote: > Hi Ben/Team, > > Thanks for the reply. > > We are working on implementation of vacancy events and have developed th

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2014-12-31 Thread Ben Pfaff
On Fri, Dec 26, 2014 at 05:22:42PM +0530, Saloni Jain wrote: > There have been some changes in the ovs-master code, so we have > rebased our eviction patch in accordance to that. > > Please find attached the updated patch for eviction feature, rebased > with the latest ovs-master as on 26 Dec 2014

Re: [ovs-dev] [RFC 0/2] Add support to control Reports forwarding

2014-12-31 Thread Ben Pfaff
On Thu, Dec 11, 2014 at 09:38:17AM -0200, Flavio Leitner wrote: > The RFC4541 section 2.1.1 item 1 allows the snooping switch > to provide an administrative control to allow Report messages > to be flooded to ports not connected to multicast routers. > > This is useful for tunnels and patch ports

Re: [ovs-dev] [PATCH] vtep: Document rationale for the 'switches' column in the Global table.

2014-12-31 Thread Ben Pfaff
This could use a review (it should be easy). On Mon, Dec 01, 2014 at 10:28:43AM -0800, Ben Pfaff wrote: > At first glance it wasn't obvious why there was the possibility for more > than one switch. > > Signed-off-by: Ben Pfaff > --- > vtep/vtep.xml | 17 - > 1 file changed, 16

Re: [ovs-dev] bug in flow stats for VLAN acceleration?

2014-12-31 Thread Ben Pfaff
I sent out a patch that should fix this: http://openvswitch.org/pipermail/dev/2014-December/049972.html It will take some time, probably a few days, for it to get into the kernel and the OVS tree's kernel module. After that, I think you'll be ready to go. (However, the buggy behavior wil

[ovs-dev] [PATCH net] openvswitch: Consistently include VLAN header in flow and port stats.

2014-12-31 Thread Ben Pfaff
Until now, when VLAN acceleration was in use, the bytes of the VLAN header were not included in port or flow byte counters. They were however included when VLAN acceleration was not used. This commit corrects the inconsistency, by always including the VLAN header in byte counters. Previous discu