Hey Ben, Thx for the review,
On Thu, Dec 11, 2014 at 12:07 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Tue, Nov 25, 2014 at 06:17:46PM -0800, Alex Wang wrote: > > This commit integrates the unit tests defined in > > utilities/ovs-command-compgen-test.bash into 'make check'. > > The tests will be skipped if the current shell is not > > '/bin/bash'. > > > > Signed-off-by: Alex Wang <al...@nicira.com> > > Did you consider using one of the bash built-in variables > (e.g. "$BASH_VERSION") to check whether we're running under bash? > Thx for the suggestion, I'll take it~ > This adds a number of m4 macros. Sometimes it's more elegant to define > shell functions instead. Did you think about that? > I see, I thought we prefer to use m4 macros, > I'm not sure that "grep -A 1" and "tail -n+2" are portable in practice. > I'd want to find out whether *BSD support them, at least. > Thx, I checked bsd grep and tail manual, looks to me it support both, I'll run it on my freebsd vm to make sure, > I think that these uses of m4_foreach can be written as shell "for" > statements. If that's so, then it's probably better to write them in > shell because it is easier to read and keeps the generated testsuite a > little smaller (you don't get an extra copy for each variable > substitution). > I see, thanks, will use shell "for" statement. > > Thanks, > > Ben. > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
