I suggest submitting the entire patch when it's ready. I don't feel like reviewing a test case in isolation.
On Fri, Dec 12, 2014 at 02:31:29PM +0530, Shashwat Srivastava wrote: > Hi Ben/Team, > > Thanks for the reply. > > We are working on implementation of vacancy events and have developed the > module for same. > > As suggested, we have made a separate test case for [ofproto - > asynchronous message control (OpenFlow 1.4)]. > > The commands (ovs-ofctl ofp-print > 051F00180000000004000000000000000008000000000008) works for us, as we have > introduced the code for TABLE_STATUS message. > > We are getting the following output with the above mentioned command: > > OFPT_TABLE_STATUS (OF1.4) (xid=0x0): VACANCY_UP: config: Vacancy > table_id: 0 current vacancy: 4 vacancy up: 248 vacancy down: 216 > > Can you please review this output and suggest is the hex string correct? > > We have attached the full test case for your reference. > > And after running this test case our monitor.log file comes out as empty. > Can you please have a look and provide us your input. > > > Thanks in advance. > > Regards > Shashwat Srivastava > > > > > From: Ben Pfaff <b...@nicira.com> > To: Shashwat Srivastava <shashwat.srivast...@tcs.com> > Cc: d...@openvswitch.com > Date: 12/12/2014 08:42 AM > Subject: Re: Query while writing test case for Vacancy Events > > > > On Thu, Dec 11, 2014 at 04:35:28PM +0530, Shashwat Srivastava wrote: > > Query 1: Will the testcase for table status messages (where vacancy > reason > > value can be OFPTR_VACANCY_UP or OFPTR_VACANCY_DOWN) be written in > > [ofproto - asynchronous message control (OpenFlow 1.5)] block or shall > we > > make a new block for OpenFlow1.4 async messages for table Status async > > messages ? > > I suggest adding a new test case, since OF1.4 and OF1.5 are somewhat > different. > > > Query 2: Is the hex-string used > > (061F00180000000003000000000000000008000000000000) correct for > > OFPTR_VACANCY_UP reason for table_status_messages ? > > You can use "ovs-ofctl ofp-print" to print the contents of an OpenFlow > hexstring if you are unsure. In this case: > > $ utilities/ovs-ofctl ofp-print > 061F00180000000003000000000000000008000000000000 > 2014-12-12T03:08:01Z|00001|ofp_msgs|WARN|unknown OpenFlow message > (version 6, type 31) > ***decode error: OFPBRC_BAD_TYPE*** > 00000000 06 1f 00 18 00 00 00 00-03 00 00 00 00 00 00 00 > |................| > 00000010 00 08 00 00 00 00 00 00- |........ > | > > > Query 3: While running the testcase it fails at check_async 2. Why does > it > > fails in check_async 2 if our changes are only in check_async 3 ? > > Also here the monitor.log file contains TABLE_STATUS message along with > > PORT_STATUS messages. Whereas it should contain only PORT_STATUS > messages. > > It sounds like you wrote or modified a testcase, but I don't think I've > seen your code so I don't feel comfortable speculating on why the > testcase doesn't pass. > > =====-----=====-----===== > Notice: The information contained in this e-mail > message and/or attachments to it may contain > confidential or privileged information. If you are > not the intended recipient, any dissemination, use, > review, distribution, printing or copying of the > information contained in this e-mail message > and/or attachments to it are strictly prohibited. If > you have received this communication in error, > please notify us by reply e-mail or telephone and > immediately and permanently delete the message > and any attachments. Thank you > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
