Hi Nithin,
The callout is not deleted after the session to the engine is closed, i.e.
FwpmEngineClose. As you can see, the engine handle is not necessary for
unregistering the callout. So it's OK to unregister the callout after the
engine session is closed.
Thanks,
Sorin
-Original Message
net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR
on line 189
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccin
> Hey Yamamoto,
>
> Thx for the fix, so sorry for not being careful about this...
>
> Acked-by: Alex Wang
thank you. applied.
YAMAMOTO Takashi
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Dec 23, 2014 at 7:53 PM, Pravin Shelar wrote:
> On Mon, Dec 22, 2014 at 8:32 PM, Jesse Gross wrote:
>> On Mon, Dec 22, 2014 at 6:24 PM, Pravin B Shelar wrote:
>>> Today vport-send has complex error handling because it involves
>>> freeing skb and updating stats depending on return value
Hey Yamamoto,
Thx for the fix, so sorry for not being careful about this...
Acked-by: Alex Wang
Thanks,
Alex Wang,
On Tue, Dec 23, 2014 at 7:00 PM, YAMAMOTO Takashi
wrote:
> Introduced by commit f9038ef61e0bf89bcd753b7cfd187adb112601ec.
> ("recirculation: Map recirc_id to ofproto_dpif.")
>
>
When 'ovs-appctl revalidator/purge' is called, the main thread
sweeps and destroys all ukeys and the associated datapath flows.
If, at the same time, revalidators are dumping those flows from
datapath, the ukey lookup of dumped flows could fail due to
deletion by main thread. This race will also c
Introduced by commit f9038ef61e0bf89bcd753b7cfd187adb112601ec.
("recirculation: Map recirc_id to ofproto_dpif.")
Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 43bde
Thx applied to master and branch-2.3
On Tue, Dec 23, 2014 at 3:17 PM, Andy Zhou wrote:
> Thanks for making the change.
>
> Acked-by: Andy Zhou
>
> On Tue, Dec 23, 2014 at 2:21 PM, Alex Wang wrote:
> > Issues a ERR log when the 'recirc_id' is not freed by the
> > owning 'ofproto'.
> >
> > Sign
On Mon, Dec 22, 2014 at 8:32 PM, Jesse Gross wrote:
> On Mon, Dec 22, 2014 at 6:24 PM, Pravin B Shelar wrote:
>> Today vport-send has complex error handling because it involves
>> freeing skb and updating stats depending on return value from
>> vport send implementation.
>> This can be simplified
There are two possible reasons for the ‘test atomic operations’ to hang: If
compiling without real atomic support, OVS is using pthread locks to implement
atomics, which is very slow. In this case, the test does not really hang, but
takes a long time to finish. If it really hangs, the compiler a
I see this same error, Stephen -- the test gets caught in an infinite while
loop where the atomic reader waits for an atomic writer that is not running
(maybe terminated or failed to spawn). I see the error when building on Ubuntu
14.10 and CentOS 7. I do not see it on CentOS 6.6.
I also se
This patch adds set-field operations for nd_target, nd_sll, and nd_tll fields,
with and without masks, using Nicira extensions and OpenFlow 1.2 protocol.
This version defines protocol structures in packets.h to support messages
aligned on 16-bit boundaries. It eliminates the clang alignment war
Thanks for making the change.
Acked-by: Andy Zhou
On Tue, Dec 23, 2014 at 2:21 PM, Alex Wang wrote:
> Issues a ERR log when the 'recirc_id' is not freed by the
> owning 'ofproto'.
>
> Signed-off-by: Alex Wang
> ---
> ofproto/ofproto-dpif.c |7 +++
> 1 file changed, 7 insertions(+)
>
On 23 December 2014 at 03:12, Fabio Fantoni wrote:
> For have it working I had to do "service networking restart".
> I found probably final solution applying also this patch:
> http://git.openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9a8b5cc1a3d941c0e33f3f5b5ac260a35a8130af
> Eve
Issues a ERR log when the 'recirc_id' is not freed by the
owning 'ofproto'.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index cdd302a..b5fe73f 100644
--- a/ofproto/ofproto-dpif.c
On Tue, Dec 23, 2014 at 10:15 AM, Joe Stringer
wrote:
> I welcome any fix this improves the intermittent testsuite failures :D
>
> On 23 December 2014 at 09:03, Alex Wang wrote:
> > This commit fixes the intermittent failure of test (ofproto-dpif,
> > balance-tcp bonding, different recirc flow),
hi Sorin,
Thanks for making the change.
I had a couple of minor comments.
> @@ -288,12 +346,13 @@ Exit:
> VOID
> OvsTunnelUnregisterCallouts(VOID)
> {
> +OvsTunnelRemoveFilter(&OVS_TUNNEL_FILTER_KEY,
> + &OVS_TUNNEL_SUBLAYER);
> FwpmEngineClose(gEngineHandle);
>
Got an offline ACK from Ethan,
Applied to patch to branch-2.3
On Tue, Dec 23, 2014 at 10:42 AM, Alex Wang wrote:
> After commit 0c7812e5e (recirculation: Do not drop packet when
> there is no match from internal table.), if flow keys are modified
> before the recirculation action (e.g. set vlan
Got an offline Ack from Ethan, applied to master,
On Tue, Dec 23, 2014 at 10:30 AM, Alex Wang wrote:
> This commit RCU postpones the free of 'struct dpif_backer_recirc_node',
> after it is removed from the cmap. This is in that other threads may
> be accessing the struct at the same time.
>
> S
After commit 0c7812e5e (recirculation: Do not drop packet when
there is no match from internal table.), if flow keys are modified
before the recirculation action (e.g. set vlan ID), the miss
handling of recirc'ed packets may not reach the intended
'ofproto_dpif' which has rules looking up the 'reci
This commit RCU postpones the free of 'struct dpif_backer_recirc_node',
after it is removed from the cmap. This is in that other threads may
be accessing the struct at the same time.
Signed-off-by: Alex Wang
---
ofproto/ofproto-dpif.c | 11 +--
1 file changed, 9 insertions(+), 2 delet
I welcome any fix this improves the intermittent testsuite failures :D
On 23 December 2014 at 09:03, Alex Wang wrote:
> This commit fixes the intermittent failure of test (ofproto-dpif,
> balance-tcp bonding, different recirc flow), by waiting for all
> bond interfaces to be enabled, and by waiti
This commit fixes the intermittent failure of test (ofproto-dpif,
balance-tcp bonding, different recirc flow), by waiting for all
bond interfaces to be enabled, and by waiting for datapath flow
installation finish before purging it.
Signed-off-by: Alex Wang
---
tests/ofproto-dpif.at |5 +
>
> I tried 2.3.0+git20140819-3 building it in wheezy with kernel 3.16 from
> backports but bridge of my test was still not working:
>>
>> auto xenbr0
>> allow-ovs xenbr0
>> iface xenbr0 inet static
>>address 192.168.1.90
>> netmask 255.255.255.0
>> network 192.168.1.0
>>
Il 19/12/2014 17:04, Simon Horman ha scritto:
On Fri, Dec 19, 2014 at 11:43:42PM +0800, Thomas Goirand wrote:
On 12/19/2014 11:32 PM, Thomas Goirand wrote:
On 12/19/2014 10:25 PM, Simon Horman wrote:
On Fri, Dec 19, 2014 at 06:39:39PM +0800, Thomas Goirand wrote:
On 12/19/2014 11:50 AM, Simon
25 matches
Mail list logo
