Hi Ben,
>"git am" tells me "fatal: corrupt patch at line 21". Please try to send
>the patch to yourself; if you can apply it with "git am", then send it
>the same way to the mailing list.
"[PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance" sent
on Nov 5,2014 has been succ
On Thu, Nov 6, 2014 at 12:21 PM, Lori Jakab wrote:
> On 11/6/14 4:06 AM, Pravin Shelar wrote:
>
> +static int push_eth(struct sk_buff *skb, const struct
> ovs_action_push_eth *ethh)
> +{
> + /* De-accelerate any hardware accelerated VLAN tag added to a
> previous
On Thu, Nov 06, 2014 at 03:01:23PM -0800, Ben Pfaff wrote:
> On Wed, Nov 05, 2014 at 01:57:39PM +0900, Simon Horman wrote:
> > parse_ofp_group_mod_str() may limit the usable protocols according
> > to the group and in particular its actions. However, without this
> > change ovs-ofctl ignores this c
On Fri, Oct 31, 2014 at 04:08:49PM -0700, Ben Pfaff wrote:
> It looks like branch-2.1 and branch-2.0 need commit 5469535090
> "lib/odp-util: Do not use mask if it doesn't exist." Any objection?
> (It's possible, though I think it is unlikely, that this fixes the bug
> that Duncan reported.)
Jarno
My patch review backlog is empty, so if you think I should have reviewed
a patch of yours, let me know.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Nov 05, 2014 at 06:33:22PM +0530, Saloni Jain wrote:
> From: Saloni Jain
>
> This commit enables the eviction mechanism on the basis of importance as
> per the openflow specification 1.4.
>
> ovs-ofctl -O OpenFlow14 mod-table evict
> Enable eviction on of . Eviction adds a mecha
On Wed, Nov 05, 2014 at 03:05:51PM +0530, Rishi Bamba wrote:
> From: rishibamba
>
> This patch enables a user to set importance for a new rule via add-flow
> OF1.4+ in the OVS and display the same via dump-flows command OF1.4+ .
> The changes are made in accordance with OpenFlow 1.4 specs to impl
On Wed, Nov 05, 2014 at 10:37:18AM -0800, Jarno Rajahalme wrote:
> Ethernet frames may contain padding after the IP payload. When
> parsing IP packets, check the IP total size (IPv4) or IP payload size
> (IPv6) to detect the size of l2 padding. The l2 padding size is
> stored in the ofpbuf to pre
On Wed, Nov 05, 2014 at 02:48:43PM -0800, Jarno Rajahalme wrote:
> Keep knowledge about ofproto-dpif internal rules within ofproto-dpif.
> This removes duplication of code (accross multiple files), and allows
> making the ofproto-dpif-xlate interface a bit smaller.
>
> 'may_packet_in' was previous
On Nov 6, 2014, at 3:32 PM, Ben Pfaff wrote:
> On Wed, Nov 05, 2014 at 02:48:41PM -0800, Jarno Rajahalme wrote:
>> Move the frags handling check up in the call chain, so that it is done
>> once for each rule_dpif_lookup_from_table() call.
>>
>> Signed-off-by: Jarno Rajahalme
>
> rule_dpif_loo
On Thu, Nov 06, 2014 at 03:40:32PM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 3:05 PM, Ben Pfaff wrote:
>
> > On Wed, Nov 05, 2014 at 10:37:18AM -0800, Jarno Rajahalme wrote:
> >> Ethernet frames may contain padding after the IP payload. When
> >> parsing IP packets, check the IP tota
On Nov 6, 2014, at 3:05 PM, Ben Pfaff wrote:
> On Wed, Nov 05, 2014 at 10:37:18AM -0800, Jarno Rajahalme wrote:
>> Ethernet frames may contain padding after the IP payload. When
>> parsing IP packets, check the IP total size (IPv4) or IP payload size
>> (IPv6) to detect the size of l2 padding.
On Wed, Nov 05, 2014 at 02:48:42PM -0800, Jarno Rajahalme wrote:
> It it no longer used, so better remove it.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Nov 05, 2014 at 02:48:41PM -0800, Jarno Rajahalme wrote:
> Move the frags handling check up in the call chain, so that it is done
> once for each rule_dpif_lookup_from_table() call.
>
> Signed-off-by: Jarno Rajahalme
rule_dpif_lookup_from_table() is close to the point where it would be
c
On Wed, Nov 05, 2014 at 10:37:19AM -0800, Jarno Rajahalme wrote:
> Packets with 'LATER' fragment do not have a transport header, so it is
> not possible to either match on or set transport ports on such
> packets. Matching is prevented by augmenting mf_are_prereqs_ok() with
> a nw_frag 'LATER' bit
On Wed, Nov 05, 2014 at 12:12:03PM -0800, Ankur Sharma wrote:
> Signed-off-by: Ankur Sharma
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Nov 6, 2014, at 11:28 AM, Ben Pfaff wrote:
> On Mon, Nov 03, 2014 at 11:39:03AM -0800, Jarno Rajahalme wrote:
>> Add asserts to make sure the containers within are already empty.
>>
>> Signed-off-by: Jarno Rajahalme
>
> Acked-by: Ben Pfaff
Pushed, thanks!
Jarno
__
On Nov 6, 2014, at 11:25 AM, Ben Pfaff wrote:
> On Mon, Nov 03, 2014 at 11:39:02AM -0800, Jarno Rajahalme wrote:
>> Some struct cls_match and cls_subtable fields were already documented
>> of being const. Make them const and use CONST_CAST where appropriate
>> to initialize them.
>>
>> This wi
Updated the commit message according to your comment and pushed to master,
thanks for the review!
Jarno
On Nov 6, 2014, at 11:24 AM, Ben Pfaff wrote:
> On Mon, Nov 03, 2014 at 11:39:01AM -0800, Jarno Rajahalme wrote:
>> struct cls_match 'list' member was recently changed to an rculist.
>> Th
On Wed, Nov 05, 2014 at 10:37:18AM -0800, Jarno Rajahalme wrote:
> Ethernet frames may contain padding after the IP payload. When
> parsing IP packets, check the IP total size (IPv4) or IP payload size
> (IPv6) to detect the size of l2 padding. The l2 padding size is
> stored in the ofpbuf to pre
Thanks for the review!
Pushed with the change that classifier_remove takes a const struct cls_rule
pointer as an argument.
Jarno
On Nov 6, 2014, at 11:58 AM, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 11:29:26AM -0800, Jarno Rajahalme wrote:
>>
>> On Nov 6, 2014, at 11:08 AM, Ben Pfaff wr
On Wed, Nov 05, 2014 at 01:57:39PM +0900, Simon Horman wrote:
> parse_ofp_group_mod_str() may limit the usable protocols according
> to the group and in particular its actions. However, without this
> change ovs-ofctl ignores this calculation.
>
> Signed-off-by: Simon Horman
It looks useful, but
ovs-vsctl has the concept of a VLAN (or "fake") bridge, which is a
sort of a sub-bridge that receives only packets on a particular VLAN.
There is no way to distinguish two VLAN bridges with the same parent on the
same VLAN, but until now ovs-vsctl did not prevent creating duplicates or
report them.
On Nov 6, 2014, at 1:40 PM, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 01:16:39PM -0800, Jarno Rajahalme wrote:
>>
>> On Nov 6, 2014, at 12:28 PM, Ben Pfaff wrote:
>>
>>> On Thu, Nov 06, 2014 at 10:50:09AM -0800, Jarno Rajahalme wrote:
With notes below:
Acked-by: Jarno Rajahal
On Thu, Nov 06, 2014 at 01:04:39PM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 12:34 PM, Ben Pfaff wrote:
>
> > On Mon, Nov 03, 2014 at 11:39:04AM -0800, Jarno Rajahalme wrote:
> >> Previously, accurate iteration required writers to be excluded during
> >> iteration. This patch adds an
On Thu, Nov 06, 2014 at 04:50:06PM -0200, Flavio Leitner wrote:
> The tunnel port is invisible to the OS, so there is
> no reason to call OTHERSCRIPT in the ifup/ifdown scripts.
>
> Signed-off-by: Flavio Leitner
Applied, thanks! Also backported to branch-2.3.
___
On Thu, Nov 06, 2014 at 04:45:18PM -0200, Flavio Leitner wrote:
> This patchset updates the fedora spec file to be
> compliant with the distro guidelines and includes
> some fixes as well.
I can tell when I'm outclassed ;-)
Applied.
___
dev mailing list
Thanks! Applied.
On Thu, Nov 06, 2014 at 01:20:41PM -0800, Andy Zhou wrote:
> I am in the process adding a new action. The steps described are good
> starting points. Thanks for documenting them.
>
> Acked-by: Andy Zhou
>
>
> On Tue, Nov 4, 2014 at 10:59 AM, Ben Pfaff wrote:
> > We get thes
On Thu, Nov 06, 2014 at 01:09:20PM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 12:21 PM, Ben Pfaff wrote:
>
> > The classifier has an internal mutex, but in ofproto that mutex is
> > redundant with the external ofproto_mutex. If the classifier mutex were
> > removed, to be replaced by
On Thu, Nov 06, 2014 at 01:16:39PM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 12:28 PM, Ben Pfaff wrote:
>
> > On Thu, Nov 06, 2014 at 10:50:09AM -0800, Jarno Rajahalme wrote:
> >> With notes below:
> >>
> >> Acked-by: Jarno Rajahalme
> >>
> >> On Nov 6, 2014, at 10:03 AM, Ben Pfaff
I am in the process adding a new action. The steps described are good
starting points. Thanks for documenting them.
Acked-by: Andy Zhou
On Tue, Nov 4, 2014 at 10:59 AM, Ben Pfaff wrote:
> We get these questions from time to time and it would be nice to just be
> able to cut and paste the answ
On Nov 6, 2014, at 12:28 PM, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 10:50:09AM -0800, Jarno Rajahalme wrote:
>> With notes below:
>>
>> Acked-by: Jarno Rajahalme
>>
>> On Nov 6, 2014, at 10:03 AM, Ben Pfaff wrote:
>>
>>> Inserting or removing a sequence of flows with different wildcard
On Nov 6, 2014, at 12:21 PM, Ben Pfaff wrote:
> The classifier has an internal mutex, but in ofproto that mutex is
> redundant with the external ofproto_mutex. If the classifier mutex were
> removed, to be replaced by documentation that certain routines need
> mutual exclusion, then possibly th
On Nov 6, 2014, at 12:34 PM, Ben Pfaff wrote:
> On Mon, Nov 03, 2014 at 11:39:04AM -0800, Jarno Rajahalme wrote:
>> Previously, accurate iteration required writers to be excluded during
>> iteration. This patch adds an rculist to struct cls_subtable, and a
>> corresponding list node to struct c
On Mon, Nov 03, 2014 at 11:39:04AM -0800, Jarno Rajahalme wrote:
> Previously, accurate iteration required writers to be excluded during
> iteration. This patch adds an rculist to struct cls_subtable, and a
> corresponding list node to struct cls_rule, which makes iteration more
> straightforward,
On Thu, Nov 06, 2014 at 10:50:09AM -0800, Jarno Rajahalme wrote:
> With notes below:
>
> Acked-by: Jarno Rajahalme
>
> On Nov 6, 2014, at 10:03 AM, Ben Pfaff wrote:
>
> > Inserting or removing a sequence of flows with different wildcard patterns
> > causes temporary use of O(n**2) memory due t
On 11/6/14 7:17 PM, Pravin Shelar wrote:
On Thu, Nov 6, 2014 at 7:53 AM, Jesse Gross wrote:
On Wed, Nov 5, 2014 at 6:06 PM, Pravin Shelar wrote:
On Wed, Nov 5, 2014 at 10:19 AM, Lori Jakab wrote:
On 11/5/14 12:16 AM, Pravin Shelar wrote:
On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
On 11/6/14 4:06 AM, Pravin Shelar wrote:
+static int push_eth(struct sk_buff *skb, const struct
ovs_action_push_eth *ethh)
+{
+ /* De-accelerate any hardware accelerated VLAN tag added to a
previous
+* Ethernet header */
+ if (unlikely(vlan_tx_tag_present(skb))) {
+
The classifier has an internal mutex, but in ofproto that mutex is
redundant with the external ofproto_mutex. If the classifier mutex were
removed, to be replaced by documentation that certain routines need
mutual exclusion, then possibly the reduced locking could yield a
performance improvement.
On Thu, Nov 06, 2014 at 11:34:41AM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 10:50 AM, Jarno Rajahalme wrote:
>
> >> +for i in `seq 1 5`; do echo "reg0=$i/$i actions=drop"; done > flows
>
> Running this test case alone with ‘time’ added to the preceding line:
>
> real 1m12.531s
On Thu, Nov 06, 2014 at 11:29:26AM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 11:08 AM, Ben Pfaff wrote:
>
> > On Thu, Nov 06, 2014 at 11:06:59AM -0800, Ben Pfaff wrote:
> >> On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
> >>> On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarn
On Nov 6, 2014, at 10:50 AM, Jarno Rajahalme wrote:
>> +for i in `seq 1 5`; do echo "reg0=$i/$i actions=drop"; done > flows
Running this test case alone with ‘time’ added to the preceding line:
real1m12.531s
user0m2.492s
sys 0m6.928s
>> +AT_CHECK([ovs-ofctl diff-flows flows fl
On Mon, Nov 03, 2014 at 11:39:03AM -0800, Jarno Rajahalme wrote:
> Add asserts to make sure the containers within are already empty.
>
> Signed-off-by: Jarno Rajahalme
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org
On Nov 6, 2014, at 11:08 AM, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 11:06:59AM -0800, Ben Pfaff wrote:
>> On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
>>> On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
Returning const struct cls_rule pointers from the cla
On Mon, Nov 03, 2014 at 11:39:02AM -0800, Jarno Rajahalme wrote:
> Some struct cls_match and cls_subtable fields were already documented
> of being const. Make them const and use CONST_CAST where appropriate
> to initialize them.
>
> This will help catch future errors modifying those fields after
On Mon, Nov 03, 2014 at 11:39:01AM -0800, Jarno Rajahalme wrote:
> struct cls_match 'list' member was recently changed to an rculist.
> This allows classifier_find_rule_exactly() to be made lockless.
>
> Since subtable's 'max_priority' member would still require a lock, we
> no longer check it bef
On Thu, Nov 06, 2014 at 11:06:59AM -0800, Ben Pfaff wrote:
> On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
> > On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
> > > Returning const struct cls_rule pointers from the classifier API helps
> > > callers to remember that th
On Thu, Nov 06, 2014 at 11:02:56AM -0800, Ben Pfaff wrote:
> On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
> > Returning const struct cls_rule pointers from the classifier API helps
> > callers to remember that they should not modify the rules returned.
> >
> > Signed-off-by: Ja
On Thu, Nov 06, 2014 at 10:57:13AM -0800, Ben Pfaff wrote:
> From: Madhu Challa
>
> Remove hard coded array index and make it dependent on the array size.
>
> Signed-off-by: Madhu Challa
> Co-authored-by: Ben Pfaff
> Signed-off-by: Ben Pfaff
Madhu looked at this, so I applied it.
Thanks,
B
On Mon, Nov 03, 2014 at 11:39:00AM -0800, Jarno Rajahalme wrote:
> Returning const struct cls_rule pointers from the classifier API helps
> callers to remember that they should not modify the rules returned.
>
> Signed-off-by: Jarno Rajahalme
I don't think it has much practical effect since most
Thanks.
On Tue, Nov 04, 2014 at 06:45:02PM -0700, Scott Mann wrote:
> Ben,
> Yes, I will. But it will likely be this weekend before I am able to do that
> (in traveling).
> Scott
>
> On Nov 4, 2014 3:51 PM, "Ben Pfaff" wrote:
> >
> > On Wed, Oct 29, 2014 at 02:55:39PM -0600, Scott Mann wrote:
>
From: Madhu Challa
Remove hard coded array index and make it dependent on the array size.
Signed-off-by: Madhu Challa
Co-authored-by: Ben Pfaff
Signed-off-by: Ben Pfaff
---
lib/learn.c | 6 --
lib/meta-flow.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/
The DB initialization is done by ovs-ctl script as well,
so remove the duplicated code from the spec.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 13 -
1 file changed, 13 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec
The tunnel port is invisible to the OS, so there is
no reason to call OTHERSCRIPT in the ifup/ifdown scripts.
Signed-off-by: Flavio Leitner
---
rhel/etc_sysconfig_network-scripts_ifdown-ovs | 4 ++--
rhel/etc_sysconfig_network-scripts_ifup-ovs | 1 -
2 files changed, 2 insertions(+), 3 deletio
The systemd requires some actions when the package is
installed, upgraded or removed. This patch adds the
needed RPM sections with the missing systemd actions.
There is a change in behavior - the service is not enabled
or started by default.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fe
Move the sysconfig template close to other systemd lines.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 6e169b4..67b7ca9 100644
-
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index a51365d..6e169b4 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/o
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index b48e971..a51365d 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openv
Use empty lines to split blocks to improve readability.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 11 +++
1 file changed, 11 insertions(+)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 1d81567..b48e971 100644
--- a/rhel/op
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 96b808e..080a460 100644
--- a/rhel/openvswitch-fedora.spec.in
Use spaces instead of tabs as the other lines
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 080a460..1d73435 100644
--- a/rhel/ope
Don't overwrite if the logrotate configuration
file is modified.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 8ccfc2c..96b808e 100644
-
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index daa5d73..8ccfc2c 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitc
The default tarball directory follows the standard.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 456e5d5..03bf0b2 100644
--- a/rhel/ope
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 6d0aca4..daa5d73 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index f1f283c..6d0aca4 100644
--- a/rhel/openvswitch-fedora.spec
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index a75175a..c97d0ef 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedo
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 37 -
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 3834339..a75175a 100644
--- a/rhel/openvswitch-fedo
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index b226218..456e5d5 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora
Once upon a time there was a controller subpackage
that was obsoleted
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 401698d..b226218 100644
--- a/rhel/o
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index c97d0ef..f1f283c 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitc
Both conf.db and system-id.conf needs to be owned, so
spec now list them in the %files section. However,
they are not shipped with the rpm (%ghost)
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/r
This provides static library, libopenswitch.a and the openvswitch
header files needed to build an external application in a separate
RPM package.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 30 --
1 file changed, 28 insertions(+), 2 deletions(-
Package guidelines request to enable PIE.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 9dc607c..401698d 100644
--- a/rhel/openvswitch-fedora.spec.in
Put the utilities that are useful to diagnose performance
and connectivity issues in Open vSwitch setup into another
package since they are not needed in most cases.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 27 ---
1 file changed, 20 insertions(
This creates a subpackage called python-openvswitch
providing python bidings for the Open vSwitch database.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 55 +
1 file changed, 17 insertions(+), 38 deletions(-)
diff --git a/rhel/openv
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index db62455..3e19c91 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 26d4b37..db62455 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora
The minimum recommended kernel for fedora is
3.15.0-0 due to be the first one including the
upstream kernel commit below:
commit 4f647e0a3c37b8d5086214128614a136064110c3
Author: Flavio Leitner
Date: Thu Mar 27 11:05:34 2014 -0300
openvswitch: fix a possible deadlock and lockdep warning
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 42a816e..0413cf1 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora
This is needed to ensure all the packages are
installed on the system to be able to build
Open vSwitch.
This also permits to use yum-builddep(1) to
automatically install the dependencies on the
system.
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 6 ++
1 file changed,
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 1ee08fc..776cfbf 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index d036acb..1ee08fc 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -26,7
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index dd61449..d036acb 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -27,7
This patchset updates the fedora spec file to be
compliant with the distro guidelines and includes
some fixes as well.
Flavio Leitner (33):
fedora.spec: added license details
fedora-spec: use default buildroot
fedora-spec: remove stale comment
fedora-spec: source line points to upstream ta
Signed-off-by: Flavio Leitner
---
rhel/openvswitch-fedora.spec.in | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 0a1fe00..dd61449 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch
With notes below:
Acked-by: Jarno Rajahalme
On Nov 6, 2014, at 10:03 AM, Ben Pfaff wrote:
> Inserting or removing a sequence of flows with different wildcard patterns
> causes temporary use of O(n**2) memory due to pvector modifications inside
> the classifier. This commit fixes the problem i
On Thu, Nov 06, 2014 at 10:33:54AM -0800, Ben Pfaff wrote:
> On Wed, Nov 05, 2014 at 09:57:25PM -0200, Flavio Leitner wrote:
> > On Wed, Nov 05, 2014 at 03:51:30PM -0800, Andy Zhou wrote:
> > > On Wed, Nov 5, 2014 at 3:47 PM, Flavio Leitner wrote:
> > > > On Wed, Nov 05, 2014 at 03:23:24PM -0800,
On Thu, Nov 06, 2014 at 09:36:19AM -0800, Pravin Shelar wrote:
> On Wed, Nov 5, 2014 at 4:44 PM, Ben Pfaff wrote:
> > On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote:
> > I don't understand why struct udp_header is now marked as packed, or
> > why struct gre_base_hdr is marked as a
On Wed, Nov 05, 2014 at 09:57:25PM -0200, Flavio Leitner wrote:
> On Wed, Nov 05, 2014 at 03:51:30PM -0800, Andy Zhou wrote:
> > On Wed, Nov 5, 2014 at 3:47 PM, Flavio Leitner wrote:
> > > On Wed, Nov 05, 2014 at 03:23:24PM -0800, Andy Zhou wrote:
> > >> On Wed, Nov 5, 2014 at 2:56 PM, Flavio Leit
On Thu, Nov 06, 2014 at 10:19:14AM -0800, Jarno Rajahalme wrote:
> On Nov 6, 2014, at 9:36 AM, Pravin Shelar wrote:
> >> I think that all of the flows added to the tnl-ports classifier have
> >> the same wildcard pattern. I don't know why a classifier is the best
> >> choice; wouldn't an hmap wor
On Nov 6, 2014, at 9:36 AM, Pravin Shelar wrote:
>> I think that all of the flows added to the tnl-ports classifier have
>> the same wildcard pattern. I don't know why a classifier is the best
>> choice; wouldn't an hmap work?
>>
The lookup should be RCU, so hmap would not work. cmap would th
Inserting or removing a sequence of flows with different wildcard patterns
causes temporary use of O(n**2) memory due to pvector modifications inside
the classifier. This commit fixes the problem in two easy cases. There
is at least one more difficult case inside ovs-vswitchd that this does not
f
On Wed, Nov 5, 2014 at 4:44 PM, Ben Pfaff wrote:
> On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote:
>> Following patch adds support for userspace tunneling. Tunneling
>> needs three more component first is routing table which is configured by
>> caching kernel routes and second is
Thanks for testing, I'll review this and check out the dummy test case.
Jarno
> On Nov 6, 2014, at 7:30 AM, Daniele Venturino
> wrote:
>
> Hi.
> We tested the RSTP implementation against the IXIA IxANVL validation software.
> This allowed us to fix some small bugs, and the implementation no
On Thu, Nov 6, 2014 at 7:53 AM, Jesse Gross wrote:
> On Wed, Nov 5, 2014 at 6:06 PM, Pravin Shelar wrote:
>> On Wed, Nov 5, 2014 at 10:19 AM, Lori Jakab wrote:
>>> On 11/5/14 12:16 AM, Pravin Shelar wrote:
On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
> +static int pop_eth(struct
On Wed, Nov 5, 2014 at 6:06 PM, Pravin Shelar wrote:
> On Wed, Nov 5, 2014 at 10:19 AM, Lori Jakab wrote:
>> On 11/5/14 12:16 AM, Pravin Shelar wrote:
>>> On Mon, Nov 3, 2014 at 1:36 PM, Lorand Jakab wrote:
+static int pop_eth(struct sk_buff *skb)
+{
+ skb_pull_rcsum(skb, ET
All MAC addresses previously learned on a Root Port can be moved to an
Alternate Port that becomes the new Root Port; i.e., Dynamic Filtering
Entries for those addresses may be modified to show the new Root Port as
their source, reducing the need to flood frames when recover
A Config BPDU always conveys a Designated Port Role.
Signed-off-by: Daniele Venturino
---
lib/rstp-state-machines.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/rstp-state-machines.c b/lib/rstp-state-machines.c
index 13abec0..516093f 100644
--- a/l
Other ports should stop forwarding and learning when a port receives a
superior BPDU carrying a Proposal flag.
Without this patch this does not happen and other ports keep executing
the learning and forwarding processes.
This patch contains some fixes reported in the 8
1 - 100 of 116 matches
Mail list logo
