On Thu, Nov 06, 2014 at 01:09:20PM -0800, Jarno Rajahalme wrote:
>
> On Nov 6, 2014, at 12:21 PM, Ben Pfaff <b...@nicira.com> wrote:
>
> > The classifier has an internal mutex, but in ofproto that mutex is
> > redundant with the external ofproto_mutex. If the classifier mutex were
> > removed, to be replaced by documentation that certain routines need
> > mutual exclusion, then possibly the reduced locking could yield a
> > performance improvement.
> >
> > However, I don't think any of the functions that take the lock are on
> > fast paths anyway, so this is just a thought.
>
> How about removing the mutex and adding a wrapper layer for those
> users who don’t have the mutex (like guarded_list/list)?
I only see a few classifier users:
* ofproto: has internal locking
* ovs-ofctl: single-threaded
* test-classifier: single-threaded
* ovs-router: potential user for the wrapper (though it looks
like the code would be racy if it's not locked externally
anyhow, e.g. see rt_entry_delete()).
So there would be one user for that, maybe. Might still be useful, or
might not.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
