You mean netdev_open(), or rxq_open() or some function else?
netdev_open() seems not a good place, it can be called at multiple
places. and we need to keep record of the n_rxq config at some high
level module.
for rxq_open(), currently it is used to create a 'struct netdev_rxq', not
for
specifyi
On Thu, Sep 11, 2014 at 10:56 PM, Alex Wang wrote:
>> >
>> > Specifically, the default number of rx queues will be the number
>> > of dpdk interfaces on the numa node. And the upcoming work
>> > will assign each rx queue to a different poll thread. The default
>> > number of tx queues will be th
On Thu, Sep 11, 2014 at 10:43 PM, Alex Wang wrote:
> One example is when STP config pkts are received from the dpdk port,
>
> when processing the pkts in xlate's process_special(), if the stp state
> machine need to send a config immediately via the dpdk interface, the state
> machine will directl
Samuel/Eitan,
If you are OK with the changes, can you pls. give a Acked-by, so we can check
it in?
thanks,
Nithin
On Sep 11, 2014, at 12:23 AM, Eitan Eliahu wrote:
> HI Sam,
> Please note that the cleanup callback is not called by NDIS rather called
> directed by the I/O manager for the devi
>
> >
> > Specifically, the default number of rx queues will be the number
> > of dpdk interfaces on the numa node. And the upcoming work
> > will assign each rx queue to a different poll thread. The default
> > number of tx queues will be the number of cpu cores on the machine.
> > Although not
One example is when STP config pkts are received from the dpdk port,
when processing the pkts in xlate's process_special(), if the stp state
machine need to send a config immediately via the dpdk interface, the state
machine will directly invoke the stp->send() callback function and sends the
pkt
On Tue, Sep 9, 2014 at 5:00 PM, Alex Wang wrote:
> The previous commit makes OVS create one tx queue for each
> cpu core, each pmd thread will use a separate tx queue.
> Also, tx of non-pmd threads on dpdk interface is all through
> 'NON_PMD_THREAD_TX_QUEUE', protected by the 'nonpmd_mempool_mutex
On Tue, Sep 9, 2014 at 5:00 PM, Alex Wang wrote:
> With this commit, ovs by default will try creating 'number of
> dpdk interfaces on numa node' pmd threads for each numa node
> and pin the pmd threads to available cpu cores on the numa node.
>
> NON_PMD_CORE_ID (currently 0) is used to reserve a
On Tue, Sep 9, 2014 at 5:00 PM, Alex Wang wrote:
> Previous commit makes OVS create one tx queue for each cpu
> core. An upcoming patch will allow multiple pmd threads be
> created and pinned to cpu cores. So each pmd thread will use
> the tx queue corresponding to its core id.
>
> Moreover, the
On Tue, Sep 9, 2014 at 5:00 PM, Alex Wang wrote:
> This commit adds new variable n_txq to 'struct netdev' for recording
> the number of tx queues. Correspondingly, the send_*() functions are
> extended to accept queue id as input argument.
>
> All 'netdev-*' implementation will ignore the queue i
On Tue, Sep 9, 2014 at 5:00 PM, Alex Wang wrote:
> Before this commit, ovs creates one tx and one rx queue for
> each dpdk interface and uses only one poll thread for handling
> I/O of all dpdk interfaces. An upcoming patch will allow multiple
> poll threads be created. As a preparation, this co
On Tue, Sep 9, 2014 at 5:00 PM, Alex Wang wrote:
> This commit adds a new API to the 'struct netdev_class' which
> allows user to query the numa node id the 'netdev' is on.
>
> Currently, only netdev-dpdk module implements this function.
>
> Signed-off-by: Alex Wang
LGTM
Acked-by: Pravin B Shela
On Wed, Sep 10, 2014 at 3:58 PM, Andy Zhou wrote:
> Current autoconfig detection logic for HAVE_PER_CPU_PTR is not robust.
> Depends on linux kernel version, the definition can be in either
> linux/percpu.h or asm/percpu.h
>
I could not find kernel with this_cpu_ptr () definition in
linux/percpu.h
On Sun, Sep 7, 2014 at 7:18 PM, Simon Horman wrote:
> On Fri, Sep 05, 2014 at 12:07:17PM -0700, Jesse Gross wrote:
>> On Thu, Sep 4, 2014 at 12:28 AM, Simon Horman
>> wrote:
>> > On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote:
>> >> On Tue, Sep 2, 2014 at 6:55 PM, Jesse Gross wrot
This commit adds function that extracts (both long and short)
options and returns them as string. Right now, only ovs-appctl
command provides an option to print this function output. And
the output is to be used by bash command-line completion script
for completion other options of the same comma
hi Sam,
Thanks for the updating the patch to make it specific to "handle NBLs with
multiple NBs".
In general it looks good. There are a few bugs w.r.t NBL completion that I have
highlighted.
More than that I was a little concerned about the changes in OvsTunnelTx to
split a TSOed NBL (with mul
On Sep 11, 2014, at 4:23 PM, Pravin Shelar wrote:
> On Wed, Sep 10, 2014 at 2:06 PM, Jarno Rajahalme
> wrote:
>> This new flag is useful for suppressing error logging when error
>> messages may be expected, as when probing for datapath features using
>> flow commands.
>>
(snip)
>> diff --gi
Daniele,
Thanks for the analysis. I did not see that now all miniflows need benefit form
the count.
I’ll send a separate patch just for the NETDEV_KEY_BUF_SIZE_U32 changes.
Jarno
On Sep 11, 2014, at 4:09 PM, Daniele Di Proietto wrote:
> Thanks Jarno,
>
> Your patches look good, unfortunat
On Wed, Sep 10, 2014 at 2:06 PM, Jarno Rajahalme wrote:
> This new flag is useful for suppressing error logging when error
> messages may be expected, as when probing for datapath features using
> flow commands.
>
> Signed-off-by: Jarno Rajahalme
> ---
> datapath/datapath.c
Thanks Jarno,
Your patches look good, unfortunately they do not achieve the same
performance enhancements.
By looking at the perf output it appears that we spend a lot of time in
miniflow_extract() storing the miniflow length. I believe this is due to
two reasons:
- Storing the length in the same
Actually, I wanted to push and pop the warning settings. But, the new warning
level is taken into effect only after the compiler encounters the open curly
brace. This means that we need to push and pop the warning on the conataing
macros. This change is not trivial.
I'm still looking for the iss
The datapath max_idle value determines how long to wait before deleting
an idle datapath flow when operating below the flow_limit. This patch
increases the max_idle to 10 seconds, which allows datapath flows to be
remain cached even if they are used less consistently, and provides a
small improveme
It looks good overall. Thanks for working on this.
Signed-off-by: Andy Zhou
I have a few minor comments:
In datapatch.c, should we extend flow_policy[] for the new flow
attributes? It seems OVS_fLOW_ATTR_MASK is also
missing -- may be good to fix that also.
in flow_netlink.c for function ovs_n
On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote:
> On 8/25/14 3:33 AM, Jesse Gross wrote:
>>
>> On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote:
>>>
>>> On 8/6/14 4:37 AM, Jesse Gross wrote:
Besides the fact that it would be nice to unify things, I'm not sure
that it is actuall
Hi Jarno,
Thanks for the patch.
The problem was that after the recent changes to odp-util.c
{ovs-,ovs-appctl }dpctl do not work anymore. Here¹s a line that used to
work:
ovs-appctl dpctl/add-flow dummy@br0
"in_port(1),eth(src=00:00:00:00:00:00/00:00:00:00:00:00,dst=ff:ff:ff:ff:ff:
ff/00:00:00:00
Thx, applied to master,
On Thu, Sep 11, 2014 at 10:45 AM, Ben Pfaff wrote:
> On Wed, Sep 10, 2014 at 02:12:29PM -0700, Alex Wang wrote:
> > There is no use case of this option in ovsdb-server. Also,
> > it causes dpif-dummy and netdev-dummy module register unrelated
> > unixctl commands.
> >
>
On Sep 11, 2014, at 11:44 AM, Ben Pfaff wrote:
> On Wed, Sep 10, 2014 at 02:06:06PM -0700, Jarno Rajahalme wrote:
>> Use the new OVS_FLOW_ATTR_SILENT flag when probing for datapath
>> feature support. Suppress also dpif error logging when requested, as
>> probe failures are already logged at ofp
On Sep 11, 2014, at 11:42 AM, Ben Pfaff wrote:
> On Wed, Sep 10, 2014 at 02:06:04PM -0700, Jarno Rajahalme wrote:
>> When probing for variable length userdata before handler threads are
>> set, the pid included in the userspace action will be 0, which is
>> flagged as an error by the linux kerne
On Thu, Sep 11, 2014 at 09:34:20PM +0200, Thomas Graf wrote:
> v2:
> Thanks to Daniele Di Proietto's follow-up fixes to the previous patch
> series the DPDK build is finally fully funtional.
>
> Also addresses Ben's feedback on escaping autoconf vars and provides a
> reference to flag variables od
On Thu, Sep 11, 2014 at 12:20 PM, Eitan Eliahu wrote:
>
> Here is the local warning suppression :
> #define OBJECT_OFFSETOF(OBJECT, MEMBER) __pragma(pack(push, 1))
> __pragma(warning(disable:4700)) ((char *)&(OBJECT)->MEMBER - (char
> *)(OBJECT)) __pragma(pack(pop))
It is possible that I don't
A missing " prevented the DPDK build in the matrix from functioning
so far. This patch enables the DPDK build by properly building DPDK
as a single library and by pointing the OVS build to the corresponding
build directory. Also removes the 'make install' as it is not required
and only slows down t
configure cannot expect that the user will not pass additional CFLAGS
and LDFLAGS at make time [0]. Use OVS_CFLAGS and OVS_LDFLAGS instead to
collect compiler and linker flags and substitute in Makefile.am.
This allows for:
./configure --with-dpdk=[...]
make CFLAGS=-Wno-error=foo
[0]
http://www.
v2:
Thanks to Daniele Di Proietto's follow-up fixes to the previous patch
series the DPDK build is finally fully funtional.
Also addresses Ben's feedback on escaping autoconf vars and provides a
reference to flag variables odering section in the automake manual.
Successful build:
https://travis-c
On Thu, Sep 11, 2014 at 07:20:13PM +, Eitan Eliahu wrote:
>
> Here is the local warning suppression :
> #define OBJECT_OFFSETOF(OBJECT, MEMBER) __pragma(pack(push, 1))
> __pragma(warning(disable:4700)) ((char *)&(OBJECT)->MEMBER - (char
> *)(OBJECT)) __pragma(pack(pop))
>
>
> The right way
Here is the local warning suppression :
#define OBJECT_OFFSETOF(OBJECT, MEMBER) __pragma(pack(push, 1))
__pragma(warning(disable:4700)) ((char *)&(OBJECT)->MEMBER - (char *)(OBJECT))
__pragma(pack(pop))
The right way to do it is as follows, but it doesn't work on OVS source base,
struct my_no
On 09/11/14 at 05:57pm, Daniele Di Proietto wrote:
> In case my main client screws up the code, you can find the commit here
>
> https://github.com/ddiproietto/ovs/commit/6e3523f3bcc74b2af9df221073b45026f
> 9757b15
>
> The corresponding travis build is:
>
> https://travis-ci.org/ddiproietto/ovs/
On Wed, Sep 10, 2014 at 02:06:06PM -0700, Jarno Rajahalme wrote:
> Use the new OVS_FLOW_ATTR_SILENT flag when probing for datapath
> feature support. Suppress also dpif error logging when requested, as
> probe failures are already logged at ofproto-dpif.
>
> Signed-off-by: Jarno Rajahalme
Acked
On Wed, Sep 10, 2014 at 02:06:04PM -0700, Jarno Rajahalme wrote:
> When probing for variable length userdata before handler threads are
> set, the pid included in the userspace action will be 0, which is
> flagged as an error by the linux kernel datapath. As a result the
> feature probe will produ
Does MSVC support decltype in C or only in C++?
On Thu, Sep 11, 2014 at 10:41 AM, Eitan Eliahu wrote:
> As an alternative I tried to use decltype() operator (which I thing is the
> right way to do it):
>
> #define OBJECT_OFFSETOF(OBJECT, MEMBER) \
> ((LONG)(LONG_PTR)&((decltype(OBJECT))0)->M
On Sep 11, 2014, at 11:11 AM, Ben Pfaff wrote:
> On Thu, Sep 11, 2014 at 11:12:29AM -0700, Jarno Rajahalme wrote:
>> This could fix using ovs-dpctl to add userspace datapath flows.
>
> It's a big patch, could you expand slightly on what it does before I
> start reading it?
I planned to follow
THanks.
On Thu, Sep 11, 2014 at 11:15:14AM -0700, Alex Wang wrote:
> Thx Ben,
>
> I'll adjust the commit message,
>
> Also, i think it makes sense to generalize into a function in command-line
> module.
>
> Alex Wang,
>
> On Thu, Sep 11, 2014 at 11:03 AM, Ben Pfaff wrote:
>
> > Can you add t
Thx Ben,
I'll adjust the commit message,
Also, i think it makes sense to generalize into a function in command-line
module.
Alex Wang,
On Thu, Sep 11, 2014 at 11:03 AM, Ben Pfaff wrote:
> Can you add that to the commit message?
>
> Does it make any sense to generalize this or is it only usefu
On Thu, Sep 11, 2014 at 11:12:29AM -0700, Jarno Rajahalme wrote:
> This could fix using ovs-dpctl to add userspace datapath flows.
It's a big patch, could you expand slightly on what it does before I
start reading it?
___
dev mailing list
dev@openvswitch
This could fix using ovs-dpctl to add userspace datapath flows.
Signed-off-by: Jarno Rajahalme
---
lib/dpctl.c |4 +-
lib/dpif-netdev.c | 85 ---
lib/odp-util.c| 88 ++---
Can you add that to the commit message?
Does it make any sense to generalize this or is it only useful for
ovs-appctl?
On Thu, Sep 11, 2014 at 10:59:26AM -0700, Alex Wang wrote:
> for my completion script, i changed design to get subcmds from `ovs-appctl
> help' and long options from `ovs-appctl
On Wed, Sep 10, 2014 at 12:55:48PM -0700, Gurucharan Shetty wrote:
> Implementation of OBJECT_OFFSETOF() for non-GNUC compilers like MSVC
> causes "uninitialized variable" warnings. Since OBJECT_OFFSETOF() is
> indirectly used through all the *_FOR_EACH() (through ASSIGN_CONTAINER()
> and OBJECT_C
for my completion script, i changed design to get subcmds from `ovs-appctl
help' and long options from `ovs-appctl --option`
parsing manpage is very slow, i'm finishing up the unit tests for the script
will post it soon after this series,
On Thu, Sep 11, 2014 at 10:49 AM, Ben Pfaff wrote:
> On
On Wed, Sep 10, 2014 at 12:55:47PM -0700, Gurucharan Shetty wrote:
> The lack of 'const' in function declaration causes MSVC to complain
> because the function definition uses it.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailin
On Wed, Sep 10, 2014 at 12:55:46PM -0700, Gurucharan Shetty wrote:
> MSVC complains about a void function returning a value if there is a
> statement of the form - 'return foo()' even if foo() has a void return
> type.
>
> Signed-off-by: Gurucharan Shetty
It's a weird thing to do anyway. I thin
Hi Thomas,
I finally managed to care of the issue. With the following incremental on
the top of your series OVS DPDK builds properly on travis:
diff --git a/.travis/build.sh b/.travis/build.sh
index c096eaf..b96181f 100755
--- a/.travis/build.sh
+++ b/.travis/build.sh
@@ -23,9 +23,8 @@ function i
On Wed, Sep 10, 2014 at 10:33:37PM +0200, Thomas Graf wrote:
> A missing " prevented the DPDK build in the matrix from functioning.
> Correctly build DPDK as a single, shared library and point the OVS
> build to the corresponding build directory. Also removes the 'make
> install' as it is not neede
On Wed, Sep 10, 2014 at 10:33:36PM +0200, Thomas Graf wrote:
> configure cannot expect that the user will not pass additional CFLAGS
> and LDFLAGS at make time. Use OVS_CFLAGS and OVS_LDFLAGS instead to
> collect compiler and linker flags and substitute in Makefile.am.
>
> This allows for:
> ./con
On Wed, Sep 10, 2014 at 02:12:31PM -0700, Alex Wang wrote:
> Signed-off-by: Alex Wang
What's it for?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Sep 10, 2014 at 02:12:30PM -0700, Alex Wang wrote:
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Sep 10, 2014 at 02:12:29PM -0700, Alex Wang wrote:
> There is no use case of this option in ovsdb-server. Also,
> it causes dpif-dummy and netdev-dummy module register unrelated
> unixctl commands.
>
> Signed-off-by: Alex Wang
Acked-by: Ben Pfaff
___
On Thu, Sep 11, 2014 at 10:41 AM, Eitan Eliahu wrote:
> As an alternative I tried to use decltype() operator (which I thing is the
> right way to do it):
>
> #define OBJECT_OFFSETOF(OBJECT, MEMBER) \
> ((LONG)(LONG_PTR)&((decltype(OBJECT))0)->MEMBER);
>
> This worked correctly in a standalone
On Thu, Sep 11, 2014 at 09:43:27AM -0700, Gurucharan Shetty wrote:
> Commit b2a0daa5bd (debian: Don't recreate bridges during manual restart.)
> added a check on $RUNLEVEL to only create bridges and ports when the
> system starts up. This fix does not work with systemd.
>
> This commit uses a diff
On Thu, Sep 11, 2014 at 01:04:57PM +0200, Philipp S. Schmidt wrote:
> It seems that most of the problem is fixed in the recent version
> as "ifup --allow=ovs [bridges?]? is called in the network_interfaces()
> function.
>
> Sadly, when using systems, this function just return and does not
> execut
On Thu, Sep 11, 2014 at 4:04 AM, Philipp S. Schmidt wrote:
> It seems that most of the problem is fixed in the recent version
> as "ifup --allow=ovs [bridges…]” is called in the network_interfaces()
> function.
>
> Sadly, when using systems, this function just return and does not
> execute ifup as
As an alternative I tried to use decltype() operator (which I thing is the
right way to do it):
#define OBJECT_OFFSETOF(OBJECT, MEMBER) \
((LONG)(LONG_PTR)&((decltype(OBJECT))0)->MEMBER);
This worked correctly in a standalone program I wrote but for some reason any
use decltypea s an l-valu
On Thu, Sep 11, 2014 at 11:04:50AM -0300, Flavio Leitner wrote:
> This patchset contains two backports needed to build
> branch-2.3 on older distros.
Both applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/d
Commit b2a0daa5bd (debian: Don't recreate bridges during manual restart.)
added a check on $RUNLEVEL to only create bridges and ports when the
system starts up. This fix does not work with systemd.
This commit uses a different approach to solve the same problem.
Reported-by: Philipp S. Schmidt
S
On Thu, Sep 11, 2014 at 05:34:34PM +0530, Saloni Jain wrote:
> 1. As per current implementation, "ovs-vsctl create table ...
> overflow-policy=evict" command, configures openvswitch database(conf.db) and
> sets table structure eviction fields and eviction groups.
> ?
> 2. As per our understanding
On Sep 11, 2014, at 5:49 AM, Daniele Venturino wrote:
>
> Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino
> ha scritto:
>
>>
>> Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme
>> ha scritto:
>>
>>>
>>> On Sep 9, 2014, at 3:53 AM, Daniele Venturino
>>> wrote:
>>>
On Wed, Sep 10, 2014 at 10:20 PM, Eitan Eliahu wrote:
> Hi Guru,
> You can just suppress the warning by wrapping the code in a pragama warning
> block:
>
> #pragma warning( push )
> #pragma warning( disable : 4707 )
> // Some code
> #pragma warning( pop )
For this particular case, I think what y
Sent from my iPhone
> On Sep 11, 2014, at 2:08 AM, Daniele Venturino
> wrote:
>
>
>> Il giorno 10/set/2014, alle ore 18:54, Jarno Rajahalme
>> ha scritto:
>>
>> Daniele,
>>
>> See comments below.
>>
>> Also, it would be preferable to send related changes, or multiple unrelated
>> chang
From: Joe Stringer
This could cause configuration failure on earlier versions of autoconf.
Reported-by: Lin Shaopeng
Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
Signed-off-by: Flavio Leitner
---
tests/ofp-print.at |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
This patchset contains two backports needed to build
branch-2.3 on older distros.
The first patch (autoconf) had a small conflict with
the versioning.
The second patch (parenthesis) had no conflicts.
Joe Stringer (1):
tests: Remove extraneous parenthesis from test name.
Thomas Graf (1):
bui
From: Thomas Graf
Reduces the dependency on autoconf from 2.64 to 2.63 to ease building
on older platforms. There is only a few macros missing and they can
be provided easily.
A handful of tests needed modification. The difference in quoting
behaviour between 2.63 and later require the m4_define
Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino
ha scritto:
>
> Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme
> ha scritto:
>
>>
>> On Sep 9, 2014, at 3:53 AM, Daniele Venturino
>> wrote:
>>
>>>
>>> Thanks for the review!
>>> It would be nice to have an Acked-by from
Hi Ben/Team,
We have started with the implementation of eviction feature as per openflow
specification 1.4. Following points needs discussion:
1. As per current implementation, "ovs-vsctl create table ...
overflow-policy=evict" command, configures openvswitch database(conf.db) and
sets table
It seems that most of the problem is fixed in the recent version
as "ifup --allow=ovs [bridges…]” is called in the network_interfaces()
function.
Sadly, when using systems, this function just return and does not
execute ifup as ${RUNLEVEL} is not set.
I have no idea what purpose the line "[ -z "$
+1 :)
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis: Thursday, September 11, 2014 8:01 PM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v5] Netlink_socket.c Join/Unjoin an MC group for
event subscription
Use a specific out of band d
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Thursday, September 11, 2014 3:36 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4 1/2] datapath-windows/NetlinkBuf.h: Added NlBufSize
Added an inline
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Ankur Sharma
Trimis: Thursday, September 11, 2014 3:36 AM
Către: dev@openvswitch.org
Subiect: [ovs-dev] [PATCH v4 2/2] datapath-windows/Netlink: Nested attributes
put/parse.
Added A
> -Original Message-
> From: Tahhan, Maryam
> Sent: Friday, August 22, 2014 2:42 PM
> To: dev@openvswitch.org
> Cc: Tahhan, Maryam
> Subject: [PATCH v4 1/1] netdev-dpdk: add dpdk vhost ports
>
> This patch implements the vhost-net offload API. It adds support for
> a new port type to us
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove whi
Il giorno 10/set/2014, alle ore 18:54, Jarno Rajahalme
ha scritto:
> Daniele,
>
> See comments below.
>
> Also, it would be preferable to send related changes, or multiple unrelated
> changes to any given subsystem, as a series of patches instead of individual
> ones. “git format-patch” doe
You have a point. Probably, not all developers would like to have MSVC pragams
inside the code. But, still, I don't like the idea of adding instructions to
suppress warnings.
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Thursday, September
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove whi
Alin, I will send out a rebased version. (no short cuts here:-) )
Thank you,
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Thursday, September 11, 2014 1:27 AM
To: Eitan Eliahu; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v3] Netlink_sock
Hi Eitan,
For a limited scope just to suppress the warnings the code will get very
cumbersome.
For some variable initialization I do not see what is so inefficient.
Alin.
-Mesaj original-
De la: Eitan Eliahu [mailto:elia...@vmware.com]
Trimis: Thursday, September 11, 2014 1:19 AM
Către:
Hi Eitan,
Still cannot get the patch to apply:
$ git apply patch1
error: patch failed: datapath-windows/include/OvsDpInterfaceExt.h:70
error: datapath-windows/include/OvsDpInterfaceExt.h: patch does not apply
This part:
@@ -70,6 +70,14 @@
/* Commands available under the OVS_WIN_CONTROL_FAMILY. *
Hi Alin,
I would prefer to disable the warning in a very limited scope rather than
disabling them across all source code.
Adding instructions just for suppressing warning would be inefficient.
Eitan
-Original Message-
From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com]
Sent: Th
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove whi
Hi Eitan,
I think putting in pragmas to disable warnings is a bit over our hand.
Either we just disable them in a common include header or we leave them and
actually fix the warnings.
Alin.
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Eitan Eliahu
Trimis:
Use a specific out of band device control to subscribe/unsubscribe a socket
to the driver event queue for notification.
Signed-off-by: Eitan Eliahu
Acked-by: Nithin Raju
Acked-by: Saurabh Shah
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
---
v1 CodingStyle fix alignment
v2 Remove whi
HI Sam,
Please note that the cleanup callback is not called by NDIS rather called
directed by the I/O manager for the device we created for communicating with
the user mode process.
This device is not part of the network stack.
Per your question: Socket for sump operation are transient (i.e. cre
Thanks Sam for reviewing this code.
On the sequence number I will use the nl_sock_send() instead so the sequence
number will be 1 rather than zero. But, please not that this is not necessary
because our implementation use a single system I/O call for write the NL
command and read the response.
89 matches
Mail list logo
