On Sep 11, 2014, at 4:23 PM, Pravin Shelar <pshe...@nicira.com> wrote:
> On Wed, Sep 10, 2014 at 2:06 PM, Jarno Rajahalme <jrajaha...@nicira.com> > wrote: >> This new flag is useful for suppressing error logging when error >> messages may be expected, as when probing for datapath features using >> flow commands. >> (snip) >> diff --git a/datapath/linux/compat/include/linux/openvswitch.h >> b/datapath/linux/compat/include/linux/openvswitch.h >> index 306ea86..14c05fc 100644 >> --- a/datapath/linux/compat/include/linux/openvswitch.h >> +++ b/datapath/linux/compat/include/linux/openvswitch.h >> @@ -483,6 +483,9 @@ enum ovs_flow_attr { >> OVS_FLOW_ATTR_USED, /* u64 msecs last used in monotonic time. */ >> OVS_FLOW_ATTR_CLEAR, /* Flag to clear stats, tcp_flags, used. */ >> OVS_FLOW_ATTR_MASK, /* Sequence of OVS_KEY_ATTR_* attributes. */ >> + OVS_FLOW_ATTR_SILENT, /* Flag to suppress any logging for the flow >> + * operation, useful when probing for >> feature >> + * compatibility. */ > > Can we call this attribute as OVS_FLOW_ATTR_PROBE to make it explicit > about its use-case for vswitchd probe. OK, I’ll re-spin the patches. Jarno > > >> __OVS_FLOW_ATTR_MAX >> }; >> >> -- >> 1.7.10.4 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev