On Wed, Sep 10, 2014 at 10:33:36PM +0200, Thomas Graf wrote: > configure cannot expect that the user will not pass additional CFLAGS > and LDFLAGS at make time. Use OVS_CFLAGS and OVS_LDFLAGS instead to > collect compiler and linker flags and substitute in Makefile.am. > > This allows for: > ./configure --with-dpdk=[...] > make CFLAGS=-Wno-error=foo > > Signed-off-by: Thomas Graf <tg...@noironetworks.com>
I'd add a reference to the "Flag Variables Ordering" section of the Automake manual to the commit message, because it encourages the way you've done this here. I had to go back and reread it to make sure that it is the preferred way. > diff --git a/configure.ac b/configure.ac > index f1c9f9f..063dce5 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -122,6 +122,8 @@ AC_SUBST(KARCH) > OVS_CHECK_LINUX > OVS_CHECK_DPDK > OVS_CHECK_PRAGMA_MESSAGE > +AC_SUBST(OVS_CFLAGS) > +AC_SUBST(OVS_LDFLAGS) Please []-quote the names here. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
