I've been having a bit of trouble with ovs after this patch was applied,
ovs-vswitchd locks up on Debian 7.6 (VBox VM). Kernel is 3.2.0-4-amd64 #1
SMP Debian 3.2.60-1+deb7u3 x86_64 GNU/Linux.
I have a fairly typical phy bridge + int bridge setup, with dhclient
running on br-int:
# ovs-vsctl show
I didn't realize earlier while defining OvsDpInterfaceExt.h that
there are special values defined in netlink-protocol.h for nlmsg_type.
For Eg. NLMSG_ERROR is defined to be 2. In this patch, we update the
values of the family IDs to not clash with the special defines.
I'm using NLMSG_MIN_TYPE as a
A typo crept in while respinning get_sock_pid_from_kernel() in the previous
patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT
argument. Fixing that too.
Signed-off-by: Nithin Raju
---
lib/netlink-socket.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-
dpif-linux.c makes a nl_lookup_genl_mcgroup(OVS_VPORT_FAMILY) that is not
implemented yet on Windows yet. Multicast group is used currently to
subscribe to events related to VPORTs. Whether the exact same mechanism
would be used is unclear yet.
In the interim, we can implement code to support nl_l
While we work out whether nl_sock_join_mcgroup() will be the mechanism
to support VPORT events, it is easy to add support for
nl_lookup_genl_mcgroup() and make progress on the other commands.
In this patch, we implement support for nl_lookup_genl_mcgroup() only
for the VPORT family though, which i
On Thu, Aug 21, 2014 at 9:41 AM, Ben Hutchings wrote:
> On Thu, 2014-08-21 at 18:18 +0200, Jiri Pirko wrote:
>> The goal of this is to provide a possibility to suport various switch
>> chips. Drivers should implement relevant ndos to do so. Now there is a
>> couple of ndos defines:
>> - for gettin
From: yinpeijun
Signed-off-by: yinpeijun
---
lib/nx-match.c| 1 +
ovsdb/execution.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index 1d3205f..54712cc 100644
--- a/lib/nx-match.c
+++ b/lib/nx-match.c
@@ -109,6 +109,7 @@ check_mask_consistency(const
On Fri, Aug 22, 2014 at 08:30:08AM -0700, Ben Pfaff wrote:
> On Fri, Aug 22, 2014 at 09:19:41PM +0900, Simon Horman wrote:
> > I have been working with Netronome on examining the possibilities of
> > providing (richer) load balancing facilities in Open vSwitch.
> >
> > It seems to us that the curr
error string should be freed in all cases.
Signed-off-by: Madhu Challa
---
vtep/vtep-ctl.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
index 0b9463a..064ad1f 100644
--- a/vtep/vtep-ctl.c
+++ b/vtep/vtep-ctl.c
@@ -3199,11 +3199,13 @@
call odp_execute_actions__ only if there are any subactions to prevent null
pointer dereference in nl_attr_get().
Signed-off-by: Madhu Challa
---
lib/odp-execute.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index e1e9b57..607af03 100644
--- a/
Pushed with the fix suggested. Thanks.
On Tue, Aug 26, 2014 at 5:15 PM, Pravin Shelar wrote:
> On Tue, Aug 26, 2014 at 3:36 PM, Andy Zhou wrote:
>> If recirc action is the last action of a action list, the SKB triggers
>> the recirc will be freed twice. This patch fixes this bug.
>>
>> Reported-
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Tuesday, August 26, 2014 5:03 PM
> To: Saurabh Shah
> Cc: Samuel Ghinet; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] Rename files under datapath-windows
>
> On Wed, Aug 27, 2014 at 12:00:33AM +, Saurabh Sh
On Tue, Aug 26, 2014 at 3:36 PM, Andy Zhou wrote:
> If recirc action is the last action of a action list, the SKB triggers
> the recirc will be freed twice. This patch fixes this bug.
>
> Reported-by: Justin Pettit
> Signed-off-by: Andy Zhou
> ---
> datapath/actions.c | 26 -
On Wed, Aug 27, 2014 at 12:11:34AM +, Saurabh Shah wrote:
> > -Original Message-
> > From: Ben Pfaff [mailto:b...@nicira.com]
> > Sent: Tuesday, August 26, 2014 4:56 PM
> > To: Saurabh Shah
> > Cc: Jarno Rajahalme; dev@openvswitch.org
> > Subject: Re: [ovs-dev] [PATCH] lib/flow.h: Impro
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Tuesday, August 26, 2014 4:56 PM
> To: Saurabh Shah
> Cc: Jarno Rajahalme; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] lib/flow.h: Improve struct miniflow comment
> and definition.
>
> On Tue, Aug 26, 2014 at
On Wed, Aug 27, 2014 at 12:00:33AM +, Saurabh Shah wrote:
> I manually patched the change but I wasn't able to build it. Haven't
> spent much time figuring out why.
Possibly you need to rerun autoreconf.
___
dev mailing list
dev@openvswitch.org
http:
Hi Samuel,
I manually patched the change but I wasn't able to build it. Haven't spent much
time figuring out why.
link -nologo -DEBUG -out:ovsdb/ovsdb-server.exe ovsdb/ovsdb-server.obj -LIBPATH:
C:/pthread/lib/x86 ovsdb/.libs/libovsdb.lib lib/.libs/libopenvswitch.lib pthread
VC2.lib ws2_32.lib
L
On Tue, Aug 26, 2014 at 11:32:55PM +, Saurabh Shah wrote:
>
>
> >Miniflows can nowadays be dynamically allocated to different inline
> >sizes, as done by lib/classifier.c, but this had not been documented
> >at the struct miniflow definition.
> >
> >Also, MINI_N_INLINE had a different value f
Signed-off-by: Joe Stringer
---
datapath/flow_netlink.c | 219 +++
1 file changed, 86 insertions(+), 133 deletions(-)
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 69d1919..aa2cece 100644
--- a/datapath/flow_netlink.c
+++ b/data
This function allows netlink attributes to be parsed more strictly,
to check for duplicate attributes, attribute max lengths, and detecting
attributes with only non-zero values.
Signed-off-by: Joe Stringer
---
acinclude.m4 |2 +
datapath/linux/Modules.mk
Hey Alin,
Are you planning on re-spinning this patch?
Saurabh
>This commit adds to the automake build system the full build required by
>the
>forwarding extension solution.
>
>It will help a lot in the future CI to check the full build of the
>project.
>
>Also the documentation was updated.
>
>Si
>Miniflows can nowadays be dynamically allocated to different inline
>sizes, as done by lib/classifier.c, but this had not been documented
>at the struct miniflow definition.
>
>Also, MINI_N_INLINE had a different value for 32-bit and 64-bit builds
>due to a historical reason. Now we use 8 for b
On Tue, Aug 26, 2014 at 04:05:31PM -0700, Jarno Rajahalme wrote:
> I forgot to add your Reviewed-by:, and it seems it is not possible
> to ?git commit ?amend? a commit that already is at github ? or is
> it?
You can do it with a forced push, e.g. "git push --force". It is
risky, though, so one sh
On Tue, Aug 26, 2014 at 04:04:09PM -0700, Jarno Rajahalme wrote:
>
> On Aug 26, 2014, at 3:53 PM, Ben Pfaff wrote:
>
> > On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
> >> Finally, use change the storage type of 'values_inline' to uint8_t, as
> >> uint64_t looks kind of wide f
I wish there were a way to make "make" do it automatically, but I do
not know of one.
On Tue, Aug 26, 2014 at 04:06:26PM -0700, Jarno Rajahalme wrote:
> I forgot about that, sorry. ./boot.sh and ./configure worked for me.
>
> Jarno
>
> On Aug 26, 2014, at 3:31 PM, Ben Pfaff wrote:
>
> > You
I forgot about that, sorry. ./boot.sh and ./configure worked for me.
Jarno
On Aug 26, 2014, at 3:31 PM, Ben Pfaff wrote:
> You probably need to "autoreconf".
>
> On Tue, Aug 26, 2014 at 03:17:32PM -0700, Jarno Rajahalme wrote:
>> Not sure if it was this patch, but after git pull:
>>
>> test
On Aug 26, 2014, at 3:44 PM, Thomas Graf wrote:
> On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
>> Miniflows can nowadays be dynamically allocated to different inline
>> sizes, as done by lib/classifier.c, but this had not been documented
>> at the struct miniflow definition.
>>
>> Also, MINI_
On Aug 26, 2014, at 3:53 PM, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
>> Finally, use change the storage type of 'values_inline' to uint8_t, as
>> uint64_t looks kind of wide for a boolean, even though we intend the
>> bit be carved out from the uint64_
On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
> Finally, use change the storage type of 'values_inline' to uint8_t, as
> uint64_t looks kind of wide for a boolean, even though we intend the
> bit be carved out from the uint64_t where 'map' resides.
It can't be type "bool"?
_
An error returned from ovsdb_row_from_json() currently results in
leaking of row.
Signed-off-by: Thomas Graf
---
ovsdb/execution.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index 7a1db0c..6314757 100644
--- a/ovsdb/execution.c
+++ b/ovsdb/execution
On Aug 26, 2014, at 3:29 PM, Thomas Graf wrote:
> On 08/26/14 at 12:02pm, Jarno Rajahalme wrote:
>> Miniflows can also be dynamically allocated to have more inline space than
>> the default amount. classifier.c makes use of that, but it never calls
>> miniflow_move (even indirectly) so you are
On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
> Miniflows can nowadays be dynamically allocated to different inline
> sizes, as done by lib/classifier.c, but this had not been documented
> at the struct miniflow definition.
>
> Also, MINI_N_INLINE had a different value for 32-bit and 64-bit build
Although the check is present already, a missing !error branch
in the next condition prevents the error from being reported back.
Signed-off-by: Thomas Graf
---
ovsdb/execution.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ovsdb/execution.c b/ovsdb/execution.c
index 6314757..2be131d 10
Miniflows can nowadays be dynamically allocated to different inline
sizes, as done by lib/classifier.c, but this had not been documented
at the struct miniflow definition.
Also, MINI_N_INLINE had a different value for 32-bit and 64-bit builds
due to a historical reason. Now we use 8 for both.
Fi
If recirc action is the last action of a action list, the SKB triggers
the recirc will be freed twice. This patch fixes this bug.
Reported-by: Justin Pettit
Signed-off-by: Andy Zhou
---
datapath/actions.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff -
You probably need to "autoreconf".
On Tue, Aug 26, 2014 at 03:17:32PM -0700, Jarno Rajahalme wrote:
> Not sure if it was this patch, but after git pull:
>
> tests/test-controller.8.in not found in: . .
> make[2]: *** [manpages.mk] Error 1
> make[2]: Failed to remake makefile `Makefile'.
> make[2]
On 08/26/14 at 12:02pm, Jarno Rajahalme wrote:
> Miniflows can also be dynamically allocated to have more inline space than
> the default amount. classifier.c makes use of that, but it never calls
> miniflow_move (even indirectly) so you are not getting an assert fail. The
> motivation for right
Not sure if it was this patch, but after git pull:
tests/test-controller.8.in not found in: . .
make[2]: *** [manpages.mk] Error 1
make[2]: Failed to remake makefile `Makefile'.
make[2]: *** No rule to make target `tests/test-controller.c', needed by
`tests/test-controller.o’.
Jarno
On Aug 26
On 26/08/14 11:13, Ben Pfaff wrote:
> Is your mininet packaging targeted at jessie? That is, do you need
> ovs-testcontroller in jessie or just in jessie+1? It makes a
> difference because jessie will have Open vSwitch 2.3, but the
> ovs-testcontroller change will only be in 2.4, and I do not wan
On 27 August 2014 06:09, Ben Pfaff wrote:
> On Thu, Aug 21, 2014 at 05:42:02PM +1200, Joe Stringer wrote:
> > Currently, when a revalidator thread first dumps a flow, it creates a
> > 'udpif_key' object and caches a copy of a kernel flow key. This allows
> > us to perform lookups in the classifie
What I thought is to generally use metadata as matching rule in datapath.
It is not just between tables.
Thanks,
Junguk
2014-08-26 15:15 GMT-06:00 Ben Pfaff :
> On Tue, Aug 26, 2014 at 03:14:10PM -0600, Junguk Cho wrote:
> > But, it is in "struct flow" in lib/flow.h.
> > It is not from "stru
On Tue, Aug 26, 2014 at 03:14:10PM -0600, Junguk Cho wrote:
> But, it is in "struct flow" in lib/flow.h.
> It is not from "struct sw_flow_key" in /datapath/flow.h.
>
> I assume metadata is used in action in datapath.
metadata is not a datapath concept. There is no need for it to be a
datapath co
But, it is in "struct flow" in lib/flow.h.
It is not from "struct sw_flow_key" in /datapath/flow.h.
I assume metadata is used in action in datapath.
Is it right?
Thanks,
Junguk
2014-08-26 14:00 GMT-06:00 Ben Pfaff :
> On Tue, Aug 26, 2014 at 01:57:32PM -0600, Junguk Cho wrote:
> > One more qu
On 08/26/14 at 11:28am, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 06:36:08PM +0200, Thomas Graf wrote:
> > Signed-off-by: Thomas Graf
> > ---
> > lib/dpif-netdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> > index 7401293..c7a1242 1
On 08/26/14 at 01:13pm, Alexei Starovoitov wrote:
> I think it's important distinction. In-kernel OVS is not OF.
> It's a networking function that has hard-coded packet parser,
> N-tuple match and programmable actions.
> There were times when HW vendors were using OF check-box
> to sell more chips,
"Let me think a little more about this. The functionality is meant to be
generic, so I don't like calling the variable 'encapBytes', since it becomes a
specific usage of the API."
I know, but I think "encapBytes" is the only usage we could ever have for the
project.
We could also use something
On Tue, Aug 26, 2014 at 9:19 AM, Thomas Graf wrote:
>
> Wait... I don't want to use OpenFlow to configure my laptop ;-)
+1
> We should leave the controller out of this discussion though. A
> controller is not required to run OVS at all. OpenStack Neutron
> is a very good example for that. There
This patch includes the file renaming and accommodations needed for the file
renaming to build the forwarding extension for Hyper-V.
This patch is also a follow-up for the thread:
http://openvswitch.org/pipermail/dev/2014-August/044005.html
Signed-off-by: Samuel Ghinet
Co-authored-by: Alin Gabr
On Aug 26, 2014, at 1:01 AM, Thomas Graf wrote:
> On 08/25/14 at 08:10pm, Jesse Gross wrote:
>> On Mon, Aug 25, 2014 at 7:19 PM, Jarno Rajahalme
>> wrote:
>>> instead of:
>>>
>>> set(ipv4(src=35.8.2.41/0.0.0.0,dst=172.16.0.20/0.0.0.0,proto=6/0xff,tos=0x80/0,ttl=128/0,frag=no/0))
>>>
>>> we c
On Tue, Aug 26, 2014 at 01:57:32PM -0600, Junguk Cho wrote:
> One more question, if we used metadata, is metadata stored in "tun_in" in
> "struct ovs_key_ipv4_tunnel"?
No.
> Which data structure keeps metadata information?
struct flow's "metadata" member.
Ok. I got it. Maybe I misunderstood the concept of metadata.
Metadata is passed between tables. It is not from packets.
One more question, if we used metadata, is metadata stored in "tun_in" in
"struct ovs_key_ipv4_tunnel"?
Which data structure keeps metadata information?
Thanks,
Junguk
2014-08
On Tue, Aug 26, 2014 at 12:39 PM, Pravin Shelar wrote:
> On Tue, Aug 26, 2014 at 11:45 AM, Andy Zhou wrote:
>> On Mon, Aug 25, 2014 at 6:32 PM, Pravin Shelar wrote:
>>> On Mon, Aug 25, 2014 at 3:24 PM, Andy Zhou wrote:
If recirc action is the last action of a action list, the SKB triggers
Metadata is always 0 at the point that a packet enters the OpenFlow
pipeline, so there's no need for the datapath to match on it--it would
always be a match against 0.
On Tue, Aug 26, 2014 at 01:44:56PM -0600, Junguk Cho wrote:
> Oh, really?
>
> Basically, what I understood is datapath keeps some
Oh, really?
Basically, what I understood is datapath keeps some tables based on "struct
sw_flow_key" and used it for evaluating if incoming packet is matched or
not.
Is it right or do I miss something?
If I miss something, can you forward me to metadata matching in datapath?
Thanks,
Junguk
2
On Mon, Aug 25, 2014 at 09:45:08AM -0700, Nithin Raju wrote:
> While we work out whether nl_sock_join_mcgroup() will be the mechanism
> to support VPORT events, it is easy to add support for
> nl_lookup_genl_mcgroup() and make progress on the other commands.
>
> In this patch, we implement support
On Tue, Aug 26, 2014 at 01:36:04PM -0600, Junguk Cho wrote:
> Hi, I have a simple question.
> When we use metadata as flow-rule,
> Does all traffic forward ofproto to match it because there is no match
> field in "struct sw_flow" in datapath?
No, metadata matching still allows for kernel forwardin
On Tue, Aug 26, 2014 at 11:45 AM, Andy Zhou wrote:
> On Mon, Aug 25, 2014 at 6:32 PM, Pravin Shelar wrote:
>> On Mon, Aug 25, 2014 at 3:24 PM, Andy Zhou wrote:
>>> If recirc action is the last action of a action list, the SKB triggers
>>> the recirc will be freed twice. This patch fixes this bug
On Tue, Aug 26, 2014 at 12:02:48PM -0700, Jarno Rajahalme wrote:
>
> On Aug 26, 2014, at 3:01 AM, Thomas Graf wrote:
>
> > The branch is unused as size < sizeof dst->inline_values must
> > always be true for inlined values. Hitting the branch would lead
> > to corruption as inline_values is acce
Hi, I have a simple question.
When we use metadata as flow-rule,
Does all traffic forward ofproto to match it because there is no match
field in "struct sw_flow" in datapath?
Thanks,
Junguk
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/
>A typo crept in while respinning get_sock_pid_from_kernel() in the
>previous
>patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT
>argument. Fixing that too.
>---
> lib/netlink-socket.c | 10 +-
> 1 files changed, 5 insertions(+), 5 deletions(-)
Acked-by: Saurabh
>---
> datapath-windows/ovsext/Netlink.c | 16 +---
> 1 files changed, 9 insertions(+), 7 deletions(-)
Acked-by: Saurabh Shah
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi Samuel,
> -Original Message-
> From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
> Sent: Tuesday, August 26, 2014 10:40 AM
> To: Saurabh Shah
> Cc: dev@openvswitch.org
> Subject: RE: Cloning packets for "action: set field"
>
> Hi Saurabh,
>
> That may not be a very easy answ
On Thu, Aug 21, 2014 at 06:18:59PM +0200, Jiri Pirko wrote:
> Dummy switch implementation using switchdev interface
>
[...]
> + if (!data || !data[IFLA_DYMMYSWPORT_PHYS_SWITCH_ID])
[...]
> + dsp->psid.id_len = nla_len(data[IFLA_DYMMYSWPORT_PHYS_SWITCH_ID]);
> + memcpy(dsp->psid.id, nla
On Aug 26, 2014, at 3:01 AM, Thomas Graf wrote:
> The branch is unused as size < sizeof dst->inline_values must
> always be true for inlined values. Hitting the branch would lead
> to corruption as inline_values is accessed out of bounds.
>
Miniflows can also be dynamically allocated to have m
On Mon, Aug 25, 2014 at 6:32 PM, Pravin Shelar wrote:
> On Mon, Aug 25, 2014 at 3:24 PM, Andy Zhou wrote:
>> If recirc action is the last action of a action list, the SKB triggers
>> the recirc will be freed twice. This patch fixes this bug.
>>
>> Reported-by: Justin Pettit
>> Signed-off-by: And
On Tue, Aug 26, 2014 at 05:19:56PM +0100, Thomas Graf wrote:
> On 08/26/14 at 11:54am, Andy Gospodarek wrote:
> > It is easy to *say* it could be added later, but connecting to software
> > forwarding in the kernel outside of OVS (which is important to some)
> > would take significant effort since
Git also told me so. :). Thanks.
On Tue, Aug 26, 2014 at 11:30 AM, Ben Pfaff wrote:
> Too late, I already got this one ;-)
>
> On Tue, Aug 26, 2014 at 11:24:17AM -0700, Andy Zhou wrote:
>> Thanks for the fix. Will push in a short while.
>>
>> Acked-by: Andy Zhou
>>
>> On Tue, Aug 26, 2014 at 9:3
Too late, I already got this one ;-)
On Tue, Aug 26, 2014 at 11:24:17AM -0700, Andy Zhou wrote:
> Thanks for the fix. Will push in a short while.
>
> Acked-by: Andy Zhou
>
> On Tue, Aug 26, 2014 at 9:34 AM, Thomas Graf wrote:
> > Current unconditional call may result in NULL being passed to
>
On Tue, Aug 26, 2014 at 06:36:08PM +0200, Thomas Graf wrote:
> Signed-off-by: Thomas Graf
> ---
> lib/dpif-netdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 7401293..c7a1242 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
Thanks for the fix. Will push in a short while.
Acked-by: Andy Zhou
On Tue, Aug 26, 2014 at 9:34 AM, Thomas Graf wrote:
> Current unconditional call may result in NULL being passed to
> nl_msg_put_u32().
>
> Cc: Andy Zhou
> Signed-off-by: Thomas Graf
> ---
> lib/odp-util.c | 4 +++-
> 1 file
On Tue, Aug 26, 2014 at 09:15:07AM -0700, Nithin Raju wrote:
> I didn't realize earlier while defining OvsDpInterfaceExt.h that
> there are special values defined in netlink-protocol.h for nlmsg_type.
> For Eg. NLMSG_ERROR is defined to be 2. In this patch, we update the
> values of the family IDs
On Tue, Aug 26, 2014 at 09:08:16AM -0700, Nithin Raju wrote:
> A typo crept in while respinning get_sock_pid_from_kernel() in the previous
> patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT
> argument. Fixing that too.
Needs a Signed-off-by.
__
On Tue, Aug 26, 2014 at 09:02:07AM -0700, Nithin Raju wrote:
> ---
Needs a Signed-off-by.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 26, 2014 at 06:25:13PM +0200, Thomas Graf wrote:
> On 08/26/14 at 09:15am, Ben Pfaff wrote:
> > On Tue, Aug 26, 2014 at 12:24:04PM +0200, Thomas Graf wrote:
> > > Causes the build script to fail if any command inside the
> > > script returns nonzero.
> > >
> > > Signed-off-by: Thomas G
Is your mininet packaging targeted at jessie? That is, do you need
ovs-testcontroller in jessie or just in jessie+1? It makes a
difference because jessie will have Open vSwitch 2.3, but the
ovs-testcontroller change will only be in 2.4, and I do not want to
backport the change to 2.3 unless I rea
On Thu, Aug 21, 2014 at 05:42:02PM +1200, Joe Stringer wrote:
> Currently, when a revalidator thread first dumps a flow, it creates a
> 'udpif_key' object and caches a copy of a kernel flow key. This allows
> us to perform lookups in the classifier to attribute stats and validate
> the correctness
Thx, applied to master and branch-2.3,
On Tue, Aug 26, 2014 at 12:26 AM, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> On August 25, 2014 at 10:42:24 PM, Alex Wang (al...@nicira.com) wrote:
> > Signed-off-by: Alex Wang
> > ---
> > vswitchd/vswitch.xml | 2 +-
> > 1 file chan
Nithin,
Perhaps it will also be useful if you could show the relationship between
OVS_WIN_NL_VPORT_MCGRP_ID and OVS_WIN_NL_MCGRP_START_ID in OvsDpInterfaceExt.h.
Something like:
[CODE]
#define OVS_WIN_NL_MCGRP_START_ID100
#define OVS_WIN_NL_VPORT_MCGRP_ID (OVS_WIN_NL_MCGRP
On Fri, Aug 22, 2014 at 04:31:11PM -0700, Justin Pettit wrote:
> On Fri, Aug 15, 2014 at 10:28 AM, Ben Pfaff wrote:
> > diff --git a/NEWS b/NEWS
> > index 1ea7bda..656f750 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -17,6 +17,9 @@ Post-v2.3.0
> > * OpenFlow 1.5 (draft) Copy-Field action is n
Hi Saurabh,
That may not be a very easy answer, but, a better way would be, I believe:
headRoom -> encapBytes
copySize -> headersSize
copySize + headRoom -> (new variable) newMdlSize
It would also be very useful to have documentation comments on the parameters,
e.g.
/*
* headersSize:the numb
hi Samuel,
Sure, I can trim the list to have only the OVS_WIN_NL_VPORT_MCGRP_ID defined
and nothing else. Pls. do note that we also need the OVS_WIN_NL_MCGRP_START_ID.
I'll respin the patch and send it out.
thanks,
Nithin
On Aug 26, 2014, at 9:55 AM, Samuel Ghinet
wrote:
> Hello Nithin,
>
>
hi Alin/Sam,
These were the items we wanted to discuss:
1. Netlink implementation:
* status
* work has been spread out now, and issues have been created for each
individual task. There should be no confusion now. This was the plan all along,
BTW. We'll discuss anything that is not clear.
2.
On Tue, 26 Aug 2014 15:23:24 +0300
Or Gerlitz wrote:
> just a nit, but if this approach/patch goes in, any reason not to change
> IFLA_PHYS_PORT_ID to IFLA_PHYS_ITEM_ID?
Userspace API
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mai
Hello Nithin,
If there are great odds that only the VPORT multicast group will be used, I
think it would be best not to add the other multicast group ids.
If a need will arise in the future to add support for multicast groups for
datapath, packet, etc. it would be best done only then.
I think t
Signed-off-by: Thomas Graf
---
lib/dpif-netdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 7401293..c7a1242 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -669,6 +669,8 @@ do_add_port(struct dp_netdev *dp, const char *devname,
co
Current unconditional call may result in NULL being passed to
nl_msg_put_u32().
Cc: Andy Zhou
Signed-off-by: Thomas Graf
---
lib/odp-util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 19d0627..8a96068 100644
--- a/lib/odp-util.c
+
Thanks Ben!
From: Ben Pfaff [b...@nicira.com]
Sent: Friday, August 22, 2014 7:59 PM
To: Samuel Ghinet
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] Agenda for IRC neeting for 8/13 (Nithin Raju)
On Fri, Aug 22, 2014 at 04:27:01PM +, Samuel Ghinet wrote:
Acked-by: Ankur Sharma
Regards,
Ankur
From: Ankur Sharma
Sent: Tuesday, August 26, 2014 9:21 AM
To: Nithin Raju; dev@openvswitch.org
Subject: RE: [PATCH] datapath-windows: trivial formatting changes in Netlink.c
Hi,
Changes are fine.
Acked.
Regards,
Ank
On 08/26/14 at 09:15am, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 12:24:04PM +0200, Thomas Graf wrote:
> > Causes the build script to fail if any command inside the
> > script returns nonzero.
> >
> > Signed-off-by: Thomas Graf
>
> We don't seem to have the file that this modifies. Did I miss
Hi,
Changes are fine.
Acked.
Regards,
Ankur
From: Nithin Raju
Sent: Tuesday, August 26, 2014 9:02 AM
To: dev@openvswitch.org; Ankur Sharma
Cc: Nithin Raju
Subject: [PATCH] datapath-windows: trivial formatting changes in Netlink.c
---
datapath-windows/ov
On 08/26/14 at 11:54am, Andy Gospodarek wrote:
> It is easy to *say* it could be added later, but connecting to software
> forwarding in the kernel outside of OVS (which is important to some)
> would take significant effort since this set only connects switch
> hardware to OVS.
Can you explain why
On Tue, Aug 26, 2014 at 12:24:04PM +0200, Thomas Graf wrote:
> Causes the build script to fail if any command inside the
> script returns nonzero.
>
> Signed-off-by: Thomas Graf
We don't seem to have the file that this modifies. Did I miss a patch?
__
I didn't realize earlier while defining OvsDpInterfaceExt.h that
there are special values defined in netlink-protocol.h for nlmsg_type.
For Eg. NLMSG_ERROR is defined to be 2. In this patch, we update the
values of the family IDs to not clash with the special defines.
I'm using NLMSG_MIN_TYPE as a
On Tue, Aug 26, 2014 at 12:23:03PM +0200, Thomas Graf wrote:
> nodes is allocated through shash_sort() but never freed.
>
> Signed-off-by: Thomas Graf
Wow, that's a long-standing bug. It looks like in practice we only ever
hash objects used as identifiers in the OVSDB protocol, and it's not
lik
On Tue, Aug 26, 2014 at 12:01:34PM +0200, Thomas Graf wrote:
> The branch is unused as size < sizeof dst->inline_values must
> always be true for inlined values. Hitting the branch would lead
> to corruption as inline_values is accessed out of bounds.
>
> Remove branch and add assertion.
>
> Cc:
A typo crept in while respinning get_sock_pid_from_kernel() in the previous
patch. Fixing it now. Also, get_sock_pid_from_kernel() doesn't need an OUT
argument. Fixing that too.
---
lib/netlink-socket.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/netlink-s
---
datapath-windows/ovsext/Netlink.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/datapath-windows/ovsext/Netlink.c
b/datapath-windows/ovsext/Netlink.c
index 1c8d054..7b50221 100644
--- a/datapath-windows/ovsext/Netlink.c
+++ b/datapath-windows/ovsext/N
> On Aug 26, 2014, at 8:48 AM, Ben Pfaff wrote:
>
>> On Mon, Aug 25, 2014 at 06:13:14PM +0200, Thomas Graf wrote:
>> Can you setup a mailing list for the reports on openvswitch.org
>> and set an environment variable in the github settings to contain
>> the address of the list? [1]
>
> Justin, c
On Tue, Aug 26, 2014 at 05:44:59PM +0200, Jiri Pirko wrote:
> Tue, Aug 26, 2014 at 05:29:10PM CEST, j...@mojatatu.com wrote:
> >On 08/26/14 11:22, Jiri Pirko wrote:
> >
> >>I do not think that really matters. Phase one is flows. After that we
> >>can focus on l2/l3. If we would be able to fit in in
On Mon, Aug 25, 2014 at 06:13:14PM +0200, Thomas Graf wrote:
> Can you setup a mailing list for the reports on openvswitch.org
> and set an environment variable in the github settings to contain
> the address of the list? [1]
Justin, can we create an "ovs-build" or "ovs-ci" mailing list?
_
1 - 100 of 126 matches
Mail list logo
