> Sorry, this was wrong. I mean this (as you suggested):
>
> +OVS_VSCTL_CHECK_RX_PKT([p1], [1])
> dnl advance the clock by 100K ms, the previous 'recv' should be updated.
> -for i in `seq 0 100`; do ovs-appctl time/warp 1000; done
> +for i in `seq 0 99`; do ovs-appctl time/warp 1000; done
> OVS
Thanks a lot for the fix, YAMAMOTO,
@@
Just reminder, this also requires backport to branch-2.2.
On Fri, May 2, 2014 at 4:49 PM, Ben Pfaff wrote:
> On Sat, May 03, 2014 at 08:10:01AM +0900, YAMAMOTO Takashi wrote:
> > Introduced by commit 12eb035b.
> > ("bridge: Allow users to configure stati
This file was obtained from:
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_func_posix_memalign.m4
Signed-off-by: YAMAMOTO Takashi
---
m4/ax_func_posix_memalign.m4 | 50
1 file changed, 50 insertions(+)
create mode 10
A malloc library is expected to provide a better implementation
using the knowledge of its internal details.
Signed-off-by: YAMAMOTO Takashi
---
lib/util.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/util.c b/lib/util.c
index 464d730..37d2ba0 100644
--- a/lib/util.
Signed-off-by: YAMAMOTO Takashi
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 9672cb0..16bc6a6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -91,6 +91,7 @@ OVS_CHECK_ATOMIC_ALWAYS_LOCK_FREE(8)
OVS_CHECK_POSIX_AIO
OVS_CHECK_PTHREAD_SET_N
xmalloc_cacheline API is relatively new. It's better
not to inherit the kludge from xmalloc. This kind of
kludge rather hurts these days.
Signed-off-by: YAMAMOTO Takashi
---
lib/util.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/util.c b/lib/util.c
index 1ebe22a..464d730 100644
---
On Sat, May 03, 2014 at 08:12:02AM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sat, May 03, 2014 at 08:12:03AM +0900, YAMAMOTO Takashi wrote:
> Complained by clang 3.4.
>
> lib/route-table-bsd.c:35:1: error: unused variable 'THIS_MODULE'
> [-Werror,-Wunused-const-variable]
> VLOG_DEFINE_THIS_MODULE(route_table);
> ^
> ./lib/vlog.h:176:42: note: expanded from macro '
On Sat, May 03, 2014 at 08:10:01AM +0900, YAMAMOTO Takashi wrote:
> Introduced by commit 12eb035b.
> ("bridge: Allow users to configure statistics update to OVSDB.")
>
> Cc: Alex Wang
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mail
On Sat, May 03, 2014 at 08:12:01AM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sat, May 03, 2014 at 08:09:59AM +0900, YAMAMOTO Takashi wrote:
> Introduced by commit 12eb035b.
> ("bridge: Allow users to configure statistics update to OVSDB.")
>
> Cc: Alex Wang
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mail
On Sat, May 03, 2014 at 08:10:00AM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sat, May 03, 2014 at 08:13:20AM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
All four patches look good to me,
Acked-by: Alex Wang
On Wed, Apr 30, 2014 at 10:51 AM, Ben Pfaff wrote:
> I've had a number of requests for more specific logging of flow_mod
> information. It is useful for troubleshooting.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/connmgr.c |
Signed-off-by: YAMAMOTO Takashi
---
FAQ | 6 ++
1 file changed, 6 insertions(+)
diff --git a/FAQ b/FAQ
index 86b48a2..519060a 100644
--- a/FAQ
+++ b/FAQ
@@ -431,6 +431,12 @@ A: First, why do you want to do this? Two connected
bridges are not
ports will not work with the userspace datap
Signed-off-by: YAMAMOTO Takashi
---
lib/route-table-bsd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c
index 4cdf2ac..d02c76f 100644
--- a/lib/route-table-bsd.c
+++ b/lib/route-table-bsd.c
@@ -29,6 +29,7 @@
#include
#inc
Complained by clang 3.4.
lib/route-table-bsd.c:35:1: error: unused variable 'THIS_MODULE'
[-Werror,-Wunused-const-variable]
VLOG_DEFINE_THIS_MODULE(route_table);
^
./lib/vlog.h:176:42: note: expanded from macro 'VLOG_DEFINE_THIS_MODULE'
static struct vlog_module *const THIS_MODULE =
Signed-off-by: YAMAMOTO Takashi
---
lib/netdev-bsd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
index ef1e649..8291182 100644
--- a/lib/netdev-bsd.c
+++ b/lib/netdev-bsd.c
@@ -548,7 +548,7 @@ struct pcap_arg {
static void
Introduced by commit 12eb035b.
("bridge: Allow users to configure statistics update to OVSDB.")
Cc: Alex Wang
Signed-off-by: YAMAMOTO Takashi
---
vswitchd/bridge.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 1145e98..4
Signed-off-by: YAMAMOTO Takashi
---
tests/ovs-vswitchd.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at
index a90477d..9f9721b 100644
--- a/tests/ovs-vswitchd.at
+++ b/tests/ovs-vswitchd.at
@@ -39,7 +39,7 @@ AT_SETUP([ovs-vsw
Introduced by commit 12eb035b.
("bridge: Allow users to configure statistics update to OVSDB.")
Cc: Alex Wang
Signed-off-by: YAMAMOTO Takashi
---
tests/ovs-vswitchd.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at
index 9f9721b
Thanks for the review.
Overnight, I found myself thinking about an alternative approach that
might perform even better. I am going to do a few experiments to find
out before I make any specific responses to your comments. (But I
imagine that many of them will apply anyway.)
On Fri, May 02, 2014
>
> Assuming you tested it and it fixed the problem,
> Acked-by: Ben Pfaff
>
Thanks Ben,
Yes, I have confirmed the fix. Pushed to master and branch-2.2
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 02, 2014 at 11:15:46AM -0700, Alex Wang wrote:
> Commit 3e912ffcbb (netdev: Add 'change_seq' back to netdev.) added per-
> netdev change number for indicating status change. Future commits used
> this change number to optimize the netdev status update to database.
> However, the work a
Thx for the review, applied to master, branch-2.2
On Thu, May 1, 2014 at 7:21 PM, Joe Stringer wrote:
> On 30 April 2014 12:46, Alex Wang wrote:
>>
>> +dnl set the stats update interval to 100K ms, the following 'recv'
>> should not be updated.
>> +AT_CHECK([ovs-vsctl set O . other_config:stat
On Fri, May 2, 2014 at 1:14 PM, Alex Wang wrote:
>
>
>
> On Thu, May 1, 2014 at 7:21 PM, Joe Stringer wrote:
>
>> On 30 April 2014 12:46, Alex Wang wrote:
>>>
>>> +dnl set the stats update interval to 100K ms, the following 'recv'
>>> should not be updated.
>>> +AT_CHECK([ovs-vsctl set O . other
On Thu, May 1, 2014 at 7:21 PM, Joe Stringer wrote:
> On 30 April 2014 12:46, Alex Wang wrote:
>>
>> +dnl set the stats update interval to 100K ms, the following 'recv'
>> should not be updated.
>> +AT_CHECK([ovs-vsctl set O . other_config:stats-update-interval=10])
>> +for i in `seq 0 50`;
Thanks for the review,
Tested again and applied to master, branch-2.2
On Thu, May 1, 2014 at 8:36 AM, Ben Pfaff wrote:
> On Tue, Apr 29, 2014 at 11:06:29AM -0700, Alex Wang wrote:
> > Commit 6b59b543 (ovs-thread: Use fair (but nonrecursive)
> > rwlocks on glibc.) changed the rwlocks to nonrecu
On May 1, 2014, at 5:14 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-netdev.c | 153 +
> 1 file changed, 73 insertions(+), 80 deletions(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 55712dd..2dddad5 100
On May 1, 2014, at 5:14 PM, Ben Pfaff wrote:
…
> The results show:
>
>- Insertion is generally 3x to 5x faster in an hmap.
>
>- Iteration is generally about 3x faster in a cmap.
>
>- Search and mutation is 4x faster with .1% mutations and the
> advantage grows as the fraction
Commit 3e912ffcbb (netdev: Add 'change_seq' back to netdev.) added per-
netdev change number for indicating status change. Future commits used
this change number to optimize the netdev status update to database.
However, the work also introduced the bug in the following scenario:
- assume interfa
On Fri, May 2, 2014 at 3:04 AM, Suresh Kumar Reddy Reddygari
wrote:
>
>
>> -Original Message-
>> From: Jesse Gross [mailto:je...@nicira.com]
>> Sent: Thursday, May 01, 2014 10:07 PM
>> To: Suresh Kumar Reddy Reddygari
>> Cc: dev@openvswitch.org
>> Subject: Re: [ovs-dev] MacVTap support in
Thanks Ben for the review, my reply below,
>
> > Bug #1240626
> >
> > Signed-off-by: Alex Wang
>
> The new version of tunnel_check_status_change__() uses memset(),
> memcpy(), and memcmp() to work with strings. Is there some reason that
> one can't use the normal approach for strings, e.g. set
On Thu, May 01, 2014 at 04:20:05PM -0700, Alex Wang wrote:
> Commit 3e912ffcbb (netdev: Add 'change_seq' back to netdev.) added per-
> netdev change number for indicating status change. Future commits used
> this change number to optimize the netdev status update to database.
> However, the work a
On Fri, May 02, 2014 at 09:54:27AM +0300, Alexandru Copot wrote:
> This is only the communication part of the bundles functionality.
> The actual message pre-validation and commits are not implemented.
>
> We also enable OF1.4 for all the tests.
>
> Signed-off-by: Alexandru Copot
> Cc: Daniel Ba
Unless otherwise configured, the prefix trie lookup is enabled for
IPv4 destination and source address fields. A new keyword "none" is
accepted as the value of "prefixes" in the OVSDB Flow_Table column.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto.c| 10 ++
ofproto/ofproto.h
On Fri, May 2, 2014 at 6:22 AM, Thomas F Herbert
wrote:
> On 5/1/2014 4:21 PM, Jesse Gross wrote:
>>
>> On Wed, Apr 30, 2014 at 4:46 PM, Andy Zhou wrote:
>>>
>>> diff --git a/datapath/actions.c b/datapath/actions.c
>>> index 5871d82..5556a0c 100644
>>> --- a/datapath/actions.c
>>> +++ b/datapath/
On Thu, May 01, 2014 at 03:47:44PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 02, 2014 at 02:10:19PM +0900, Simon Horman wrote:
> I would be happy to do without this stopgap measure if
> (a rebased version of) the recirculation MPLS would be considered
> with the caveat that packets with an in_port that doesn't exist
> in the datapath can't be recirculated (yet).
On Fri, May 02, 2014 at 01:13:43PM +1200, Joe Stringer wrote:
> Previously, it was possible to open a netdevice as one type, then
> proceed to open it as a different type without first closing it. The
> bridge code would expect it to be opened as the latter type and try to
> apply configuration to
On Fri, May 02, 2014 at 01:13:42PM +1200, Joe Stringer wrote:
> netdev_open() would previously increment a netdev's refcount without
> holding a lock for it. This commit shifts the locking to protect it.
>
> Found by inspection.
>
> Signed-off-by: Joe Stringer
Should we backport this?
Acked-by
On Fri, May 02, 2014 at 01:13:41PM +1200, Joe Stringer wrote:
> netdev_rxq_open() open-codes much of netdev_ref(), so re-use that
> function instead.
>
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://o
On Thu, May 01, 2014 at 06:37:24PM -0700, Bruce Davie wrote:
> Signed-off-by: Bruce Davie
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, May 02, 2014 at 05:41:35PM +0900, Simon Horman wrote:
> This is to allow a recirculation id to be associated with a rule
> in the case that its actions cause recirculation.
>
> In such a case if the recirc_id field is non-zero then that value should be
> used, otherwise a value should be o
On Fri, May 02, 2014 at 05:41:33PM +0900, Simon Horman wrote:
> This will be used by a subsequent patch to add support for
> recirculation for MPLS.
>
> Signed-off-by: Simon Horman
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvs
On Fri, May 02, 2014 at 05:41:32PM +0900, Simon Horman wrote:
> This is in preparation for using the same helper as part of support
> for using recirculation in conjunction series of actions including
> with MPLS actions that are currently not able to be translated.
>
> In that scenario this helpe
On 5/1/2014 4:21 PM, Jesse Gross wrote:
On Wed, Apr 30, 2014 at 4:46 PM, Andy Zhou wrote:
diff --git a/datapath/actions.c b/datapath/actions.c
index 5871d82..5556a0c 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
@@ -644,22 +649,24 @@ static DEFINE_PER_CPU(struct loop_counter, loop_co
> -Original Message-
> From: Jesse Gross [mailto:je...@nicira.com]
> Sent: Thursday, May 01, 2014 10:07 PM
> To: Suresh Kumar Reddy Reddygari
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] MacVTap support in OVS
>
> On Thu, May 1, 2014 at 2:00 AM, Suresh Kumar Reddy Reddygari
> wrot
Thanks Ben, I have send v2.
On 01/05/14 8:30 PM, "Ben Pfaff" wrote:
>On Mon, Apr 28, 2014 at 10:25:21PM -0700, Arun Sharma wrote:
>> For each field, if the mask is all zeros, don't print it at all,
>> if it is all ones, print it without the mask trailer.
>> If it is neither of those two, print t
This is to allow a recirculation id to be associated with a rule
in the case that its actions cause recirculation.
In such a case if the recirc_id field is non-zero then that value should be
used, otherwise a value should be obtained using
ofproto_dpif_alloc_recirc_id and saved in recirc_id field.
This will be used by a subsequent patch to add support for
recirculation for MPLS.
Signed-off-by: Simon Horman
---
v4
* Rebase
v3
* No change
v2
* First post
---
ofproto/ofproto-dpif.c | 7 +++
ofproto/ofproto-dpif.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/ofproto/ofproto-d
This is in preparation for using this value
in ofproto-dpif-xlate.c when composing recirculation
actions added as a result of processing (MPLS) actions.
Signed-off-by: Simon Horman
---
ofproto/bond.c | 1 -
ofproto/ofproto-dpif.h | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
This is in preparation for using the same helper as part of support
for using recirculation in conjunction series of actions including
with MPLS actions that are currently not able to be translated.
In that scenario this helper will be used to test if load, move and
set_field actions require recir
This is in preparation for using the same helper as part of support
for using recirculation in conjunction series of actions including
with MPLS actions that are currently not able to be translated.
In that scenario the idle timeout will be used to expire internal
rules that are added to handle re
With recirculation in place this should be safe.
XXX: What if recirculation is disabled???
Signed-off-by: Simon Horman
---
lib/ofp-actions.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index ce14004..69d6505 100644
--- a/lib/ofp-actions.c
+++ b
In some cases an pop MPLS action changes a packet to be a non-mpls packet.
In this case subsequent any L3+ actions require access to portions
of the packet which were not decoded as they were opaque when the
packet was MPLS. Allow such actions to be translated by
first recirculating the packet.
Si
This makes maintaining the controller test slightly easier
by splitting it in two.
Based on a similar patch by Joe Stringer.
Cc: Joe Stringer
Signed-off-by: Simon Horman
--
v3
* Rebase
v2
* No change
v1
* Taken from another patch-set and re-worked
---
tests/ofproto-dpif.at | 353 +++
The motivation of this series is to allow some sequences of actions
that include MPLS actions to be performed using recirculation.
Sequences of actions that could not previously be handled.
For example pop_mpls:0x0800,dec_ttl.
This uses recirculation after the pop_mpls action to allow access to
On Thu, May 01, 2014 at 10:50:49PM -0700, Andy Zhou wrote:
> Thanks you for clarifying the need. Since there is no urgent need to
> introduce a stop gap measure, I am happy to drop this patch for now.
Thanks, I think that is the best approach for now.
I'll should be able to send out a revised re
59 matches
Mail list logo
