The logic looks good. 233 unit tests failed now. Apparently this
patch is great doing a great job on catching uninitialized mutex and
rwlocks.
Assume the tests will be fixed before checking in:
Acked-by: Andy Zhou
___
dev mailing list
dev@openvswitch.
Acked-by: Andy Zhou
With a question inline.
On Thu, Apr 24, 2014 at 4:59 PM, Ben Pfaff wrote:
> If the 'lacp' parameter is nonnull, then we know that the file scope mutex
> has been initialized, since that's done as a side effect of creating a
> lacp object, but otherwise there's no guarantee.
i'll kick an overnight run on "learning action - self-modifying flow with
idle_timeout".~ (seq 1). if it survives, tmr morning,
i'll ack it~~
On Thu, Apr 24, 2014 at 10:26 PM, Joe Stringer wrote:
> revalidate_ukey() had a bug where it would update the ukey->stats even
> if it decided not to
Bond rebalancing was disabled for bonds not using recirculation. The
patch fixes this bug.
While fixing the bug, the bond_rebalance() was also restructured
slightly to move bond related logic back into ofproto/bond.c
Signed-off-by: Andy Zhou
---
ofproto/bond.c | 21 +++--
When recirc pool is exhausted, a new bond won't be allocate a new
recirc_id. The bond->recirc_id will remain zero. This condition
should prevent the bond from use recirculation. This check was missing
before this patch.
Signed-off-by: Andy Zhou
---
ofproto/bond.c | 2 +-
1 file changed, 1 insert
revalidate_ukey() had a bug where it would update the ukey->stats even
if it decided not to push stats (as an optimisation). ukey->stats should
only be updated when those stats are pushed.
This bug would arise in the following situation:
* A flow has been dumped before.
* The flow needs to be reva
On Tue, Apr 22, 2014 at 05:54:48PM +0900, Simon Horman wrote:
>
> The motivation of this series is to allow some sequences of actions
> that include MPLS actions to be performed using recirculation.
> Sequences of actions that could not previously be handled.
>
> For example pop_mpls:0x0800,dec_t
I sent a V2 based Ben's suggestion.
On Thu, Apr 24, 2014 at 3:45 PM, Ben Pfaff wrote:
> On Thu, Apr 24, 2014 at 03:41:52PM -0700, Gurucharan Shetty wrote:
>> On Thu, Apr 24, 2014 at 2:48 PM, Andy Zhou wrote:
>> > Visual studio does not support 0 size array within a struct,
>> > but supports flex
On Wed, Apr 16, 2014 at 12:18 PM, Lori Jakab wrote:
> On 4/16/14, 2:57 AM, Jesse Gross wrote:
>>
>> On Fri, Apr 11, 2014 at 4:30 AM, Lori Jakab wrote:
>>>
>>> On 4/11/14, 1:47 AM, Jesse Gross wrote:
On Thu, Mar 20, 2014 at 4:37 AM, Lori Jakab wrote:
>
> On 1/6/14, 7:55 PM, Jess
On Thu, Apr 24, 2014 at 4:30 PM, Jarno Rajahalme wrote:
>
> On Apr 24, 2014, at 3:32 PM, Ben Pfaff wrote:
>
>> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
>>> I suppose the other possibility is to pass some kind of flag attribute
>>> with messages indicating that this is a test p
I haven't read this patch yet, but a high level question. Why not
just hide all of struct cls_rule and make callers embed a pointer to
it? We'd replace the cls_rule_init() function with a
cls_rule_create() function which mallocs the rule and returns it (for
example).
Ethan
On Fri, Apr 18, 2014
In the cache_push_back function, you might consider using the
x2nrealloc() function.
Does this actually help? I've found we spend most of our time getting
the memory for the rule, not the subtable itself.
Ethan
On Fri, Apr 18, 2014 at 12:41 PM, Jarno Rajahalme wrote:
> Using a linear array all
I think there should be a comment explaining when to use prefetch vs
prefetch_write. I certainly don't know off the top of my head.
Acked-by: Ethan Jackson
On Fri, Apr 18, 2014 at 12:41 PM, Jarno Rajahalme wrote:
> Define OVS_PREFETCH() and OVS_PREFETCH_WRITE() using builtin prefetch
> for GC
Acked-by: Ethan Jackson
On Fri, Apr 18, 2014 at 12:41 PM, Jarno Rajahalme wrote:
> We only need to iterate over the bits masked by the 'b' in
> minimask_has_extra(), since for zeroes in 'b' there can be no 'extra'
> wildcards in 'a', as 'b' has already wildcarded all the bits.
>
> minimask_is_c
Looking again, it's probably better to change the lines which look for
"monitor thread created" and "..terminated" to be OVS_WAIT_UNTIL. I plan to
send a fresh version.
On 25 April 2014 12:34, Joe Stringer wrote:
> Occasionally, test #770 "ofproto-dpif - ofproto-dpif-monitor 1" would
> fail, be
So it seems to me that the only data needed in struct classifier by
callers is the fat_rwlock. What if we add a classifier_rdlock() and a
classifier_wrlock() function. That done, we could entirely hide
struct classifier, and would need to make the distinction between it
and the cls_classifier. T
Occasionally, test #770 "ofproto-dpif - ofproto-dpif-monitor 1" would
fail, because the testsuite looked in the logs for evidence of a thread
being created, but it checked before vswitchd was able to spawn the
thread.
This patch fixes the race by waiting until there is a reasonable amount
of logs
Acked-by: Ethan Jackson
On Fri, Apr 18, 2014 at 12:41 PM, Jarno Rajahalme wrote:
> This was the only place in OVS code that accessed classifier internal
> data structures directly. Use the classifier cursor API instead, so
> that following patches can hide classifier internal data structures.
Visual studio supports zero-size array within a struct or union,
but has to be the last element. GCC does not have this restriction.
Commits 644cfd84772eb7d8 and 6fdaa45a6f6c9 make use of 0 size array.
Remove them so that visual studio can compile them as well.
Reported-by: Gurucharan Shetty
Sig
The first line in the commit message needs a period.
As Yamamoto asked, please verify that this actually helps. If it
doesn't I'd prefer not to merge it.
I think we need to get rid of the hindex anyways, so I'd prefer we
don't inline it now.
Assuming the above is addressed:
Acked-by: Ethan Jac
Jesse, Ben, Jarno et. al,
This message although harmless can be confusing for developers who are
introducing new functionality and testing it on the datapath. When I
first turned on logging and saw it, I thought it was my bug until I
found saw it in the master branch.
I will take no action
On Tue, Apr 22, 2014 at 2:08 PM, Pritesh Kothari
wrote:
> diff --git a/datapath/linux/compat/include/linux/skbuff.h
> b/datapath/linux/compat/include/linux/skbuff.h
> index b0d0190..f47ccfe 100644
> --- a/datapath/linux/compat/include/linux/skbuff.h
> +++ b/datapath/linux/compat/include/linux/skb
In the commit message s/suppoort/support/
Out of curiosity why replace the miniflow_get inline functions with macros?
> +/* Separate loops for better optimization. */
Why do we need separate loops? You think it somehow improves the
branch predictor or something? Does this actually help
On Tue, Apr 22, 2014 at 2:08 PM, Pritesh Kothari
wrote:
> diff --git a/acinclude.m4 b/acinclude.m4
> index 4269620..06983cb 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -244,6 +244,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>OVS_GREP_IFELSE([$KSRC/include/linux/err.h], [ERR_CAST])
>
>
With glibc, a mutex or rwlock filled with all-zero-bytes is properly
initialized for use, but this is not true for any other libc that OVS
supports. However, OVS gets a lot more testing with glibc than any other
libc. This means that developers keep introducing bugs that do not
manifest on the ma
If the 'lacp' parameter is nonnull, then we know that the file scope mutex
has been initialized, since that's done as a side effect of creating a
lacp object, but otherwise there's no guarantee.
Signed-off-by: Ben Pfaff
---
lib/lacp.c | 18 +-
1 file changed, 9 insertions(+), 9
This commit adds per 'struct ofproto_dpif' sequence number for
packet-in I/O. Whenever ofproto_dpif_send_packet_in() is called,
the calling thread will change the sequence number to wake up the
main thread.
Signed-off-by: Alex Wang
Acked-by: Joe Stringer
---
V4 -> V5:
- always call seq_change(
This commit refactors the 'Instant' stats related logic in bridge.c
by moving it into bridge_run().
This change brings the following effects:
1. bridge.c will wait on the global connectivity sequence number when
there is no pending instant stats transaction. and the main thread
will no lon
I removed the comments from the .h file before pushing.
Jarno
On Apr 23, 2014, at 4:53 PM, Ethan Jackson wrote:
> Traditionally we've put function comments just in the .c file, not in
> the .c and .h file as you've done for rule_dpif_lookup(). That said,
> I don't know where that convention
Thanks for the review!
The series pushed to master,
Jarno
On Apr 23, 2014, at 4:56 PM, Ethan Jackson wrote:
> LGTM
>
> Acked-by: Ethan Jackson
>
>
> On Wed, Apr 23, 2014 at 4:20 PM, Jarno Rajahalme
> wrote:
>> Only take reference to a looked up rule when needed.
>>
>> This reduces the
On Apr 24, 2014, at 3:32 PM, Ben Pfaff wrote:
> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
>> I suppose the other possibility is to pass some kind of flag attribute
>> with messages indicating that this is a test probe and would silence
>> logging. Existing kernels would ignore
On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
> hi,
>
> > + * Due to the sample action there may be multiple possible eth types.
> > + * In order to correctly validate actions all possible types are tracked
> > + * and verified. This is done using struct eth_types.
>
> is ther
On Thu, Apr 24, 2014 at 4:14 PM, Ben Pfaff wrote:
> On Thu, Apr 24, 2014 at 4:01 PM, Jesse Gross wrote:
>> On Thu, Apr 24, 2014 at 3:32 PM, Ben Pfaff wrote:
>>> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
I suppose the other possibility is to pass some kind of flag attribut
On Thu, Apr 24, 2014 at 4:01 PM, Jesse Gross wrote:
> On Thu, Apr 24, 2014 at 3:32 PM, Ben Pfaff wrote:
>> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
>>> I suppose the other possibility is to pass some kind of flag attribute
>>> with messages indicating that this is a test probe
On Fri, Apr 11, 2014 at 11:18 AM, Ben Pfaff wrote:
> It seems that it is useful to admins after all.
>
> Reported-by: Brian Candler
> Signed-off-by: Ben Pfaff
> ---
> debian/openvswitch-switch.manpages |1 +
> rhel/openvswitch-fedora.spec.in|3 ++-
> utilities/automake.mk
On Thu, Apr 24, 2014 at 3:32 PM, Ben Pfaff wrote:
> On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
>> I suppose the other possibility is to pass some kind of flag attribute
>> with messages indicating that this is a test probe and would silence
>> logging. Existing kernels would igno
Thanks for the review, Joe
Replies inline,
On 18 April 2014 08:32, Alex Wang wrote:
>
>> This commit removes the 'Instant' stats related logic in bridge.c.
>> Instead, the corresponding status is updated immediately after the
>> global connectivity sequence number changes.
>>
>
> Could you updat
On Tue, Apr 22, 2014 at 02:15:11PM -0700, Gurucharan Shetty wrote:
> This code path currently does not initialize
> netdev_class_mutex.
> dummy_enable
> ->netdev_dummy_register
>->netdev_register_provider
> ->ovs_mutex_lock(&netdev_class_mutex)
>
> ovsdb-server on windows crashes without
On Tue, Apr 22, 2014 at 02:15:12PM -0700, Gurucharan Shetty wrote:
> Currently, we are calling guarded_list_destroy()
> to destroy a mutex and then go ahead and use it through
> delete_group
> ->delete_group__
>->handle_flow_mod__
> ->run_rule_executes
> ->guarded_list_pop_all
>
> Th
On Thu, Apr 24, 2014 at 03:41:52PM -0700, Gurucharan Shetty wrote:
> On Thu, Apr 24, 2014 at 2:48 PM, Andy Zhou wrote:
> > Visual studio does not support 0 size array within a struct,
> > but supports flexible array. For example, char p[0] is not supported,
> > but char p[] is O.K. GCC supports b
On Thu, Apr 24, 2014 at 2:48 PM, Andy Zhou wrote:
> Visual studio does not support 0 size array within a struct,
> but supports flexible array. For example, char p[0] is not supported,
> but char p[] is O.K. GCC supports both.
>
> Flexible array can not directly replace a zero sized array.
> http
On Thu, Apr 24, 2014 at 02:52:30PM -0700, Gurucharan Shetty wrote:
> On Thu, Apr 24, 2014 at 1:31 PM, Ben Pfaff wrote:
> > Also add references to this FAQ from INSTALL and configure.
> >
> > Signed-off-by: Ben Pfaff
> Acked-by: Gurucharan Shetty
Thanks, applied to master.
__
On Thu, Apr 24, 2014 at 02:51:45PM -0700, Jesse Gross wrote:
> On Thu, Apr 24, 2014 at 1:31 PM, Ben Pfaff wrote:
> > diff --git a/INSTALL b/INSTALL
> > index f43c65b..71ce963 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -164,10 +164,6 @@ Prerequisites section, follow the procedure below to
>
Realized that we should always seq_change() in the
ofproto_dpif_send_packet_in()
Will send another version, should be very straight forward,
On Thu, Apr 24, 2014 at 5:54 AM, Joe Stringer wrote:
> Good to see this as a separate change.
>
> Acked-by: Joe Stringer
>
>
> On 18 April 2014 08:32, A
On Thu, Apr 24, 2014 at 02:57:28PM -0700, Jesse Gross wrote:
> I suppose the other possibility is to pass some kind of flag attribute
> with messages indicating that this is a test probe and would silence
> logging. Existing kernels would ignore this so they would still log
> but the behavior would
Applied, thx~
On Thu, Apr 24, 2014 at 5:54 AM, Joe Stringer wrote:
> Acked-by: Joe Stringer
>
>
> On 18 April 2014 08:32, Alex Wang wrote:
>
>> This commit adds boolean flag in bfd/cfm module for checking
>> status change. If there is no status change, the current
>> update to OVS database wi
The cleanest way seems to be to just reduce the default log level for
these messages so they don't pop up normally. I think we talked about
this before and were concerned about debugging when problems show up
at runtime other than developer testing.
I suppose the other possibility is to pass some
On Thu, Apr 24, 2014 at 1:31 PM, Ben Pfaff wrote:
> Also add references to this FAQ from INSTALL and configure.
>
> Signed-off-by: Ben Pfaff
Acked-by: Gurucharan Shetty
> ---
> FAQ | 35 ++-
> INSTALL |8
> acinclude.m4 |2 +-
>
On Thu, Apr 24, 2014 at 1:31 PM, Ben Pfaff wrote:
> diff --git a/INSTALL b/INSTALL
> index f43c65b..71ce963 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -164,10 +164,6 @@ Prerequisites section, follow the procedure below to
> build.
> To use a specific C compiler for compiling Open vSwitch use
Visual studio does not support 0 size array within a struct,
but supports flexible array. For example, char p[0] is not supported,
but char p[] is O.K. GCC supports both.
Flexible array can not directly replace a zero sized array.
http://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html lists the
diffe
I am sure it can be done and most likely involving some netlink
changes. Since netlink message design is your forte, any suggestions?
On Thu, Apr 24, 2014 at 2:22 PM, Jesse Gross wrote:
> That's a good point, I didn't think about that. I wonder if there is a
> way to avoid the error message in t
That's a good point, I didn't think about that. I wonder if there is a
way to avoid the error message in these cases since it's likely to
cause confusion given that it is logged by default.
On Thu, Apr 24, 2014 at 1:57 PM, Andy Zhou wrote:
> Whenever we instantiate a new ofproto (i.e. bridge), we
Whenever we instantiate a new ofproto (i.e. bridge), we probe datapath
to detect if it supports MPLS, and if yes, how many labels it can
support. The probing produces similar error messages on my system.
It should only appear when you add the bridge, but not afterwards.
On Thu, Apr 24, 2014 at 12
After getting back from my vacation on Monday, I've found myself
unable to properly keep track of which patches people would like me to
review. Therefore, if you have an outstanding patch or patch series,
and think I should review it, please send me a pointer.
_
Also add references to this FAQ from INSTALL and configure.
Signed-off-by: Ben Pfaff
---
FAQ | 35 ++-
INSTALL |8
acinclude.m4 |2 +-
3 files changed, 31 insertions(+), 14 deletions(-)
diff --git a/FAQ b/FAQ
index 6b4be43..c43b0c
Thanks for checking. I applied this to master.
On Thu, Apr 24, 2014 at 01:12:27PM -0700, Padmanabhan Krishnan wrote:
> This works for my requirement of passing LLDP frames with NCB. Good to go
> from my side.
>
>
> Thanks,
> Paddu
>
> On Thursday, April 24, 2014 11:16 AM, Padmanabhan Krishnan
This works for my requirement of passing LLDP frames with NCB. Good to go from
my side.
Thanks,
Paddu
On Thursday, April 24, 2014 11:16 AM, Padmanabhan Krishnan
wrote:
Sure, this looks better. Wasn't aware of the define for FLOW_DL_TYPE_NONE. I
was searching for the define for minimum ethe
On Thu, Apr 24, 2014 at 09:41:00AM -0700, Gurucharan Shetty wrote:
> We have some common code between daemon-unix.c and
> daemon-windows.c. Move them to daemon.c
>
> Signed-off-by: Gurucharan Shetty
I didn't trying building this but at a glance the change from v1 is
what I expected.
Acked-by: B
On Thu, Apr 24, 2014 at 10:26:26AM -0700, Gurucharan Shetty wrote:
> On Thu, Apr 24, 2014 at 9:26 AM, Ben Pfaff wrote:
> > On Thu, Apr 24, 2014 at 08:31:04AM -0700, Gurucharan Shetty wrote:
> >> We have some common code between daemon-unix.c and
> >> daemon-windows.c. Move them to daemon.c
> >>
>
On 4/24/2014 1:47 PM, Jesse Gross wrote:
On Thu, Apr 24, 2014 at 8:38 AM, Thomas F Herbert
wrote:
Hi,
I think there is a problem with parsing out the OVS ATTRIBUTE nesting in the
NL message in the datapath and I am having trouble finding the cause. I
think the nl msg is built up wrong in the c
Sure, this looks better. Wasn't aware of the define for FLOW_DL_TYPE_NONE. I
was searching for the define for minimum ethertype. Now i do see ETH_TYPE_MIN.
Let me apply this patch, test and will update this thread.
Thanks,
Paddu
Ben Pfaff blp at nicira.com
Thu Apr 24 10:15:24 PDT 2014
On Thu, Apr 24, 2014 at 8:38 AM, Thomas F Herbert
wrote:
> Hi,
>
> I think there is a problem with parsing out the OVS ATTRIBUTE nesting in the
> NL message in the datapath and I am having trouble finding the cause. I
> think the nl msg is built up wrong in the case of the vlan push action.
>
> I
On Thu, Apr 24, 2014 at 9:26 AM, Ben Pfaff wrote:
> On Thu, Apr 24, 2014 at 08:31:04AM -0700, Gurucharan Shetty wrote:
>> We have some common code between daemon-unix.c and
>> daemon-windows.c. Move them to daemon.c
>>
>> Signed-off-by: Gurucharan Shetty
>
> "sparse" reports:
>
> ../lib/daemo
We have some common code between daemon-unix.c and
daemon-windows.c. Move them to daemon.c
Signed-off-by: Gurucharan Shetty
---
lib/automake.mk |1 +
lib/daemon-private.h | 25 +
lib/daemon-unix.c| 38 --
lib/daemon-win
On Thu, Apr 24, 2014 at 01:12:43AM -0700, Padmanabhan Krishnan wrote:
> Apart from STP, EVB extension of LLDP as well as IEEE 802.1QBG
> use the Nearest Customer Bridge (NCB) DMAC which
> has a value of 0180.c200.. If a flow is programmed for
> LLDP or QBG packets specifying the NCB DMAC and et
On Thu, Apr 24, 2014 at 08:31:04AM -0700, Gurucharan Shetty wrote:
> We have some common code between daemon-unix.c and
> daemon-windows.c. Move them to daemon.c
>
> Signed-off-by: Gurucharan Shetty
"sparse" reports:
../lib/daemon-unix.c:42:6: warning: symbol 'detach' was not declared.
Sho
On Thu, Apr 24, 2014 at 08:31:02AM -0700, Gurucharan Shetty wrote:
> An upcoming commit re-introduces daemon.c to have
> common functions across daemon-unix.c and daemon-windows.c
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailin
On Thu, Apr 24, 2014 at 08:31:03AM -0700, Gurucharan Shetty wrote:
> In the unit tests, we check for some logs stored in stderr. In case
> of windows, unit tests fail because the child writes additional information
> into stderr because it does not have it closed. This commit
> closes standard file
On Thu, Apr 24, 2014 at 09:09:03AM -0700, Jarno Rajahalme wrote:
> rule_dpif_is_internal is among the top ten OVS internal functions in
> recent perf reports. Inline it and some other equally trivial
> functions.
>
> This change removes rule_is_internal(), since the fact that a table is
> an inte
We have some common code between daemon-unix.c and
daemon-windows.c. Move them to daemon.c
Signed-off-by: Gurucharan Shetty
---
lib/daemon-unix.c| 37 +++--
lib/daemon-windows.c | 40 ++--
lib/daemon.c | 33 +++
In the unit tests, we check for some logs stored in stderr. In case
of windows, unit tests fail because the child writes additional information
into stderr because it does not have it closed. This commit
closes standard file descriptors for windows too.
Because the functions related to closing fil
An upcoming commit re-introduces daemon.c to have
common functions across daemon-unix.c and daemon-windows.c
Signed-off-by: Gurucharan Shetty
---
lib/automake.mk |2 +-
lib/{daemon.c => daemon-unix.c} |2 +-
lib/daemon-windows.c|2 +-
3 files changed, 3 in
rule_dpif_is_internal is among the top ten OVS internal functions in
recent perf reports. Inline it and some other equally trivial
functions.
This change removes rule_is_internal(), since the fact that a table is
an internal one is defined within ofproto-dpif, not ofproto.
Signed-off-by: Jarno R
On 4/24/2014 8:46 AM, Jiri Pirko wrote:
Thu, Apr 24, 2014 at 04:54:19PM CEST, john.fastab...@gmail.com wrote:
On 04/17/2014 05:15 AM, Jiri Pirko wrote:
Benefit from the possibility to work with flows in switch devices and
use the swdev api to offload flow datapath.
Signed-off-by: Jiri Pirko
-
Thu, Apr 24, 2014 at 04:54:19PM CEST, john.fastab...@gmail.com wrote:
>On 04/17/2014 05:15 AM, Jiri Pirko wrote:
>>Benefit from the possibility to work with flows in switch devices and
>>use the swdev api to offload flow datapath.
>>
>>Signed-off-by: Jiri Pirko
>>---
>
>
>[...]
>
>>
>>@@ -840,13 +
Hi,
I think there is a problem with parsing out the OVS ATTRIBUTE nesting in
the NL message in the datapath and I am having trouble finding the
cause. I think the nl msg is built up wrong in the case of the vlan push
action.
I first saw the problem while testing my patch for 802.1ad. However
On 04/17/2014 05:15 AM, Jiri Pirko wrote:
Benefit from the possibility to work with flows in switch devices and
use the swdev api to offload flow datapath.
Signed-off-by: Jiri Pirko
---
[...]
@@ -840,13 +841,15 @@ static int ovs_flow_cmd_new_or_set(struct sk_buff *skb,
struct genl_info *
There's a few comments inline.
On 18 April 2014 08:32, Alex Wang wrote:
> This commit removes the 'Instant' stats related logic in bridge.c.
> Instead, the corresponding status is updated immediately after the
> global connectivity sequence number changes.
>
Could you update the commit message
Good to see this as a separate change.
Acked-by: Joe Stringer
On 18 April 2014 08:32, Alex Wang wrote:
> This commit adds per 'struct ofproto_dpif' sequence number for
> packet-in I/O. Whenever a packet-in is inserted into the 'pins'
> queue, the inserting thread will change the sequence num
Acked-by: Joe Stringer
On 18 April 2014 08:32, Alex Wang wrote:
> This commit adds boolean flag in bfd/cfm module for checking
> status change. If there is no status change, the current
> update to OVS database will skip the bfd/cfm session.
>
> In the experiment with 5K bfd sessions, when on
hi,
> + * Due to the sample action there may be multiple possible eth types.
> + * In order to correctly validate actions all possible types are tracked
> + * and verified. This is done using struct eth_types.
is there any real-world use cases of these actions inside a sample?
otherwise, how abou
Apart from STP, EVB extension of LLDP as well as IEEE 802.1QBG
use the Nearest Customer Bridge (NCB) DMAC which
has a value of 0180.c200.. If a flow is programmed for
LLDP or QBG packets specifying the NCB DMAC and ethertype,
the userspace still drops the frame thinking it's a STP
frame. STP BP
82 matches
Mail list logo
