Re: [ovs-dev] [urcu 3/8] ovs-rcu: New library.

2014-03-10 Thread Ben Pfaff
On Mon, Mar 10, 2014 at 11:52:48PM -0700, Andy Zhou wrote: > Thanks for the reference. It provides the relevant background, especially > on memory_order_consume. > > BTW, the example has an unfamiliar syntax, p -< next (Its usage looks > like p -> next) Is this something new? I think that's ju

Re: [ovs-dev] [urcu 3/8] ovs-rcu: New library.

2014-03-10 Thread Andy Zhou
Thanks for the reference. It provides the relevant background, especially on memory_order_consume. BTW, the example has an unfamiliar syntax, p -< next (Its usage looks like p -> next) Is this something new? Looking forward to the revision. Your implementation is much smaller than the kernel R

Re: [ovs-dev] [urcu 3/8] ovs-rcu: New library.

2014-03-10 Thread Ben Pfaff
On Wed, Mar 05, 2014 at 11:12:58PM -0800, Ben Pfaff wrote: > RCU allows multiple threads to read objects in parallel without any > performance penalty. The following commit will introduce the first use. > > Signed-off-by: Ben Pfaff Hey, I just found out that memory_order_consume is designed spe

Re: [ovs-dev] [PATCH] lib/classifier: Use a prefix tree to optimize ports wildcarding.

2014-03-10 Thread Ethan Jackson
Yep this is the same thing. I've successfully shown that this algorithm is the best for our use case and was intending to implement it myself. However, for many rather complicated reasons it became important to have a prototype implementation quickly, so Jarno graciously offered to pound out the

Re: [ovs-dev] [PATCH] lib/classifier: Use a prefix tree to optimize ports wildcarding.

2014-03-10 Thread Ben Pfaff
Is this the same as what you've been working on, Ethan? If not, is it complementary, or...? On Mar 10, 2014 6:39 PM, "Jarno Rajahalme" wrote: > Intended to send this as an RFC, > > Jarno > > On Mar 10, 2014, at 6:43 PM, Jarno Rajahalme > wrote: > > > This should optimize port masks for megaflo

Re: [ovs-dev] [PATCH] lib/classifier: Use a prefix tree to optimize ports wildcarding.

2014-03-10 Thread Jarno Rajahalme
Intended to send this as an RFC, Jarno On Mar 10, 2014, at 6:43 PM, Jarno Rajahalme wrote: > This should optimize port masks for megaflows for typical port usage > in matches. Each subtable has it's own trie if the subtable matches > any of the ports bits. This trie is consulted only after

[ovs-dev] [PATCH] lib/classifier: Use a prefix tree to optimize ports wildcarding.

2014-03-10 Thread Jarno Rajahalme
This should optimize port masks for megaflows for typical port usage in matches. Each subtable has it's own trie if the subtable matches any of the ports bits. This trie is consulted only after failing lookup to determine the number of bits that needs to be unwildcarded to guarantee that any pack

Re: [ovs-dev] Running openvswitch in Android

2014-03-10 Thread Zoi Vasileiou
I do the same configure command as you mentioned(in my case kernel for maguro device) but i cannot get the openvswitch.ko. I read in documentation that : If you wish to build the kernel module for an architecture other than the architecture of the machine used for the build, you may spec

Re: [ovs-dev] [RFC] ofp-actions: Remove expectation of struct ofpact size.

2014-03-10 Thread Gurucharan Shetty
On Mon, Mar 10, 2014 at 2:47 PM, Ben Pfaff wrote: > On Mon, Mar 10, 2014 at 02:12:27PM -0700, Gurucharan Shetty wrote: >> struct ofpact has enums that are packed in case of __GNUC__. >> This packing does not occur for visual studio. For 'struct ofpact_nest', >> we are expecting that this structure

Re: [ovs-dev] [RFC] ofp-actions: Remove expectation of struct ofpact size.

2014-03-10 Thread Ben Pfaff
On Mon, Mar 10, 2014 at 02:12:27PM -0700, Gurucharan Shetty wrote: > struct ofpact has enums that are packed in case of __GNUC__. > This packing does not occur for visual studio. For 'struct ofpact_nest', > we are expecting that this structure is less than or equal to 8 bytes > which won't be true

[ovs-dev] [RFC] ofp-actions: Remove expectation of struct ofpact size.

2014-03-10 Thread Gurucharan Shetty
struct ofpact has enums that are packed in case of __GNUC__. This packing does not occur for visual studio. For 'struct ofpact_nest', we are expecting that this structure is less than or equal to 8 bytes which won't be true in compilers where enums are not packed. Signed-off-by: Gurucharan Shetty

Re: [ovs-dev] [PATCH] netdev-linux: Remove unnecessary header.

2014-03-10 Thread Pravin Shelar
On Thu, Feb 6, 2014 at 3:23 PM, Ben Pfaff wrote: > On Thu, Feb 06, 2014 at 12:31:13PM -0800, Pravin wrote: >> From: Pravin Shelar >> >> netdev-linux does not depend on linux kernel version. So >> remove header file include. >> >> Signed-off-by: Pravin B Shelar > > Acked-by: Ben Pfaff Thanks. P

Re: [ovs-dev] Support for Linux kernels >= 3.12 with the out of tree kernel module

2014-03-10 Thread Pravin Shelar
On Thu, Mar 6, 2014 at 1:57 PM, Kyle Mestery wrote: > On Thu, Feb 27, 2014 at 3:28 PM, Pravin Shelar wrote: >> >> On Thu, Feb 27, 2014 at 12:41 PM, Kyle Mestery >> wrote: >> > On Wed, Feb 26, 2014 at 5:07 PM, Pravin Shelar >> > wrote: >> >> >> >> On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery >>

[ovs-dev] [PATCH] byte-order: htonll() and ntohll() for Windows.

2014-03-10 Thread Gurucharan Shetty
These functions exist, so don't provide them. Signed-off-by: Gurucharan Shetty --- lib/byte-order.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/byte-order.h b/lib/byte-order.h index 352f91e..e5ea8db 100644 --- a/lib/byte-order.h +++ b/lib/byte-order.h @@ -22,6 +22,7 @@ #include

[ovs-dev] [PATCH] ovs-thread: count the number of cpu cores.

2014-03-10 Thread Gurucharan Shetty
We use the number of cpu cores to determine the number of threads that we spawn. We are not yet sure what is the ideal number of OVS userspace threads that can run on Hyper-V. Till we figure that out, use the same logic of counting CPU cores in Windows too. Signed-off-by: Gurucharan Shetty --- l

[ovs-dev] [PATCH] uuid: Use current time to compute sha.

2014-03-10 Thread Gurucharan Shetty
Windows does not have the getppid(), getuid(), getgid() functions. We do get a random seed from CryptGenRandom(). That seed along with process id and current time hopefully is good enough. Signed-off-by: Gurucharan Shetty --- include/windows/windefs.h |4 lib/uuid.c|

[ovs-dev] [PATCH] util: Maximum path length for Windows.

2014-03-10 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- lib/util.c |4 1 file changed, 4 insertions(+) diff --git a/lib/util.c b/lib/util.c index bbca262..3f9a2e2 100644 --- a/lib/util.c +++ b/lib/util.c @@ -646,7 +646,11 @@ get_cwd(void) size_t size; /* Get maximum path length or at least a r

[ovs-dev] [PATCH] ofp-print: __attribute__ format in visual studio.

2014-03-10 Thread Gurucharan Shetty
Visual studio does not understand __attribute__ format. All the violations would be caught with gcc in linux. So, it should be okay removing that. Signed-off-by: Gurucharan Shetty --- lib/ofp-print.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index

[ovs-dev] [PATCH] vlog: Array intialization for Windows.

2014-03-10 Thread Gurucharan Shetty
Visual studio does not understand array initialization done this way: [first ... last] = value Signed-off-by: Gurucharan Shetty --- lib/vlog.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vlog.h b/lib/vlog.h index 226b7f8..0f791af 100644 --- a/lib/vlog.h +++ b/lib/v

[ovs-dev] [PATCH] ovsdb-server: Truncate file for Windows.

2014-03-10 Thread Gurucharan Shetty
There is no ftruncate() in visual studio. There is a _chsize_s() which has a similar functionality. Signed-off-by: Gurucharan Shetty --- include/windows/windefs.h |1 + lib/util.c| 10 ++ lib/util.h|1 + 3 files changed, 12 insertions(+) diff --

[ovs-dev] [PATCH] windows: Add stub headers for windows.

2014-03-10 Thread Gurucharan Shetty
Windows does not have a bunch of headers that are available in Linux. Instead of littering the code with #ifndef _WIN32, add stub headers. Signed-off-by: Gurucharan Shetty --- include/windows/automake.mk | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 include/wind

Re: [ovs-dev] How to add a file?

2014-03-10 Thread Alon Harel
Thanks Ben, that worked. For some reason I was under the impression that the lib/automake.mk is being automatically built. Alon -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Monday, March 10, 2014 5:54 PM To: Alon Harel Cc: dev@openvswitch.org Subject: Re: [ovs-dev]

Re: [ovs-dev] How to add a file?

2014-03-10 Thread Ben Pfaff
On Mon, Mar 10, 2014 at 03:31:39PM +, Alon Harel wrote: > I'm trying to add a new file under openvswitch/lib but I cannot find the > way to compile and link it as part of the build. > I'm running: > > configure > > make > > make install > > But the added file is not being compiled. > I have

[ovs-dev] How to add a file?

2014-03-10 Thread Alon Harel
Hi, I'm trying to add a new file under openvswitch/lib but I cannot find the way to compile and link it as part of the build. I'm running: > configure > make > make install But the added file is not being compiled. I have tried also 'make clean' prior, but that didn't help either. Please let me

[ovs-dev] [PATCH] tests: Add '-latomic' only for 'test-atomic.c'

2014-03-10 Thread Cosmin Paraschiv
Commit fd2e50c (Add check for -latomic) fixed a bug for 32-bit PowerPC systems, where the compiler would generate calls to functions implemented by libatomic, such as '__atomic_load_8'. Nonetheless, it passes '-latomic' to all files that get compiled and that isn't necessary, so add it only for 't

Re: [ovs-dev] Help for java (bindings?) development

2014-03-10 Thread Lori Jakab
Hi Pasquale, On 3/8/14, 2:09 PM, Pasquale Dir wrote: Hello, I'd need to create some java apis who would allow to interact with openvswitch, creating bridges, adding ports, creating gre tunnels...in short: the exact same thing ovs-vsctl does. As c code seems fairly complex I write here to ask