Thanks for the review. I applied this to master.
On Fri, Feb 28, 2014 at 05:18:05PM -0800, Alex Wang wrote:
> Looks good to me,
>
> I had trouble connecting to controller, this patch solves the problem,
>
>
>
> On Fri, Feb 28, 2014 at 4:21 PM, Ben Pfaff wrote:
>
> > When a connection takes
Looks good to me,
I had trouble connecting to controller, this patch solves the problem,
On Fri, Feb 28, 2014 at 4:21 PM, Ben Pfaff wrote:
> When a connection takes a few rounds of the state machine to complete,
> 'error' gets filled with EAGAIN until that completes. This didn't match
> the
pushed with the fix.
On Thu, Feb 27, 2014 at 2:36 PM, Andy Zhou wrote:
> Thanks, I will fix it before push.
>
>
> On Thu, Feb 27, 2014 at 2:18 PM, Joe Stringer wrote:
>
>> Before you push, there's a typo in the patch name - "inlucde"
>>
>>
>> On 26 February 2014 20:08, Ben Pfaff wrote:
>>
>>>
Pushed to the master with the changes suggested.
On Thu, Feb 27, 2014 at 3:21 PM, Jarno Rajahalme wrote:
> I like this, some comments below, otherwise:
>
> Acked-by: Jarno Rajahalme
>
> On Feb 26, 2014, at 6:22 PM, Andy Zhou wrote:
>
> > Change the flow_extract() API to accept struct pkt_metad
When a connection takes a few rounds of the state machine to complete,
'error' gets filled with EAGAIN until that completes. This didn't match
the vconn_get_status() documentation, which says that it only returns a
positive errno value if there was an error. One could fix the problem
by updating
On Fri, Feb 28, 2014 at 03:15:17PM -0800, Ben Pfaff wrote:
> On Fri, Feb 28, 2014 at 03:07:45PM -0800, Pravin Shelar wrote:
> > On Fri, Feb 28, 2014 at 1:14 PM, Ben Pfaff wrote:
> > > The kernel starts out its "jiffies" timer as 5 minutes below zero, as
> > > shown in include/linux/jiffies.h:
> >
On Fri, Feb 28, 2014 at 03:07:45PM -0800, Pravin Shelar wrote:
> On Fri, Feb 28, 2014 at 1:14 PM, Ben Pfaff wrote:
> > The kernel starts out its "jiffies" timer as 5 minutes below zero, as
> > shown in include/linux/jiffies.h:
> >
> > /*
> >* Have the 32 bit jiffies value wrap 5 minutes afte
On Fri, Feb 28, 2014 at 1:14 PM, Ben Pfaff wrote:
> The kernel starts out its "jiffies" timer as 5 minutes below zero, as
> shown in include/linux/jiffies.h:
>
> /*
>* Have the 32 bit jiffies value wrap 5 minutes after boot
>* so jiffies wrap bugs show up earlier.
>*/
> #define INI
I figured that if we're not using the retval currently, then it doesn't
matter too much. But I'm happy to change it.
On 28 February 2014 13:53, Ben Pfaff wrote:
> On Fri, Feb 28, 2014 at 01:42:13PM -0800, Joe Stringer wrote:
> > Signed-off-by: Joe Stringer
>
> I would have xpthread_barrier_wai
On Fri, Feb 28, 2014 at 01:42:13PM -0800, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
I would have xpthread_barrier_wait() pass along the return value from
pthread_barrier_wait(), because some uses of barriers want that
information.
Otherwise, looks good.
__
From: Ethan Jackson
Previously, we had a separate flow_dumper thread that fetched flows from
the datapath to distribute to revalidator threads. This patch takes the
logic for dumping and pushes it into the revalidator threads, resulting
in simpler code with similar performance to the current code
Signed-off-by: Joe Stringer
---
v5: First post.
---
lib/ovs-thread.c | 24
lib/ovs-thread.h |6 ++
2 files changed, 30 insertions(+)
diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c
index 4dfccaf..e2a28a0 100644
--- a/lib/ovs-thread.c
+++ b/lib/ovs-thread.c
@@
Thanks for the review. Pushed to branch-2.0 with the comment fix folded in.
On Thu, Feb 27, 2014 at 5:40 PM, Alex Wang wrote:
> I see, there is no revalidator thread in branch-2.0
>
> Looks good to me,
>
> May also make sense to remove the "revalidator" from comment,
>
> diff --git a/ofproto/of
On Feb 26, 2014, at 8:38 PM, Ben Pfaff wrote:
> On Wed, Feb 26, 2014 at 04:35:44PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks for the reviews. I'll push these patches shortly.
--Justin
___
dev mail
The kernel starts out its "jiffies" timer as 5 minutes below zero, as
shown in include/linux/jiffies.h:
/*
* Have the 32 bit jiffies value wrap 5 minutes after boot
* so jiffies wrap bugs show up earlier.
*/
#define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-300*HZ))
The loop i
I also had problems with these locks on current net-next, I believe the
issue is that "datapath: Fix deadlock during stats update." is not
merged from official OVS repo to kernel.
Zoli
On 13/02/14 17:13, Jiri Pirko wrote:
Hi.
On current net-next I'm getting following message once I add a dp:
The kernel datapath now switched to zerocopy Netlink messages, but that also
means that the pages on frags array are sent straight to userspace. If those
pages came outside the kernel, we have to swap them out with local copies.
Signed-off-by: Zoltan Kiss
---
net/openvswitch/datapath.c |6 ++
Hi,
On Fri, Feb 28, 2014 at 04:52:28PM +0100, fred wrote:
> module-assistant auto-install openvswitch-datapath fails without any useful
> log.
>
> I have no clue.
Can you please still post the log? It builds just fine for me.
Regards
Evgeni
___
dev m
Processing commands for cont...@bugs.debian.org:
> tags 740355 + unreproducible moreinfo
Bug #740355 [openvswitch-datapath-source] openvswitch-datapath-source:
module-assistant openvswitch-datapath fails on 7.4 3.2.0-4-amd64
Added tag(s) unreproducible and moreinfo.
> thanks
Stopping processing h
On Thu, Feb 27, 2014 at 04:55:49PM -0800, Joe Stringer wrote:
> On 27 February 2014 15:23, Ben Pfaff wrote:
> > Datapath flow dumps can sometimes repeat or omit flows, but
> > revalidate() appears to create a new ukey if it doesn't find one
> > without making sure that a duplicate wasn't added in
On Fri, Feb 28, 2014 at 01:06:11PM +0900, YAMAMOTO Takashi wrote:
> > @@ -1452,32 +1507,18 @@ dpif_netdev_queue_to_priority(const struct dpif
> > *dpif OVS_UNUSED,
> > return 0;
> > }
> >
> > -static struct dp_netdev_queue *
> > -find_nonempty_queue(struct dp_netdev *dp)
> > -OVS_REQUI
Hey Yamamoto,
I discussed this with Ben, we want to give it a try. If there is fairness
issue, we will address it.
Also, there should not be a hard priority of DPIF_UC_MISS over
DPIF_UC_ACTION.
The find_nonempty_queue() should return in a round-robin fashion if both
queues
are non-empty.
Thanks
Hi,
As a leading database provider, I was inquisitive to check if you would be
interested in owning a list of companies using VMware that can be used for
your marketing campaigns? These lists can be customized based on
application, geography, titles and more.
Some of the other Virtualizatio
On Fri, Feb 28, 2014 at 10:36:07AM +, thomas.mo...@orange.com wrote:
> I understand the ideas behind generic l3 vports (Lori's patches), but I
> don't clearly see how NSH fits in the picture, apart from the fact that
> NSH has to cooperate with the tunneling code. It does not seem to me why
Package: openvswitch-datapath-source
Version: 1.4.2+git20120612-9.1~deb7u1
Severity: important
Dear Maintainer,
module-assistant auto-install openvswitch-datapath fails without any useful
log.
I have no clue.
-- System Information:
Debian Release: 7.4
APT prefers stable-updates
APT policy
Hi Ben,
2014-02-27, Ben Pfaff:
> On Thu, Feb 27, 2014 at 05:16:18PM +, thomas.mo...@orange.com wrote:
>> Currently, OVS GRE tunnels use Ethertype 6558 and the GRE packets
>> produced by OVS hence always are xxx-over-Ethernet-over-GRE.
>> Symmetrically OVS expects received GRE packets to be of
Hi Lori, Praveen,
Thank you for the pointer on l3 vports.
I'll have a look at this.
-Thomas
2014-02-27, Lori Jakab:
> Hi Thomas,
>
> I'm the original contributor of the LISP tunneling code. Since it was
> originally accepted, I have been working on a series of patches to
> enable more generic
BLOCKQUOTE {MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px; MARGIN-LEFT: 2em}
28 matches
Mail list logo
