On Fri, Feb 28, 2014 at 03:07:45PM -0800, Pravin Shelar wrote:
> On Fri, Feb 28, 2014 at 1:14 PM, Ben Pfaff <b...@nicira.com> wrote:
> > The kernel starts out its "jiffies" timer as 5 minutes below zero, as
> > shown in include/linux/jiffies.h:
> >
> >   /*
> >    * Have the 32 bit jiffies value wrap 5 minutes after boot
> >    * so jiffies wrap bugs show up earlier.
> >    */
> >   #define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-300*HZ))
> >
> > The loop in ovs_flow_stats_get() starts out with 'used' set to 0, then
> > takes any "later" time.  This means that for the first five minutes after
> > boot, flows will always be reported as never used, since 0 is greater than
> > any time already seen.
> >
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> 
> Good catch.
> 
> Acked-by: Pravin B Shelar <pshe...@nicira.com>

Thanks, I applied this to master.  Shall I backport it?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to