Re: [ovs-dev] [PATCH] tests: Add support for automatically running Ryu tests against OVS.

2014-02-07 Thread Ben Pfaff
On Fri, Feb 07, 2014 at 11:18:53PM -0800, Ben Pfaff wrote: > The Ryu controller comes with an extensive library of OpenFlow tests, but > it doesn't seem so easy to me to run all of them against a development > version of Open vSwitch. This commit introduces a Makefile target so that > one can run

[ovs-dev] [PATCH] tests: Add support for automatically running Ryu tests against OVS.

2014-02-07 Thread Ben Pfaff
The Ryu controller comes with an extensive library of OpenFlow tests, but it doesn't seem so easy to me to run all of them against a development version of Open vSwitch. This commit introduces a Makefile target so that one can run all the Ryu tests with a simple "make check-ryu". This commit adds

Re: [ovs-dev] Error after inserting MPLS flow using OVS2.0

2014-02-07 Thread Ben Pfaff
Cut it out with the CC to discuss-request, by the way. It makes no sense at all and just causes a bounce back. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Error after inserting MPLS flow using OVS2.0

2014-02-07 Thread Ben Pfaff
On Fri, Feb 07, 2014 at 06:09:45PM -0800, Madhusudhan Kandadai wrote: > But, when I try to attempt in pushing two mpls header for a flow, I > could not see two labels while using tcpdump that means, the packets > are not flowing through it. So, I had an idea to make it work. Did you read the FAQ?

Re: [ovs-dev] Error after inserting MPLS flow using OVS2.0

2014-02-07 Thread Madhusudhan Kandadai
Thanks Ben for some insights on userspace datapath. I had a quick peek into the file, INSTALL.space and followed the instructions. Its working fine for pushing a MPLS header for flows. i.e., sudo ovs-ofctl add-flow br0 in_port=1,actions=push_mpls:0x8847,set_field:100-\>mpls_label,output:2 -O Op

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-07 Thread Alex Wang
Based on the discussion offline, we agree on that the kernel side implementation should be kept simple. So, the current design will still be used. Also, change the key name from OVS_VPORT_ATTR_UPCALL_PIDS to OVS_VPORT_ATTR_UPCALL_PID. I'll send V2 patch soon. On Fri, Feb 7, 2014 at 1:00 PM, Pr

[ovs-dev] [PATCH 2/4] flow: Copy MPLS label on mpls_push.

2014-02-07 Thread Joe Stringer
OpenFlow 1.3.3 spec (and earlier) specify that the default value for an MPLS label should be copied from the outer header. Signed-off-by: Joe Stringer --- lib/flow.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index 06ba036..e7fe4d3 100644 -

[ovs-dev] [PATCH 4/4] tests: Add MPLS push on MPLS test.

2014-02-07 Thread Joe Stringer
Signed-off-by: Joe Stringer --- This test currently fails, and for some reason we're seeing a VLAN tagged packet arrive at the monitor. The expected result is not 100% correct, but it's a lot closer than what OVS is currently doing. --- tests/ofproto-dpif.at | 33 +++

[ovs-dev] [PATCH 3/4] tests: Fix MPLS test cases.

2014-02-07 Thread Joe Stringer
The "userspace" MPLS test case was checking the same things as the "drop" test case, rather than checking to see that packets were being sent to userspace. This patch makes the testsuite consistent with itself. Signed-off-by: Joe Stringer --- I'm not sure what the intended behaviour is here. At t

[ovs-dev] [PATCH 1/4] tests: Add basic MPLS push test.

2014-02-07 Thread Joe Stringer
Signed-off-by: Joe Stringer --- tests/ofproto-dpif.at | 46 ++ 1 file changed, 46 insertions(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 46a6b67..d57319c 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -1112,

[ovs-dev] [PATCH] tests: Don't rely on strace for IPv6 IDL testcases.

2014-02-07 Thread Joe Stringer
This would cause testsuite failures if someone runs the testsuite without strace installed. Signed-off-by: Joe Stringer --- tests/ovsdb-idl.at |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index 0c6d7df..89752f0 100644 --- a/tests/

Re: [ovs-dev] [PATCH] netdev-dummy: disable periodic probing

2014-02-07 Thread Ben Pfaff
On Fri, Feb 07, 2014 at 12:59:27PM -0800, Andy Zhou wrote: > netdev-dummy is mostly useed over reliable link for testing. Periodic > probing over those links seem overkill. > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@open

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-07 Thread Pravin Shelar
On Fri, Feb 7, 2014 at 11:55 AM, Alex Wang wrote: > Thanks Pravin, > > >> > >> > This patch also significantly simplifies the flow miss handling >> > code and brings slight improvement to flow setup rate. >> > >> Hi Alex, >> >> I have couple of high level comments: >> >> 1. Are we trying to solve

[ovs-dev] [PATCH] netdev-dummy: disable periodic probing

2014-02-07 Thread Andy Zhou
netdev-dummy is mostly useed over reliable link for testing. Periodic probing over those links seem overkill. Signed-off-by: Andy Zhou --- lib/netdev-dummy.c |1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 0f93363..b8e7ab7 100644 --- a/lib/net

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-07 Thread Alex Wang
Thanks Pravin, > > > This patch also significantly simplifies the flow miss handling > > code and brings slight improvement to flow setup rate. > > > Hi Alex, > > I have couple of high level comments: > > 1. Are we trying to solve fairness here? If yes then how does it work > for tunnel ports? If

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-07 Thread Pravin Shelar
On Wed, Feb 5, 2014 at 11:01 PM, Alex Wang wrote: > This commit removes the 'dispatcher' thread by allowing 'handler' > threads to read upcalls directly from dpif. vport in dpif will > open netlink sockets for each handler and will use the 5-tuple > hash from the missed packet to choose which soc

[ovs-dev] [PATCH V2] bond: Change the way of assigning bond slave for unassigned bond entry.

2014-02-07 Thread Alex Wang
Before this commit, ovs randomly selects a slave for unassigned bond entry. If the selected slave is not enabled, the active slave is chosen instead. In this commit, the slave is selected from the list of all enabled slaves in a round-robin fashion. This helps improve the consistency of bond beh

[ovs-dev] [PATCH] datapath: Add support for Linux 3.12

2014-02-07 Thread Pravin
From: Pravin Shelar Bump kernel support for datapath module to include 3.12. Make use of native ip-tunnel API for Kernel >= 3.12. Based on patch from James Page. Signed-off-by: James Page Signed-off-by: Pravin B Shelar --- FAQ|2 +- NEWS

Re: [ovs-dev] [PATCH] bond: Change the way of assigning bond slave for unassigned bond entry.

2014-02-07 Thread Alex Wang
exactly, thanks for pointing it out, On Fri, Feb 7, 2014 at 10:09 AM, Ben Pfaff wrote: > On Thu, Feb 06, 2014 at 04:31:27PM -0800, Alex Wang wrote: > > Before this commit, ovs randomly selects a slave for unassigned > > bond entry. If the selected slave is not enabled, the active slave > > is

Re: [ovs-dev] [PATCH] bond: Change the way of assigning bond slave for unassigned bond entry.

2014-02-07 Thread Ben Pfaff
On Thu, Feb 06, 2014 at 04:31:27PM -0800, Alex Wang wrote: > Before this commit, ovs randomly selects a slave for unassigned > bond entry. If the selected slave is not enabled, the active slave > is chosen instead. In this commit, the slave is selected from the > list of all enabled slaves in a r

Re: [ovs-dev] [PATCH] ofproto: Update documentation

2014-02-07 Thread Ben Pfaff
On Tue, Feb 04, 2014 at 03:16:01PM -0800, Joe Stringer wrote: > 'cls' is no longer a parameter to this function. > > Signed-off-by: Joe Stringer Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] collectors: Improve log message to better describe errors.

2014-02-07 Thread Ben Pfaff
Thanks, applied. On Thu, Feb 06, 2014 at 04:43:12PM -0800, Alex Wang wrote: > Looks good to me~ > > > On Thu, Feb 6, 2014 at 4:16 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > ofproto/collectors.c |8 +--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > >

Re: [ovs-dev] [PATCH 1/5] ovs-thread: Add a comment

2014-02-07 Thread Ben Pfaff
On Fri, Feb 07, 2014 at 10:24:45AM +0900, YAMAMOTO Takashi wrote: > > On Wed, Feb 05, 2014 at 11:47:17AM +0900, YAMAMOTO Takashi wrote: > >> > On Wed, Jan 15, 2014 at 12:41:20PM +0900, YAMAMOTO Takashi wrote: > >> >> Add a comment about implicit synchronization which > >> >> fat-rwlock seems to rel

Re: [ovs-dev] Error after inserting MPLS flow using OVS2.0

2014-02-07 Thread Ben Pfaff
On Fri, Feb 07, 2014 at 07:43:55AM -0800, Madhusudhan Kandadai wrote: > Can you please let me know the differences between userspace datapaths > and kernal datapaths? INSTALL.userspace explains how to use the userspace datapath. > With that being said, MPLS push,pop,match are happening at user sp

Re: [ovs-dev] [PATCH v2.53] datapath: Add basic MPLS support to kernel

2014-02-07 Thread Ben Pfaff
On Wed, Feb 05, 2014 at 05:54:38PM +0900, Simon Horman wrote: > * Ben has explained to me that there has been a change of direction > at the ONF with regards to MPLS and VLAN tag ordering. As per > his changelog for "Always insert MPLS labels after VLAN tags", > the situation is now as follow

Re: [ovs-dev] [PATCH] FAQ: Describe the state of MPLS in Open vSwitch.

2014-02-07 Thread Ben Pfaff
On Fri, Feb 07, 2014 at 11:49:32AM +0200, Pasi K?rkk?inen wrote: > On Thu, Feb 06, 2014 at 08:50:39PM -0800, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > CC: Simon Horman > > --- > > FAQ | 20 > > 1 file changed, 20 insertions(+) > > > > diff --git a/FAQ b/FAQ > > in

Re: [ovs-dev] Error after inserting MPLS flow using OVS2.0

2014-02-07 Thread Madhusudhan Kandadai
Hello, Can you please let me know the differences between userspace datapaths and kernal datapaths? With that being said, MPLS push,pop,match are happening at user space data paths. I appreciate if you can point me the documentation, or with examples to get familiar with this stuffs. Thanks

[ovs-dev] Overenie e-mailu!

2014-02-07 Thread webmail aktualizácie
Vážený užívateľ, Vezmite prosím na vedomie, že váš e-mailový účet bol prekročený limit skladovacie kapacity pre dnešok. Nebudete musieť odosielať alebo prijímať správy, bude zlyhanie upgrade vašej e-mailový účet bude vymazaný z našej šetrič. Ak sa chcete tomuto problému vyhnúť, kliknite na o

Re: [ovs-dev] [PATCH] FAQ: Describe the state of MPLS in Open vSwitch.

2014-02-07 Thread Pasi Kärkkäinen
On Thu, Feb 06, 2014 at 08:50:39PM -0800, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > CC: Simon Horman > --- > FAQ | 20 > 1 file changed, 20 insertions(+) > > diff --git a/FAQ b/FAQ > index 75d9e6b..e6e649f 100644 > --- a/FAQ > +++ b/FAQ > @@ -,6 +,26 @@ A: Ope