exactly, thanks for pointing it out,
On Fri, Feb 7, 2014 at 10:09 AM, Ben Pfaff <[email protected]> wrote: > On Thu, Feb 06, 2014 at 04:31:27PM -0800, Alex Wang wrote: > > Before this commit, ovs randomly selects a slave for unassigned > > bond entry. If the selected slave is not enabled, the active slave > > is chosen instead. In this commit, the slave is selected from the > > list of all enabled slaves in a round-robin fashion. This helps > > improve the consistency of bond behavior when new flows are added. > > > > Signed-off-by: Alex Wang <[email protected]> > > In get_enabled_slave(), I think that the test for an empty list needs to > take place while holding the lock. Otherwise it could see an > intermediate version of the list while another thread is rotating it. >
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
