On Wed, Feb 5, 2014 at 11:01 PM, Alex Wang <al...@nicira.com> wrote: > This commit removes the 'dispatcher' thread by allowing 'handler' > threads to read upcalls directly from dpif. vport in dpif will > open netlink sockets for each handler and will use the 5-tuple > hash from the missed packet to choose which socket (handler) to > send the upcall. > > This patch also significantly simplifies the flow miss handling > code and brings slight improvement to flow setup rate. > Hi Alex,
I have couple of high level comments: 1. Are we trying to solve fairness here? If yes then how does it work for tunnel ports? If not then this is about only removing dispatcher. Therefore can we have a per datapath pool of pids rather than per vport? 2. In any case we need to handle OVS_VPORT_ATTR_UPCALL_PID attribute in kernel. Since it is kernel interface. Thanks. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
